phy: qcom-qmp: clean up defines
Subsystems (2)
cover phy: qcom-qmp: clean up defines
Here are some trivial cleanups of the QMP defines for issues found while adding support for SC8280XP.
Johan
Johan Hovold (3):
phy: qcom-qmp: clean up v4 and v5 define order
phy: qcom-qmp: clean up define alignment
phy: qcom-qmp: clean up hex defines
drivers/phy/qualcomm/phy-qcom-qmp.h | 70 ++++++++++++++--------------- 1 file changed, 35 insertions(+), 35 deletions(-)
Signature · 1 line
2.35.1
PATCH 1/3 phy: qcom-qmp: clean up v4 and v5 define order
Clean up the QMP v4 and v5 defines by moving a few entries that were out of order.
--- drivers/phy/qualcomm/phy-qcom-qmp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/phy/qualcomm/phy-qcom-qmp.h +3 -3
@@ -577,8 +577,8 @@#define QSERDES_V4_COM_LOCK_CMP1_MODE0 0x0ac#define QSERDES_V4_COM_LOCK_CMP2_MODE0 0x0b0#define QSERDES_V4_COM_LOCK_CMP1_MODE1 0x0b4 -#define QSERDES_V4_COM_DEC_START_MODE0 0x0bc#define QSERDES_V4_COM_LOCK_CMP2_MODE1 0x0b8 +#define QSERDES_V4_COM_DEC_START_MODE0 0x0bc#define QSERDES_V4_COM_DEC_START_MODE1 0x0c4#define QSERDES_V4_COM_DIV_FRAC_START1_MODE0 0x0cc#define QSERDES_V4_COM_DIV_FRAC_START2_MODE0 0x0d0
@@ -1106,8 +1106,8 @@#define QSERDES_V5_COM_LOCK_CMP1_MODE0 0x0ac#define QSERDES_V5_COM_LOCK_CMP2_MODE0 0x0b0#define QSERDES_V5_COM_LOCK_CMP1_MODE1 0x0b4 -#define QSERDES_V5_COM_DEC_START_MODE0 0x0bc#define QSERDES_V5_COM_LOCK_CMP2_MODE1 0x0b8 +#define QSERDES_V5_COM_DEC_START_MODE0 0x0bc#define QSERDES_V5_COM_DEC_START_MODE1 0x0c4#define QSERDES_V5_COM_DIV_FRAC_START1_MODE0 0x0cc#define QSERDES_V5_COM_DIV_FRAC_START2_MODE0 0x0d0
@@ -1134,8 +1134,8 @@#define QSERDES_V5_COM_BIN_VCOCAL_CMP_CODE1_MODE0 0x1ac#define QSERDES_V5_COM_BIN_VCOCAL_CMP_CODE2_MODE0 0x1b0#define QSERDES_V5_COM_BIN_VCOCAL_CMP_CODE1_MODE1 0x1b4 -#define QSERDES_V5_COM_BIN_VCOCAL_HSCLK_SEL 0x1bc#define QSERDES_V5_COM_BIN_VCOCAL_CMP_CODE2_MODE1 0x1b8 +#define QSERDES_V5_COM_BIN_VCOCAL_HSCLK_SEL 0x1bc/* Only for QMP V5 PHY - TX registers */ #define QSERDES_V5_TX_RES_CODE_LANE_TX 0x34
Signature · 1 line
2.35.1
Re: [PATCH 1/3] phy: qcom-qmp: clean up v4 and v5 define order
Quoted 4 lines · Johan Hovold
Clean up the QMP v4 and v5 defines by moving a few entries that were out of order.
Signed-off-by Johan Hovold <[email protected]>
Quoted 38 lines
--- drivers/phy/qualcomm/phy-qcom-qmp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/phy/qualcomm/phy-qcom-qmp.h +3
-3@@ -577,8 +577,8 @@#define QSERDES_V4_COM_LOCK_CMP1_MODE0 0x0ac#define QSERDES_V4_COM_LOCK_CMP2_MODE0 0x0b0#define QSERDES_V4_COM_LOCK_CMP1_MODE1 0x0b4 -#define QSERDES_V4_COM_DEC_START_MODE0 0x0bc#define QSERDES_V4_COM_LOCK_CMP2_MODE1 0x0b8 +#define QSERDES_V4_COM_DEC_START_MODE0 0x0bc#define QSERDES_V4_COM_DEC_START_MODE1 0x0c4#define QSERDES_V4_COM_DIV_FRAC_START1_MODE0 0x0cc#define QSERDES_V4_COM_DIV_FRAC_START2_MODE0 0x0d0@@ -1106,8 +1106,8 @@#define QSERDES_V5_COM_LOCK_CMP1_MODE0 0x0ac#define QSERDES_V5_COM_LOCK_CMP2_MODE0 0x0b0#define QSERDES_V5_COM_LOCK_CMP1_MODE1 0x0b4 -#define QSERDES_V5_COM_DEC_START_MODE0 0x0bc#define QSERDES_V5_COM_LOCK_CMP2_MODE1 0x0b8 +#define QSERDES_V5_COM_DEC_START_MODE0 0x0bc#define QSERDES_V5_COM_DEC_START_MODE1 0x0c4#define QSERDES_V5_COM_DIV_FRAC_START1_MODE0 0x0cc#define QSERDES_V5_COM_DIV_FRAC_START2_MODE0 0x0d0@@ -1134,8 +1134,8 @@#define QSERDES_V5_COM_BIN_VCOCAL_CMP_CODE1_MODE0 0x1ac#define QSERDES_V5_COM_BIN_VCOCAL_CMP_CODE2_MODE0 0x1b0#define QSERDES_V5_COM_BIN_VCOCAL_CMP_CODE1_MODE1 0x1b4 -#define QSERDES_V5_COM_BIN_VCOCAL_HSCLK_SEL 0x1bc#define QSERDES_V5_COM_BIN_VCOCAL_CMP_CODE2_MODE1 0x1b8 +#define QSERDES_V5_COM_BIN_VCOCAL_HSCLK_SEL 0x1bc/* Only for QMP V5 PHY - TX registers */ #define QSERDES_V5_TX_RES_CODE_LANE_TX 0x34
Signature · 2 lines
With best wishes Dmitry
PATCH 2/3 phy: qcom-qmp: clean up define alignment
In reply to Johan HovoldClean up the QMP defines by removing some stray white space and making sure values are aligned.
--- drivers/phy/qualcomm/phy-qcom-qmp.h | 48 ++++++++++++++--------------- 1 file changed, 24 insertions(+), 24 deletions(-)
drivers/phy/qualcomm/phy-qcom-qmp.h +24 -24
@@ -627,8 +627,8 @@#define QSERDES_V4_TX_INTERFACE_SELECT 0x2c#define QSERDES_V4_TX_RES_CODE_LANE_TX 0x34#define QSERDES_V4_TX_RES_CODE_LANE_RX 0x38 -#define QSERDES_V4_TX_RES_CODE_LANE_OFFSET_TX 0x3c -#define QSERDES_V4_TX_RES_CODE_LANE_OFFSET_RX 0x40 +#define QSERDES_V4_TX_RES_CODE_LANE_OFFSET_TX 0x3c +#define QSERDES_V4_TX_RES_CODE_LANE_OFFSET_RX 0x40#define QSERDES_V4_TX_TRANSCEIVER_BIAS_EN 0x54#define QSERDES_V4_TX_HIGHZ_DRVR_EN 0x58#define QSERDES_V4_TX_TX_POL_INV 0x5c
@@ -678,7 +678,7 @@#define QSERDES_V4_RX_UCDR_SB2_THRESH2 0x050#define QSERDES_V4_RX_UCDR_SB2_GAIN1 0x054#define QSERDES_V4_RX_UCDR_SB2_GAIN2 0x058 -#define QSERDES_V4_RX_AUX_DATA_TCOARSE_TFINE 0x060 +#define QSERDES_V4_RX_AUX_DATA_TCOARSE_TFINE 0x060#define QSERDES_V4_RX_RCLK_AUXDATA_SEL 0x064#define QSERDES_V4_RX_AC_JTAG_ENABLE 0x068#define QSERDES_V4_RX_AC_JTAG_MODE 0x078
@@ -759,26 +759,26 @@#define QSERDES_V4_20_RX_MARG_COARSE_CTRL2 0x23c/* Only for QMP V4 PHY - UFS PCS registers */ -#define QPHY_V4_PCS_UFS_PHY_START 0x000 -#define QPHY_V4_PCS_UFS_POWER_DOWN_CONTROL 0x004 -#define QPHY_V4_PCS_UFS_SW_RESET 0x008 -#define QPHY_V4_PCS_UFS_TIMER_20US_CORECLK_STEPS_MSB 0x00c -#define QPHY_V4_PCS_UFS_TIMER_20US_CORECLK_STEPS_LSB 0x010 -#define QPHY_V4_PCS_UFS_PLL_CNTL 0x02c -#define QPHY_V4_PCS_UFS_TX_LARGE_AMP_DRV_LVL 0x030 -#define QPHY_V4_PCS_UFS_TX_SMALL_AMP_DRV_LVL 0x038 -#define QPHY_V4_PCS_UFS_BIST_FIXED_PAT_CTRL 0x060 -#define QPHY_V4_PCS_UFS_TX_HSGEAR_CAPABILITY 0x074 -#define QPHY_V4_PCS_UFS_RX_HSGEAR_CAPABILITY 0x0b4 -#define QPHY_V4_PCS_UFS_DEBUG_BUS_CLKSEL 0x124 -#define QPHY_V4_PCS_UFS_LINECFG_DISABLE 0x148 -#define QPHY_V4_PCS_UFS_RX_MIN_HIBERN8_TIME 0x150 -#define QPHY_V4_PCS_UFS_RX_SIGDET_CTRL2 0x158 -#define QPHY_V4_PCS_UFS_TX_PWM_GEAR_BAND 0x160 -#define QPHY_V4_PCS_UFS_TX_HS_GEAR_BAND 0x168 +#define QPHY_V4_PCS_UFS_PHY_START 0x000 +#define QPHY_V4_PCS_UFS_POWER_DOWN_CONTROL 0x004 +#define QPHY_V4_PCS_UFS_SW_RESET 0x008 +#define QPHY_V4_PCS_UFS_TIMER_20US_CORECLK_STEPS_MSB 0x00c +#define QPHY_V4_PCS_UFS_TIMER_20US_CORECLK_STEPS_LSB 0x010 +#define QPHY_V4_PCS_UFS_PLL_CNTL 0x02c +#define QPHY_V4_PCS_UFS_TX_LARGE_AMP_DRV_LVL 0x030 +#define QPHY_V4_PCS_UFS_TX_SMALL_AMP_DRV_LVL 0x038 +#define QPHY_V4_PCS_UFS_BIST_FIXED_PAT_CTRL 0x060 +#define QPHY_V4_PCS_UFS_TX_HSGEAR_CAPABILITY 0x074 +#define QPHY_V4_PCS_UFS_RX_HSGEAR_CAPABILITY 0x0b4 +#define QPHY_V4_PCS_UFS_DEBUG_BUS_CLKSEL 0x124 +#define QPHY_V4_PCS_UFS_LINECFG_DISABLE 0x148 +#define QPHY_V4_PCS_UFS_RX_MIN_HIBERN8_TIME 0x150 +#define QPHY_V4_PCS_UFS_RX_SIGDET_CTRL2 0x158 +#define QPHY_V4_PCS_UFS_TX_PWM_GEAR_BAND 0x160 +#define QPHY_V4_PCS_UFS_TX_HS_GEAR_BAND 0x168#define QPHY_V4_PCS_UFS_READY_STATUS 0x180 -#define QPHY_V4_PCS_UFS_TX_MID_TERM_CTRL1 0x1d8 -#define QPHY_V4_PCS_UFS_MULTI_LANE_CTRL1 0x1e0 +#define QPHY_V4_PCS_UFS_TX_MID_TERM_CTRL1 0x1d8 +#define QPHY_V4_PCS_UFS_MULTI_LANE_CTRL1 0x1e0/* PCIE GEN3 COM registers */ #define PCIE_GEN3_QHP_COM_SSC_EN_CENTER 0x14
@@ -1140,8 +1140,8 @@/* Only for QMP V5 PHY - TX registers */ #define QSERDES_V5_TX_RES_CODE_LANE_TX 0x34#define QSERDES_V5_TX_RES_CODE_LANE_RX 0x38 -#define QSERDES_V5_TX_RES_CODE_LANE_OFFSET_TX 0x3c -#define QSERDES_V5_TX_RES_CODE_LANE_OFFSET_RX 0x40 +#define QSERDES_V5_TX_RES_CODE_LANE_OFFSET_TX 0x3c +#define QSERDES_V5_TX_RES_CODE_LANE_OFFSET_RX 0x40#define QSERDES_V5_TX_LANE_MODE_1 0x84#define QSERDES_V5_TX_LANE_MODE_2 0x88#define QSERDES_V5_TX_LANE_MODE_3 0x8c
Signature · 1 line
2.35.1
PATCH 3/3 phy: qcom-qmp: clean up hex defines
In reply to Johan HovoldUse lower case hex consistently for define values.
--- drivers/phy/qualcomm/phy-qcom-qmp.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/phy/qualcomm/phy-qcom-qmp.h +8 -8
@@ -30,7 +30,7 @@#define QSERDES_PLL_CP_CTRL_MODE0 0x080#define QSERDES_PLL_CP_CTRL_MODE1 0x084#define QSERDES_PLL_PLL_RCTRL_MODE0 0x088 -#define QSERDES_PLL_PLL_RCTRL_MODE1 0x08C +#define QSERDES_PLL_PLL_RCTRL_MODE1 0x08c#define QSERDES_PLL_PLL_CCTRL_MODE0 0x090#define QSERDES_PLL_PLL_CCTRL_MODE1 0x094#define QSERDES_PLL_BIAS_EN_CTRL_BY_PSM 0x0a4
@@ -44,7 +44,7 @@#define QSERDES_PLL_DIV_FRAC_START3_MODE0 0x0e0#define QSERDES_PLL_DIV_FRAC_START1_MODE1 0x0e4#define QSERDES_PLL_DIV_FRAC_START2_MODE1 0x0e8 -#define QSERDES_PLL_DIV_FRAC_START3_MODE1 0x0eC +#define QSERDES_PLL_DIV_FRAC_START3_MODE1 0x0ec#define QSERDES_PLL_INTEGLOOP_GAIN0_MODE0 0x100#define QSERDES_PLL_INTEGLOOP_GAIN1_MODE0 0x104#define QSERDES_PLL_INTEGLOOP_GAIN0_MODE1 0x108
@@ -270,11 +270,11 @@#define QPHY_RX_MIN_HIBERN8_TIME 0x140#define QPHY_RX_SIGDET_CTRL2 0x148#define QPHY_RX_PWM_GEAR_BAND 0x154 -#define QPHY_PLL_LOCK_CHK_DLY_TIME_AUXCLK_LSB 0x1A8 -#define QPHY_OSC_DTCT_ACTIONS 0x1AC -#define QPHY_RX_SIGDET_LVL 0x1D8 -#define QPHY_L1SS_WAKEUP_DLY_TIME_AUXCLK_LSB 0x1DC -#define QPHY_L1SS_WAKEUP_DLY_TIME_AUXCLK_MSB 0x1E0 +#define QPHY_PLL_LOCK_CHK_DLY_TIME_AUXCLK_LSB 0x1a8 +#define QPHY_OSC_DTCT_ACTIONS 0x1ac +#define QPHY_RX_SIGDET_LVL 0x1d8 +#define QPHY_L1SS_WAKEUP_DLY_TIME_AUXCLK_LSB 0x1dc +#define QPHY_L1SS_WAKEUP_DLY_TIME_AUXCLK_MSB 0x1e0/* Only for QMP V3 & V4 PHY - DP COM registers */ #define QPHY_V3_DP_COM_PHY_MODE_CTRL 0x00
@@ -639,7 +639,7 @@#define QSERDES_V4_TX_TRAN_DRVR_EMP_EN 0xb8#define QSERDES_V4_TX_TX_INTERFACE_MODE 0xbc#define QSERDES_V4_TX_PWM_GEAR_1_DIVIDER_BAND0_1 0xd8 -#define QSERDES_V4_TX_PWM_GEAR_2_DIVIDER_BAND0_1 0xdC +#define QSERDES_V4_TX_PWM_GEAR_2_DIVIDER_BAND0_1 0xdc#define QSERDES_V4_TX_PWM_GEAR_3_DIVIDER_BAND0_1 0xe0#define QSERDES_V4_TX_PWM_GEAR_4_DIVIDER_BAND0_1 0xe4#define QSERDES_V4_TX_VMODE_CTRL1 0xe8
Signature · 1 line
2.35.1
Re: [PATCH 3/3] phy: qcom-qmp: clean up hex defines
Quoted 3 lines · Johan Hovold
Use lower case hex consistently for define values.
Signed-off-by Johan Hovold <[email protected]>
Quoted 52 lines
--- drivers/phy/qualcomm/phy-qcom-qmp.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)drivers/phy/qualcomm/phy-qcom-qmp.h +8
-8@@ -30,7 +30,7 @@#define QSERDES_PLL_CP_CTRL_MODE0 0x080#define QSERDES_PLL_CP_CTRL_MODE1 0x084#define QSERDES_PLL_PLL_RCTRL_MODE0 0x088 -#define QSERDES_PLL_PLL_RCTRL_MODE1 0x08C +#define QSERDES_PLL_PLL_RCTRL_MODE1 0x08c#define QSERDES_PLL_PLL_CCTRL_MODE0 0x090#define QSERDES_PLL_PLL_CCTRL_MODE1 0x094#define QSERDES_PLL_BIAS_EN_CTRL_BY_PSM 0x0a4@@ -44,7 +44,7 @@#define QSERDES_PLL_DIV_FRAC_START3_MODE0 0x0e0#define QSERDES_PLL_DIV_FRAC_START1_MODE1 0x0e4#define QSERDES_PLL_DIV_FRAC_START2_MODE1 0x0e8 -#define QSERDES_PLL_DIV_FRAC_START3_MODE1 0x0eC +#define QSERDES_PLL_DIV_FRAC_START3_MODE1 0x0ec#define QSERDES_PLL_INTEGLOOP_GAIN0_MODE0 0x100#define QSERDES_PLL_INTEGLOOP_GAIN1_MODE0 0x104#define QSERDES_PLL_INTEGLOOP_GAIN0_MODE1 0x108@@ -270,11 +270,11 @@#define QPHY_RX_MIN_HIBERN8_TIME 0x140#define QPHY_RX_SIGDET_CTRL2 0x148#define QPHY_RX_PWM_GEAR_BAND 0x154 -#define QPHY_PLL_LOCK_CHK_DLY_TIME_AUXCLK_LSB 0x1A8 -#define QPHY_OSC_DTCT_ACTIONS 0x1AC -#define QPHY_RX_SIGDET_LVL 0x1D8 -#define QPHY_L1SS_WAKEUP_DLY_TIME_AUXCLK_LSB 0x1DC -#define QPHY_L1SS_WAKEUP_DLY_TIME_AUXCLK_MSB 0x1E0 +#define QPHY_PLL_LOCK_CHK_DLY_TIME_AUXCLK_LSB 0x1a8 +#define QPHY_OSC_DTCT_ACTIONS 0x1ac +#define QPHY_RX_SIGDET_LVL 0x1d8 +#define QPHY_L1SS_WAKEUP_DLY_TIME_AUXCLK_LSB 0x1dc +#define QPHY_L1SS_WAKEUP_DLY_TIME_AUXCLK_MSB 0x1e0/* Only for QMP V3 & V4 PHY - DP COM registers */ #define QPHY_V3_DP_COM_PHY_MODE_CTRL 0x00@@ -639,7 +639,7 @@#define QSERDES_V4_TX_TRAN_DRVR_EMP_EN 0xb8#define QSERDES_V4_TX_TX_INTERFACE_MODE 0xbc#define QSERDES_V4_TX_PWM_GEAR_1_DIVIDER_BAND0_1 0xd8 -#define QSERDES_V4_TX_PWM_GEAR_2_DIVIDER_BAND0_1 0xdC +#define QSERDES_V4_TX_PWM_GEAR_2_DIVIDER_BAND0_1 0xdc#define QSERDES_V4_TX_PWM_GEAR_3_DIVIDER_BAND0_1 0xe0#define QSERDES_V4_TX_PWM_GEAR_4_DIVIDER_BAND0_1 0xe4#define QSERDES_V4_TX_VMODE_CTRL1 0xe8
Signature · 7 lines
With best wishes Dmitry -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Quoted 7 lines · Johan Hovold
Here are some trivial cleanups of the QMP defines for issues found while adding support for SC8280XP.
Johan Hovold (3):
phy: qcom-qmp: clean up v4 and v5 define order
phy: qcom-qmp: clean up define alignment
phy: qcom-qmp: clean up hex defines
Any comments to these, Vinod?
Quoted 2 lines
drivers/phy/qualcomm/phy-qcom-qmp.h | 70 ++++++++++++++--------------- 1 file changed, 35 insertions(+), 35 deletions(-)
Johan
Signature · 3 lines
linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Quoted 2 lines · Johan Hovold
Here are some trivial cleanups of the QMP defines for issues found while adding support for SC8280XP.
Applied, thanks
Signature · 1 line
~Vinod