Skip to contentSkip to conversation

multipath-tools: tests: fix hwtable test

PATCH In review [email protected] 2 participants 2 messages Jun 9, 2022 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 multipath-tools: tests: fix hwtable test

From: Martin Wilck <[email protected]>

After "libmultipath: hwtable: new defaults for NVMe", we need to fix the unit tests.

---
 tests/hwtable.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tests/hwtable.c +2 -2
index e60e914..bfaf613 100644
@@ -573,7 +573,7 @@ static void test_internal_nvme(const struct hwt_state *hwt)
 	assert_ptr_not_equal(mp, NULL);
 	TEST_PROP(checker_name(&pp->checker), NONE);
 	TEST_PROP(pp->uid_attribute, DEFAULT_NVME_UID_ATTRIBUTE);
-	assert_int_equal(mp->pgpolicy, DEFAULT_PGPOLICY);
+	assert_int_equal(mp->pgpolicy, GROUP_BY_PRIO);
 	assert_int_equal(mp->no_path_retry, DEFAULT_NO_PATH_RETRY);
 	assert_int_equal(mp->retain_hwhandler, RETAIN_HWHANDLER_OFF);
 
@@ -586,7 +586,7 @@ static void test_internal_nvme(const struct hwt_state *hwt)
 	assert_ptr_not_equal(mp, NULL);
 	TEST_PROP(checker_name(&pp->checker), NONE);
 	TEST_PROP(pp->uid_attribute, "ID_WWN");
-	assert_int_equal(mp->pgpolicy, MULTIBUS);
+	assert_int_equal(mp->pgpolicy, GROUP_BY_PRIO);
 	assert_int_equal(mp->no_path_retry, NO_PATH_RETRY_QUEUE);
 	assert_int_equal(mp->retain_hwhandler, RETAIN_HWHANDLER_OFF);
 }
Signature · 6 lines
2.36.1

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · On Thu, Jun 09, 2022 at 12:13:55PM +0200, [email protected] wrote:

From: Martin Wilck <[email protected]>

After "libmultipath: hwtable: new defaults for NVMe", we need to fix the unit tests.

Quoted 28 lines
---
 tests/hwtable.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tests/hwtable.c +2 -2
index e60e914..bfaf613 100644
@@ -573,7 +573,7 @@ static void test_internal_nvme(const struct hwt_state *hwt)
 	assert_ptr_not_equal(mp, NULL);
 	TEST_PROP(checker_name(&pp->checker), NONE);
 	TEST_PROP(pp->uid_attribute, DEFAULT_NVME_UID_ATTRIBUTE);
-	assert_int_equal(mp->pgpolicy, DEFAULT_PGPOLICY);
+	assert_int_equal(mp->pgpolicy, GROUP_BY_PRIO);
 	assert_int_equal(mp->no_path_retry, DEFAULT_NO_PATH_RETRY);
 	assert_int_equal(mp->retain_hwhandler, RETAIN_HWHANDLER_OFF);
 
@@ -586,7 +586,7 @@ static void test_internal_nvme(const struct hwt_state *hwt)
 	assert_ptr_not_equal(mp, NULL);
 	TEST_PROP(checker_name(&pp->checker), NONE);
 	TEST_PROP(pp->uid_attribute, "ID_WWN");
-	assert_int_equal(mp->pgpolicy, MULTIBUS);
+	assert_int_equal(mp->pgpolicy, GROUP_BY_PRIO);
 	assert_int_equal(mp->no_path_retry, NO_PATH_RETRY_QUEUE);
 	assert_int_equal(mp->retain_hwhandler, RETAIN_HWHANDLER_OFF);
 }
Signature · 1 line
2.36.1

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel