Skip to contentSkip to conversation

arm64: dts: rockchip: Fix SoQuartz CM4IO usb

PATCH In review Peter Geis 2 participants 5 messages Jun 10, 2022 – Jun 11, 2022

Subsystems (2)
lore
Share & tools
lore

Peter Geis

author
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: Fix SoQuartz CM4IO usb

The SoQuartz CM4-IO should support otg mode, however it currently defaults to device mode when otg is enabled. Force it to host mode to retain the previous behavior.

Fixes bc405bb3eeee ("arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk356x")
---
 arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts +1 -0
index e00568a6be5c..56764fae9f9d 100644
@@ -169,6 +169,7 @@ &usb2phy0_otg {
 };
 
 &usb_host0_xhci {
+	dr_mode = "host";
 	status = "okay";
 };
 
Signature · 1 line
2.25.1
author
#1 lore raw
Quoted 4 lines · Peter Geis

The SoQuartz CM4-IO should support otg mode, however it currently defaults to device mode when otg is enabled. Force it to host mode to retain the previous behavior.

It would seem the role-switch issue is more widespread than originally thought, affecting other boards where automatic control should work. Please hold this patch while I investigate further.

Thanks!

Quoted 23 lines
Fixes bc405bb3eeee ("arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk356x")
---
 arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts +1 -1
index e00568a6be5c..56764fae9f9d 100644
@@ -169,6 +169,7 @@ &usb2phy0_otg {
 };
 
 &usb_host0_xhci {
+       dr_mode = "host";
        status = "okay";
 };
 
--

2.25.1

maintainer
#2 lore raw

Am Freitag, 10. Juni 2022, 16:44:23 CEST schrieb Peter Geis:

Quoted 9 lines · Peter Geis
Quoted 4 lines

The SoQuartz CM4-IO should support otg mode, however it currently defaults to device mode when otg is enabled. Force it to host mode to retain the previous behavior.

It would seem the role-switch issue is more widespread than originally thought, affecting other boards where automatic control should work. Please hold this patch while I investigate further.

ok!

I guess this also applies to
"arm64: dts: rockchip: Fix Quartz64-A dwc3 otg port behavior"?

Heiko

Quoted 24 lines
Quoted 23 lines
Fixes bc405bb3eeee ("arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk356x")
---
 arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts +1 -1
index e00568a6be5c..56764fae9f9d 100644
@@ -169,6 +169,7 @@ &usb2phy0_otg {
 };
 
 &usb_host0_xhci {
+       dr_mode = "host";
        status = "okay";
 };
 
--

2.25.1

author
#3 lore raw
Quoted 8 lines · Heiko Stuebner

Am Freitag, 10. Juni 2022, 16:44:23 CEST schrieb Peter Geis:

Quoted 6 lines · Peter Geis
Quoted 4 lines

The SoQuartz CM4-IO should support otg mode, however it currently defaults to device mode when otg is enabled. Force it to host mode to retain the previous behavior.

Quoted 8 lines
Quoted 3 lines

It would seem the role-switch issue is more widespread than originally thought, affecting other boards where automatic control should work. Please hold this patch while I investigate further.

ok!

I guess this also applies to
"arm64: dts: rockchip: Fix Quartz64-A dwc3 otg port behavior"?

No, on Quartz64 Model A it can't work, the requisite pin isn't connected. I think I've found the problem, I've requested a few people to test a fix. Do you have a Model B or SoQuartz to test against (or any other rk356x board that has the id pin hooked up)?

Thanks,
Peter

Quoted 33 lines

Heiko

Quoted 24 lines
Quoted 23 lines
Fixes bc405bb3eeee ("arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk356x")
---
 arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts +1 -1
index e00568a6be5c..56764fae9f9d 100644
@@ -169,6 +169,7 @@ &usb2phy0_otg {
 };
 
 &usb_host0_xhci {
+       dr_mode = "host";
        status = "okay";
 };
 
--

2.25.1

maintainer
#4 lore raw

Am Samstag, 11. Juni 2022, 15:53:41 CEST schrieb Peter Geis:

Quoted 13 lines · Heiko Stuebner
Quoted 12 lines

Am Freitag, 10. Juni 2022, 16:44:23 CEST schrieb Peter Geis:

Quoted 9 lines · Peter Geis
Quoted 4 lines

The SoQuartz CM4-IO should support otg mode, however it currently defaults to device mode when otg is enabled. Force it to host mode to retain the previous behavior.

It would seem the role-switch issue is more widespread than originally thought, affecting other boards where automatic control should work. Please hold this patch while I investigate further.

Quoted 6 lines
Quoted 4 lines

ok!

I guess this also applies to
"arm64: dts: rockchip: Fix Quartz64-A dwc3 otg port behavior"?

No, on Quartz64 Model A it can't work, the requisite pin isn't connected.

ok, so I can pick that other patch up :-) .

Quoted 3 lines

I think I've found the problem, I've requested a few people to test a fix. Do you have a Model B or SoQuartz to test against (or any other rk356x board that has the id pin hooked up)?

The rk356x in my boardfarm is a Quartz-B ... though an very early model, so hopefully nothing changed on the board since then.

Although there is nothing connected to usb right now and I only have remote access this weekend, so any usb tests would need to wait till next week on my end.

Heiko

Quoted 38 lines

Thanks,
Peter

Quoted 33 lines

Heiko

Quoted 24 lines
Quoted 23 lines
Fixes bc405bb3eeee ("arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk356x")
---
 arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts +1 -1
index e00568a6be5c..56764fae9f9d 100644
@@ -169,6 +169,7 @@ &usb2phy0_otg {
 };
 
 &usb_host0_xhci {
+       dr_mode = "host";
        status = "okay";
 };
 
--

2.25.1