Skip to contentSkip to conversation

rockchip: pinebook-pro: minor SPI flash fixes

PATCH In review Peter Robinson 2 participants 2 messages Jun 12, 2022 – Jun 29, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rockchip: pinebook-pro: minor SPI flash fixes

Set a default offset for environment so it doesn't write it to unexpected locations, drop unneeded mtd config option.

---
 configs/pinebook-pro-rk3399_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/pinebook-pro-rk3399_defconfig +1 -1
index 8ca1d0708f9..aaa52c6ea70 100644
@@ -5,6 +5,7 @@ CONFIG_ARCH_ROCKCHIP=y
 CONFIG_SYS_TEXT_BASE=0x00200000
 CONFIG_NR_DRAM_BANKS=1
 CONFIG_ENV_SIZE=0x8000
+CONFIG_ENV_OFFSET=0x3F8000
 CONFIG_DEFAULT_DEVICE_TREE="rk3399-pinebook-pro"
 CONFIG_ROCKCHIP_RK3399=y
 CONFIG_TARGET_PINEBOOK_PRO_RK3399=y
@@ -22,7 +23,6 @@ CONFIG_MISC_INIT_R=y
 # CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
 CONFIG_SPL_STACK_R=y
 CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x10000
-CONFIG_SPL_MTD_SUPPORT=y
 CONFIG_SPL_SPI_LOAD=y
 CONFIG_TPL=y
 CONFIG_CMD_BOOTZ=y
Signature · 1 line
2.36.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Peter Robinson

Set a default offset for environment so it doesn't write it to unexpected locations, drop unneeded mtd config option.

Thanks,

- Kever

Quoted 24 lines
---
  configs/pinebook-pro-rk3399_defconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
configs/pinebook-pro-rk3399_defconfig +1 -1
index 8ca1d0708f9..aaa52c6ea70 100644
@@ -5,6 +5,7 @@ CONFIG_ARCH_ROCKCHIP=y
  CONFIG_SYS_TEXT_BASE=0x00200000
  CONFIG_NR_DRAM_BANKS=1
  CONFIG_ENV_SIZE=0x8000
+CONFIG_ENV_OFFSET=0x3F8000
  CONFIG_DEFAULT_DEVICE_TREE="rk3399-pinebook-pro"
  CONFIG_ROCKCHIP_RK3399=y
  CONFIG_TARGET_PINEBOOK_PRO_RK3399=y
@@ -22,7 +23,6 @@ CONFIG_MISC_INIT_R=y
  # CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
  CONFIG_SPL_STACK_R=y
  CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x10000
-CONFIG_SPL_MTD_SUPPORT=y
  CONFIG_SPL_SPI_LOAD=y
  CONFIG_TPL=y
  CONFIG_CMD_BOOTZ=y