scsi: target: iscsi: Fix NULL pointer dereference in iscsi_conn_auth_required()
Subsystems (2)
PATCH 1/1 scsi: target: iscsi: Fix NULL pointer dereference in iscsi_conn_auth_required()
Fix following coccicheck error:
./drivers/target/iscsi/iscsi_target_nego.c:831:13-26: ERROR: se_nacl is NULL but dereferenced.
--- drivers/target/iscsi/iscsi_target_nego.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/target/iscsi/iscsi_target_nego.c +1 -2
@@ -827,8 +827,7 @@ static bool iscsi_conn_auth_required(struct iscsit_conn *conn)*/ se_nacl = conn->sess->se_sess->se_node_acl;if (!se_nacl) { -pr_debug ("Unknown ACL %s is trying to connect\n" , - se_nacl->initiatorname); +pr_debug ("Unknown ACL is trying to connect\n" );return true; }
Signature · 1 line
2.20.1.7.g153144c
Quoted 6 lines · Yang Li
Fix following coccicheck error:
./drivers/target/iscsi/iscsi_target_nego.c:831:13-26: ERROR:se_naclis NULL but dereferenced.Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>
This was just added in Martin's 5.20 tree in:
a75fcb0912a549c6c1da8395f33271ce06e84acd
scsi: target: iscsi: Extract auth functions
Do we need a Fixes or should the original patch be fixed?
Patch looks ok to me, so if we just add it:
Quoted 18 lines
--- drivers/target/iscsi/iscsi_target_nego.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/target/iscsi/iscsi_target_nego.c +1
-2@@ -827,8 +827,7 @@ static bool iscsi_conn_auth_required(struct iscsit_conn *conn)*/ se_nacl = conn->sess->se_sess->se_node_acl;if (!se_nacl) { -pr_debug ("Unknown ACL %s is trying to connect\n" , - se_nacl->initiatorname); +pr_debug ("Unknown ACL is trying to connect\n" );return true; }
Martin K. Petersen
AppliedYang,
Quoted 3 lines
Fix following coccicheck error:
./drivers/target/iscsi/iscsi_target_nego.c:831:13-26: ERROR:se_naclis NULL but dereferenced.
Applied to 5.20/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 5 lines · Yang Li
Fix following coccicheck error:
./drivers/target/iscsi/iscsi_target_nego.c:831:13-26: ERROR:se_naclis NULL but dereferenced.
Applied to 5.20/scsi-queue, thanks!
[1/1] scsi: target: iscsi: Fix NULL pointer dereference in iscsi_conn_auth_required()
https://git.kernel.org/mkp/scsi/c/35bf020bd8ab
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering