Skip to contentSkip to conversation

pinctrl: imx: Add the zero base flag for imx93

PATCH In review Jacky Bai 2 participants 5 messages Jun 13, 2022 – Jul 6, 2022

Subsystems (4)
lore
Share & tools
lore

Jacky Bai

author maintainer
#0 lore raw

PATCH 1/1 pinctrl: imx: Add the zero base flag for imx93

On i.MX93, the pin mux reg offset is from 0x0, so need to add the 'ZERO_OFFSET_VALID' flag to make sure the pin at mux offset 0 can be found.

---
 drivers/pinctrl/freescale/pinctrl-imx93.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/freescale/pinctrl-imx93.c +1 -0
index c0630f69e995..417e41b37a6f 100644
@@ -239,6 +239,7 @@ static const struct pinctrl_pin_desc imx93_pinctrl_pads[] = {
 static const struct imx_pinctrl_soc_info imx93_pinctrl_info = {
 	.pins = imx93_pinctrl_pads,
 	.npins = ARRAY_SIZE(imx93_pinctrl_pads),
+	.flags = ZERO_OFFSET_VALID,
 	.gpr_compatible = "fsl,imx93-iomuxc-gpr",
 };
 
Signature · 1 line
2.25.1
author maintainer
#1 lore raw

Ping...

BR

Quoted 25 lines

Subject: [PATCH] pinctrl: imx: Add the zero base flag for imx93

On i.MX93, the pin mux reg offset is from 0x0, so need to add the 'ZERO_OFFSET_VALID' flag to make sure the pin at mux offset 0 can be found.

---
 drivers/pinctrl/freescale/pinctrl-imx93.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/freescale/pinctrl-imx93.c +0 -0
index c0630f69e995..417e41b37a6f 100644
@@ -239,6 +239,7 @@ static const struct pinctrl_pin_desc

imx93_pinctrl_pads[] = { static const struct imx_pinctrl_soc_info imx93_pinctrl_info = {

drivers/pinctrl/freescale/pinctrl-imx93.c +1 -1
 	.pins = imx93_pinctrl_pads,
 	.npins = ARRAY_SIZE(imx93_pinctrl_pads),
+	.flags = ZERO_OFFSET_VALID,
 	.gpr_compatible = "fsl,imx93-iomuxc-gpr",  };
 
--

2.25.1

#2 lore raw
In reply to Jacky Bai
Quoted 5 lines · Jacky Bai

On i.MX93, the pin mux reg offset is from 0x0, so need to add the 'ZERO_OFFSET_VALID' flag to make sure the pin at mux offset 0 can be found.

No reply from maintainers for an urgent fix for two weeks -> patch applied.

Jacky, maybe you should be listed as comaintainer for the freescale pin controller if you are doing active maintenance on it?

Yours,
Linus Walleij

author maintainer
#3 lore raw
Quoted 8 lines

Subject: Re: [PATCH] pinctrl: imx: Add the zero base flag for imx93

Quoted 4 lines · Jacky Bai

On i.MX93, the pin mux reg offset is from 0x0, so need to add the 'ZERO_OFFSET_VALID' flag to make sure the pin at mux offset 0 can be found.

Quoted 7 lines
Quoted 1 line

No reply from maintainers for an urgent fix for two weeks -> patch applied.

Jacky, maybe you should be listed as comaintainer for the freescale pin controller if you are doing active maintenance on it?

Yes, I can help on this.

BR

Quoted 2 lines

Yours,
Linus Walleij

#4 lore raw
Quoted 7 lines · Jacky Bai
Quoted 7 lines

Subject: Re: [PATCH] pinctrl: imx: Add the zero base flag for imx93

Quoted 4 lines · Jacky Bai

On i.MX93, the pin mux reg offset is from 0x0, so need to add the 'ZERO_OFFSET_VALID' flag to make sure the pin at mux offset 0 can be found.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

No reply from maintainers for an urgent fix for two weeks -> patch applied.

Jacky, maybe you should be listed as comaintainer for the freescale pin controller if you are doing active maintenance on it?

Yes, I can help on this.

Please send a patch to MAINATINERS adding yourself as maintainer and CC the other maintainers listed there.

Maybe you have some internal NXP mail list and procedure to follow too, no idea :D discuss amongs yourselves if necessary, but I really like active maintainers.

Thanks!
Linus Walleij