blktests: Ignore errors from wait(1)
PATCH 1/1 blktests: Ignore errors from wait(1)
Multiple blktests use wait(1) to wait for background tasks. However in some cases tasks can exit before wait(1) is called and in that case wait(1) complains which breaks expected output. Make sure we ignore output from wait(1) to avoid this breakage.
--- tests/block/016 | 2 +- tests/block/017 | 2 +- tests/block/018 | 2 +- tests/block/024 | 2 +- tests/block/029 | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)
tests/block/016 +1 -1
@@ -41,7 +41,7 @@ test() { # While dd is blocked, send a signal which we know dd has a handler # for. kill -USR1 $! - wait + wait &>/dev/null _exit_null_blk
tests/block/017 +1 -1
@@ -40,7 +40,7 @@ test() { sleep 0.1 show_inflight - wait + wait &>/dev/null show_inflight _exit_null_blk
tests/block/018 +1 -1
@@ -50,7 +50,7 @@ test() { dd if=/dev/nullb1 of=/dev/null bs=4096 iflag=direct count=1 status=none & dd if=/dev/zero of=/dev/nullb1 bs=4096 oflag=direct count=1 status=none & dd if=/dev/zero of=/dev/nullb1 bs=4096 oflag=direct count=1 status=none & - wait + wait &>/dev/null show_times _exit_null_blk
tests/block/024 +1 -1
@@ -57,7 +57,7 @@ test() { dd if=/dev/nullb1 of=/dev/null bs=4096 iflag=direct count=1500 status=none & dd if=/dev/zero of=/dev/nullb1 bs=4096 oflag=direct count=1800 status=none & dd if=/dev/zero of=/dev/nullb1 bs=4096 oflag=direct count=1800 status=none & - wait + wait &>/dev/null show_times _exit_null_blk
tests/block/029 +1 -1
@@ -41,7 +41,7 @@ test() { --runtime="${TIMEOUT}" --name=nullb1 \ --output="${RESULTS_DIR}/block/fio-output-029.txt" \ >>"$FULL" - wait + wait &>/dev/null else echo "Skipping test because $sq cannot be modified" >>"$FULL" fi
Signature · 1 line
2.26.2
Quoted 6 lines · Jan Kara
Multiple blktests use wait(1) to wait for background tasks. However in some cases tasks can exit before wait(1) is called and in that case wait(1) complains which breaks expected output. Make sure we ignore output from wait(1) to avoid this breakage.
Signed-off-by Jan Kara <[email protected]>
Please note that Shinichiro (CC'd here) is a new blktests maintainer and not Omar.
Looks good.
-ck
Quoted 10 lines · Chaitanya Kulkarni
Quoted 6 lines · Jan Kara
Multiple blktests use wait(1) to wait for background tasks. However in some cases tasks can exit before wait(1) is called and in that case wait(1) complains which breaks expected output. Make sure we ignore output from wait(1) to avoid this breakage.
Signed-off-by Jan Kara <[email protected]>Please note that Shinichiro (CC'd here) is a new blktests maintainer and not Omar.
Thanks for review and notifying me. Maybe CONTRIBUTING.md should be updated to speak about Shinichiro and not Omar?
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 7 lines · Jan Kara
Quoted 6 lines · Chaitanya Kulkarni
Quoted 5 lines · Jan Kara
Multiple blktests use wait(1) to wait for background tasks. However in some cases tasks can exit before wait(1) is called and in that case wait(1) complains which breaks expected output. Make sure we ignore output from wait(1) to avoid this breakage.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Jan Kara <[email protected]>Please note that Shinichiro (CC'd here) is a new blktests maintainer and not Omar.
Thanks for review and notifying me. Maybe CONTRIBUTING.md should be updated to speak about Shinichiro and not Omar?
Yes, it was done, just a few weeks ago :)
https://lore.kernel.org/linux-block/[email protected]/
Signature · 1 line
Shin'ichiro Kawasaki
Quoted 4 lines · Jan Kara
Multiple blktests use wait(1) to wait for background tasks. However in some cases tasks can exit before wait(1) is called and in that case wait(1) complains which breaks expected output. Make sure we ignore output from wait(1) to avoid this breakage.
Hi Jan, thanks for the patch.
May I know how to create the wait(1) complaint message? I added sleep command before the waits to ensure the background tasks completed, but was not able to see message by wait on my test system. I suspect it may depend on bash version.
Signature · 1 line
Shin'ichiro Kawasaki
Quoted 6 lines · Shinichiro Kawasaki
Quoted 4 lines · Jan Kara
Multiple blktests use wait(1) to wait for background tasks. However in some cases tasks can exit before wait(1) is called and in that case wait(1) complains which breaks expected output. Make sure we ignore output from wait(1) to avoid this breakage.
Quoted 6 lines
Hi Jan, thanks for the patch.
May I know how to create the wait(1) complaint message? I added sleep command before the waits to ensure the background tasks completed, but was not able to see message by wait on my test system. I suspect it may depend on bash version.
Yes, I suspect it depends on the shell as well (because otherwise I expect people would hit this much earlier than me :). The bash I have is "4.4.23(1)-release" - the one in openSUSE 15.3 and it shows the error pretty reliably...
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 1 line · Jan Kara
On Tue 14-06-22 07:04:54, Shinichiro Kawasaki wrote:
[...]
Quoted 4 lines
Yes, I suspect it depends on the shell as well (because otherwise I expect people would hit this much earlier than me :). The bash I have is "4.4.23(1)-release" - the one in openSUSE 15.3 and it shows the error pretty reliably...
I guess the problematic wait command output is job exit status report. To confirm my guess, could your share example of the wait command output?
Based on my guess, I checked difference between bash 4.4 and my bash 5.1, but I did not find notable bash code change about job exit status report. Hmm.
Your patch covers several waits in the block group. I suspect other waits in other groups may have same risk. Instead of your patch, could you try the patch below on your system? If it works, all waits in all groups can be addressed.
check +4 -0
@@ -440,6 +440,10 @@ _run_test() { RUN_FOR_ZONED=0 FALLBACK_DEVICE=0 + # Ensure job control monitor mode is off in this sub-shell to suppress + # job status output. + set +m + # shellcheck disable=SC1090 . "tests/${TEST_NAME}"
Signature · 1 line
Shin'ichiro Kawasaki
Quoted 13 lines · Shinichiro Kawasaki
Quoted 1 line · Jan Kara
On Tue 14-06-22 07:04:54, Shinichiro Kawasaki wrote:
[...]
Quoted 4 lines
Yes, I suspect it depends on the shell as well (because otherwise I expect people would hit this much earlier than me :). The bash I have is "4.4.23(1)-release" - the one in openSUSE 15.3 and it shows the error pretty reliably...
I guess the problematic wait command output is job exit status report. To confirm my guess, could your share example of the wait command output?
Quoted 6 lines
Based on my guess, I checked difference between bash 4.4 and my bash 5.1, but I did not find notable bash code change about job exit status report. Hmm.
Your patch covers several waits in the block group. I suspect other waits in other groups may have same risk. Instead of your patch, could you try the patch below on your system? If it works, all waits in all groups can be addressed.
Ah, indeed. This patch fixes the problem for me as well. Thanks for looking into this!
Honza
Quoted 20 lines
check +4
-0@@ -440,6 +440,10 @@ _run_test() { RUN_FOR_ZONED=0 FALLBACK_DEVICE=0 + # Ensure job control monitor mode is off in this sub-shell to suppress + # job status output. + set +m + # shellcheck disable=SC1090 . "tests/${TEST_NAME}"Signature · 2 lines
-- Shin'ichiro Kawasaki
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 1 line · Jan Kara
On Wed 15-06-22 11:50:14, Shinichiro Kawasaki wrote:
[...]
Quoted 6 lines
Quoted 3 lines
Your patch covers several waits in the block group. I suspect other waits in other groups may have same risk. Instead of your patch, could you try the patch below on your system? If it works, all waits in all groups can be addressed.
Ah, indeed. This patch fixes the problem for me as well. Thanks for looking into this!
Okay, thanks! I've posted the official patch to go through the review process.
Signature · 1 line
Shin'ichiro Kawasaki