Skip to contentSkip to conversation

drm/msm: Make msm_gem_free_object() static

PATCH In review Rob Clark 3 participants 3 messages Jun 13, 2022 – Jun 14, 2022

Subsystems (3)
lore
Share & tools
lore

Rob Clark

author
#0 lore raw

PATCH 1/1 drm/msm: Make msm_gem_free_object() static

From: Rob Clark <[email protected]>

Misc small cleanup I noticed. Not called from another object file since 3c9edd9c85f5 ("drm/msm: Introduce GEM object funcs")

---
 drivers/gpu/drm/msm/msm_gem.c | 2 +-
 drivers/gpu/drm/msm/msm_gem.h | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/msm/msm_gem.c +1 -1
index 35845e273d81..3ef7ada59392 100644
@@ -1004,7 +1004,7 @@ void msm_gem_describe_objects(struct list_head *list, struct seq_file *m)
 #endif
 
 /* don't call directly!  Use drm_gem_object_put() */
-void msm_gem_free_object(struct drm_gem_object *obj)
+static void msm_gem_free_object(struct drm_gem_object *obj)
 {
 	struct msm_gem_object *msm_obj = to_msm_bo(obj);
 	struct drm_device *dev = obj->dev;
drivers/gpu/drm/msm/msm_gem.h +0 -1
index 6b7d5bb3b575..d608339c1643 100644
@@ -175,7 +175,6 @@ void msm_gem_active_get(struct drm_gem_object *obj, struct msm_gpu *gpu);
 void msm_gem_active_put(struct drm_gem_object *obj);
 int msm_gem_cpu_prep(struct drm_gem_object *obj, uint32_t op, ktime_t *timeout);
 int msm_gem_cpu_fini(struct drm_gem_object *obj);
-void msm_gem_free_object(struct drm_gem_object *obj);
 int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file,
 		uint32_t size, uint32_t flags, uint32_t *handle, char *name);
 struct drm_gem_object *msm_gem_new(struct drm_device *dev,
Signature · 1 line
2.36.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Rob Clark

From: Rob Clark <[email protected]>

Misc small cleanup I noticed. Not called from another object file since 3c9edd9c85f5 ("drm/msm: Introduce GEM object funcs")

Quoted 30 lines
---
  drivers/gpu/drm/msm/msm_gem.c | 2 +-
  drivers/gpu/drm/msm/msm_gem.h | 1 -
  2 files changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/msm/msm_gem.c +1 -1
index 35845e273d81..3ef7ada59392 100644
@@ -1004,7 +1004,7 @@ void msm_gem_describe_objects(struct list_head *list, struct seq_file *m)
  #endif
 
  /* don't call directly!  Use drm_gem_object_put() */
-void msm_gem_free_object(struct drm_gem_object *obj)
+static void msm_gem_free_object(struct drm_gem_object *obj)
  {
  	struct msm_gem_object *msm_obj = to_msm_bo(obj);
  	struct drm_device *dev = obj->dev;
drivers/gpu/drm/msm/msm_gem.h +0 -1
index 6b7d5bb3b575..d608339c1643 100644
@@ -175,7 +175,6 @@ void msm_gem_active_get(struct drm_gem_object *obj, struct msm_gpu *gpu);
  void msm_gem_active_put(struct drm_gem_object *obj);
  int msm_gem_cpu_prep(struct drm_gem_object *obj, uint32_t op, ktime_t *timeout);
  int msm_gem_cpu_fini(struct drm_gem_object *obj);
-void msm_gem_free_object(struct drm_gem_object *obj);
  int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file,
  		uint32_t size, uint32_t flags, uint32_t *handle, char *name);
  struct drm_gem_object *msm_gem_new(struct drm_device *dev,
Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Clark
Quoted 7 lines · Rob Clark

From: Rob Clark <[email protected]>

Misc small cleanup I noticed. Not called from another object file since 3c9edd9c85f5 ("drm/msm: Introduce GEM object funcs")

Quoted 33 lines
---
 drivers/gpu/drm/msm/msm_gem.c | 2 +-
 drivers/gpu/drm/msm/msm_gem.h | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/msm/msm_gem.c +1 -1
index 35845e273d81..3ef7ada59392 100644
@@ -1004,7 +1004,7 @@ void msm_gem_describe_objects(struct list_head *list, struct seq_file *m)
 #endif
 
 /* don't call directly!  Use drm_gem_object_put() */
-void msm_gem_free_object(struct drm_gem_object *obj)
+static void msm_gem_free_object(struct drm_gem_object *obj)
 {
        struct msm_gem_object *msm_obj = to_msm_bo(obj);
        struct drm_device *dev = obj->dev;
drivers/gpu/drm/msm/msm_gem.h +0 -2
index 6b7d5bb3b575..d608339c1643 100644
@@ -175,7 +175,6 @@ void msm_gem_active_get(struct drm_gem_object *obj, struct msm_gpu *gpu);
 void msm_gem_active_put(struct drm_gem_object *obj);
 int msm_gem_cpu_prep(struct drm_gem_object *obj, uint32_t op, ktime_t *timeout);
 int msm_gem_cpu_fini(struct drm_gem_object *obj);
-void msm_gem_free_object(struct drm_gem_object *obj);
 int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file,
                uint32_t size, uint32_t flags, uint32_t *handle, char *name);
 struct drm_gem_object *msm_gem_new(struct drm_device *dev,
--

2.36.1

Signature · 2 lines
With best wishes
Dmitry