Skip to contentSkip to conversation

device: Add connectable flag to bearer state

PATCH In review Luiz Augusto von Dentz 3 participants 5 messages Jun 13, 2022 – Jun 14, 2022 Bluetooth drivers

lore
Share & tools
lore

Luiz Augusto von Dentz

author maintainer
#0 lore raw

PATCH 1/1 device: Add connectable flag to bearer state

From: Luiz Augusto von Dentz <[email protected]>

This adds connectable flag to state so it can be used to detect which is the last seen connectable bearer.

---
 src/adapter.c |  6 +++---
 src/device.c  | 41 +++++++++++++++++++++++------------------
 src/device.h  |  3 ++-
 3 files changed, 28 insertions(+), 22 deletions(-)
src/adapter.c +3 -3
index a75dd61bf..aeef6b7a8 100644
@@ -3484,7 +3484,7 @@ static void device_connect_cb(GIOChannel *io, GError *gerr, gpointer user_data)
 
 	/* continue with service discovery and connection */
 	btd_device_set_temporary(device, false);
-	device_update_last_seen(device, data->dst_type);
+	device_update_last_seen(device, data->dst_type, true);
 
 	if (data->dst_type != BDADDR_BREDR){
 		g_io_channel_set_close_on_unref(io, FALSE);
@@ -6994,7 +6994,7 @@ void btd_adapter_update_found_device(struct btd_adapter *adapter,
 		return;
 	}
 
-	device_update_last_seen(dev, bdaddr_type);
+	device_update_last_seen(dev, bdaddr_type, !not_connectable);
 
 	/*
 	 * FIXME: We need to check for non-zero flags first because
@@ -7006,7 +7006,7 @@ void btd_adapter_update_found_device(struct btd_adapter *adapter,
 					!(eir_data.flags & EIR_BREDR_UNSUP)) {
 		device_set_bredr_support(dev);
 		/* Update last seen for BR/EDR in case its flag is set */
-		device_update_last_seen(dev, BDADDR_BREDR);
+		device_update_last_seen(dev, BDADDR_BREDR, !not_connectable);
 	}
 
 	if (eir_data.name != NULL && eir_data.name_complete)
src/device.c +23 -18

106 lines not on this page · raw message

src/device.h +2 -1
index 5e8d1c3e1..1bf7b3989 100644
@@ -33,7 +33,8 @@ void device_update_addr(struct btd_device *device, const bdaddr_t *bdaddr,
 							uint8_t bdaddr_type);
 void device_set_bredr_support(struct btd_device *device);
 void device_set_le_support(struct btd_device *device, uint8_t bdaddr_type);
-void device_update_last_seen(struct btd_device *device, uint8_t bdaddr_type);
+void device_update_last_seen(struct btd_device *device, uint8_t bdaddr_type,
+							bool last_seen);
 void device_merge_duplicate(struct btd_device *dev, struct btd_device *dup);
 uint32_t btd_device_get_class(struct btd_device *device);
 uint16_t btd_device_get_vendor(struct btd_device *device);
Signature · 1 line
2.35.3
author maintainer
#1 lore raw

PATCH 1/1 monitor/att: Fix decoding for notifications

From: Luiz Augusto von Dentz <[email protected]>

---
 monitor/att.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
monitor/att.c +1 -1
index 00db8ddaa..de70a9dc4 100644
@@ -1547,7 +1547,7 @@ static void print_notify(const struct l2cap_frame *frame, uint16_t handle,
 		return;
 	}
 
-	attr = get_attribute(frame, handle, false);
+	attr = get_attribute(frame, handle, true);
 	if (!attr)
 		return;
 
Signature · 1 line
2.35.3
#2 lore raw

RE: [BlueZ] monitor/att: Fix decoding for notifications

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=650006

---Test result---

Test Summary:

CheckPatch                    PASS      1.10 seconds
GitLint                       PASS      0.70 seconds
Prep - Setup ELL              PASS      37.88 seconds
Build - Prep                  PASS      0.57 seconds
Build - Configure             PASS      7.42 seconds
Build - Make                  PASS      1338.88 seconds
Make Check                    PASS      11.80 seconds
Make Check w/Valgrind         PASS      398.51 seconds
Make Distcheck                PASS      212.71 seconds
Build w/ext ELL - Configure   PASS      7.30 seconds
Build w/ext ELL - Make        PASS      1275.21 seconds
Incremental Build with patchesPASS      0.00 seconds

---
Regards,
Linux Bluetooth

#3 lore raw

Re: [PATCH BlueZ] monitor/att: Fix decoding for notifications

In reply to Luiz Augusto von Dentz
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 5 lines · On Mon, 13 Jun 2022 16:34:19 -0700 you wrote:

From: Luiz Augusto von Dentz <[email protected]>

---
 monitor/att.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [BlueZ] monitor/att: Fix decoding for notifications

    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=ef14e6eaa7e6

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
#4 lore raw
In reply to Luiz Augusto von Dentz

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=650005

---Test result---

Test Summary:

CheckPatch                    PASS      1.43 seconds
GitLint                       PASS      0.97 seconds
Prep - Setup ELL              PASS      42.60 seconds
Build - Prep                  PASS      0.66 seconds
Build - Configure             PASS      8.47 seconds
Build - Make                  PASS      1391.45 seconds
Make Check                    PASS      11.87 seconds
Make Check w/Valgrind         PASS      445.83 seconds
Make Distcheck                PASS      231.66 seconds
Build w/ext ELL - Configure   PASS      8.62 seconds
Build w/ext ELL - Make        PASS      1383.55 seconds
Incremental Build with patchesPASS      0.00 seconds

---
Regards,
Linux Bluetooth