PCI: Add ACS quirk for Broadcom BCM5750x NICs
Subsystems (3)
PATCH 1/1 PCI: Add ACS quirk for Broadcom BCM5750x NICs
From: Pavan Chebbi <[email protected]>
The Broadcom BCM5750x NICs may be multi-function devices. They do not advertise ACS capability. Peer-to-peer transactions are not possible between the individual functions, so it is safe to treat them as fully isolated.
Add an ACS quirk for these devices so the functions can be in independent IOMMU groups and attached individually to userspace applications using VFIO.
--- drivers/pci/quirks.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/pci/quirks.c +3 -0
@@ -4924,6 +4924,9 @@ static const struct pci_dev_acs_enabled { { PCI_VENDOR_ID_AMPERE, 0xE00C, pci_quirk_xgene_acs },/* Broadcom multi-function device */ { PCI_VENDOR_ID_BROADCOM, 0x16D7, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1750, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1751, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1752, pci_quirk_mf_endpoint_acs }, { PCI_VENDOR_ID_BROADCOM, 0xD714, pci_quirk_brcm_acs },/* Amazon Annapurna Labs */ { PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS, 0x0031, pci_quirk_al_acs },
Signature · 1 line
2.18.1
Bjorn Helgaas
AppliedQuoted 7 lines · Michael Chan
From: Pavan Chebbi <[email protected]>
The Broadcom BCM5750x NICs may be multi-function devices. They do not advertise ACS capability. Peer-to-peer transactions are not possible between the individual functions, so it is safe to treat them as fully isolated.
Quoted 6 lines
Add an ACS quirk for these devices so the functions can be in independent IOMMU groups and attached individually to userspace applications using VFIO.
Signed-off-by Pavan Chebbi <[email protected]>Signed-off-by Michael Chan <[email protected]>
Applied to pci/virtualization for v5.20, thanks!
Quoted 21 lines
--- drivers/pci/quirks.c | 3 +++ 1 file changed, 3 insertions(+)drivers/pci/quirks.c +3
-0@@ -4924,6 +4924,9 @@ static const struct pci_dev_acs_enabled { { PCI_VENDOR_ID_AMPERE, 0xE00C, pci_quirk_xgene_acs },/* Broadcom multi-function device */ { PCI_VENDOR_ID_BROADCOM, 0x16D7, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1750, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1751, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1752, pci_quirk_mf_endpoint_acs }, { PCI_VENDOR_ID_BROADCOM, 0xD714, pci_quirk_brcm_acs },/* Amazon Annapurna Labs */ { PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS, 0x0031, pci_quirk_al_acs },Signature · 1 line
2.18.1
Quoted 8 lines · Bjorn Helgaas
Quoted 7 lines · Michael Chan
From: Pavan Chebbi <[email protected]>
The Broadcom BCM5750x NICs may be multi-function devices. They do not advertise ACS capability. Peer-to-peer transactions are not possible between the individual functions, so it is safe to treat them as fully isolated.
Quoted 8 lines
Quoted 6 lines
Add an ACS quirk for these devices so the functions can be in independent IOMMU groups and attached individually to userspace applications using VFIO.
Signed-off-by Pavan Chebbi <[email protected]>Signed-off-by Michael Chan <[email protected]>Applied to pci/virtualization for v5.20, thanks!
I forgot to ask: is there a plan for future devices to include an ACS capability? Or will we be stuck adding quirks forever?
Quoted 23 lines
Quoted 21 lines
--- drivers/pci/quirks.c | 3 +++ 1 file changed, 3 insertions(+)drivers/pci/quirks.c +3
-0@@ -4924,6 +4924,9 @@ static const struct pci_dev_acs_enabled { { PCI_VENDOR_ID_AMPERE, 0xE00C, pci_quirk_xgene_acs },/* Broadcom multi-function device */ { PCI_VENDOR_ID_BROADCOM, 0x16D7, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1750, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1751, pci_quirk_mf_endpoint_acs }, + { PCI_VENDOR_ID_BROADCOM, 0x1752, pci_quirk_mf_endpoint_acs }, { PCI_VENDOR_ID_BROADCOM, 0xD714, pci_quirk_brcm_acs },/* Amazon Annapurna Labs */ { PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS, 0x0031, pci_quirk_al_acs },Signature · 1 line
2.18.1
Quoted 14 lines · Bjorn Helgaas
Quoted 12 lines · Bjorn Helgaas
Quoted 11 lines · Michael Chan
From: Pavan Chebbi <[email protected]>
The Broadcom BCM5750x NICs may be multi-function devices. They do not advertise ACS capability. Peer-to-peer transactions are not possible between the individual functions, so it is safe to treat them as fully isolated.
Add an ACS quirk for these devices so the functions can be in independent IOMMU groups and attached individually to userspace applications using VFIO.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Signed-off-by Pavan Chebbi <[email protected]>Signed-off-by Michael Chan <[email protected]>Applied to pci/virtualization for v5.20, thanks!
I forgot to ask: is there a plan for future devices to include an ACS capability? Or will we be stuck adding quirks forever?
I still have not heard back definitively from the hardware team yet. It's likely that the next device will not have ACS but the one after that will have it.