Two sets of trivials
cover Two sets of trivials
From: "Dr. David Alan Gilbert" <[email protected]>
I've sent the 3 char set last month, but have updated it a little; I cleaned up a comment style that was already broken so checkpatch is happy.
The 'namesapce' is a new patch; it's amazing how many places make the same typo!
Dave
Dr. David Alan Gilbert (2):
Trivial: 3 char repeat typos
trivial typos: namesapce
hw/9pfs/9p-xattr-user.c | 8 ++++---- hw/acpi/nvdimm.c | 2 +- hw/intc/openpic.c | 2 +- hw/net/imx_fec.c | 2 +- hw/nvme/ctrl.c | 2 +- hw/pci/pcie_aer.c | 2 +- hw/pci/shpc.c | 3 ++- hw/ppc/spapr_caps.c | 2 +- hw/scsi/spapr_vscsi.c | 2 +- qapi/net.json | 2 +- tools/virtiofsd/passthrough_ll.c | 2 +- ui/input.c | 2 +- 12 files changed, 16 insertions(+), 15 deletions(-)
Signature · 1 line
2.36.1
PATCH 1/2 Trivial: 3 char repeat typos
From: "Dr. David Alan Gilbert" <[email protected]>
Inspired by Julia Lawall's fixing of Linux
kernel comments, I looked at qemu, although I did it manually.
--- hw/intc/openpic.c | 2 +- hw/net/imx_fec.c | 2 +- hw/pci/pcie_aer.c | 2 +- hw/pci/shpc.c | 3 ++- hw/ppc/spapr_caps.c | 2 +- hw/scsi/spapr_vscsi.c | 2 +- qapi/net.json | 2 +- tools/virtiofsd/passthrough_ll.c | 2 +- ui/input.c | 2 +- 9 files changed, 10 insertions(+), 9 deletions(-)
hw/intc/openpic.c +1 -1
@@ -729,7 +729,7 @@ static void openpic_tmr_set_tmr(OpenPICTimer *tmr, uint32_t val, bool enabled) }/* -* Returns the currrent tccr value, i.e., timer value (in clocks) with +* Returns the current tccr value, i.e., timer value (in clocks) with * appropriate TOG. */ static uint64_t openpic_tmr_get_timer (OpenPICTimer *tmr)
hw/net/imx_fec.c +1 -1
@@ -438,7 +438,7 @@ static void imx_eth_update(IMXFECState *s)* assignment fail. * * To ensure that all versions of Linux work, generate ENET_INT_MAC -* interrrupts on both interrupt lines. This should be changed if and when +* interrupts on both interrupt lines. This should be changed if and when * qemu supports IOMUX. */ if (s->regs[ENET_EIR] & s->regs[ENET_EIMR] &
hw/pci/pcie_aer.c +1 -1
@@ -323,7 +323,7 @@ static void pcie_aer_msg_root_port(PCIDevice *dev, const PCIEAERMsg *msg)*/ } -/* Errro Message Received: Root Error Status register */ +/* Error Message Received: Root Error Status register */ switch (msg->severity) {case PCI_ERR_ROOT_CMD_COR_EN :if (root_status &PCI_ERR_ROOT_COR_RCV ) {
hw/pci/shpc.c +2 -1
@@ -480,7 +480,8 @@ static const MemoryRegionOps shpc_mmio_ops = { .endianness = DEVICE_LITTLE_ENDIAN, .valid = {/* SHPC ECN requires dword accesses, but the original 1.0 spec doesn't. -* It's easier to suppport all sizes than worry about it. */ +* It's easier to support all sizes than worry about it. +*/ .min_access_size = 1, .max_access_size = 4, },
hw/ppc/spapr_caps.c +1 -1
@@ -553,7 +553,7 @@ static void cap_ccf_assist_apply(SpaprMachineState *spapr, uint8_t val,* instruction is a harmless no-op. It won't correctly * implement the cache count flush *but* if we have * count-cache-disabled in the host, that flush is -* unnnecessary. So, specifically allow this case. This +* unnecessary. So, specifically allow this case. This * allows us to have better performance on POWER9 DD2.3, * while still working on POWER9 DD2.2 and POWER8 host * cpus.
hw/scsi/spapr_vscsi.c +1 -1
@@ -1013,7 +1013,7 @@ static int vscsi_send_capabilities(VSCSIState *s, vscsi_req *req) }/* -* Current implementation does not suppport any migration or +* Current implementation does not support any migration or * reservation capabilities. Construct the response telling the * guest not to use them. */
qapi/net.json +1 -1
@@ -298,7 +298,7 @@ # # @udp: use the udp version of l2tpv3 encapsulation # -# @cookie64: use 64 bit coookies +# @cookie64: use 64 bit cookies # # @counter: have sequence counter #
tools/virtiofsd/passthrough_ll.c +1 -1
@@ -2319,7 +2319,7 @@ static int do_lo_create(fuse_req_t req, struct lo_inode *parent_inode,* If security.selinux has not been remapped and selinux is enabled, * use fscreate to set context before file creation. If not, use * tmpfile method for regular files. Otherwise fallback to -* non-atomic method of file creation and xattr settting. +* non-atomic method of file creation and xattr setting. */ if (!mapped_name && lo->use_fscreate) { err = do_create_secctx_fscreate(req, parent_inode, name, mode, fi,
ui/input.c +1 -1
@@ -364,7 +364,7 @@ void qemu_input_event_send(QemuConsole *src, InputEvent *evt)* when 'alt+print' was pressed. This flaw is now fixed and the * 'sysrq' key serves no further purpose. We normalize it to * 'print', so that downstream receivers of the event don't -* neeed to deal with this mistake +* need to deal with this mistake */ if (evt->type ==INPUT_EVENT_KIND_KEY && evt->u.key.data->key->u.qcode.data ==Q_KEY_CODE_SYSRQ ) {
Signature · 1 line
2.36.1
Re: [PATCH 1/2] Trivial: 3 char repeat typos
Quoted 7 lines · Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" <[email protected]>
Inspired by Julia Lawall's fixing of Linux
kernel comments, I looked at qemu, although I did it manually.Signed-off-by Dr. David Alan Gilbert <[email protected]>---
Quoted 129 lines
hw/intc/openpic.c | 2 +- hw/net/imx_fec.c | 2 +- hw/pci/pcie_aer.c | 2 +- hw/pci/shpc.c | 3 ++- hw/ppc/spapr_caps.c | 2 +- hw/scsi/spapr_vscsi.c | 2 +- qapi/net.json | 2 +- tools/virtiofsd/passthrough_ll.c | 2 +- ui/input.c | 2 +- 9 files changed, 10 insertions(+), 9 deletions(-)hw/intc/openpic.c +1
-1@@ -729,7 +729,7 @@ static void openpic_tmr_set_tmr(OpenPICTimer *tmr, uint32_t val, bool enabled) }/* -* Returns the currrent tccr value, i.e., timer value (in clocks) with +* Returns the current tccr value, i.e., timer value (in clocks) with * appropriate TOG. */ static uint64_t openpic_tmr_get_timer (OpenPICTimer *tmr)hw/net/imx_fec.c +1
-1@@ -438,7 +438,7 @@ static void imx_eth_update(IMXFECState *s)* assignment fail. * * To ensure that all versions of Linux work, generate ENET_INT_MAC -* interrrupts on both interrupt lines. This should be changed if and when +* interrupts on both interrupt lines. This should be changed if and when * qemu supports IOMUX. */ if (s->regs[ENET_EIR] & s->regs[ENET_EIMR] &hw/pci/pcie_aer.c +1
-1@@ -323,7 +323,7 @@ static void pcie_aer_msg_root_port(PCIDevice *dev, const PCIEAERMsg *msg)*/ } -/* Errro Message Received: Root Error Status register */ +/* Error Message Received: Root Error Status register */ switch (msg->severity) {case PCI_ERR_ROOT_CMD_COR_EN :if (root_status &PCI_ERR_ROOT_COR_RCV ) {hw/pci/shpc.c +2
-1@@ -480,7 +480,8 @@ static const MemoryRegionOps shpc_mmio_ops = { .endianness = DEVICE_LITTLE_ENDIAN, .valid = {/* SHPC ECN requires dword accesses, but the original 1.0 spec doesn't. -* It's easier to suppport all sizes than worry about it. */ +* It's easier to support all sizes than worry about it. +*/ .min_access_size = 1, .max_access_size = 4, },hw/ppc/spapr_caps.c +1
-1@@ -553,7 +553,7 @@ static void cap_ccf_assist_apply(SpaprMachineState *spapr, uint8_t val,* instruction is a harmless no-op. It won't correctly * implement the cache count flush *but* if we have * count-cache-disabled in the host, that flush is -* unnnecessary. So, specifically allow this case. This +* unnecessary. So, specifically allow this case. This * allows us to have better performance on POWER9 DD2.3, * while still working on POWER9 DD2.2 and POWER8 host * cpus. hw/scsi/spapr_vscsi.c +1
-1@@ -1013,7 +1013,7 @@ static int vscsi_send_capabilities(VSCSIState *s, vscsi_req *req) }/* -* Current implementation does not suppport any migration or +* Current implementation does not support any migration or * reservation capabilities. Construct the response telling the * guest not to use them. */ qapi/net.json +1
-1@@ -298,7 +298,7 @@ # # @udp: use the udp version of l2tpv3 encapsulation # -# @cookie64: use 64 bit coookies +# @cookie64: use 64 bit cookies # # @counter: have sequence counter #tools/virtiofsd/passthrough_ll.c +1
-1@@ -2319,7 +2319,7 @@ static int do_lo_create(fuse_req_t req, struct lo_inode *parent_inode,* If security.selinux has not been remapped and selinux is enabled, * use fscreate to set context before file creation. If not, use * tmpfile method for regular files. Otherwise fallback to -* non-atomic method of file creation and xattr settting. +* non-atomic method of file creation and xattr setting. */ if (!mapped_name && lo->use_fscreate) { err = do_create_secctx_fscreate(req, parent_inode, name, mode, fi,ui/input.c +1
-1@@ -364,7 +364,7 @@ void qemu_input_event_send(QemuConsole *src, InputEvent *evt)* when 'alt+print' was pressed. This flaw is now fixed and the * 'sysrq' key serves no further purpose. We normalize it to * 'print', so that downstream receivers of the event don't -* neeed to deal with this mistake +* need to deal with this mistake */ if (evt->type ==INPUT_EVENT_KIND_KEY && evt->u.key.data->key->u.qcode.data ==Q_KEY_CODE_SYSRQ ) {
Laurent Vivier
AppliedRe: [PATCH 1/2] Trivial: 3 char repeat typos
In reply to Dr. David Alan Gilbert (git)Le 14/06/2022 à 12:40, Dr. David Alan Gilbert (git) a écrit :
Quoted 128 lines
From: "Dr. David Alan Gilbert" <[email protected]>
Inspired by Julia Lawall's fixing of Linux
kernel comments, I looked at qemu, although I did it manually.Signed-off-by Dr. David Alan Gilbert <[email protected]>--- hw/intc/openpic.c | 2 +- hw/net/imx_fec.c | 2 +- hw/pci/pcie_aer.c | 2 +- hw/pci/shpc.c | 3 ++- hw/ppc/spapr_caps.c | 2 +- hw/scsi/spapr_vscsi.c | 2 +- qapi/net.json | 2 +- tools/virtiofsd/passthrough_ll.c | 2 +- ui/input.c | 2 +- 9 files changed, 10 insertions(+), 9 deletions(-)hw/intc/openpic.c +1
-1@@ -729,7 +729,7 @@ static void openpic_tmr_set_tmr(OpenPICTimer *tmr, uint32_t val, bool enabled) }/* -* Returns the currrent tccr value, i.e., timer value (in clocks) with +* Returns the current tccr value, i.e., timer value (in clocks) with * appropriate TOG. */ static uint64_t openpic_tmr_get_timer (OpenPICTimer *tmr)hw/net/imx_fec.c +1
-1@@ -438,7 +438,7 @@ static void imx_eth_update(IMXFECState *s)* assignment fail. * * To ensure that all versions of Linux work, generate ENET_INT_MAC -* interrrupts on both interrupt lines. This should be changed if and when +* interrupts on both interrupt lines. This should be changed if and when * qemu supports IOMUX. */ if (s->regs[ENET_EIR] & s->regs[ENET_EIMR] &hw/pci/pcie_aer.c +1
-1@@ -323,7 +323,7 @@ static void pcie_aer_msg_root_port(PCIDevice *dev, const PCIEAERMsg *msg)*/ } -/* Errro Message Received: Root Error Status register */ +/* Error Message Received: Root Error Status register */ switch (msg->severity) {case PCI_ERR_ROOT_CMD_COR_EN :if (root_status &PCI_ERR_ROOT_COR_RCV ) {hw/pci/shpc.c +2
-1@@ -480,7 +480,8 @@ static const MemoryRegionOps shpc_mmio_ops = { .endianness = DEVICE_LITTLE_ENDIAN, .valid = {/* SHPC ECN requires dword accesses, but the original 1.0 spec doesn't. -* It's easier to suppport all sizes than worry about it. */ +* It's easier to support all sizes than worry about it. +*/ .min_access_size = 1, .max_access_size = 4, },hw/ppc/spapr_caps.c +1
-1@@ -553,7 +553,7 @@ static void cap_ccf_assist_apply(SpaprMachineState *spapr, uint8_t val,* instruction is a harmless no-op. It won't correctly * implement the cache count flush *but* if we have * count-cache-disabled in the host, that flush is -* unnnecessary. So, specifically allow this case. This +* unnecessary. So, specifically allow this case. This * allows us to have better performance on POWER9 DD2.3, * while still working on POWER9 DD2.2 and POWER8 host * cpus. hw/scsi/spapr_vscsi.c +1
-1@@ -1013,7 +1013,7 @@ static int vscsi_send_capabilities(VSCSIState *s, vscsi_req *req) }/* -* Current implementation does not suppport any migration or +* Current implementation does not support any migration or * reservation capabilities. Construct the response telling the * guest not to use them. */ qapi/net.json +1
-1@@ -298,7 +298,7 @@ # # @udp: use the udp version of l2tpv3 encapsulation # -# @cookie64: use 64 bit coookies +# @cookie64: use 64 bit cookies # # @counter: have sequence counter #tools/virtiofsd/passthrough_ll.c +1
-1@@ -2319,7 +2319,7 @@ static int do_lo_create(fuse_req_t req, struct lo_inode *parent_inode,* If security.selinux has not been remapped and selinux is enabled, * use fscreate to set context before file creation. If not, use * tmpfile method for regular files. Otherwise fallback to -* non-atomic method of file creation and xattr settting. +* non-atomic method of file creation and xattr setting. */ if (!mapped_name && lo->use_fscreate) { err = do_create_secctx_fscreate(req, parent_inode, name, mode, fi,ui/input.c +0
-0
ui/input.c void qemu_input_event_send(QemuConsole *src, InputEvent *evt) · line 370
Quoted 8 lines
ui/input.c +1
-1@@ -364,7 +364,7 @@ void qemu_input_event_send(QemuConsole *src, InputEvent *evt)* when 'alt+print' was pressed. This flaw is now fixed and the * 'sysrq' key serves no further purpose. We normalize it to * 'print', so that downstream receivers of the event don't -* neeed to deal with this mistake +* need to deal with this mistake */ if (evt->type ==INPUT_EVENT_KIND_KEY && evt->u.key.data->key->u.qcode.data ==Q_KEY_CODE_SYSRQ ) {
Applied to my trivial-patches branch.
Thanks,
Laurent
PATCH 2/2 trivial typos: namesapce
In reply to Dr. David Alan Gilbert (git)From: "Dr. David Alan Gilbert" <[email protected]>
'namespace' is misspelled in a bunch of places.
--- hw/9pfs/9p-xattr-user.c | 8 ++++---- hw/acpi/nvdimm.c | 2 +- hw/nvme/ctrl.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-)
hw/9pfs/9p-xattr-user.c +4 -4
@@ -27,7 +27,7 @@ static ssize_t mp_user_getxattr(FsContext *ctx, const char *path, {if (strncmp (name,"user.virtfs." ,12 ) ==0 ) {/* -* Don't allow fetch of user.virtfs namesapce +* Don't allow fetch of user.virtfs namespace * in case of mapped security */ errno =ENOATTR ;
@@ -49,7 +49,7 @@ static ssize_t mp_user_listxattr(FsContext *ctx, const char *path, name_size -=12 ; }else {/* -* Don't allow fetch of user.virtfs namesapce +* Don't allow fetch of user.virtfs namespace * in case of mapped security */ return 0 ;
@@ -74,7 +74,7 @@ static int mp_user_setxattr(FsContext *ctx, const char *path, const char *name, {if (strncmp (name,"user.virtfs." ,12 ) ==0 ) {/* -* Don't allow fetch of user.virtfs namesapce +* Don't allow fetch of user.virtfs namespace * in case of mapped security */ errno =EACCES ;
@@ -88,7 +88,7 @@ static int mp_user_removexattr(FsContext *ctx, {if (strncmp (name,"user.virtfs." ,12 ) ==0 ) {/* -* Don't allow fetch of user.virtfs namesapce +* Don't allow fetch of user.virtfs namespace * in case of mapped security */ errno =EACCES ;
hw/acpi/nvdimm.c +1 -1
@@ -476,7 +476,7 @@ struct NvdimmFuncGetLabelDataOut {/* the size of buffer filled by QEMU. */ uint32_t len;uint32_t func_ret_status;/* return status code. */ -uint8_t out_buf[];/* the data got via Get Namesapce Label function. */ +uint8_t out_buf[];/* the data got via Get Namespace Label function. */ }QEMU_PACKED ;typedef struct NvdimmFuncGetLabelDataOut NvdimmFuncGetLabelDataOut ;QEMU_BUILD_BUG_ON (sizeof (NvdimmFuncGetLabelDataOut) >NVDIMM_DSM_MEMORY_SIZE );
hw/nvme/ctrl.c +1 -1
@@ -71,7 +71,7 @@* the SUBNQN field in the controller will report the NQN of the subsystem * device. This also enables multi controller capability represented in * Identify Controller data structure in CMIC (Controller Multi-path I/O and -* Namesapce Sharing Capabilities). +* Namespace Sharing Capabilities). * * - `aerl` * The Asynchronous Event Request Limit (AERL). Indicates the maximum number
Signature · 1 line
2.36.1
Laurent Vivier
AppliedRe: [PATCH 2/2] trivial typos: namesapce
Le 14/06/2022 à 12:40, Dr. David Alan Gilbert (git) a écrit :
Quoted 69 lines
From: "Dr. David Alan Gilbert" <[email protected]>
'namespace' is misspelled in a bunch of places.
Signed-off-by Dr. David Alan Gilbert <[email protected]>--- hw/9pfs/9p-xattr-user.c | 8 ++++---- hw/acpi/nvdimm.c | 2 +- hw/nvme/ctrl.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-)hw/9pfs/9p-xattr-user.c +4
-4@@ -27,7 +27,7 @@ static ssize_t mp_user_getxattr(FsContext *ctx, const char *path, {if (strncmp (name,"user.virtfs." ,12 ) ==0 ) {/* -* Don't allow fetch of user.virtfs namesapce +* Don't allow fetch of user.virtfs namespace * in case of mapped security */ errno =ENOATTR ;@@ -49,7 +49,7 @@ static ssize_t mp_user_listxattr(FsContext *ctx, const char *path, name_size -=12 ; }else {/* -* Don't allow fetch of user.virtfs namesapce +* Don't allow fetch of user.virtfs namespace * in case of mapped security */ return 0 ;@@ -74,7 +74,7 @@ static int mp_user_setxattr(FsContext *ctx, const char *path, const char *name, {if (strncmp (name,"user.virtfs." ,12 ) ==0 ) {/* -* Don't allow fetch of user.virtfs namesapce +* Don't allow fetch of user.virtfs namespace * in case of mapped security */ errno =EACCES ;@@ -88,7 +88,7 @@ static int mp_user_removexattr(FsContext *ctx, {if (strncmp (name,"user.virtfs." ,12 ) ==0 ) {/* -* Don't allow fetch of user.virtfs namesapce +* Don't allow fetch of user.virtfs namespace * in case of mapped security */ errno =EACCES ;hw/acpi/nvdimm.c +1
-1@@ -476,7 +476,7 @@ struct NvdimmFuncGetLabelDataOut {/* the size of buffer filled by QEMU. */ uint32_t len;uint32_t func_ret_status;/* return status code. */ -uint8_t out_buf[];/* the data got via Get Namesapce Label function. */ +uint8_t out_buf[];/* the data got via Get Namespace Label function. */ }QEMU_PACKED ;typedef struct NvdimmFuncGetLabelDataOut NvdimmFuncGetLabelDataOut ;QEMU_BUILD_BUG_ON (sizeof (NvdimmFuncGetLabelDataOut) >NVDIMM_DSM_MEMORY_SIZE );hw/nvme/ctrl.c +0
-0
hw/nvme/ctrl.c line 77
Quoted 8 lines
hw/nvme/ctrl.c +1
-1@@ -71,7 +71,7 @@* the SUBNQN field in the controller will report the NQN of the subsystem * device. This also enables multi controller capability represented in * Identify Controller data structure in CMIC (Controller Multi-path I/O and -* Namesapce Sharing Capabilities). +* Namespace Sharing Capabilities). * * - `aerl` * The Asynchronous Event Request Limit (AERL). Indicates the maximum number
Applied to my trivial-patches branch.
Thanks,
Laurent
Quoted 15 lines · Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" <[email protected]>
I've sent the 3 char set last month, but have updated it a little; I cleaned up a comment style that was already broken so checkpatch is happy.
The 'namesapce' is a new patch; it's amazing how many places make the same typo!
Dave
Dr. David Alan Gilbert (2):
Trivial: 3 char repeat typos
trivial typos: namesapce
Quoted 17 lines
hw/9pfs/9p-xattr-user.c | 8 ++++---- hw/acpi/nvdimm.c | 2 +- hw/intc/openpic.c | 2 +- hw/net/imx_fec.c | 2 +- hw/nvme/ctrl.c | 2 +- hw/pci/pcie_aer.c | 2 +- hw/pci/shpc.c | 3 ++- hw/ppc/spapr_caps.c | 2 +- hw/scsi/spapr_vscsi.c | 2 +- qapi/net.json | 2 +- tools/virtiofsd/passthrough_ll.c | 2 +- ui/input.c | 2 +- 12 files changed, 16 insertions(+), 15 deletions(-)Signature · 1 line
2.36.1
Nice (and Thanks)!