Skip to contentSkip to conversation

dt-bindings: dma: apple,admac: Fix example interrupt parsing

PATCH Applied Rob Herring 3 participants 3 messages Jun 14, 2022 – Jun 16, 2022

Subsystems (3)
Device tree bindings dmaengine Arm/Apple machine support
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: dma: apple,admac: Fix example interrupt parsing

Commit 873971f8fb08 ("dt-bindings: dma: Add Apple ADMAC") has a warning in its example:

Documentation/devicetree/bindings/dma/apple,admac.example.dtb: dma-controller@238200000: interrupts-extended: [[0], [4294967295, 0, 626, 4, 0, 0]] is too short
From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/dma/apple,admac.yaml

The problem is the number of interrupt cells can't be guessed when there are empty '0' entries. So the example must have a valid interrupt controller defining the number of interrupt cells.

Fixes 873971f8fb08 ("dt-bindings: dma: Add Apple ADMAC")
Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/dma/apple,admac.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/dma/apple,admac.yaml +5 -0
index ab8a4ec7779f..bdc8c129c4f5 100644
@@ -63,6 +63,11 @@ examples:
     #include <dt-bindings/interrupt-controller/apple-aic.h>
     #include <dt-bindings/interrupt-controller/irq.h>
 
+    aic: interrupt-controller {
+      interrupt-controller;
+      #interrupt-cells = <3>;
+    };
+
     admac: dma-controller@238200000 {
       compatible = "apple,t8103-admac", "apple,admac";
       reg = <0x38200000 0x34000>;
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Rob Herring

Commit 873971f8fb08 ("dt-bindings: dma: Add Apple ADMAC") has a warning in its example:

Documentation/devicetree/bindings/dma/apple,admac.example.dtb: dma-controller@238200000: interrupts-extended: [[0], [4294967295, 0, 626, 4, 0, 0]] is too short
From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/dma/apple,admac.yaml

Quoted 6 lines

The problem is the number of interrupt cells can't be guessed when there are empty '0' entries. So the example must have a valid interrupt controller defining the number of interrupt cells.

Fixes 873971f8fb08 ("dt-bindings: dma: Add Apple ADMAC")
Signed-off-by Rob Herring <[email protected]>

Thanks,

Acked-by Martin Povišer <[email protected]>
maintainer Applied
#2 lore raw
In reply to Rob Herring
Quoted 9 lines · Rob Herring

Commit 873971f8fb08 ("dt-bindings: dma: Add Apple ADMAC") has a warning in its example:

Documentation/devicetree/bindings/dma/apple,admac.example.dtb: dma-controller@238200000: interrupts-extended: [[0], [4294967295, 0, 626, 4, 0, 0]] is too short
From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/dma/apple,admac.yaml

The problem is the number of interrupt cells can't be guessed when there are empty '0' entries. So the example must have a valid interrupt controller defining the number of interrupt cells.

Applied, thanks

Signature · 1 line
~Vinod