tools/xenstore: simplify loop handling connection I/O
PATCH 1/1 tools/xenstore: simplify loop handling connection I/O
The loop handling input and output of connections of xenstored is open coding list_for_each_entry_safe() in an incredibly complicated way.
Use list_for_each_entry_safe() instead, making it much more clear how the code is working.
Signed-off-by Juergen Gross <[email protected]>
--- tools/xenstore/xenstored_core.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)
tools/xenstore/xenstored_core.c +2 -10
@@ -2368,16 +2368,8 @@ int main(int argc, char *argv[]) } } - next =list_entry (connections.next,typeof (*conn), list); -if (&next->list != &connections) -talloc_increase_ref_count (next); -while (&next->list != &connections) { - conn = next; - - next =list_entry (conn->list.next, -typeof (*conn), list); -if (&next->list != &connections) -talloc_increase_ref_count (next); +list_for_each_entry_safe (conn, next, &connections, list) { +talloc_increase_ref_count (conn);if (conn_can_read (conn))handle_input (conn);
Signature · 1 line
2.35.3
Hi Juergen,
Quoted 8 lines · Juergen Gross
The loop handling input and output of connections of xenstored is open coding
list_for_each_entry_safe()in an incredibly complicated way.Use
list_for_each_entry_safe()instead, making it much more clear how the code is working.Signed-off-by Juergen Gross <[email protected]>
Reviewed-by Julien Grall <[email protected]>
Cheers,
Signature · 1 line
Julien Grall