4.9.319-rc1 review
Subsystems (3)
Greg Kroah-Hartman
maintainercover 4.9.319-rc1 review
This is the start of the stable review cycle for the 4.9.319 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 16 Jun 2022 18:37:02 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.319-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 4.9.319-rc1
Josh Poimboeuf <[email protected]>
x86/speculation/mmio: Print SMT warning
Pawan Gupta <[email protected]>
KVM: x86/speculation: Disable Fill buffer clear within guests
Pawan Gupta <[email protected]>
x86/speculation/mmio: Reuse SRBDS mitigation for SBDS
Pawan Gupta <[email protected]>
x86/speculation/srbds: Update SRBDS mitigation selection
Pawan Gupta <[email protected]>
x86/speculation/mmio: Add sysfs reporting for Processor MMIO Stale Data
Pawan Gupta <[email protected]>
x86/speculation/mmio: Enable CPU Fill buffer clearing on idle
Pawan Gupta <[email protected]>
x86/bugs: Group MDS, TAA & Processor MMIO Stale Data mitigations
Pawan Gupta <[email protected]>
x86/speculation/mmio: Add mitigation for Processor MMIO Stale Data
Pawan Gupta <[email protected]>
x86/speculation: Add a common function for MD_CLEAR mitigation update
Pawan Gupta <[email protected]>
x86/speculation/mmio: Enumerate Processor MMIO Stale Data bug
Pawan Gupta <[email protected]>
Documentation: Add documentation for Processor MMIO Stale Data
Gayatri Kammela <[email protected]>
x86/cpu: Add another Alder Lake CPU to the Intel family
Tony Luck <[email protected]>
x86/cpu: Add Lakefield, Alder Lake and Rocket Lake models to the to Intel CPU family
Kan Liang <[email protected]>
x86/cpu: Add Comet Lake to the Intel CPU models header
Kan Liang <[email protected]>
x86/CPU: Add more Icelake model numbers
Rajneesh Bhardwaj <[email protected]>
x86/CPU: Add Icelake model number
Rajneesh Bhardwaj <[email protected]>
x86/cpu: Add Cannonlake to Intel family
Zhang Rui <[email protected]>
x86/cpu: Add Jasper Lake to Intel family
Guenter Roeck <[email protected]>
cpu/speculation: Add prototype for cpu_show_srbds()
Gayatri Kammela <[email protected]>
x86/cpu: Add Elkhart Lake to Intel family
-------------
Diffstat:
Documentation/ABI/testing/sysfs-devices-system-cpu | 1 + Documentation/hw-vuln/index.rst | 1 + .../hw-vuln/processor_mmio_stale_data.rst | 246 +++++++++++++++++++++ Documentation/kernel-parameters.txt | 36 +++ Makefile | 4 +- arch/x86/include/asm/cpufeatures.h | 1 + arch/x86/include/asm/intel-family.h | 25 +++ arch/x86/include/asm/msr-index.h | 25 +++ arch/x86/include/asm/nospec-branch.h | 2 + arch/x86/kernel/cpu/bugs.c | 235 +++++++++++++++++--- arch/x86/kernel/cpu/common.c | 52 ++++- arch/x86/kvm/vmx.c | 77 ++++++- arch/x86/kvm/x86.c | 4 + drivers/base/cpu.c | 8 + include/linux/cpu.h | 4 + 15 files changed, 679 insertions(+), 42 deletions(-)
Greg Kroah-Hartman
maintainerPATCH 1/20 x86/cpu: Add Elkhart Lake to Intel family
From: Gayatri Kammela <[email protected]>
commit 0f65605a8d744b3a205d0a2cd8f20707e31fc023 upstream.
Add the model number/CPUID of atom based Elkhart Lake to the Intel family.
--- arch/x86/include/asm/intel-family.h | 2 ++ 1 file changed, 2 insertions(+)
arch/x86/include/asm/intel-family.h +2 -0
@@ -67,7 +67,9 @@#define INTEL_FAM6_ATOM_GOLDMONT 0x5C/* Apollo Lake */ #define INTEL_FAM6_ATOM_GOLDMONT_X 0x5F/* Denverton */ #define INTEL_FAM6_ATOM_GOLDMONT_PLUS 0x7A/* Gemini Lake */ +#define INTEL_FAM6_ATOM_TREMONT_X 0x86/* Jacobsville */ +#define INTEL_FAM6_ATOM_TREMONT 0x96/* Elkhart Lake */ /* Xeon Phi */
Greg Kroah-Hartman
maintainerPATCH 2/20 cpu/speculation: Add prototype for cpu_show_srbds()
In reply to Greg Kroah-HartmanFrom: Guenter Roeck <[email protected]>
commit 2accfa69050c2a0d6fc6106f609208b3e9622b26 upstream.
0-day is not happy that there is no prototype for cpu_show_srbds():
drivers/base/cpu.c:565:16: error: no previous prototype for 'cpu_show_srbds'
--- include/linux/cpu.h | 1 + 1 file changed, 1 insertion(+)
include/linux/cpu.h +1 -0
@@ -61,6 +61,7 @@ extern ssize_t cpu_show_tsx_async_abort( char *buf);extern ssize_t cpu_show_itlb_multihit (struct device *dev,struct device_attribute *attr,char *buf); +extern ssize_t cpu_show_srbds (struct device *dev,struct device_attribute *attr,char *buf); extern __printf(4, 5) struct device *cpu_device_create(struct device *parent, void *drvdata,
Greg Kroah-Hartman
maintainerPATCH 3/20 x86/cpu: Add Jasper Lake to Intel family
In reply to Greg Kroah-HartmanFrom: Zhang Rui <[email protected]>
commit b2d32af0bff402b4c1fce28311759dd1f6af058a upstream.
Japser Lake is an Atom family processor.
It uses Tremont cores and is targeted at mobile platforms.
--- arch/x86/include/asm/intel-family.h | 1 + 1 file changed, 1 insertion(+)
arch/x86/include/asm/intel-family.h +1 -0
@@ -70,6 +70,7 @@#define INTEL_FAM6_ATOM_TREMONT_X 0x86/* Jacobsville */ #define INTEL_FAM6_ATOM_TREMONT 0x96/* Elkhart Lake */ +#define INTEL_FAM6_ATOM_TREMONT_L 0x9C/* Jasper Lake */ /* Xeon Phi */
Greg Kroah-Hartman
maintainerPATCH 4/20 x86/cpu: Add Cannonlake to Intel family
In reply to Greg Kroah-HartmanFrom: Rajneesh Bhardwaj <[email protected]>
commit 850eb9fba3711e98bafebde26675d9c082c0ff48 upstream.
Add CPUID of Cannonlake (CNL) processors to Intel family list.
--- arch/x86/include/asm/intel-family.h | 6 ++++++ 1 file changed, 6 insertions(+)
arch/x86/include/asm/intel-family.h +6 -0
@@ -9,6 +9,10 @@* * Things ending in "2" are usually because we have no better * name for them. There's no processor called "SILVERMONT2". +* +* While adding a new CPUID for a new microarchitecture, add a new +* group to keep logically sorted out in chronological order. Within +* that group keep the CPUID for the variants sorted by model number. */ #define INTEL_FAM6_CORE_YONAH 0x0E
@@ -48,6 +52,8 @@#define INTEL_FAM6_KABYLAKE_MOBILE 0x8E#define INTEL_FAM6_KABYLAKE_DESKTOP 0x9E +#define INTEL_FAM6_CANNONLAKE_MOBILE 0x66 +/* "Small Core" Processors (Atom) */ #define INTEL_FAM6_ATOM_BONNELL 0x1C/* Diamondville, Pineview */
Greg Kroah-Hartman
maintainerPATCH 5/20 x86/CPU: Add Icelake model number
In reply to Greg Kroah-HartmanFrom: Rajneesh Bhardwaj <[email protected]>
commit 8cd8f0ce0d6aafe661cb3d6781c8b82bc696c04d upstream.
Add the CPUID model number of Icelake (ICL) mobile processors to the Intel family list. Icelake U/Y series uses model number 0x7E.
--- arch/x86/include/asm/intel-family.h | 2 ++ 1 file changed, 2 insertions(+)
arch/x86/include/asm/intel-family.h +2 -0
@@ -54,6 +54,8 @@#define INTEL_FAM6_CANNONLAKE_MOBILE 0x66 +#define INTEL_FAM6_ICELAKE_MOBILE 0x7E +/* "Small Core" Processors (Atom) */ #define INTEL_FAM6_ATOM_BONNELL 0x1C/* Diamondville, Pineview */
Greg Kroah-Hartman
maintainerPATCH 6/20 x86/CPU: Add more Icelake model numbers
In reply to Greg Kroah-HartmanFrom: Kan Liang <[email protected]>
commit e35faeb64146f2015f2aec14b358ae508e4066db upstream.
Add the CPUID model numbers of Icelake (ICL) desktop and server processors to the Intel family list.
[ Qiuxu: Sort the macros by model number. ]
--- arch/x86/include/asm/intel-family.h | 3 +++ 1 file changed, 3 insertions(+)
arch/x86/include/asm/intel-family.h +3 -0
@@ -54,6 +54,9 @@#define INTEL_FAM6_CANNONLAKE_MOBILE 0x66 +#define INTEL_FAM6_ICELAKE_X 0x6A +#define INTEL_FAM6_ICELAKE_XEON_D 0x6C +#define INTEL_FAM6_ICELAKE_DESKTOP 0x7D#define INTEL_FAM6_ICELAKE_MOBILE 0x7E/* "Small Core" Processors (Atom) */
Greg Kroah-Hartman
maintainerPATCH 7/20 x86/cpu: Add Comet Lake to the Intel CPU models header
In reply to Greg Kroah-HartmanFrom: Kan Liang <[email protected]>
commit 8d7c6ac3b2371eb1cbc9925a88f4d10efff374de upstream.
Comet Lake is the new 10th Gen Intel processor. Add two new CPU model numbers to the Intel family list.
The CPU model numbers are not published in the SDM yet but they come from an authoritative internal source.
[ bp: Touch up commit message. ]
--- arch/x86/include/asm/intel-family.h | 3 +++ 1 file changed, 3 insertions(+)
arch/x86/include/asm/intel-family.h +3 -0
@@ -59,6 +59,9 @@#define INTEL_FAM6_ICELAKE_DESKTOP 0x7D#define INTEL_FAM6_ICELAKE_MOBILE 0x7E +#define INTEL_FAM6_COMETLAKE 0xA5 +#define INTEL_FAM6_COMETLAKE_L 0xA6 +/* "Small Core" Processors (Atom) */ #define INTEL_FAM6_ATOM_BONNELL 0x1C/* Diamondville, Pineview */
Greg Kroah-Hartman
maintainerPATCH 8/20 x86/cpu: Add Lakefield, Alder Lake and Rocket Lake models to the to Intel CPU family
In reply to Greg Kroah-HartmanFrom: Tony Luck <[email protected]>
commit e00b62f0b06d0ae2b844049f216807617aff0cdb upstream.
Add three new Intel CPU models.
--- arch/x86/include/asm/intel-family.h | 7 +++++++ 1 file changed, 7 insertions(+)
arch/x86/include/asm/intel-family.h +7 -0
@@ -62,6 +62,13 @@#define INTEL_FAM6_COMETLAKE 0xA5#define INTEL_FAM6_COMETLAKE_L 0xA6 +#define INTEL_FAM6_ROCKETLAKE 0xA7 + +/* Hybrid Core/Atom Processors */ + +#define INTEL_FAM6_LAKEFIELD 0x8A +#define INTEL_FAM6_ALDERLAKE 0x97 +/* "Small Core" Processors (Atom) */ #define INTEL_FAM6_ATOM_BONNELL 0x1C/* Diamondville, Pineview */
Greg Kroah-Hartman
maintainerPATCH 9/20 x86/cpu: Add another Alder Lake CPU to the Intel family
In reply to Greg Kroah-HartmanFrom: Gayatri Kammela <[email protected]>
commit 6e1239c13953f3c2a76e70031f74ddca9ae57cd3 upstream.
Add Alder Lake mobile CPU model number to Intel family.
--- arch/x86/include/asm/intel-family.h | 1 + 1 file changed, 1 insertion(+)
arch/x86/include/asm/intel-family.h +1 -0
@@ -68,6 +68,7 @@#define INTEL_FAM6_LAKEFIELD 0x8A#define INTEL_FAM6_ALDERLAKE 0x97 +#define INTEL_FAM6_ALDERLAKE_L 0x9A/* "Small Core" Processors (Atom) */
Greg Kroah-Hartman
maintainerPATCH 10/20 Documentation: Add documentation for Processor MMIO Stale Data
In reply to Greg Kroah-HartmanFrom: Pawan Gupta <[email protected]>
commit 4419470191386456e0b8ed4eb06a70b0021798a6 upstream
Add the admin guide for Processor MMIO stale data vulnerabilities.
--- Documentation/hw-vuln/index.rst | 1 Documentation/hw-vuln/processor_mmio_stale_data.rst | 246 ++++++++++++++++++++ 2 files changed, 247 insertions(+) create mode 100644 Documentation/hw-vuln/processor_mmio_stale_data.rst
Documentation/hw-vuln/index.rst +1 -0
@@ -15,3 +15,4 @@ are configurable at compile, boot or run tsx_async_abort multihit special-register-buffer-data-sampling + processor_mmio_stale_data
Documentation/hw-vuln/processor_mmio_stale_data.rst new file +246 -0
246 lines not on this page · raw message
Greg Kroah-Hartman
maintainerPATCH 11/20 x86/speculation/mmio: Enumerate Processor MMIO Stale Data bug
In reply to Greg Kroah-HartmanFrom: Pawan Gupta <[email protected]>
commit 51802186158c74a0304f51ab963e7c2b3a2b046f upstream
Processor MMIO Stale Data is a class of vulnerabilities that may expose data after an MMIO operation. For more details please refer to Documentation/admin-guide/hw-vuln/processor_mmio_stale_data.rst
Add the Processor MMIO Stale Data bug enumeration. A microcode update adds new bits to the MSR IA32_ARCH_CAPABILITIES, define them.
--- arch/x86/include/asm/cpufeatures.h | 1 arch/x86/include/asm/msr-index.h | 19 ++++++++++++++++ arch/x86/kernel/cpu/common.c | 43 +++++++++++++++++++++++++++++++++++-- 3 files changed, 61 insertions(+), 2 deletions(-)
arch/x86/include/asm/cpufeatures.h +1 -0
@@ -362,5 +362,6 @@#define X86_BUG_TAA X86_BUG(22)/* CPU is affected by TSX Async Abort(TAA) */ #define X86_BUG_ITLB_MULTIHIT X86_BUG(23)/* CPU may incur MCE during certain page attribute changes */ #define X86_BUG_SRBDS X86_BUG(24)/* CPU may leak RNG bits if not mitigated */ +#define X86_BUG_MMIO_STALE_DATA X86_BUG(25)/* CPU is affected by Processor MMIO Stale Data vulnerabilities */ #endif /* _ASM_X86_CPUFEATURES_H */
arch/x86/include/asm/msr-index.h +19 -0
@@ -89,6 +89,25 @@* Not susceptible to * TSX Async Abort (TAA) vulnerabilities. */ +#define ARCH_CAP_SBDR_SSDP_NO BIT(13)/* +* Not susceptible to SBDR and SSDP +* variants of Processor MMIO stale data +* vulnerabilities. +*/ +#define ARCH_CAP_FBSDP_NO BIT(14)/* +* Not susceptible to FBSDP variant of +* Processor MMIO stale data +* vulnerabilities. +*/ +#define ARCH_CAP_PSDP_NO BIT(15)/* +* Not susceptible to PSDP variant of +* Processor MMIO stale data +* vulnerabilities. +*/ +#define ARCH_CAP_FB_CLEAR BIT(17)/* +* VERW clears CPU fill buffer +* even on MDS_NO CPUs. +*/ #define MSR_IA32_FLUSH_CMD 0x0000010b#define L1D_FLUSH BIT(0)/*
arch/x86/kernel/cpu/common.c +41 -2
71 lines not on this page · raw message
Greg Kroah-Hartman
maintainerPATCH 12/20 x86/speculation: Add a common function for MD_CLEAR mitigation update
In reply to Greg Kroah-HartmanFrom: Pawan Gupta <[email protected]>
commit f52ea6c26953fed339aa4eae717ee5c2133c7ff2 upstream
Processor MMIO Stale Data mitigation uses similar mitigation as MDS and TAA. In preparation for adding its mitigation, add a common function to update all mitigations that depend on MD_CLEAR.
[ bp: Add a newline in md_clear_update_mitigation() to separate
statements better. ]
--- arch/x86/kernel/cpu/bugs.c | 59 +++++++++++++++++++++++++-------------------- 1 file changed, 33 insertions(+), 26 deletions(-)
arch/x86/kernel/cpu/bugs.c +33 -26
@@ -39,7 +39,7 @@ static void __init spectre_v2_select_mitstatic void __init ssb_select_mitigation (void );static void __init l1tf_select_mitigation (void );static void __init mds_select_mitigation (void ); -static void __init mds_print_mitigation (void ); +static void __init md_clear_update_mitigation (void );static void __init taa_select_mitigation (void );static void __init srbds_select_mitigation (void );
@@ -112,10 +112,10 @@ void __init check_bugs(void)srbds_select_mitigation ();/* -* As MDS and TAA mitigations are inter-related, print MDS -* mitigation until after TAA mitigation selection is done. +* As MDS and TAA mitigations are inter-related, update and print their +* mitigation after TAA mitigation selection is done. */ -mds_print_mitigation (); +md_clear_update_mitigation ();arch_smt_update ();
@@ -256,14 +256,6 @@ static void __init mds_select_mitigation } } -static void __init mds_print_mitigation (void ) -{ -if (!boot_cpu_has_bug (X86_BUG_MDS ) ||cpu_mitigations_off ()) -return ; - -pr_info ("%s\n" , mds_strings[mds_mitigation]); -} -static int __init mds_cmdline (char *str) {if (!boot_cpu_has_bug (X86_BUG_MDS ))
@@ -311,7 +303,7 @@ static void __init taa_select_mitigation/* TSX previously disabled by tsx=off */ if (!boot_cpu_has (X86_FEATURE_RTM )) { taa_mitigation =TAA_MITIGATION_TSX_DISABLED ; - goto out; +return ; }if (cpu_mitigations_off ()) {
@@ -325,7 +317,7 @@ static void __init taa_select_mitigation*/ if (taa_mitigation ==TAA_MITIGATION_OFF && mds_mitigation ==MDS_MITIGATION_OFF ) - goto out; +return ;if (boot_cpu_has (X86_FEATURE_MD_CLEAR )) taa_mitigation =TAA_MITIGATION_VERW ;
@@ -357,18 +349,6 @@ static void __init taa_select_mitigationif (taa_nosmt ||cpu_mitigations_auto_nosmt ())cpu_smt_disable (false); - -/* -* Update MDS mitigation, if necessary, as the mds_user_clear is -* now enabled for TAA mitigation. -*/ -if (mds_mitigation ==MDS_MITIGATION_OFF && -boot_cpu_has_bug (X86_BUG_MDS )) { - mds_mitigation =MDS_MITIGATION_FULL ; -mds_select_mitigation (); - } -out: -pr_info ("%s\n" , taa_strings[taa_mitigation]); }static int __init tsx_async_abort_parse_cmdline (char *str)
@@ -393,6 +373,33 @@ static int __init tsx_async_abort_parse_early_param ("tsx_async_abort" , tsx_async_abort_parse_cmdline);#undef pr_fmt +#define pr_fmt (fmt) "" fmt + +static void __init md_clear_update_mitigation (void ) +{ +if (cpu_mitigations_off ()) +return ; + +if (!static_key_enabled (&mds_user_clear)) + goto out; + +/* +* mds_user_clear is now enabled. Update MDS mitigation, if +* necessary. +*/ +if (mds_mitigation ==MDS_MITIGATION_OFF && +boot_cpu_has_bug (X86_BUG_MDS )) { + mds_mitigation =MDS_MITIGATION_FULL ; +mds_select_mitigation (); + } +out: +if (boot_cpu_has_bug (X86_BUG_MDS )) +pr_info ("MDS: %s\n" , mds_strings[mds_mitigation]); +if (boot_cpu_has_bug (X86_BUG_TAA )) +pr_info ("TAA: %s\n" , taa_strings[taa_mitigation]); +} + +#undef pr_fmt#define pr_fmt (fmt) "SRBDS: " fmtenum srbds_mitigations {
Greg Kroah-Hartman
maintainerPATCH 13/20 x86/speculation/mmio: Add mitigation for Processor MMIO Stale Data
In reply to Greg Kroah-HartmanFrom: Pawan Gupta <[email protected]>
commit 8cb861e9e3c9a55099ad3d08e1a3b653d29c33ca upstream
Processor MMIO Stale Data is a class of vulnerabilities that may expose data after an MMIO operation. For details please refer to Documentation/admin-guide/hw-vuln/processor_mmio_stale_data.rst.
These vulnerabilities are broadly categorized as:
Device Register Partial Write (DRPW):
Some endpoint MMIO registers incorrectly handle writes that are smaller than the register size. Instead of aborting the write or only copying the correct subset of bytes (for example, 2 bytes for a 2-byte write), more bytes than specified by the write transaction may be written to the register. On some processors, this may expose stale data from the fill buffers of the core that created the write transaction.
Shared Buffers Data Sampling (SBDS):
After propagators may have moved data around the uncore and copied stale data into client core fill buffers, processors affected by MFBDS can leak data from the fill buffer.
Shared Buffers Data Read (SBDR):
It is similar to Shared Buffer Data Sampling (SBDS) except that the data is directly read into the architectural software-visible state.
An attacker can use these vulnerabilities to extract data from CPU fill buffers using MDS and TAA methods. Mitigate it by clearing the CPU fill buffers using the VERW instruction before returning to a user or a guest.
On CPUs not affected by MDS and TAA, user application cannot sample data from CPU fill buffers using MDS or TAA. A guest with MMIO access can still use DRPW or SBDR to extract data architecturally. Mitigate it with VERW instruction to clear fill buffers before VMENTER for MMIO capable guests.
Add a kernel parameter mmio_stale_data={off|full|full,nosmt} to control the mitigation.
--- Documentation/kernel-parameters.txt | 36 +++++++++++ arch/x86/include/asm/nospec-branch.h | 2 arch/x86/kernel/cpu/bugs.c | 111 +++++++++++++++++++++++++++++++++-- arch/x86/kvm/vmx.c | 3 4 files changed, 148 insertions(+), 4 deletions(-)
Documentation/kernel-parameters.txt +36 -0
@@ -2520,6 +2520,7 @@ bytes respectively. Such letter suffixes kvm.nx_huge_pages=off [X86] no_entry_flush [PPC] no_uaccess_flush [PPC] + mmio_stale_data=off [X86] Exceptions: This does not have any effect on
@@ -2541,6 +2542,7 @@ bytes respectively. Such letter suffixes Equivalent to: l1tf=flush,nosmt [X86] mds=full,nosmt [X86] tsx_async_abort=full,nosmt [X86] + mmio_stale_data=full,nosmt [X86] mminit_loglevel= [KNL] When CONFIG_DEBUG_MEMORY_INIT is set, this
@@ -2550,6 +2552,40 @@ bytes respectively. Such letter suffixes log everything. Information is printed at KERN_DEBUG so loglevel=8 may also need to be specified. + mmio_stale_data= + [X86,INTEL] Control mitigation for the Processor + MMIO Stale Data vulnerabilities. + + Processor MMIO Stale Data is a class of + vulnerabilities that may expose data after an MMIO + operation. Exposed data could originate or end in + the same CPU buffers as affected by MDS and TAA. + Therefore, similar to MDS and TAA, the mitigation + is to clear the affected CPU buffers. + + This parameter controls the mitigation. The + options are: + + full - Enable mitigation on vulnerable CPUs + + full,nosmt - Enable mitigation and disable SMT on + vulnerable CPUs. + + off - Unconditionally disable mitigation + + On MDS or TAA affected machines, + mmio_stale_data=off can be prevented by an active + MDS or TAA mitigation as these vulnerabilities are + mitigated with the same mechanism so in order to + disable this mitigation, you need to specify + mds=off and tsx_async_abort=off too. + + Not specifying this option is equivalent to + mmio_stale_data=full. + + For details see: + Documentation/admin-guide/hw-vuln/processor_mmio_stale_data.rst + module.sig_enforce [KNL] When CONFIG_MODULE_SIG is set, this means that modules without (valid) signatures will fail to load.
arch/x86/include/asm/nospec-branch.h +2 -0
@@ -323,6 +323,8 @@ DECLARE_STATIC_KEY_FALSE(switch_mm_alwayDECLARE_STATIC_KEY_FALSE (mds_user_clear);DECLARE_STATIC_KEY_FALSE (mds_idle_clear); +DECLARE_STATIC_KEY_FALSE (mmio_stale_data_clear); +#include <asm/segment.h> /**
arch/x86/kernel/cpu/bugs.c +107 -4
155 lines not on this page · raw message
arch/x86/kvm/vmx.c +3 -0
@@ -9177,6 +9177,9 @@ static void __noclone vmx_vcpu_run(strucvmx_l1d_flush (vcpu); else if (static_branch_unlikely(&mds_user_clear)) mds_clear_cpu_buffers(); + else if (static_branch_unlikely(&mmio_stale_data_clear) && + kvm_arch_has_assigned_device(vcpu->kvm)) + mds_clear_cpu_buffers(); asm(/* Store host registers */
Re: [PATCH 4.9 13/20] x86/speculation/mmio: Add mitigation for Processor MMIO Stale Data
Hi!
Quoted 9 lines
arch/x86/kernel/cpu/bugs.c +9
-0+static int __init mmio_stale_data_parse_cmdline (char *str) +{ +if (!boot_cpu_has_bug (X86_BUG_MMIO_STALE_DATA )) +return 0 ; + +if (!str) +return -EINVAL ; + +if (!strcmp (str,"off" )) {
arch/x86/kernel/cpu/bugs.c static int __init tsx_async_abort_parse_ · line 463
Quoted 10 lines
arch/x86/kernel/cpu/bugs.c +10
-0+ mmio_mitigation =MMIO_MITIGATION_OFF ; + }else if (!strcmp (str,"full" )) { + mmio_mitigation =MMIO_MITIGATION_VERW ; + }else if (!strcmp (str,"full,nosmt" )) { + mmio_mitigation =MMIO_MITIGATION_VERW ; + mmio_nosmt = true; + } + +return 0 ; +}
This is wrong, AFAICT. Returning 0 will pollute init's environment; Randy was cleaning those lately and we are even seeing them in -stable. See for example b793a01000122d2bd133ba451a76cc135b5e162c.
The early return 0 should disappear, too; we should validate the option even on non-buggy machines.
Best regards,
Pavel
Signature · 2 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Re: [PATCH 4.9 13/20] x86/speculation/mmio: Add mitigation for Processor MMIO Stale Data
Quoted 27 lines · Pavel Machek
Hi!
Quoted 9 lines
arch/x86/kernel/cpu/bugs.c +9
-0+static int __init mmio_stale_data_parse_cmdline (char *str) +{ +if (!boot_cpu_has_bug (X86_BUG_MMIO_STALE_DATA )) +return 0 ; + +if (!str) +return -EINVAL ; + +if (!strcmp (str,"off" )) {arch/x86/kernel/cpu/bugs.c static int __init tsx_async_abort_parse_ · line 463
Quoted 10 lines
arch/x86/kernel/cpu/bugs.c +10
-0+ mmio_mitigation =MMIO_MITIGATION_OFF ; + }else if (!strcmp (str,"full" )) { + mmio_mitigation =MMIO_MITIGATION_VERW ; + }else if (!strcmp (str,"full,nosmt" )) { + mmio_mitigation =MMIO_MITIGATION_VERW ; + mmio_nosmt = true; + } + +return 0 ; +}This is wrong, AFAICT. Returning 0 will pollute init's environment; Randy was cleaning those lately and we are even seeing them in -stable. See for example
b793a01000122d2bd133ba451a76cc135b5e162c.
Quoted 2 lines
The early return 0 should disappear, too; we should validate the option even on non-buggy machines.
It's good to be on the lookout for such problems, but __setup() functions (like I was cleaning) are the opposite (sad:( of early_param() functions, which this one is.
early_param() does return 0 on success and non-zero on error, so this looks OK to me.
Signature · 1 line
~Randy
Greg Kroah-Hartman
maintainerPATCH 14/20 x86/bugs: Group MDS, TAA & Processor MMIO Stale Data mitigations
In reply to Greg Kroah-HartmanFrom: Pawan Gupta <[email protected]>
commit e5925fb867290ee924fcf2fe3ca887b792714366 upstream
MDS, TAA and Processor MMIO Stale Data mitigations rely on clearing CPU buffers. Moreover, status of these mitigations affects each other. During boot, it is important to maintain the order in which these mitigations are selected. This is especially true for md_clear_update_mitigation() that needs to be called after MDS, TAA and Processor MMIO Stale Data mitigation selection is done.
Introduce md_clear_select_mitigation(), and select all these mitigations from there. This reflects relationships between these mitigations and ensures proper ordering.
--- arch/x86/kernel/cpu/bugs.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-)
arch/x86/kernel/cpu/bugs.c +16 -10
@@ -40,6 +40,7 @@ static void __init ssb_select_mitigationstatic void __init l1tf_select_mitigation (void );static void __init mds_select_mitigation (void );static void __init md_clear_update_mitigation (void ); +static void __init md_clear_select_mitigation (void );static void __init taa_select_mitigation (void );static void __init mmio_select_mitigation (void );static void __init srbds_select_mitigation (void );
@@ -112,18 +113,9 @@ void __init check_bugs(void)spectre_v2_select_mitigation ();ssb_select_mitigation ();l1tf_select_mitigation (); -mds_select_mitigation (); -taa_select_mitigation (); -mmio_select_mitigation (); +md_clear_select_mitigation ();srbds_select_mitigation (); -/* -* As MDS, TAA and MMIO Stale Data mitigations are inter-related, update -* and print their mitigation after MDS, TAA and MMIO Stale Data -* mitigation selection is done. -*/ -md_clear_update_mitigation (); -arch_smt_update ();#ifdef CONFIG_X86_32
@@ -502,6 +494,20 @@ out:pr_info ("MMIO Stale Data: %s\n" , mmio_strings[mmio_mitigation]); } +static void __init md_clear_select_mitigation (void ) +{ +mds_select_mitigation (); +taa_select_mitigation (); +mmio_select_mitigation (); + +/* +* As MDS, TAA and MMIO Stale Data mitigations are inter-related, update +* and print their mitigation after MDS, TAA and MMIO Stale Data +* mitigation selection is done. +*/ +md_clear_update_mitigation (); +} +#undef pr_fmt#define pr_fmt (fmt) "SRBDS: " fmt
Greg Kroah-Hartman
maintainerPATCH 15/20 x86/speculation/mmio: Enable CPU Fill buffer clearing on idle
In reply to Greg Kroah-HartmanFrom: Pawan Gupta <[email protected]>
commit 99a83db5a605137424e1efe29dc0573d6a5b6316 upstream
When the CPU is affected by Processor MMIO Stale Data vulnerabilities, Fill Buffer Stale Data Propagator (FBSDP) can propagate stale data out of Fill buffer to uncore buffer when CPU goes idle. Stale data can then be exploited with other variants using MMIO operations.
Mitigate it by clearing the Fill buffer before entering idle state.
--- arch/x86/kernel/cpu/bugs.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/bugs.c +14 -2
@@ -416,6 +416,14 @@ static void __init mmio_select_mitigatiostatic_branch_enable (&mmio_stale_data_clear);/* +* If Processor-MMIO-Stale-Data bug is present and Fill Buffer data can +* be propagated to uncore buffers, clearing the Fill buffers on idle +* is required irrespective of SMT state. +*/ +if (!(ia32_cap &ARCH_CAP_FBSDP_NO )) +static_branch_enable (&mds_idle_clear); + +/* * Check if the system has the right microcode. * * CPU Fill buffer clear mitigation is enumerated by either an explicit
@@ -1181,6 +1189,8 @@ static void update_indir_branch_cond(voi/* Update the static key controlling the MDS CPU buffer clear in idle */ static void update_mds_branch_idle (void ) { +u64 ia32_cap =x86_read_arch_cap_msr (); +/* * Enable the idle clearing if SMT is active on CPUs which are * affected only by MSBDS and not any other MDS variant.
@@ -1192,10 +1202,12 @@ static void update_mds_branch_idle(void)if (!boot_cpu_has_bug (X86_BUG_MSBDS_ONLY ))return ; -if (sched_smt_active ()) +if (sched_smt_active ()) {static_branch_enable (&mds_idle_clear); -else + }else if (mmio_mitigation ==MMIO_MITIGATION_OFF || + (ia32_cap &ARCH_CAP_FBSDP_NO )) {static_branch_disable (&mds_idle_clear); + } }#define MDS_MSG_SMT "MDS CPU bug present and SMT on, data leak possible. See https://www.kernel.org/doc/html/latest/admin-guide/hw-vuln/mds.html for more details.\n"
Greg Kroah-Hartman
maintainerPATCH 16/20 x86/speculation/mmio: Add sysfs reporting for Processor MMIO Stale Data
In reply to Greg Kroah-HartmanFrom: Pawan Gupta <[email protected]>
commit 8d50cdf8b8341770bc6367bce40c0c1bb0e1d5b3 upstream
Add the sysfs reporting file for Processor MMIO Stale Data vulnerability. It exposes the vulnerability and mitigation state similar to the existing files for the other hardware vulnerabilities.
--- Documentation/ABI/testing/sysfs-devices-system-cpu | 1 arch/x86/kernel/cpu/bugs.c | 22 +++++++++++++++++++++ drivers/base/cpu.c | 8 +++++++ include/linux/cpu.h | 3 ++ 4 files changed, 34 insertions(+)
Documentation/ABI/testing/sysfs-devices-system-cpu +1 -0
@@ -361,6 +361,7 @@ What: /sys/devices/system/cpu/vulnerabi /sys/devices/system/cpu/vulnerabilities/srbds /sys/devices/system/cpu/vulnerabilities/tsx_async_abort /sys/devices/system/cpu/vulnerabilities/itlb_multihit + /sys/devices/system/cpu/vulnerabilities/mmio_stale_data Date: January 2018 Contact: Linux kernel mailing list <[email protected]> Description: Information about CPU vulnerabilities
arch/x86/kernel/cpu/bugs.c +22 -0
@@ -1809,6 +1809,20 @@ static ssize_t tsx_async_abort_show_stat sched_smt_active() ? "vulnerable" : "disabled"); } +static ssize_t mmio_stale_data_show_state (char *buf) +{ +if (mmio_mitigation ==MMIO_MITIGATION_OFF ) +return sysfs_emit (buf,"%s\n" , mmio_strings[mmio_mitigation]); + +if (boot_cpu_has (X86_FEATURE_HYPERVISOR )) { +return sysfs_emit (buf,"%s; SMT Host state unknown\n" , + mmio_strings[mmio_mitigation]); + } + +return sysfs_emit (buf,"%s; SMT %s\n" , mmio_strings[mmio_mitigation], +sched_smt_active () ?"vulnerable" :"disabled" ); +} +static char *stibp_state (void ) {if (spectre_v2_in_eibrs_mode (spectre_v2_enabled))
@@ -1906,6 +1920,9 @@ static ssize_t cpu_show_common(struct decase X86_BUG_SRBDS :return srbds_show_state (buf); +case X86_BUG_MMIO_STALE_DATA : +return mmio_stale_data_show_state (buf); +default :break ; }
@@ -1957,4 +1974,9 @@ ssize_t cpu_show_srbds(struct device *de {return cpu_show_common (dev, attr, buf,X86_BUG_SRBDS ); } + +ssize_t cpu_show_mmio_stale_data (struct device *dev,struct device_attribute *attr,char *buf) +{ +return cpu_show_common (dev, attr, buf,X86_BUG_MMIO_STALE_DATA ); +}#endif
drivers/base/cpu.c +8 -0
@@ -556,6 +556,12 @@ ssize_t __weak cpu_show_srbds(struct devreturn sprintf (buf,"Not affected\n" ); } +ssize_t __weak cpu_show_mmio_stale_data (struct device *dev, +struct device_attribute *attr,char *buf) +{ +return sysfs_emit (buf,"Not affected\n" ); +} + static DEVICE_ATTR(meltdown, 0444, cpu_show_meltdown, NULL); static DEVICE_ATTR(spectre_v1, 0444, cpu_show_spectre_v1, NULL); static DEVICE_ATTR(spectre_v2, 0444, cpu_show_spectre_v2, NULL);
@@ -565,6 +571,7 @@ static DEVICE_ATTR(mds, 0444, cpu_show_m static DEVICE_ATTR(tsx_async_abort, 0444, cpu_show_tsx_async_abort, NULL); static DEVICE_ATTR(itlb_multihit, 0444, cpu_show_itlb_multihit, NULL); static DEVICE_ATTR(srbds, 0444, cpu_show_srbds, NULL); +static DEVICE_ATTR(mmio_stale_data, 0444, cpu_show_mmio_stale_data, NULL);static struct attribute *cpu_root_vulnerabilities_attrs[] = { &dev_attr_meltdown.attr,
@@ -576,6 +583,7 @@ static struct attribute *cpu_root_vulner &dev_attr_tsx_async_abort.attr, &dev_attr_itlb_multihit.attr, &dev_attr_srbds.attr, + &dev_attr_mmio_stale_data.attr, NULL };
include/linux/cpu.h +3 -0
@@ -62,6 +62,9 @@ extern ssize_t cpu_show_tsx_async_abort(extern ssize_t cpu_show_itlb_multihit (struct device *dev,struct device_attribute *attr,char *buf);extern ssize_t cpu_show_srbds (struct device *dev,struct device_attribute *attr,char *buf); +extern ssize_t cpu_show_mmio_stale_data (struct device *dev, +struct device_attribute *attr, +char *buf); extern __printf(4, 5) struct device *cpu_device_create(struct device *parent, void *drvdata,
Greg Kroah-Hartman
maintainerPATCH 17/20 x86/speculation/srbds: Update SRBDS mitigation selection
In reply to Greg Kroah-HartmanFrom: Pawan Gupta <[email protected]>
commit 22cac9c677c95f3ac5c9244f8ca0afdc7c8afb19 upstream
Currently, Linux disables SRBDS mitigation on CPUs not affected by MDS and have the TSX feature disabled. On such CPUs, secrets cannot be extracted from CPU fill buffers using MDS or TAA. Without SRBDS mitigation, Processor MMIO Stale Data vulnerabilities can be used to extract RDRAND, RDSEED, and EGETKEY data.
Do not disable SRBDS mitigation by default when CPU is also affected by Processor MMIO Stale Data vulnerabilities.
--- arch/x86/kernel/cpu/bugs.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
arch/x86/kernel/cpu/bugs.c +5 -3
@@ -577,11 +577,13 @@ static void __init srbds_select_mitigatireturn ;/* -* Check to see if this is one of the MDS_NO systems supporting -* TSX that are only exposed to SRBDS when TSX is enabled. +* Check to see if this is one of the MDS_NO systems supporting TSX that +* are only exposed to SRBDS when TSX is enabled or when CPU is affected +* by Processor MMIO Stale Data vulnerability. */ ia32_cap =x86_read_arch_cap_msr (); -if ((ia32_cap &ARCH_CAP_MDS_NO ) && !boot_cpu_has (X86_FEATURE_RTM )) +if ((ia32_cap &ARCH_CAP_MDS_NO ) && !boot_cpu_has (X86_FEATURE_RTM ) && + !boot_cpu_has_bug (X86_BUG_MMIO_STALE_DATA )) srbds_mitigation =SRBDS_MITIGATION_TSX_OFF ;else if (boot_cpu_has (X86_FEATURE_HYPERVISOR )) srbds_mitigation =SRBDS_MITIGATION_HYPERVISOR ;
Greg Kroah-Hartman
maintainerPATCH 18/20 x86/speculation/mmio: Reuse SRBDS mitigation for SBDS
In reply to Greg Kroah-HartmanFrom: Pawan Gupta <[email protected]>
commit a992b8a4682f119ae035a01b40d4d0665c4a2875 upstream
The Shared Buffers Data Sampling (SBDS) variant of Processor MMIO Stale Data vulnerabilities may expose RDRAND, RDSEED and SGX EGETKEY data. Mitigation for this is added by a microcode update.
As some of the implications of SBDS are similar to SRBDS, SRBDS mitigation infrastructure can be leveraged by SBDS. Set X86_BUG_SRBDS and use SRBDS mitigation.
Mitigation is enabled by default; use srbds=off to opt-out. Mitigation status can be checked from below file:
/sys/devices/system/cpu/vulnerabilities/srbds
--- arch/x86/kernel/cpu/common.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-)
arch/x86/kernel/cpu/common.c +14 -7
@@ -964,6 +964,8 @@ static const __initconst struct x86_cpu_#define SRBDS BIT(0)/* CPU is affected by X86_BUG_MMIO_STALE_DATA */ #define MMIO BIT(1) +/* CPU is affected by Shared Buffers Data Sampling (SBDS), a variant of X86_BUG_MMIO_STALE_DATA */ +#define MMIO_SBDS BIT(2)static const struct x86_cpu_id cpu_vuln_blacklist[]__initconst = {VULNBL_INTEL_STEPPINGS (IVYBRIDGE ,X86_STEPPING_ANY ,SRBDS ),
@@ -985,16 +987,17 @@ static const struct x86_cpu_id cpu_vuln_VULNBL_INTEL_STEPPINGS (KABYLAKE_MOBILE ,X86_STEPPINGS (0x0 ,0x8 ),SRBDS ),VULNBL_INTEL_STEPPINGS (KABYLAKE_DESKTOP ,X86_STEPPINGS (0x9 ,0xD ),SRBDS |MMIO ),VULNBL_INTEL_STEPPINGS (KABYLAKE_DESKTOP ,X86_STEPPINGS (0x0 ,0x8 ),SRBDS ), -VULNBL_INTEL_STEPPINGS (ICELAKE_MOBILE ,X86_STEPPINGS (0x5 ,0x5 ),MMIO ), +VULNBL_INTEL_STEPPINGS (ICELAKE_MOBILE ,X86_STEPPINGS (0x5 ,0x5 ),MMIO |MMIO_SBDS ),VULNBL_INTEL_STEPPINGS (ICELAKE_XEON_D ,X86_STEPPINGS (0x1 ,0x1 ),MMIO ),VULNBL_INTEL_STEPPINGS (ICELAKE_X ,X86_STEPPINGS (0x4 ,0x6 ),MMIO ), -VULNBL_INTEL_STEPPINGS (COMETLAKE ,BIT (2 ) |BIT (3 ) |BIT (5 ),MMIO ), -VULNBL_INTEL_STEPPINGS (COMETLAKE_L ,X86_STEPPINGS (0x0 ,0x1 ),MMIO ), -VULNBL_INTEL_STEPPINGS (LAKEFIELD ,X86_STEPPINGS (0x1 ,0x1 ),MMIO ), +VULNBL_INTEL_STEPPINGS (COMETLAKE ,BIT (2 ) |BIT (3 ) |BIT (5 ),MMIO |MMIO_SBDS ), +VULNBL_INTEL_STEPPINGS (COMETLAKE_L ,X86_STEPPINGS (0x1 ,0x1 ),MMIO |MMIO_SBDS ), +VULNBL_INTEL_STEPPINGS (COMETLAKE_L ,X86_STEPPINGS (0x0 ,0x0 ),MMIO ), +VULNBL_INTEL_STEPPINGS (LAKEFIELD ,X86_STEPPINGS (0x1 ,0x1 ),MMIO |MMIO_SBDS ),VULNBL_INTEL_STEPPINGS (ROCKETLAKE ,X86_STEPPINGS (0x1 ,0x1 ),MMIO ), -VULNBL_INTEL_STEPPINGS (ATOM_TREMONT ,X86_STEPPINGS (0x1 ,0x1 ),MMIO ), +VULNBL_INTEL_STEPPINGS (ATOM_TREMONT ,X86_STEPPINGS (0x1 ,0x1 ),MMIO |MMIO_SBDS ),VULNBL_INTEL_STEPPINGS (ATOM_TREMONT_X ,X86_STEPPING_ANY ,MMIO ), - VULNBL_INTEL_STEPPINGS(ATOM_TREMONT_L, X86_STEPPINGS(0x0, 0x0), MMIO), + VULNBL_INTEL_STEPPINGS(ATOM_TREMONT_L, X86_STEPPINGS(0x0, 0x0), MMIO | MMIO_SBDS), {} };
@@ -1073,10 +1076,14 @@ static void __init cpu_set_bug_bits(stru/* * SRBDS affects CPUs which support RDRAND or RDSEED and are listed * in the vulnerability blacklist. +* +* Some of the implications and mitigation of Shared Buffers Data +* Sampling (SBDS) are similar to SRBDS. Give SBDS same treatment as +* SRBDS. */ if ((cpu_has (c,X86_FEATURE_RDRAND ) ||cpu_has (c,X86_FEATURE_RDSEED )) && -cpu_matches (cpu_vuln_blacklist,SRBDS )) +cpu_matches (cpu_vuln_blacklist,SRBDS |MMIO_SBDS ))setup_force_cpu_bug (X86_BUG_SRBDS );/*
Greg Kroah-Hartman
maintainerPATCH 19/20 KVM: x86/speculation: Disable Fill buffer clear within guests
In reply to Greg Kroah-HartmanFrom: Pawan Gupta <[email protected]>
commit 027bbb884be006b05d9c577d6401686053aa789e upstream
The enumeration of MD_CLEAR in CPUID(EAX=7,ECX=0).EDX{bit 10} is not an accurate indicator on all CPUs of whether the VERW instruction will overwrite fill buffers. FB_CLEAR enumeration in IA32_ARCH_CAPABILITIES{bit 17} covers the case of CPUs that are not vulnerable to MDS/TAA, indicating that microcode does overwrite fill buffers.
Guests running in VMM environments may not be aware of all the capabilities/vulnerabilities of the host CPU. Specifically, a guest may apply MDS/TAA mitigations when a virtual CPU is enumerated as vulnerable to MDS/TAA even when the physical CPU is not. On CPUs that enumerate FB_CLEAR_CTRL the VMM may set FB_CLEAR_DIS to skip overwriting of fill buffers by the VERW instruction. This is done by setting FB_CLEAR_DIS during VMENTER and resetting on VMEXIT. For guests that enumerate FB_CLEAR (explicitly asking for fill buffer clear capability) the VMM will not use FB_CLEAR_DIS.
Irrespective of guest state, host overwrites CPU buffers before VMENTER to protect itself from an MMIO capable guest, as part of mitigation for MMIO Stale Data vulnerabilities.
[cascardo: arch/x86/kvm/vmx.c has been split and context adjustment at
vmx_vcpu_run]
--- arch/x86/include/asm/msr-index.h | 6 +++ arch/x86/kvm/vmx.c | 74 ++++++++++++++++++++++++++++++++++++++- arch/x86/kvm/x86.c | 4 ++ 3 files changed, 83 insertions(+), 1 deletion(-)
arch/x86/include/asm/msr-index.h +6 -0
@@ -108,6 +108,11 @@* VERW clears CPU fill buffer * even on MDS_NO CPUs. */ +#define ARCH_CAP_FB_CLEAR_CTRL BIT(18)/* +* MSR_IA32_MCU_OPT_CTRL[FB_CLEAR_DIS] +* bit available to control VERW +* behavior. +*/ #define MSR_IA32_FLUSH_CMD 0x0000010b#define L1D_FLUSH BIT(0)/*
@@ -125,6 +130,7 @@/* SRBDS support */ #define MSR_IA32_MCU_OPT_CTRL 0x00000123#define RNGDS_MITG_DIS BIT(0) +#define FB_CLEAR_DIS BIT(3)/* CPU Fill buffer clear disable */ #define MSR_IA32_SYSENTER_CS 0x00000174#define MSR_IA32_SYSENTER_ESP 0x00000175
arch/x86/kvm/vmx.c +73 -1
126 lines not on this page · raw message
arch/x86/kvm/x86.c +4 -0
@@ -1090,6 +1090,10 @@ u64 kvm_get_arch_capabilities(void)/* KVM does not emulate MSR_IA32_TSX_CTRL. */ data &= ~ARCH_CAP_TSX_CTRL_MSR ; + +/* Guests don't need to know "Fill buffer clear control" exists */ + data &= ~ARCH_CAP_FB_CLEAR_CTRL ; +return data; }
Greg Kroah-Hartman
maintainerPATCH 20/20 x86/speculation/mmio: Print SMT warning
In reply to Greg Kroah-HartmanFrom: Josh Poimboeuf <[email protected]>
commit 1dc6ff02c8bf77d71b9b5d11cbc9df77cfb28626 upstream
Similar to MDS and TAA, print a warning if SMT is enabled for the MMIO Stale Data vulnerability.
--- arch/x86/kernel/cpu/bugs.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
arch/x86/kernel/cpu/bugs.c +11 -0
@@ -1214,6 +1214,7 @@ static void update_mds_branch_idle(void)#define MDS_MSG_SMT "MDS CPU bug present and SMT on, data leak possible. See https://www.kernel.org/doc/html/latest/admin-guide/hw-vuln/mds.html for more details.\n"#define TAA_MSG_SMT "TAA CPU bug present and SMT on, data leak possible. See https://www.kernel.org/doc/html/latest/admin-guide/hw-vuln/tsx_async_abort.html for more details.\n" +#define MMIO_MSG_SMT "MMIO Stale Data CPU bug present and SMT on, data leak possible. See https://www.kernel.org/doc/html/latest/admin-guide/hw-vuln/processor_mmio_stale_data.html for more details.\n"void arch_smt_update (void ) {
@@ -1258,6 +1259,16 @@ void arch_smt_update(void)break ; } +switch (mmio_mitigation) { +case MMIO_MITIGATION_VERW : +case MMIO_MITIGATION_UCODE_NEEDED : +if (sched_smt_active ()) +pr_warn_once (MMIO_MSG_SMT ); +break ; +case MMIO_MITIGATION_OFF : +break ; + } +mutex_unlock (&spec_ctrl_mutex); }
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.319 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 16 Jun 2022 18:37:02 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.319-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.9.y
and the diffstat can be found below.thanks,
greg k-h
On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels:
Signature · 1 line
Florian
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.319 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 16 Jun 2022 18:37:02 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 9 lines
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.319-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.9.y
and the diffstat can be found below.thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.319 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 16 Jun 2022 18:37:02 +0000. Anything received after that time might be too late.
Build results:
total: 164 pass: 164 fail: 0 Qemu test results: total: 397 pass: 397 fail: 0
Guenter
Quoted 10 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.319 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 16 Jun 2022 18:37:02 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.319-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.9.y
and the diffstat can be found below.thanks,
greg k-h
Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.
## Build
* kernel: 4.9.319-rc1
* git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
* git branch: linux-4.9.y
* git commit: 2b5bd1d9ab58138d38f9f2fcbf7d484e3c85d6cd
* git describe: v4.9.318-21-g2b5bd1d9ab58
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-4.9.y/build/v4.9.318-21-g2b5bd1d9ab58
## Test Regressions (compared to v4.9.317-168-gbb08155cd099) No test regressions found.
## Metric Regressions (compared to v4.9.317-168-gbb08155cd099) No metric regressions found.
## Test Fixes (compared to v4.9.317-168-gbb08155cd099) No test fixes found.
## Metric Fixes (compared to v4.9.317-168-gbb08155cd099) No metric fixes found.
## Test result summary
total: 95256, pass: 83420, fail: 191, skip: 10403, xfail: 1242
## Build Summary
* arc: 10 total, 10 passed, 0 failed
* arm: 261 total, 255 passed, 6 failed
* arm64: 50 total, 39 passed, 11 failed
* i386: 27 total, 23 passed, 4 failed
* mips: 22 total, 22 passed, 0 failed
* parisc: 12 total, 0 passed, 12 failed
* powerpc: 36 total, 16 passed, 20 failed
* s390: 12 total, 9 passed, 3 failed
* sh: 24 total, 24 passed, 0 failed
* sparc: 12 total, 12 passed, 0 failed
* x86_64: 46 total, 44 passed, 2 failed
## Test suites summary
* fwts
* igt-gpu-tools
* kunit
* kvm-unit-tests
* libhugetlbfs
* log-parser-boot
* log-parser-test
* ltp-cap_bounds
* ltp-cap_bounds-tests
* ltp-commands
* ltp-commands-tests
* ltp-containers
* ltp-containers-tests
* ltp-controllers-tests
* ltp-cpuhotplug-tests
* ltp-crypto
* ltp-crypto-tests
* ltp-cve-tests
* ltp-dio-tests
* ltp-fcntl-locktests
* ltp-fcntl-locktests-tests
* ltp-filecaps
* ltp-filecaps-tests
* ltp-fs
* ltp-fs-tests
* ltp-fs_bind
* ltp-fs_bind-tests
* ltp-fs_perms_simple
* ltp-fs_perms_simple-tests
* ltp-fsx
* ltp-fsx-tests
* ltp-hugetlb
* ltp-hugetlb-tests
* ltp-io
* ltp-io-tests
* ltp-ipc
* ltp-ipc-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-nptl
* ltp-nptl-tests
* ltp-open-posix-tests
* ltp-pty
* ltp-pty-tests
* ltp-sched
* ltp-sched-tests
* ltp-securebits
* ltp-securebits-tests
* ltp-smoke
* ltp-syscalls-tests
* ltp-tracing-tests
* network-basic-tests
* packetdrill
* rcutorture
* ssuite
* v4l2-compliance
* vdso
--
Linaro LKFT
https://lkft.linaro.org
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.319 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 16 Jun 2022 18:37:02 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.319-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.9.y
and the diffstat can be found below.thanks,
greg k-h
All tests passing for Tegra ...
Test results for stable-v4.9:
8 builds: 8 pass, 0 fail
16 boots: 16 pass, 0 fail
32 tests: 32 pass, 0 failLinux version: 4.9.319-rc1-g2b5bd1d9ab58
Boards tested: tegra124-jetson-tk1, tegra20-ventana,
tegra210-p2371-2180, tegra30-cardhu-a04
Jon
Signature · 1 line
nvpublic
Hi!
Quoted 4 lines
This is the start of the stable review cycle for the 4.9.319 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
CIP testing did not find any problems here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.9.y
Best regards,
Pavel
Signature · 2 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany