drivers: w1: Add missing of_node_put() in w1.c
Subsystems (2)
PATCH 1/1 drivers: w1: Add missing of_node_put() in w1.c
In __w1_attach_slave_device, we really need not to use of_node_put in normal path as the reference is escaped by sl. However, we need of_node_put in the fail path before put_device.
Signed-off-by Liang He <[email protected]>
--- drivers/w1/w1.c | 1 + 1 file changed, 1 insertion(+)
drivers/w1/w1.c +1 -0
@@ -702,6 +702,7 @@ static int __w1_attach_slave_device(struct w1_slave *sl)dev_err (&sl->dev,"Device registration [%s] failed. err=%d\n" ,dev_name (&sl->dev), err); +of_node_put (sl->dev.of_node);put_device (&sl->dev);return err; }
Signature · 1 line
2.25.1
Krzysztof Kozlowski
AppliedQuoted 5 lines · Liang He
In
__w1_attach_slave_device, we really need not to useof_node_putin normal path as the reference is escaped by sl. However, we needof_node_putin the fail path beforeput_device.
Applied, thanks!
[1/1] drivers: w1: Add missing of_node_put() in w1.c
https://git.kernel.org/krzk/linux-w1/c/51cbbcd6469b2a32e222ec220039af20a16f2769
Best regards,
Signature · 1 line
Krzysztof Kozlowski <[email protected]>