Skip to contentSkip to conversation

arch: arm: mach-imx: Add missing of_node_put() in avic.c

PATCH New Liang He 1 participant 1 message Jun 15, 2022

Subsystems (3)
lore
Share & tools
lore

Liang He

author
#0 lore raw

PATCH 1/1 arch: arm: mach-imx: Add missing of_node_put() in avic.c

In mxc_init_irq(), we need to use two of_node_put() for two of_find_compatible_node() functions which return node pointers with refcount incremented.

---
 arch/arm/mach-imx/avic.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/mach-imx/avic.c +2 -1
index cf6546ddc7a3..1c9af0092a07 100644
@@ -173,7 +173,7 @@ static void __init mxc_init_irq(void __iomem *irqbase)
 
 	np = of_find_compatible_node(NULL, NULL, "fsl,imx25-ccm");
 	mx25_ccm_base = of_iomap(np, 0);
-
+	of_node_put(np);
 	if (mx25_ccm_base) {
 		/*
 		 * By default, we mask all interrupts. We set the actual mask
@@ -203,6 +203,7 @@ static void __init mxc_init_irq(void __iomem *irqbase)
 	np = of_find_compatible_node(NULL, NULL, "fsl,avic");
 	domain = irq_domain_add_legacy(np, AVIC_NUM_IRQS, irq_base, 0,
 				       &irq_domain_simple_ops, NULL);
+	of_node_put(np);					   
 	WARN_ON(!domain);
 
 	for (i = 0; i < AVIC_NUM_IRQS / 32; i++, irq_base += 32)
Signature · 1 line
2.25.1