iommu/vt-d: Increase DMAR_UNITS_SUPPORTED
Subsystems (2)
PATCH 1/1 iommu/vt-d: Increase DMAR_UNITS_SUPPORTED
Increase DMAR_UNITS_SUPPORTED to support 64 sockets with 10 DMAR units each, for a total of 640.
If the available hardware exceeds DMAR_UNITS_SUPPORTED (previously set to MAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocate seq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot.
---
Note that we could not find a reason for connecting DMAR_UNITS_SUPPORTED to MAX_IO_APICS as was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.
include/linux/dmar.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/dmar.h +1 -1
@@ -19,7 +19,7 @@struct acpi_dmar_header ;#ifdef CONFIG_X86 -# define DMAR_UNITS_SUPPORTED MAX_IO_APICS +# define DMAR_UNITS_SUPPORTED 640#else # define DMAR_UNITS_SUPPORTED 64#endif
Signature · 1 line
2.26.2
Baolu Lu
maintainerQuoted 11 lines · Steve Wahl
Increase
DMAR_UNITS_SUPPORTEDto support 64 sockets with 10 DMAR units each, for a total of 640.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot.Signed-off-by Steve Wahl <[email protected]>Reviewed-by Mike Travis <[email protected]>
Quoted 7 lines
---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.
+Kevin
This maximum value was introduced by below commit. And I don't see any hardware/software restrictions that we can't enlarge it after ten years.
commit 1b198bb04ad72669d4bd6575fc9945ed595bfee0
Author: Mike Travis <[email protected]> Date: Mon Mar 5 15:05:16 2012 -0800
x86/iommu/intel: Increase the number of iommus supported toMAX_IO_APICS
The number of IOMMUs supported should be the same as the number of IO APICS. This limit comes into play when the IOMMUs are identity mapped, thus the number of possible IOMMUs in the "static identity" (si) domain should be this same number.
[...]
Quoted 9 lines
include/linux/dmar.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/dmar.h +0
-0
include/linux/dmar.h line 25
Quoted 8 lines
include/linux/dmar.h +1
-1@@ -19,7 +19,7 @@struct acpi_dmar_header ;#ifdef CONFIG_X86 -# define DMAR_UNITS_SUPPORTED MAX_IO_APICS +# define DMAR_UNITS_SUPPORTED 640#else # define DMAR_UNITS_SUPPORTED 64#endif
Best regards,
baolu
Quoted 22 lines
From: Baolu Lu <[email protected]>
Sent: Friday, May 6, 2022 1:57 PMQuoted 1 line · Steve Wahl
Increase
DMAR_UNITS_SUPPORTEDto support 64 sockets with 10 DMARunits
Quoted 3 lines
each, for a total of 640.
If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previouslyset
Quoted 11 lines
to
MAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot.Signed-off-by Steve Wahl <[email protected]>Reviewed-by Mike Travis <[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously.Perhaps
Quoted 8 lines
Quoted 3 lines
it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.
+Kevin
This maximum value was introduced by below commit. And I don't see any hardware/software restrictions that we can't enlarge it after ten years.
I don't see a rationale either, but...
Quoted 25 lines
commit
1b198bb04ad72669d4bd6575fc9945ed595bfee0Author: Mike Travis <[email protected]> Date: Mon Mar 5 15:05:16 2012 -0800x86/iommu/intel: Increase the number of iommus supported to
MAX_IO_APICSThe number of IOMMUs supported should be the same as the number of IO APICS. This limit comes into play when the IOMMUs are identity mapped, thus the number of possible IOMMUs in the "static identity" (si) domain should be this same number.
[...]Quoted 11 lines
include/linux/dmar.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/dmar.h +0
-0@@ -19,7 +19,7 @@struct acpi_dmar_header ;
Quoted 7 lines
include/linux/dmar.h line 25
Quoted 6 lines
include/linux/dmar.h +1
-1#ifdef CONFIG_X86 -# define DMAR_UNITS_SUPPORTED MAX_IO_APICS +# define DMAR_UNITS_SUPPORTED 640#else # define DMAR_UNITS_SUPPORTED 64#endif
... is it necessary to permanently do 10x increase which wastes memory on most platforms which won't have such need.
Does it make more sense to have a configurable approach similar to CONFIG_NR_CPUS? or even better can we just replace those static arrays with dynamic allocation so removing this restriction completely?
another nit: dmar is intel specific thus CONFIG_X86 is always true.
Thanks
Kevin
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Quoted 1 line · Kevin
another nit: dmar is intel specific thus
CONFIG_X86is always true.
There are Itanium systems which have DMAR units. Is that no longer supported?
Regards,
Signature · 15 lines
Jörg Rödel [email protected] SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nürnberg Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Quoted 9 lines
From: Rodel, Jorg
Sent: Friday, May 6, 2022 3:11 PMQuoted 1 line · Kevin
another nit: dmar is intel specific thus
CONFIG_X86is always true.There are Itanium systems which have DMAR units. Is that no longer supported?
Sorry I just forgot that. haven't touched an Itanium system for over ten years. 😊
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
David Woodhouse
maintainerQuoted 7 lines · Kevin
Quoted 7 lines
From: Baolu Lu <[email protected]>
Quoted 5 lines
include/linux/dmar.h +0
-0@@ -19,7 +19,7 @@struct acpi_dmar_header ;
Quoted 9 lines
Quoted 6 lines
include/linux/dmar.h line 25
Quoted 6 lines
include/linux/dmar.h +1
-1#ifdef CONFIG_X86 -# define DMAR_UNITS_SUPPORTED MAX_IO_APICS +# define DMAR_UNITS_SUPPORTED 640#else # define DMAR_UNITS_SUPPORTED 64#endif ... is it necessary to permanently do 10x increase which wastes memory on most platforms which won't have such need.
I was just looking at that. It mostly adds about 3½ KiB to each struct dmar_domain.
I think the only actual static array is the dmar_seq_ids bitmap which grows to 640 *bits* which is fairly negligible, and the main growth is that it adds about 3½ KiB to each struct dmar_domain for the iommu_refcnt[] and iommu_did[] arrays.
Quoted 4 lines
Does it make more sense to have a configurable approach similar to
CONFIG_NR_CPUS? or even better can we just replace those static arrays with dynamic allocation so removing this restriction completely?
Hotplug makes that fun, but I suppose you only need to grow the array in a given struct dmar_domain if you actually add a device to it that's behind a newly added IOMMU. I don't know if the complexity of making it fully dynamic is worth it though. We could make it a config option, and/or a command line option (perhaps automatically derived from CONFIG_NR_CPUS).
If it wasn't for hotplug, I think we'd know the right number by the time we actually need it anyway, wouldn't we? Can we have a heuristic for how many DMAR units are likely to be hotplugged? Is it as simple as the ratio of present to not-yet-present CPUs in MADT?
Quoted 1 line
another nit: dmar is intel specific thus
CONFIG_X86is always true.
DMAR exists on IA64 too.
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Quoted 21 lines
From: David Woodhouse <[email protected]>
Sent: Friday, May 6, 2022 3:17 PMQuoted 7 lines · Kevin
Quoted 7 lines
From: Baolu Lu <[email protected]>
Quoted 5 lines
include/linux/dmar.h +0
-0@@ -19,7 +19,7 @@struct acpi_dmar_header ;Quoted 9 lines
Quoted 6 lines
include/linux/dmar.h line 25
Quoted 6 lines
include/linux/dmar.h +1
-1#ifdef CONFIG_X86 -# define DMAR_UNITS_SUPPORTED MAX_IO_APICS +# define DMAR_UNITS_SUPPORTED 640#else # define DMAR_UNITS_SUPPORTED 64#endif ... is it necessary to permanently do 10x increase which wastes memory on most platforms which won't have such need.
Quoted 7 lines
I was just looking at that. It mostly adds about 3½ KiB to each struct
dmar_domain.I think the only actual static array is the
dmar_seq_idsbitmap which grows to 640 *bits* which is fairly negligible, and the main growth is that it adds about 3½ KiB to each structdmar_domainfor the iommu_refcnt[] and iommu_did[] arrays.
Thanks for the quick experiment! though the added material is negligible it's cleaner to me if having a way to configure it as discussed below.
Quoted 6 lines
Quoted 5 lines
Does it make more sense to have a configurable approach similar to
CONFIG_NR_CPUS? or even better can we just replace those static arrays with dynamic allocation so removing this restriction completely?
Quoted 6 lines
Hotplug makes that fun, but I suppose you only need to grow the array in a given struct
dmar_domainif you actually add a device to it that's behind a newly added IOMMU. I don't know if the complexity of making it fully dynamic is worth it though. We could make it a config option, and/or a command line option (perhaps automatically derived fromCONFIG_NR_CPUS).
either config option or command line option is OK to me. Probably the former is simpler given no need to dynamically expand the static array. btw though deriving from CONFIG_NR_CPUS could work in this case it is unclear why tying the two together is necessary in concept, e.g. is there guarantee that the number of IOMMUs must be smaller than the number of CPUs in a platform?
Quoted 5 lines
If it wasn't for hotplug, I think we'd know the right number by the time we actually need it anyway, wouldn't we? Can we have a heuristic for how many DMAR units are likely to be hotplugged? Is it as simple as the ratio of present to not-yet-present CPUs in MADT?
Probably. But I don't have enough knowledge on DMAR hotplug to judge (e.g. whether it's strictly tied to CPU hotplug and if yes whether there could be multiple IOMMUs hotplugged together with a CPU socket)...
Thanks
Kevin
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Quoted 59 lines · Kevin
Quoted 21 lines
From: David Woodhouse <[email protected]>
Sent: Friday, May 6, 2022 3:17 PMQuoted 7 lines · Kevin
Quoted 7 lines
From: Baolu Lu <[email protected]>
Quoted 5 lines
include/linux/dmar.h +0
-0@@ -19,7 +19,7 @@struct acpi_dmar_header ;Quoted 9 lines
Quoted 6 lines
include/linux/dmar.h line 25
Quoted 6 lines
include/linux/dmar.h +1
-1#ifdef CONFIG_X86 -# define DMAR_UNITS_SUPPORTED MAX_IO_APICS +# define DMAR_UNITS_SUPPORTED 640#else # define DMAR_UNITS_SUPPORTED 64#endif ... is it necessary to permanently do 10x increase which wastes memory on most platforms which won't have such need.
Quoted 7 lines
I was just looking at that. It mostly adds about 3½ KiB to each struct
dmar_domain.I think the only actual static array is the
dmar_seq_idsbitmap which grows to 640 *bits* which is fairly negligible, and the main growth is that it adds about 3½ KiB to each structdmar_domainfor the iommu_refcnt[] and iommu_did[] arrays.Thanks for the quick experiment! though the added material is negligible it's cleaner to me if having a way to configure it as discussed below.
Quoted 6 lines
Quoted 5 lines
Does it make more sense to have a configurable approach similar to
CONFIG_NR_CPUS? or even better can we just replace those static arrays with dynamic allocation so removing this restriction completely?Quoted 6 lines
Hotplug makes that fun, but I suppose you only need to grow the array in a given struct
dmar_domainif you actually add a device to it that's behind a newly added IOMMU. I don't know if the complexity of making it fully dynamic is worth it though. We could make it a config option, and/or a command line option (perhaps automatically derived fromCONFIG_NR_CPUS).either config option or command line option is OK to me. Probably the former is simpler given no need to dynamically expand the static array. btw though deriving from
CONFIG_NR_CPUScould work in this case it is unclear why tying the two together is necessary in concept, e.g. is there guarantee that the number of IOMMUs must be smaller than the number of CPUs in a platform?Quoted 5 lines
If it wasn't for hotplug, I think we'd know the right number by the time we actually need it anyway, wouldn't we? Can we have a heuristic for how many DMAR units are likely to be hotplugged? Is it as simple as the ratio of present to not-yet-present CPUs in MADT?
Quoted 7 lines
Probably. But I don't have enough knowledge on DMAR hotplug to judge (e.g. whether it's strictly tied to CPU hotplug and if yes whether there could be multiple IOMMUs hotplugged together with a CPU socket)...
Thanks
Kevin
Would anyone be more comfortable if we only increase the limit where MAXSMP is set?
i.e.
#if defined(CONFIG_X86) && defined(CONFIG_MAXSMP)
# define DMAR_UNITS_SUPPORTED 640
#elif defined(CONFIG_X86)
# define DMAR_UNITS_SUPPORTED MAX_IO_APICS
#else
# define DMAR_UNITS_SUPPORTED 64
#endif
Thank you all for your time looking at this.
--> Steve Wahl
Signature · 1 line
Steve Wahl, Hewlett Packard Enterprise
Quoted 84 lines
From: Steve Wahl <[email protected]>
Sent: Friday, May 6, 2022 11:26 PMQuoted 59 lines · Kevin
Quoted 21 lines
From: David Woodhouse <[email protected]>
Sent: Friday, May 6, 2022 3:17 PMQuoted 7 lines · Kevin
Quoted 7 lines
From: Baolu Lu <[email protected]>
Quoted 5 lines
include/linux/dmar.h +0
-0@@ -19,7 +19,7 @@struct acpi_dmar_header ;Quoted 9 lines
Quoted 6 lines
include/linux/dmar.h line 25
Quoted 6 lines
include/linux/dmar.h +1
-1#ifdef CONFIG_X86 -# define DMAR_UNITS_SUPPORTED MAX_IO_APICS +# define DMAR_UNITS_SUPPORTED 640#else # define DMAR_UNITS_SUPPORTED 64#endif ... is it necessary to permanently do 10x increase which wastes memory on most platforms which won't have such need.
Quoted 7 lines
I was just looking at that. It mostly adds about 3½ KiB to each struct
dmar_domain.I think the only actual static array is the
dmar_seq_idsbitmap which grows to 640 *bits* which is fairly negligible, and the main growth is that it adds about 3½ KiB to each structdmar_domainfor the iommu_refcnt[] and iommu_did[] arrays.Thanks for the quick experiment! though the added material is negligible it's cleaner to me if having a way to configure it as discussed below.
Quoted 6 lines
Quoted 5 lines
Does it make more sense to have a configurable approach similar to
CONFIG_NR_CPUS? or even better can we just replace those static arrays with dynamic allocation so removing this restriction completely?Quoted 6 lines
Hotplug makes that fun, but I suppose you only need to grow the array in a given struct
dmar_domainif you actually add a device to it that's behind a newly added IOMMU. I don't know if the complexity of making it fully dynamic is worth it though. We could make it a config option, and/or a command line option (perhaps automatically derived fromCONFIG_NR_CPUS).either config option or command line option is OK to me. Probably the former is simpler given no need to dynamically expand the static array. btw though deriving from
CONFIG_NR_CPUScould work in this case it is unclear why tying the two together is necessary in concept, e.g. is there guarantee that the number of IOMMUs must be smaller than the number of CPUs in a platform?Quoted 5 lines
If it wasn't for hotplug, I think we'd know the right number by the time we actually need it anyway, wouldn't we? Can we have a heuristic for how many DMAR units are likely to be hotplugged? Is it as simple as the ratio of present to not-yet-present CPUs in MADT?
Quoted 7 lines
Probably. But I don't have enough knowledge on DMAR hotplug to judge (e.g. whether it's strictly tied to CPU hotplug and if yes whether there could be multiple IOMMUs hotplugged together with a CPU socket)...
Thanks
KevinWould anyone be more comfortable if we only increase the limit where MAXSMP is set?
i.e.
#if
defined(CONFIG_X86)&&defined(CONFIG_MAXSMP)
# defineDMAR_UNITS_SUPPORTED640
#elifdefined(CONFIG_X86)
# defineDMAR_UNITS_SUPPORTEDMAX_IO_APICS
#else
# defineDMAR_UNITS_SUPPORTED64
#endif
Quoted 2 lines
Thank you all for your time looking at this.
This works for your own configuration but it's unclear whether other MAXSMP platforms have the exact same requirements (different number of sockets, different ratio of #iommus/#sockets, etc.). In any case since we are at it having a generic way to extend it makes more sense to me.
Thanks
Kevin
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Quoted 84 lines · Kevin
Quoted 84 lines
From: Steve Wahl <[email protected]>
Sent: Friday, May 6, 2022 11:26 PMQuoted 59 lines · Kevin
Quoted 21 lines
From: David Woodhouse <[email protected]>
Sent: Friday, May 6, 2022 3:17 PMQuoted 7 lines · Kevin
Quoted 7 lines
From: Baolu Lu <[email protected]>
Quoted 5 lines
include/linux/dmar.h +0
-0@@ -19,7 +19,7 @@struct acpi_dmar_header ;Quoted 9 lines
Quoted 6 lines
include/linux/dmar.h line 25
Quoted 6 lines
include/linux/dmar.h +1
-1#ifdef CONFIG_X86 -# define DMAR_UNITS_SUPPORTED MAX_IO_APICS +# define DMAR_UNITS_SUPPORTED 640#else # define DMAR_UNITS_SUPPORTED 64#endif ... is it necessary to permanently do 10x increase which wastes memory on most platforms which won't have such need.
Quoted 7 lines
I was just looking at that. It mostly adds about 3½ KiB to each struct
dmar_domain.I think the only actual static array is the
dmar_seq_idsbitmap which grows to 640 *bits* which is fairly negligible, and the main growth is that it adds about 3½ KiB to each structdmar_domainfor the iommu_refcnt[] and iommu_did[] arrays.Thanks for the quick experiment! though the added material is negligible it's cleaner to me if having a way to configure it as discussed below.
Quoted 6 lines
Quoted 5 lines
Does it make more sense to have a configurable approach similar to
CONFIG_NR_CPUS? or even better can we just replace those static arrays with dynamic allocation so removing this restriction completely?Quoted 6 lines
Hotplug makes that fun, but I suppose you only need to grow the array in a given struct
dmar_domainif you actually add a device to it that's behind a newly added IOMMU. I don't know if the complexity of making it fully dynamic is worth it though. We could make it a config option, and/or a command line option (perhaps automatically derived fromCONFIG_NR_CPUS).either config option or command line option is OK to me. Probably the former is simpler given no need to dynamically expand the static array. btw though deriving from
CONFIG_NR_CPUScould work in this case it is unclear why tying the two together is necessary in concept, e.g. is there guarantee that the number of IOMMUs must be smaller than the number of CPUs in a platform?Quoted 5 lines
If it wasn't for hotplug, I think we'd know the right number by the time we actually need it anyway, wouldn't we? Can we have a heuristic for how many DMAR units are likely to be hotplugged? Is it as simple as the ratio of present to not-yet-present CPUs in MADT?
Quoted 7 lines
Probably. But I don't have enough knowledge on DMAR hotplug to judge (e.g. whether it's strictly tied to CPU hotplug and if yes whether there could be multiple IOMMUs hotplugged together with a CPU socket)...
Thanks
KevinWould anyone be more comfortable if we only increase the limit where MAXSMP is set?
i.e.
#if
defined(CONFIG_X86)&&defined(CONFIG_MAXSMP)
# defineDMAR_UNITS_SUPPORTED640
#elifdefined(CONFIG_X86)
# defineDMAR_UNITS_SUPPORTEDMAX_IO_APICS
#else
# defineDMAR_UNITS_SUPPORTED64
#endif
Quoted 8 lines
Quoted 2 lines
Thank you all for your time looking at this.
This works for your own configuration but it's unclear whether other MAXSMP platforms have the exact same requirements (different number of sockets, different ratio of #iommus/#sockets, etc.). In any case since we are at it having a generic way to extend it makes more sense to me.
So, to be clear, what you would like to see would be Kconfig entries to create a config option, say "NR_DMARS", set up so the default is:
MAXSMP? 640
X86_64? 128
X86_32? 64
other 64And DMAR_UNITS_SUPPORTED gets removed, and everywhere it was used we use CONFIG_NR_DMARS in its place?
I can give that a shot but wanted to confirm this is what you'd want first.
Thanks,
--> Steve
Signature · 5 lines
Steve Wahl, Hewlett Packard Enterprise _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Quoted 102 lines
From: Steve Wahl <[email protected]>
Sent: Wednesday, May 11, 2022 3:07 AMQuoted 15 lines · Kevin
Quoted 15 lines
From: Steve Wahl <[email protected]>
Sent: Friday, May 6, 2022 11:26 PMQuoted 11 lines · Kevin
Quoted 11 lines
From: David Woodhouse <[email protected]>
Sent: Friday, May 6, 2022 3:17 PMQuoted 7 lines · Kevin
Quoted 7 lines
From: Baolu Lu <[email protected]>
Quoted 5 lines
include/linux/dmar.h +0
-0@@ -19,7 +19,7 @@struct acpi_dmar_header ;Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 6 lines
include/linux/dmar.h line 25
Quoted 6 lines
include/linux/dmar.h +1
-1#ifdef CONFIG_X86 -# define DMAR_UNITS_SUPPORTED MAX_IO_APICS +# define DMAR_UNITS_SUPPORTED 640#else # define DMAR_UNITS_SUPPORTED 64#endif ... is it necessary to permanently do 10x increase which wastes
memory
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Quoted 9 lines
Quoted 1 line
on most platforms which won't have such need.
I was just looking at that. It mostly adds about 3½ KiB to each struct
dmar_domain.I think the only actual static array is the
dmar_seq_idsbitmap which grows to 640 *bits* which is fairly negligible, and the main growth is that it adds about 3½ KiB to each structdmar_domainfor the iommu_refcnt[] and iommu_did[] arrays.Thanks for the quick experiment! though the added material is negligible it's cleaner to me if having a way to configure it as discussed below.
Quoted 1 line
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Does it make more sense to have a configurable approach similar to
CONFIG_NR_CPUS? or even better can we just replace those static arrays with dynamic allocation so removing this restriction completely?Hotplug makes that fun, but I suppose you only need to grow the
array
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
in a given struct
dmar_domainif you actually add a device to it that's behind a newly added IOMMU. I don't know if the complexity ofmaking it
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 3 lines
fully dynamic is worth it though. We could make it a config option, and/or a command line option (perhaps automatically derived from
CONFIG_NR_CPUS).either config option or command line option is OK to me. Probably the former is simpler given no need to dynamically expand the static array. btw though deriving from
CONFIG_NR_CPUScould work in this case it is unclear why tying the two together is necessary in concept, e.g. is there guarantee that the number of IOMMUs must be smaller than the number of CPUs in a platform?Quoted 1 line
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
If it wasn't for hotplug, I think we'd know the right number by the time we actually need it anyway, wouldn't we? Can we have a
heuristic
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
for how many DMAR units are likely to be hotplugged? Is it as simple
as
Quoted 23 lines
Quoted 23 lines
Quoted 9 lines
Quoted 1 line
the ratio of present to not-yet-present CPUs in MADT?
Probably. But I don't have enough knowledge on DMAR hotplug to judge (e.g. whether it's strictly tied to CPU hotplug and if yes whether there could be multiple IOMMUs hotplugged together with a CPU socket)...
Thanks
KevinWould anyone be more comfortable if we only increase the limit where MAXSMP is set?
i.e.
#if
defined(CONFIG_X86)&&defined(CONFIG_MAXSMP)
# defineDMAR_UNITS_SUPPORTED640
#elifdefined(CONFIG_X86)
# defineDMAR_UNITS_SUPPORTEDMAX_IO_APICS
#else
# defineDMAR_UNITS_SUPPORTED64
#endifQuoted 8 lines
Quoted 2 lines
Thank you all for your time looking at this.
This works for your own configuration but it's unclear whether other MAXSMP platforms have the exact same requirements (different number of sockets, different ratio of #iommus/#sockets, etc.). In any case since we are at it having a generic way to extend it makes more sense to me.
Quoted 4 lines
So, to be clear, what you would like to see would be
Kconfigentries to create a config option, say "NR_DMARS", set up so the default is:MAXSMP? 640
usually we do 2's power thus 1024 is more reasonable. If people do care about the exact memory footprint they can always manually change it.
Quoted 7 lines
X86_64? 128 X86_32? 64 other 64And
DMAR_UNITS_SUPPORTEDgets removed, and everywhere it was used we
useCONFIG_NR_DMARSin its place?
Let's keep DMAR_UNITS_SUPPORTED and just redefine it to be CONFIG_NR_DMARS for less changes.
Quoted 10 lines
I can give that a shot but wanted to confirm this is what you'd want first.
Thanks,
--> Steve
--
Steve Wahl, Hewlett Packard Enterprise
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
PATCH v2 1/1 iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
In reply to Steve WahlTo support up to 64 sockets with 10 DMAR units each (640), make the value of DMAR_UNITS_SUPPORTED adjustable by a config variable, CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.
If the available hardware exceeds DMAR_UNITS_SUPPORTED (previously set to MAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocate seq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.
---
Note that we could not find a reason for connecting DMAR_UNITS_SUPPORTED to MAX_IO_APICS as was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.
v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
drivers/iommu/intel/Kconfig | 6 ++++++ include/linux/dmar.h | 6 +----- 2 files changed, 7 insertions(+), 5 deletions(-)
drivers/iommu/intel/Kconfig +6 -0
@@ -9,6 +9,12 @@ config DMAR_PERF config DMAR_DEBUG bool +config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported" + default 1024 if MAXSMP + default 128 if X86_64 + default 64 + config INTEL_IOMMU bool "Support for Intel IOMMU using DMA Remapping Devices" depends on PCI_MSI && ACPI && (X86 || IA64)
include/linux/dmar.h +1 -5
@@ -18,11 +18,7 @@struct acpi_dmar_header ; -#ifdef CONFIG_X86 -# define DMAR_UNITS_SUPPORTED MAX_IO_APICS -#else -# define DMAR_UNITS_SUPPORTED 64 -#endif +#define DMAR_UNITS_SUPPORTED CONFIG_DMAR_UNITS_SUPPORTED/* DMAR Flags */ #define DMAR_INTR_REMAP 0x1
Signature · 6 lines
2.26.2 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 5 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.
Quoted 7 lines
If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl <[email protected]>
I've received a report from the kernel test robot <[email protected]>, that this patch causes an error (shown below) when CONFIG_IOMMU_SUPPORT is not set.
In my opinion, this is because include/linux/dmar.h and include/linux/intel-iommu are being #included when they are not really being used.
I've tried placing the contents of intel-iommu.h within an #ifdef CONFIG_INTEL_IOMMU, and that fixes the problem.
Two questions:
A) Is this the desired approach to to the fix?
B) Should it be a separate patch, or added onto this patch as a v3?
Error message: ------------------------------
In file included from include/linux/intel-iommu.h:21,
from arch/x86/kvm/x86.c:44:
Quoted 1 line
Quoted 1 line
include/linux/dmar.h:21:33: error: 'CONFIG_DMAR_UNITS_SUPPORTED' undeclared here (not in a function); did you mean 'DMAR_UNITS_SUPPORTED'?
21 | #define DMAR_UNITS_SUPPORTED CONFIG_DMAR_UNITS_SUPPORTED
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/intel-iommu.h:531:35: note: in expansion of macro 'DMAR_UNITS_SUPPORTED'
531 | unsigned int iommu_refcnt[DMAR_UNITS_SUPPORTED];
| ^~~~~~~~~~~~~~~~~~~~vim +21 include/linux/dmar.h
20
Quoted 1 line
21 #define
DMAR_UNITS_SUPPORTEDCONFIG_DMAR_UNITS_SUPPORTED
22
Initial stab at fixing it: ------------------------------
include/linux/intel-iommu.h +4 -0
@@ -10,6 +10,8 @@#ifndef _INTEL_IOMMU_H_#define _INTEL_IOMMU_H_ +#ifdef CONFIG_INTEL_IOMMU +#include <linux/types.h> #include <linux/iova.h> #include <linux/io.h>
@@ -831,4 +833,6 @@ static inline const char *decode_prq_descriptor(char *str, size_t size,return str; } +#endif /* CONFIG_IOMMU_SUPPORT */ +#endif
Thanks.
--> Steve Wahl
Signature · 5 lines
Steve Wahl, Hewlett Packard Enterprise _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Baolu Lu
maintainerRe: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 22 lines · Steve Wahl
Quoted 5 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.Quoted 7 lines
If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl <[email protected]>I've received a report from the kernel test robot <[email protected]>, that this patch causes an error (shown below) when
CONFIG_IOMMU_SUPPORTis not set.In my opinion, this is because
include/linux/dmar.handinclude/linux/intel-iommuare being #included when they are not really being used.
Quoted 6 lines
I've tried placing the contents of
intel-iommu.hwithin an #ifdefCONFIG_INTEL_IOMMU, and that fixes the problem.Two questions:
A) Is this the desired approach to to the fix?
Most part of include/linux/intel-iommu.h is private to Intel IOMMU driver. They should be put in a header like drivers/iommu/intel /iommu.h. Eventually, we should remove include/linux/intel-iommu.h and device drivers interact with iommu subsystem through the IOMMU kAPIs.
Best regards,
baolu
Quoted 45 lines
B) Should it be a separate patch, or added onto this patch as a v3?
Error message: ------------------------------
In file included from
include/linux/intel-iommu.h:21,
fromarch/x86/kvm/x86.c:44:Quoted 1 line
Quoted 1 line
include/linux/dmar.h:21:33: error: 'CONFIG_DMAR_UNITS_SUPPORTED' undeclared here (not in a function); did you mean 'DMAR_UNITS_SUPPORTED'?21 | #define DMAR_UNITS_SUPPORTED CONFIG_DMAR_UNITS_SUPPORTED | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/intel-iommu.h:531:35: note: in expansion of macro 'DMAR_UNITS_SUPPORTED' 531 | unsigned int iommu_refcnt[DMAR_UNITS_SUPPORTED]; | ^~~~~~~~~~~~~~~~~~~~vim +21
include/linux/dmar.h20Quoted 1 line
21 #define
DMAR_UNITS_SUPPORTEDCONFIG_DMAR_UNITS_SUPPORTED22Initial stab at fixing it: ------------------------------
include/linux/intel-iommu.h +4
-0@@ -10,6 +10,8 @@#ifndef _INTEL_IOMMU_H_#define _INTEL_IOMMU_H_ +#ifdef CONFIG_INTEL_IOMMU +#include <linux/types.h> #include <linux/iova.h> #include <linux/io.h> @@ -831,4 +833,6 @@ static inline const char *decode_prq_descriptor(char *str, size_t size,return str; } +#endif /* CONFIG_IOMMU_SUPPORT */ +#endif
Quoted 5 lines
Thanks.
--> Steve Wahl
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 30 lines · Baolu Lu
Quoted 22 lines · Steve Wahl
Quoted 5 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.Quoted 7 lines
If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl <[email protected]>I've received a report from the kernel test robot <[email protected]>, that this patch causes an error (shown below) when
CONFIG_IOMMU_SUPPORTis not set.In my opinion, this is because
include/linux/dmar.handinclude/linux/intel-iommuare being #included when they are not really being used.Quoted 6 lines
I've tried placing the contents of
intel-iommu.hwithin an #ifdefCONFIG_INTEL_IOMMU, and that fixes the problem.Two questions:
A) Is this the desired approach to to the fix?
Quoted 8 lines
Most part of
include/linux/intel-iommu.his private to Intel IOMMU driver. They should be put in a header likedrivers/iommu/intel/iommu.h. Eventually, we should removeinclude/linux/intel-iommu.hand device drivers interact with iommu subsystem through the IOMMU kAPIs.Best regards,
baolu
Baolu's recent patch to move intel-iommu.h private still allows my [PATCH v2] to apply with no changes, and gets rid of the compile errors when CONFIG_IOMMU_SUPPORT is not set, so the kernel test robot should be happy now.
Is there another step I should do to bring this patch back into focus?
Thanks.
--> Steve
Signature · 5 lines
Steve Wahl, Hewlett Packard Enterprise _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Tian, Kevin
Reviewed-byRE: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 46 lines
From: Steve Wahl
Sent: Thursday, May 19, 2022 3:58 AMQuoted 5 lines · Baolu Lu
Quoted 4 lines · Steve Wahl
Quoted 3 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 whenMAXSMP is
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
set.
If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
to
MAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and thesystem
Quoted 19 lines
Quoted 12 lines
Quoted 3 lines
fails to boot properly.
Signed-off-by Steve Wahl <[email protected]>I've received a report from the kernel test robot <[email protected]>, that this patch causes an error (shown below) when
CONFIG_IOMMU_SUPPORTis not set.In my opinion, this is because
include/linux/dmar.handinclude/linux/intel-iommuare being #included when they are not really being used.Quoted 6 lines
I've tried placing the contents of
intel-iommu.hwithin an #ifdefCONFIG_INTEL_IOMMU, and that fixes the problem.Two questions:
A) Is this the desired approach to to the fix?
Quoted 8 lines
Most part of
include/linux/intel-iommu.his private to Intel IOMMU driver. They should be put in a header likedrivers/iommu/intel/iommu.h. Eventually, we should removeinclude/linux/intel-iommu.hand device drivers interact with iommu subsystem through the IOMMU kAPIs.Best regards,
baolu
Quoted 7 lines
Baolu's recent patch to move
intel-iommu.hprivate still allows my [PATCH v2] to apply with no changes, and gets rid of the compile errors whenCONFIG_IOMMU_SUPPORTis not set, so the kernel test robot should be happy now.Is there another step I should do to bring this patch back into focus?
This looks good to me.
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
In reply to Steve WahlQuoted 20 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl <[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.
Quoted 8 lines
v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
drivers/iommu/intel/Kconfig | 6 ++++++ include/linux/dmar.h | 6 +----- 2 files changed, 7 insertions(+), 5 deletions(-)
Baolu do you have this queued up for v5.20? Also do you have a public repo where you keep the vt-d changes before sending Joerg the patches for a release?
Regards,
Jerry
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Baolu Lu
maintainerRe: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 25 lines · Jerry Snitselaar
Quoted 24 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl <[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
Quoted 7 lines
Quoted 4 lines
drivers/iommu/intel/Kconfig | 6 ++++++ include/linux/dmar.h | 6 +----- 2 files changed, 7 insertions(+), 5 deletions(-)Baolu do you have this queued up for v5.20? Also do you have a public repo where you keep the vt-d changes before sending Joerg the patches for a release?
Yes. I have started to queue patches for v5.20. They could be found on github:
https://github.com/LuBaolu/intel-iommu/commits/vtd-next-for-v5.20
Best regards,
baolu
Re: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
In reply to Steve WahlQuoted 33 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl <[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
drivers/iommu/intel/Kconfig | 6 ++++++ include/linux/dmar.h | 6 +----- 2 files changed, 7 insertions(+), 5 deletions(-)drivers/iommu/intel/Kconfig +0
-0
drivers/iommu/intel/Kconfig config DMAR_PERF · line 13
Quoted 5 lines
drivers/iommu/intel/Kconfig +2
-0@@ -9,6 +9,12 @@ config DMAR_PERF config DMAR_DEBUG bool +config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported"
Also, should there be a "depends on (X86 || IA64)" here?
Quoted 27 lines
drivers/iommu/intel/Kconfig +4
-0+ default 1024 if MAXSMP + default 128 if X86_64 + default 64 + config INTEL_IOMMU bool "Support for Intel IOMMU using DMA Remapping Devices" depends on PCI_MSI && ACPI && (X86 || IA64)include/linux/dmar.h +1
-5@@ -18,11 +18,7 @@struct acpi_dmar_header ; -#ifdef CONFIG_X86 -# define DMAR_UNITS_SUPPORTED MAX_IO_APICS -#else -# define DMAR_UNITS_SUPPORTED 64 -#endif +#define DMAR_UNITS_SUPPORTED CONFIG_DMAR_UNITS_SUPPORTED/* DMAR Flags */ #define DMAR_INTR_REMAP 0x1Signature · 1 line
2.26.2
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Baolu Lu
maintainerRe: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 37 lines · Jerry Snitselaar
Quoted 36 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl <[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
drivers/iommu/intel/Kconfig | 6 ++++++ include/linux/dmar.h | 6 +----- 2 files changed, 7 insertions(+), 5 deletions(-)drivers/iommu/intel/Kconfig +0
-0@@ -9,6 +9,12 @@ config DMAR_PERF config DMAR_DEBUG bool
Quoted 4 lines
drivers/iommu/intel/Kconfig config DMAR_PERF · line 13
Quoted 2 lines
drivers/iommu/intel/Kconfig +2
-0+config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported"Also, should there be a "depends on (X86 || IA64)" here?
Do you have any compilation errors or warnings?
Best regards,
baolu
Quoted 23 lines
Quoted 23 lines
drivers/iommu/intel/Kconfig +4
-0+ default 1024 if MAXSMP + default 128 if X86_64 + default 64 + config INTEL_IOMMU bool "Support for Intel IOMMU using DMA Remapping Devices" depends on PCI_MSI && ACPI && (X86 || IA64)include/linux/dmar.h +1
-5@@ -18,11 +18,7 @@struct acpi_dmar_header ; -#ifdef CONFIG_X86 -# define DMAR_UNITS_SUPPORTED MAX_IO_APICS -#else -# define DMAR_UNITS_SUPPORTED 64 -#endif +#define DMAR_UNITS_SUPPORTED CONFIG_DMAR_UNITS_SUPPORTED
Quoted 6 lines
Quoted 5 lines
include/linux/dmar.h +0
-0/* DMAR Flags */ #define DMAR_INTR_REMAP 0x1Signature · 1 line
2.26.2
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 44 lines · Baolu Lu
Quoted 37 lines · Jerry Snitselaar
Quoted 36 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl <[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
drivers/iommu/intel/Kconfig | 6 ++++++ include/linux/dmar.h | 6 +----- 2 files changed, 7 insertions(+), 5 deletions(-)drivers/iommu/intel/Kconfig +0
-0@@ -9,6 +9,12 @@ config DMAR_PERF config DMAR_DEBUG boolQuoted 4 lines
drivers/iommu/intel/Kconfig config DMAR_PERF · line 13
Quoted 2 lines
drivers/iommu/intel/Kconfig +2
-0+config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported"Also, should there be a "depends on (X86 || IA64)" here?
Quoted 5 lines
Do you have any compilation errors or warnings?
Best regards,
baolu
I think it is probably harmless since it doesn't get used elsewhere, but our tooling was complaining to me because DMAR_UNITS_SUPPORTED was being autogenerated into the configs for the non-x86 architectures we build (aarch64, s390x, ppcle64).
We have files corresponding to the config options that it looks at, and I had one for x86 and not the others so it noticed the discrepancy.
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
drivers/iommu/intel/Kconfig +4
-0+ default 1024 if MAXSMP + default 128 if X86_64 + default 64 + config INTEL_IOMMU bool "Support for Intel IOMMU using DMA Remapping Devices" depends on PCI_MSI && ACPI && (X86 || IA64)include/linux/dmar.h +1
-5@@ -18,11 +18,7 @@struct acpi_dmar_header ; -#ifdef CONFIG_X86 -# define DMAR_UNITS_SUPPORTED MAX_IO_APICS -#else -# define DMAR_UNITS_SUPPORTED 64 -#endif +#define DMAR_UNITS_SUPPORTED CONFIG_DMAR_UNITS_SUPPORTED
Quoted 7 lines
Quoted 6 lines
Quoted 5 lines
include/linux/dmar.h +0
-1/* DMAR Flags */ #define DMAR_INTR_REMAP 0x1 --2.26.2
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Baolu Lu
maintainerRe: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 47 lines · Jerry Snitselaar
Quoted 38 lines · Baolu Lu
Quoted 37 lines · Jerry Snitselaar
Quoted 36 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl<[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
drivers/iommu/intel/Kconfig | 6 ++++++ include/linux/dmar.h | 6 +----- 2 files changed, 7 insertions(+), 5 deletions(-)drivers/iommu/intel/Kconfig +0
-0@@ -9,6 +9,12 @@ config DMAR_PERF config DMAR_DEBUG boolQuoted 8 lines
Quoted 3 lines
drivers/iommu/intel/Kconfig config DMAR_PERF · line 13
Quoted 2 lines
drivers/iommu/intel/Kconfig +2
-0+config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported"Also, should there be a "depends on (X86 || IA64)" here?
Do you have any compilation errors or warnings?
Best regards,
baolu
Quoted 7 lines
I think it is probably harmless since it doesn't get used elsewhere, but our tooling was complaining to me because
DMAR_UNITS_SUPPORTEDwas being autogenerated into the configs for the non-x86 architectures we build (aarch64, s390x, ppcle64).
We have files corresponding to the config options that it looks at, and I had one for x86 and not the others so it noticed the discrepancy.
So with "depends on (X86 || IA64)", that tool doesn't complain anymore, right?
Best regards,
baolu
Re: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 57 lines · Baolu Lu
Quoted 47 lines · Jerry Snitselaar
Quoted 38 lines · Baolu Lu
Quoted 37 lines · Jerry Snitselaar
Quoted 36 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl<[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
drivers/iommu/intel/Kconfig | 6 ++++++ include/linux/dmar.h | 6 +----- 2 files changed, 7 insertions(+), 5 deletions(-)drivers/iommu/intel/Kconfig +0
-0@@ -9,6 +9,12 @@ config DMAR_PERF config DMAR_DEBUG boolQuoted 8 lines
Quoted 3 lines
drivers/iommu/intel/Kconfig config DMAR_PERF · line 13
Quoted 2 lines
drivers/iommu/intel/Kconfig +2
-0+config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported"Also, should there be a "depends on (X86 || IA64)" here?
Do you have any compilation errors or warnings?
Best regards,
baoluQuoted 7 lines
I think it is probably harmless since it doesn't get used elsewhere, but our tooling was complaining to me because
DMAR_UNITS_SUPPORTEDwas being autogenerated into the configs for the non-x86 architectures we build (aarch64, s390x, ppcle64).
We have files corresponding to the config options that it looks at, and I had one for x86 and not the others so it noticed the discrepancy.
Quoted 6 lines
So with "depends on (X86 || IA64)", that tool doesn't complain anymore, right?
Best regards,
baolu
Yes, with the depends it no longer happens.
Regards,
Jerry
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Baolu Lu
maintainerRe: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 58 lines · Jerry Snitselaar
Quoted 57 lines · Baolu Lu
Quoted 54 lines · Jerry Snitselaar
Quoted 38 lines · Baolu Lu
Quoted 37 lines · Jerry Snitselaar
Quoted 36 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl<[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
drivers/iommu/intel/Kconfig | 6 ++++++ include/linux/dmar.h | 6 +----- 2 files changed, 7 insertions(+), 5 deletions(-)drivers/iommu/intel/Kconfig +0
-0@@ -9,6 +9,12 @@ config DMAR_PERF config DMAR_DEBUG boolQuoted 8 lines
Quoted 3 lines
drivers/iommu/intel/Kconfig config DMAR_PERF · line 13
Quoted 2 lines
drivers/iommu/intel/Kconfig +2
-0+config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported"Also, should there be a "depends on (X86 || IA64)" here?
Do you have any compilation errors or warnings?
Best regards,
baoluI think it is probably harmless since it doesn't get used elsewhere, but our tooling was complaining to me because
DMAR_UNITS_SUPPORTEDwas being autogenerated into the configs for the non-x86 architectures we build (aarch64, s390x, ppcle64).
We have files corresponding to the config options that it looks at, and I had one for x86 and not the others so it noticed the discrepancy.
Quoted 8 lines
Quoted 6 lines
So with "depends on (X86 || IA64)", that tool doesn't complain anymore, right?
Best regards,
baoluYes, with the depends it no longer happens.
The dmar code only exists on X86 and IA64 arch's. Adding this depending makes sense to me. I will add it if no objections.
Best regards,
baolu
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 62 lines · Baolu Lu
Quoted 61 lines · Jerry Snitselaar
Quoted 60 lines · Baolu Lu
Quoted 47 lines · Jerry Snitselaar
Quoted 38 lines · Baolu Lu
Quoted 37 lines · Jerry Snitselaar
Quoted 36 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl<[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
drivers/iommu/intel/Kconfig | 6 ++++++ include/linux/dmar.h | 6 +----- 2 files changed, 7 insertions(+), 5 deletions(-)drivers/iommu/intel/Kconfig +0
-0@@ -9,6 +9,12 @@ config DMAR_PERF config DMAR_DEBUG boolQuoted 8 lines
Quoted 3 lines
drivers/iommu/intel/Kconfig config DMAR_PERF · line 13
Quoted 2 lines
drivers/iommu/intel/Kconfig +2
-0+config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported"Also, should there be a "depends on (X86 || IA64)" here?
Do you have any compilation errors or warnings?
Best regards,
baoluQuoted 7 lines
I think it is probably harmless since it doesn't get used elsewhere, but our tooling was complaining to me because
DMAR_UNITS_SUPPORTEDwas being autogenerated into the configs for the non-x86 architectures we build (aarch64, s390x, ppcle64).
We have files corresponding to the config options that it looks at, and I had one for x86 and not the others so it noticed the discrepancy.So with "depends on (X86 || IA64)", that tool doesn't complain anymore, right?
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Best regards,
baoluYes, with the depends it no longer happens.
The dmar code only exists on X86 and IA64 arch's. Adding this depending makes sense to me. I will add it if no objections.
I think that works after Baolu's patchset that makes intel-iommu.h private. I'm pretty sure it wouldn't have worked before that.
No objections.
--> Steve
Signature · 5 lines
Steve Wahl, Hewlett Packard Enterprise _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 69 lines · Steve Wahl
Quoted 68 lines · Baolu Lu
Quoted 66 lines · Jerry Snitselaar
Quoted 57 lines · Baolu Lu
Quoted 47 lines · Jerry Snitselaar
Quoted 38 lines · Baolu Lu
Quoted 37 lines · Jerry Snitselaar
Quoted 36 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl<[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
drivers/iommu/intel/Kconfig | 6 ++++++ include/linux/dmar.h | 6 +----- 2 files changed, 7 insertions(+), 5 deletions(-)drivers/iommu/intel/Kconfig +0
-0@@ -9,6 +9,12 @@ config DMAR_PERF config DMAR_DEBUG boolQuoted 8 lines
Quoted 3 lines
drivers/iommu/intel/Kconfig config DMAR_PERF · line 13
Quoted 2 lines
drivers/iommu/intel/Kconfig +2
-0+config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported"Also, should there be a "depends on (X86 || IA64)" here?
Do you have any compilation errors or warnings?
Best regards,
baoluQuoted 7 lines
I think it is probably harmless since it doesn't get used elsewhere, but our tooling was complaining to me because
DMAR_UNITS_SUPPORTEDwas being autogenerated into the configs for the non-x86 architectures we build (aarch64, s390x, ppcle64).
We have files corresponding to the config options that it looks at, and I had one for x86 and not the others so it noticed the discrepancy.Quoted 6 lines
So with "depends on (X86 || IA64)", that tool doesn't complain anymore, right?
Best regards,
baoluYes, with the depends it no longer happens.
Quoted 8 lines
Quoted 2 lines
The dmar code only exists on X86 and IA64 arch's. Adding this depending makes sense to me. I will add it if no objections.
I think that works after Baolu's patchset that makes
intel-iommu.hprivate. I'm pretty sure it wouldn't have worked before that.No objections.
Yes, I think applying it with the depends prior to Baolu's change would still run into the issue from the KTR report if someone compiled without INTEL_IOMMU enabled.
This was dealing with being able to do something like:
make allmodconfig ARCH=arm64 ; grep DMAR_UNITS .config
and finding CONFIG_DMAR_UNITS_SUPPORTED=64.
Thinking some more though, instead of the depends being on the arch would depending on DMAR_TABLE or INTEL_IOMMU be more appropriate?
Regards,
Jerry
Quoted 4 lines
--> Steve
Signature · 1 line
Steve Wahl, Hewlett Packard Enterprise
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 83 lines · Jerry Snitselaar
Quoted 69 lines · Steve Wahl
Quoted 68 lines · Baolu Lu
Quoted 66 lines · Jerry Snitselaar
Quoted 57 lines · Baolu Lu
Quoted 47 lines · Jerry Snitselaar
Quoted 38 lines · Baolu Lu
Quoted 37 lines · Jerry Snitselaar
Quoted 36 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl<[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
drivers/iommu/intel/Kconfig | 6 ++++++ include/linux/dmar.h | 6 +----- 2 files changed, 7 insertions(+), 5 deletions(-)drivers/iommu/intel/Kconfig +0
-0@@ -9,6 +9,12 @@ config DMAR_PERF config DMAR_DEBUG boolQuoted 8 lines
Quoted 3 lines
drivers/iommu/intel/Kconfig config DMAR_PERF · line 13
Quoted 2 lines
drivers/iommu/intel/Kconfig +2
-0+config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported"Also, should there be a "depends on (X86 || IA64)" here?
Do you have any compilation errors or warnings?
Best regards,
baoluQuoted 7 lines
I think it is probably harmless since it doesn't get used elsewhere, but our tooling was complaining to me because
DMAR_UNITS_SUPPORTEDwas being autogenerated into the configs for the non-x86 architectures we build (aarch64, s390x, ppcle64).
We have files corresponding to the config options that it looks at, and I had one for x86 and not the others so it noticed the discrepancy.Quoted 6 lines
So with "depends on (X86 || IA64)", that tool doesn't complain anymore, right?
Best regards,
baoluYes, with the depends it no longer happens.
Quoted 8 lines
Quoted 2 lines
The dmar code only exists on X86 and IA64 arch's. Adding this depending makes sense to me. I will add it if no objections.
I think that works after Baolu's patchset that makes
intel-iommu.hprivate. I'm pretty sure it wouldn't have worked before that.No objections.
Yes, I think applying it with the depends prior to Baolu's change would still run into the issue from the KTR report if someone compiled without
INTEL_IOMMUenabled.
Quoted 8 lines
This was dealing with being able to do something like:
make allmodconfig ARCH=arm64 ; grep
DMAR_UNITS.configand finding
CONFIG_DMAR_UNITS_SUPPORTED=64.Thinking some more though, instead of the depends being on the arch would depending on
DMAR_TABLEorINTEL_IOMMUbe more appropriate?
At least in my limited exploration, depending on INTEL_IOMMU yields compile errors, but depending upon DMAR_TABLE appears to work fine.
--> Steve
Signature · 5 lines
Steve Wahl, Hewlett Packard Enterprise _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Baolu Lu
maintainerRe: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 88 lines · Steve Wahl
Quoted 87 lines · Jerry Snitselaar
Quoted 69 lines · Steve Wahl
Quoted 68 lines · Baolu Lu
Quoted 66 lines · Jerry Snitselaar
Quoted 57 lines · Baolu Lu
Quoted 47 lines · Jerry Snitselaar
Quoted 38 lines · Baolu Lu
Quoted 37 lines · Jerry Snitselaar
Quoted 36 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl<[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
drivers/iommu/intel/Kconfig | 6 ++++++ include/linux/dmar.h | 6 +----- 2 files changed, 7 insertions(+), 5 deletions(-)drivers/iommu/intel/Kconfig +0
-0@@ -9,6 +9,12 @@ config DMAR_PERF config DMAR_DEBUG boolQuoted 8 lines
Quoted 3 lines
drivers/iommu/intel/Kconfig config DMAR_PERF · line 13
Quoted 2 lines
drivers/iommu/intel/Kconfig +2
-0+config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported"Also, should there be a "depends on (X86 || IA64)" here?
Do you have any compilation errors or warnings?
Best regards,
baoluQuoted 7 lines
I think it is probably harmless since it doesn't get used elsewhere, but our tooling was complaining to me because
DMAR_UNITS_SUPPORTEDwas being autogenerated into the configs for the non-x86 architectures we build (aarch64, s390x, ppcle64).
We have files corresponding to the config options that it looks at, and I had one for x86 and not the others so it noticed the discrepancy.Quoted 6 lines
So with "depends on (X86 || IA64)", that tool doesn't complain anymore, right?
Best regards,
baoluYes, with the depends it no longer happens.
Quoted 8 lines
Quoted 2 lines
The dmar code only exists on X86 and IA64 arch's. Adding this depending makes sense to me. I will add it if no objections.
I think that works after Baolu's patchset that makes
intel-iommu.hprivate. I'm pretty sure it wouldn't have worked before that.No objections.
Yes, I think applying it with the depends prior to Baolu's change would still run into the issue from the KTR report if someone compiled without
INTEL_IOMMUenabled.This was dealing with being able to do something like:
make allmodconfig ARCH=arm64 ; grep
DMAR_UNITS.config
Quoted 7 lines
Quoted 4 lines
and finding
CONFIG_DMAR_UNITS_SUPPORTED=64.Thinking some more though, instead of the depends being on the arch would depending on
DMAR_TABLEorINTEL_IOMMUbe more appropriate?At least in my limited exploration, depending on
INTEL_IOMMUyields compile errors, but depending uponDMAR_TABLEappears to work fine.
DMAR_TABLE is used beyond INTEL_IOMMU, so depending on DMAR_TABLE seems better.
Steve, do you mind posting a v3 with this fixed?
Best regards,
baolu
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 94 lines · Baolu Lu
Quoted 93 lines · Steve Wahl
Quoted 91 lines · Jerry Snitselaar
Quoted 69 lines · Steve Wahl
Quoted 68 lines · Baolu Lu
Quoted 66 lines · Jerry Snitselaar
Quoted 57 lines · Baolu Lu
Quoted 47 lines · Jerry Snitselaar
Quoted 38 lines · Baolu Lu
Quoted 37 lines · Jerry Snitselaar
Quoted 36 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl<[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
drivers/iommu/intel/Kconfig | 6 ++++++ include/linux/dmar.h | 6 +----- 2 files changed, 7 insertions(+), 5 deletions(-)drivers/iommu/intel/Kconfig +0
-0@@ -9,6 +9,12 @@ config DMAR_PERF config DMAR_DEBUG boolQuoted 8 lines
Quoted 3 lines
drivers/iommu/intel/Kconfig config DMAR_PERF · line 13
Quoted 2 lines
drivers/iommu/intel/Kconfig +2
-0+config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported"Also, should there be a "depends on (X86 || IA64)" here?
Do you have any compilation errors or warnings?
Best regards,
baoluQuoted 7 lines
I think it is probably harmless since it doesn't get used elsewhere, but our tooling was complaining to me because
DMAR_UNITS_SUPPORTEDwas being autogenerated into the configs for the non-x86 architectures we build (aarch64, s390x, ppcle64).
We have files corresponding to the config options that it looks at, and I had one for x86 and not the others so it noticed the discrepancy.Quoted 6 lines
So with "depends on (X86 || IA64)", that tool doesn't complain anymore, right?
Best regards,
baoluYes, with the depends it no longer happens.
Quoted 8 lines
Quoted 2 lines
The dmar code only exists on X86 and IA64 arch's. Adding this depending makes sense to me. I will add it if no objections.
I think that works after Baolu's patchset that makes
intel-iommu.hprivate. I'm pretty sure it wouldn't have worked before that.No objections.
Yes, I think applying it with the depends prior to Baolu's change would still run into the issue from the KTR report if someone compiled without
INTEL_IOMMUenabled.This was dealing with being able to do something like:
make allmodconfig ARCH=arm64 ; grep
DMAR_UNITS.configand finding
CONFIG_DMAR_UNITS_SUPPORTED=64.Thinking some more though, instead of the depends being on the arch would depending on
DMAR_TABLEorINTEL_IOMMUbe more appropriate?
Quoted 7 lines
Quoted 2 lines
At least in my limited exploration, depending on
INTEL_IOMMUyields compile errors, but depending uponDMAR_TABLEappears to work fine.
DMAR_TABLEis used beyondINTEL_IOMMU, so depending onDMAR_TABLEseems better.Steve, do you mind posting a v3 with this fixed?
I can do that. Expect it shortly.
--> Steve
Signature · 5 lines
Steve Wahl, Hewlett Packard Enterprise _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
PATCH v3 1/1 iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
In reply to Baolu LuTo support up to 64 sockets with 10 DMAR units each (640), make the value of DMAR_UNITS_SUPPORTED adjustable by a config variable, CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.
If the available hardware exceeds DMAR_UNITS_SUPPORTED (previously set to MAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocate seq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.
---
Note that we could not find a reason for connecting DMAR_UNITS_SUPPORTED to MAX_IO_APICS as was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.
v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
v3: Make the config option dependent upon DMAR_TABLE, as it is not used without this.
drivers/iommu/intel/Kconfig | 7 +++++++ include/linux/dmar.h | 6 +----- 2 files changed, 8 insertions(+), 5 deletions(-)
drivers/iommu/intel/Kconfig +7 -0
@@ -9,6 +9,13 @@ config DMAR_PERF config DMAR_DEBUG bool +config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported" + depends on DMAR_TABLE + default 1024 if MAXSMP + default 128 if X86_64 + default 64 + config INTEL_IOMMU bool "Support for Intel IOMMU using DMA Remapping Devices" depends on PCI_MSI && ACPI && (X86 || IA64)
include/linux/dmar.h +1 -5
@@ -18,11 +18,7 @@struct acpi_dmar_header ; -#ifdef CONFIG_X86 -# define DMAR_UNITS_SUPPORTED MAX_IO_APICS -#else -# define DMAR_UNITS_SUPPORTED 64 -#endif +#define DMAR_UNITS_SUPPORTED CONFIG_DMAR_UNITS_SUPPORTED/* DMAR Flags */ #define DMAR_INTR_REMAP 0x1
Signature · 6 lines
2.26.2 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v3] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 5 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.
Quoted 8 lines
If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl <[email protected]>Reviewed-by Kevin Tian <[email protected]>
Quoted 56 lines
---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
v3: Make the config option dependent upon
DMAR_TABLE, as it is not used without this.drivers/iommu/intel/Kconfig | 7 +++++++ include/linux/dmar.h | 6 +----- 2 files changed, 8 insertions(+), 5 deletions(-)drivers/iommu/intel/Kconfig +7
-0@@ -9,6 +9,13 @@ config DMAR_PERF config DMAR_DEBUG bool +config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported" + depends on DMAR_TABLE + default 1024 if MAXSMP + default 128 if X86_64 + default 64 + config INTEL_IOMMU bool "Support for Intel IOMMU using DMA Remapping Devices" depends on PCI_MSI && ACPI && (X86 || IA64)include/linux/dmar.h +1
-5@@ -18,11 +18,7 @@struct acpi_dmar_header ; -#ifdef CONFIG_X86 -# define DMAR_UNITS_SUPPORTED MAX_IO_APICS -#else -# define DMAR_UNITS_SUPPORTED 64 -#endif +#define DMAR_UNITS_SUPPORTED CONFIG_DMAR_UNITS_SUPPORTED/* DMAR Flags */ #define DMAR_INTR_REMAP 0x1Signature · 1 line
2.26.2
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Baolu Lu
maintainerRe: [PATCH v3] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
In reply to Steve WahlQuoted 36 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl<[email protected]>Reviewed-by Kevin Tian<[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
v3: Make the config option dependent upon
DMAR_TABLE, as it is not used without this.drivers/iommu/intel/Kconfig | 7 +++++++ include/linux/dmar.h | 6 +----- 2 files changed, 8 insertions(+), 5 deletions(-)drivers/iommu/intel/Kconfig +0
-0
drivers/iommu/intel/Kconfig config DMAR_PERF · line 17
Quoted 9 lines
drivers/iommu/intel/Kconfig +6
-0@@ -9,6 +9,13 @@ config DMAR_PERF config DMAR_DEBUG bool +config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported" + depends on DMAR_TABLE + default 1024 if MAXSMP + default 128 if X86_64 + default 64
With this patch applied, the IOMMU configuration looks like:
[*] AMD IOMMU support
<M> AMD IOMMU Version 2 driver
[*] Enable AMD IOMMU internals in DebugFS
(1024) Number of DMA Remapping Units supported <<<< NEW
[*] Support for Intel IOMMU using DMA Remapping Devices
[*] Export Intel IOMMU internals in Debugfs [*] Support for Shared Virtual Memory with Intel IOMMU [*] Enable Intel DMA Remapping Devices by default [*] Enable Intel IOMMU scalable mode by default
[*] Support for Interrupt Remapping
[*] OMAP IOMMU Support
[*] Export OMAP IOMMU internals in DebugFS
[*] Rockchip IOMMU Support
The NEW item looks confusing. It looks to be a generic configurable value though it's actually Intel DMAR specific. Any thoughts?
Best regards,
baolu
Re: [PATCH v3] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 64 lines · Baolu Lu
Quoted 36 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl<[email protected]>Reviewed-by Kevin Tian<[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
v3: Make the config option dependent upon
DMAR_TABLE, as it is not used without this.drivers/iommu/intel/Kconfig | 7 +++++++ include/linux/dmar.h | 6 +----- 2 files changed, 8 insertions(+), 5 deletions(-)drivers/iommu/intel/Kconfig +0
-0drivers/iommu/intel/Kconfig config DMAR_PERF · line 17
Quoted 9 lines
drivers/iommu/intel/Kconfig +6
-0@@ -9,6 +9,13 @@ config DMAR_PERF config DMAR_DEBUG bool +config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported" + depends on DMAR_TABLE + default 1024 if MAXSMP + default 128 if X86_64 + default 64With this patch applied, the IOMMU configuration looks like:
[*] AMD IOMMU support
<M> AMD IOMMU Version 2 driver
[*] Enable AMD IOMMU internals in DebugFS
(1024) Number of DMA Remapping Units supported <<<< NEW
[*] Support for Intel IOMMU using DMA Remapping Devices[*] Export Intel IOMMU internals in Debugfs [*] Support for Shared Virtual Memory with Intel IOMMU [*] Enable Intel DMA Remapping Devices by default [*] Enable Intel IOMMU scalable mode by default[*] Support for Interrupt Remapping
[*] OMAP IOMMU Support
[*] Export OMAP IOMMU internals in DebugFS
[*] Rockchip IOMMU Support
Quoted 6 lines
The NEW item looks confusing. It looks to be a generic configurable value though it's actually Intel DMAR specific. Any thoughts?
Best regards,
baolu
Would moving it under INTEL_IOMMU at least have it show up below "Support for Intel IOMMU using DMA Remapping Devices"? I'm not sure it can be better than that, because IRQ_REMAP selects DMAR_TABLE, so we can't stick it in the if INTEL_IOMMU section.
Regards,
Jerry
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v3] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 72 lines · Jerry Snitselaar
Quoted 64 lines · Baolu Lu
Quoted 36 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl<[email protected]>Reviewed-by Kevin Tian<[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
v3: Make the config option dependent upon
DMAR_TABLE, as it is not used without this.drivers/iommu/intel/Kconfig | 7 +++++++ include/linux/dmar.h | 6 +----- 2 files changed, 8 insertions(+), 5 deletions(-)drivers/iommu/intel/Kconfig +0
-0drivers/iommu/intel/Kconfig config DMAR_PERF · line 17
Quoted 9 lines
drivers/iommu/intel/Kconfig +6
-0@@ -9,6 +9,13 @@ config DMAR_PERF config DMAR_DEBUG bool +config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported" + depends on DMAR_TABLE + default 1024 if MAXSMP + default 128 if X86_64 + default 64With this patch applied, the IOMMU configuration looks like:
[*] AMD IOMMU support
<M> AMD IOMMU Version 2 driver
[*] Enable AMD IOMMU internals in DebugFS
(1024) Number of DMA Remapping Units supported <<<< NEW
[*] Support for Intel IOMMU using DMA Remapping Devices[*] Export Intel IOMMU internals in Debugfs [*] Support for Shared Virtual Memory with Intel IOMMU [*] Enable Intel DMA Remapping Devices by default [*] Enable Intel IOMMU scalable mode by default[*] Support for Interrupt Remapping
[*] OMAP IOMMU Support
[*] Export OMAP IOMMU internals in DebugFS
[*] Rockchip IOMMU SupportQuoted 6 lines
The NEW item looks confusing. It looks to be a generic configurable value though it's actually Intel DMAR specific. Any thoughts?
Best regards,
baolu
Quoted 7 lines
Would moving it under
INTEL_IOMMUat least have it show up below "Support for Intel IOMMU using DMA Remapping Devices"? I'm not sure it can be better than that, becauseIRQ_REMAPselectsDMAR_TABLE, so we can't stick it in the ifINTEL_IOMMUsection.Regards,
Jerry
I have no qualms with Jerry's suggestion.
--> Steve Wahl
Signature · 5 lines
Steve Wahl, Hewlett Packard Enterprise _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Baolu Lu
maintainerRe: [PATCH v3] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
In reply to Jerry SnitselaarQuoted 66 lines · Jerry Snitselaar
Quoted 65 lines · Baolu Lu
Quoted 36 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl<[email protected]>Reviewed-by Kevin Tian<[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
v3: Make the config option dependent upon
DMAR_TABLE, as it is not used without this.drivers/iommu/intel/Kconfig | 7 +++++++ include/linux/dmar.h | 6 +----- 2 files changed, 8 insertions(+), 5 deletions(-)drivers/iommu/intel/Kconfig +0
-0drivers/iommu/intel/Kconfig config DMAR_PERF · line 17
Quoted 9 lines
drivers/iommu/intel/Kconfig +6
-0@@ -9,6 +9,13 @@ config DMAR_PERF config DMAR_DEBUG bool +config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported" + depends on DMAR_TABLE + default 1024 if MAXSMP + default 128 if X86_64 + default 64With this patch applied, the IOMMU configuration looks like:
[*] AMD IOMMU support
<M> AMD IOMMU Version 2 driver
[*] Enable AMD IOMMU internals in DebugFS
(1024) Number of DMA Remapping Units supported <<<< NEW
[*] Support for Intel IOMMU using DMA Remapping Devices[*] Export Intel IOMMU internals in Debugfs [*] Support for Shared Virtual Memory with Intel IOMMU [*] Enable Intel DMA Remapping Devices by default [*] Enable Intel IOMMU scalable mode by default[*] Support for Interrupt Remapping
[*] OMAP IOMMU Support
[*] Export OMAP IOMMU internals in DebugFS
[*] Rockchip IOMMU SupportThe NEW item looks confusing. It looks to be a generic configurable value though it's actually Intel DMAR specific. Any thoughts?
Quoted 7 lines
Quoted 3 lines
Best regards,
baoluWould moving it under
INTEL_IOMMUat least have it show up below "Support for Intel IOMMU using DMA Remapping Devices"? I'm not sure it can be better than that, becauseIRQ_REMAPselectsDMAR_TABLE, so we can't stick it in the ifINTEL_IOMMUsection.
It's more reasonable to move it under INTEL_IOMMU, but the trouble is that this also stands even if INTEL_IOMMU is not configured.
The real problem here is that the iommu sequence ID overflows if DMAR_UNITS_SUPPORTED is not big enough. This is purely a software implementation issue, I am not sure whether user opt-in when building a kernel package could help a lot here.
If we can't find a better way, can we just step back?
Best regards,
baolu
Re: [PATCH v3] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 70 lines · Baolu Lu
Quoted 69 lines · Jerry Snitselaar
Quoted 68 lines · Baolu Lu
Quoted 36 lines · Steve Wahl
To support up to 64 sockets with 10 DMAR units each (640), make the value of
DMAR_UNITS_SUPPORTEDadjustable by a config variable,CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is set.If the available hardware exceeds
DMAR_UNITS_SUPPORTED(previously set toMAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to allocateseq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ remapping doesn't support X2APIC mode x2apic disabled"; and the system fails to boot properly.Signed-off-by Steve Wahl<[email protected]>Reviewed-by Kevin Tian<[email protected]>---
Note that we could not find a reason for connecting
DMAR_UNITS_SUPPORTEDtoMAX_IO_APICSas was done previously. Perhaps it seemed like the two would continue to match on earlier processors. There doesn't appear to be kernel code that assumes that the value of one is related to the other.v2: Make this value a config option, rather than a fixed constant. The default values should match previous configuration except in the MAXSMP case. Keeping the value at a power of two was requested by Kevin Tian.
v3: Make the config option dependent upon
DMAR_TABLE, as it is not used without this.drivers/iommu/intel/Kconfig | 7 +++++++ include/linux/dmar.h | 6 +----- 2 files changed, 8 insertions(+), 5 deletions(-)drivers/iommu/intel/Kconfig +0
-0drivers/iommu/intel/Kconfig config DMAR_PERF · line 17
Quoted 9 lines
drivers/iommu/intel/Kconfig +6
-0@@ -9,6 +9,13 @@ config DMAR_PERF config DMAR_DEBUG bool +config DMAR_UNITS_SUPPORTED + int "Number of DMA Remapping Units supported" + depends on DMAR_TABLE + default 1024 if MAXSMP + default 128 if X86_64 + default 64With this patch applied, the IOMMU configuration looks like:
[*] AMD IOMMU support
<M> AMD IOMMU Version 2 driver
[*] Enable AMD IOMMU internals in DebugFS
(1024) Number of DMA Remapping Units supported <<<< NEW
[*] Support for Intel IOMMU using DMA Remapping Devices[*] Export Intel IOMMU internals in Debugfs [*] Support for Shared Virtual Memory with Intel IOMMU [*] Enable Intel DMA Remapping Devices by default [*] Enable Intel IOMMU scalable mode by default[*] Support for Interrupt Remapping
[*] OMAP IOMMU Support
[*] Export OMAP IOMMU internals in DebugFS
[*] Rockchip IOMMU SupportThe NEW item looks confusing. It looks to be a generic configurable value though it's actually Intel DMAR specific. Any thoughts?
Best regards,
baolu
Quoted 7 lines
Quoted 4 lines
Would moving it under
INTEL_IOMMUat least have it show up below "Support for Intel IOMMU using DMA Remapping Devices"? I'm not sure it can be better than that, becauseIRQ_REMAPselectsDMAR_TABLE, so we can't stick it in the ifINTEL_IOMMUsection.It's more reasonable to move it under
INTEL_IOMMU, but the trouble is that this also stands even ifINTEL_IOMMUis not configured.
My thought only was with it after the 'config INTEL_IOMMU' block and before 'if INTEL_IOMMU' it would show up like:
[*] Support for Intel IOMMU using DMA Remapping Devices
(1024) Number of DMA Remapping Units supported <<<< NEW
Quoted 6 lines
The real problem here is that the iommu sequence ID overflows if
DMAR_UNITS_SUPPORTEDis not big enough. This is purely a software implementation issue, I am not sure whether user opt-in when building a kernel package could help a lot here.
Is this something that could be figured out when parsing the dmar table? It looks like currently iommu_refcnt[], iommu_did[], and dmar_seq_ids[] depend on it.
Regards,
Jerry
Quoted 4 lines
If we can't find a better way, can we just step back?
Best regards,
baolu
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Baolu Lu
maintainerRe: [PATCH v3] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Quoted 8 lines · Jerry Snitselaar
Quoted 5 lines
The real problem here is that the iommu sequence ID overflows if
DMAR_UNITS_SUPPORTEDis not big enough. This is purely a software implementation issue, I am not sure whether user opt-in when building a kernel package could help a lot here.Is this something that could be figured out when parsing the dmar table? It looks like currently iommu_refcnt[], iommu_did[], and dmar_seq_ids[] depend on it.
That's definitely a better solution.
Best regards,
baolu
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu