Skip to contentSkip to conversation

mach-versatile: (platsmp-realview) Add missing of_node_put()

PATCH In review Liang He 2 participants 2 messages Jun 16, 2022 – Sep 13, 2023

Subsystems (4)
lore
Share & tools
lore

Liang He

author
#0 lore raw

PATCH v2 1/1 mach-versatile: (platsmp-realview) Add missing of_node_put()

In realview_smp_prepare_cpus(), the second of_find_matching_node() has no corresponding of_node_put() when the node pointer is not used anymore.

---
changelog:

v2: use real name for Sob
v1: fix missing bug

 arch/arm/mach-versatile/platsmp-realview.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-versatile/platsmp-realview.c +1 -0
index 5d363385c801..059d796b26bc 100644
@@ -66,6 +66,7 @@ static void __init realview_smp_prepare_cpus(unsigned int max_cpus)
 		return;
 	}
 	map = syscon_node_to_regmap(np);
+	of_node_put(np);
 	if (IS_ERR(map)) {
 		pr_err("PLATSMP: No syscon regmap\n");
 		return;
Signature · 1 line
2.25.1
#1 lore raw
Quoted 5 lines · Liang He

In realview_smp_prepare_cpus(), the second of_find_matching_node() has no corresponding of_node_put() when the node pointer is not used anymore.

Patch applied.

Yours,
Linus Walleij