Skip to contentSkip to conversation

mach-ux500: (pm_domain) Add missing of_node_put()

PATCH New Liang He 1 participant 1 message Jun 16, 2022

Subsystems (3)
lore
Share & tools
lore

Liang He

author
#0 lore raw

PATCH v2 1/1 mach-ux500: (pm_domain) Add missing of_node_put()

In ux500_pm_domains_init(), of_find_matching_node() will return a node pointer with refcount incremented. We should use of_node_put() in fail path or when it is not used anymore.

---
changelog:

v2: use real name for Sob
v1: fix missing bug

 arch/arm/mach-ux500/pm_domains.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
arch/arm/mach-ux500/pm_domains.c +4 -1
index 427b9ac4af6c..81926b197e51 100644
@@ -65,8 +65,10 @@ int __init ux500_pm_domains_init(void)
 		return -ENODEV;
 
 	genpd_data = kzalloc(sizeof(*genpd_data), GFP_KERNEL);
-	if (!genpd_data)
+	if (!genpd_data) {
+		of_node_put(np);
 		return -ENOMEM;
+	}
 
 	genpd_data->domains = ux500_pm_domains;
 	genpd_data->num_domains = ARRAY_SIZE(ux500_pm_domains);
@@ -75,5 +77,6 @@ int __init ux500_pm_domains_init(void)
 		pm_genpd_init(ux500_pm_domains[i], NULL, false);
 
 	of_genpd_add_provider_onecell(np, genpd_data);
+	of_node_put(np);
 	return 0;
 }
Signature · 1 line
2.25.1