Skip to contentSkip to conversation

net: axienet: add missing error return code in axienet_probe()

PATCH Applied Yang Yingliang 2 participants 2 messages Jun 16, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: axienet: add missing error return code in axienet_probe()

It should return error code in error path in axienet_probe().

Fixes 00be43a74ca2 ("net: axienet: make the 64b addresable DMA depends on 64b archectures")
---
 drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/xilinx/xilinx_axienet_main.c +1 -0
index fa7bcd2c1892..1760930ec0c4 100644
@@ -2039,6 +2039,7 @@ static int axienet_probe(struct platform_device *pdev)
 	}
 	if (!IS_ENABLED(CONFIG_64BIT) && lp->features & XAE_FEATURE_DMA_64BIT) {
 		dev_err(&pdev->dev, "64-bit addressable DMA is not compatible with 32-bit archecture\n");
+		ret = -EINVAL;
 		goto cleanup_clk;
 	}
 
Signature · 1 line
2.25.1
#1 lore raw
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Thu, 16 Jun 2022 14:29:17 +0800 you wrote:

It should return error code in error path in axienet_probe().

Fixes 00be43a74ca2 ("net: axienet: make the 64b addresable DMA depends on 64b archectures")
---
 drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 +
 1 file changed, 1 insertion(+)

Here is the summary with links:
- [net] net: axienet: add missing error return code in axienet_probe()

    https://git.kernel.org/netdev/net/c/2e7bf4a6af48

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html