powerpc: platforms: 52xx: Fix refcount leak in media5200.c
Subsystems (2)
PATCH 1/1 powerpc: platforms: 52xx: Fix refcount leak in media5200.c
In media5200_init_irq(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() in fail path or when it is not used anymore.
Don't worry about 'fpga_np==NULL' as of_node_put() can correctly handle it.
Signed-off-by Liang He <[email protected]>
--- arch/powerpc/platforms/52xx/media5200.c | 3 +++ 1 file changed, 3 insertions(+)
arch/powerpc/platforms/52xx/media5200.c +3 -0
@@ -174,6 +174,8 @@ static void __init media5200_init_irq(void) goto out;pr_debug ("%s: allocated irqhost\n" , __func__); +of_node_put (fpga_np); +irq_set_handler_data (cascade_virq, &media5200_irq);irq_set_chained_handler (cascade_virq, media5200_irq_cascade);
@@ -181,6 +183,7 @@ static void __init media5200_init_irq(void) out:pr_err ("Could not find Media5200 FPGA; PCI interrupts will not work\n" ); +of_node_put (fpga_np); }/*
Signature · 1 line
2.25.1
Michael Ellerman
AppliedQuoted 8 lines · Liang He
In
media5200_init_irq(),of_find_compatible_node()will return a node pointer with refcount incremented. We should useof_node_put()in fail path or when it is not used anymore.Don't worry about 'fpga_np==NULL' as
of_node_put()can correctly handle it.[...]
Applied to powerpc/next.
[1/1] powerpc: platforms: 52xx: Fix refcount leak in media5200.c
https://git.kernel.org/powerpc/c/593d7b89c6a2bf7aea2324c94f10ef3c21308418
cheers