powerpc: sysdev: xive: Fix refcount leak in native.c
PATCH 1/1 powerpc: sysdev: xive: Fix refcount leak in native.c
In xive_native_init(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() in each fail path or when it is not used anymore.
Signed-off-by Liang He <[email protected]>
--- arch/powerpc/sysdev/xive/native.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)
arch/powerpc/sysdev/xive/native.c +10 -5
@@ -579,12 +579,12 @@ bool __init xive_native_init(void)/* Resource 1 is HV window */ if (of_address_to_resource (np,1 , &r)) {pr_err ("Failed to get thread mgmnt area resource\n" ); -return false; + goto err_put; } tima =ioremap (r.start,resource_size (&r));if (!tima) {pr_err ("Failed to map thread mgmnt area\n" ); -return false; + goto err_put; }/* Read number of priorities */
@@ -612,7 +612,7 @@ bool __init xive_native_init(void)/* Resource 2 is OS window */ if (of_address_to_resource (np,2 , &r)) {pr_err ("Failed to get thread mgmnt area resource\n" ); -return false; + goto err_put; } xive_tima_os = r.start;
@@ -624,7 +624,7 @@ bool __init xive_native_init(void) rc =opal_xive_reset (OPAL_XIVE_MODE_EXPL );if (rc) {pr_err ("Switch to exploitation mode failed with error %lld\n" , rc); -return false; + goto err_put; }/* Setup some dummy HV pool VPs */
@@ -634,10 +634,15 @@ bool __init xive_native_init(void)if (!xive_core_init (np, &xive_native_ops, tima,TM_QW3_HV_PHYS , max_prio)) {opal_xive_reset (OPAL_XIVE_MODE_EMU ); -return false; + goto err_put; } +of_node_put (np);pr_info ("Using %dkB queues\n" ,1 << (xive_queue_shift -10 ));return true; + +err_put: +of_node_put (np); +return false; }static bool xive_native_provision_pages (void )
Signature · 1 line
2.25.1