Skip to contentSkip to conversation

app/testpmd: external RxQ tests

PATCH Superseded Michael Baum 4 participants 16 messages Mar 1, 2022 – Jun 29, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover app/testpmd: external RxQ tests

Recently [1] mlx5 PMD added support for external queues, in the following patches add internal tests for in in Testpmd application.

[1]
https://patchwork.dpdk.org/project/dpdk/cover/[email protected]/

Michael Baum (2):
app/testpmd: add test for remote PD and CTX
app/testpmd: add test for external RxQ

 app/test-pmd/cmdline.c                      | 172 +++++++++++++++++++-
 app/test-pmd/meson.build                    |   3 +
 app/test-pmd/testpmd.c                      | 153 +++++++++++++++++
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  60 +++++++
 4 files changed, 386 insertions(+), 2 deletions(-)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/2 app/testpmd: add test for remote PD and CTX

Add mlx5 internal option in testpmd run-time function "port attach" to add another parameter named "mlx5_socket" for attaching port and add 2 devargs before.

The arguments are "cmd_fd" and "pd_handle" using to import device created out of PMD. Testpmd application import it using IPC, and updates the devargs list before attaching.

The syntax is:

testpmd > port attach (identifier) mlx5_socket=(path)

Where "path" is the IPC socket path agreed on the remote process.

---
 app/test-pmd/cmdline.c                      |  14 +-
 app/test-pmd/meson.build                    |   3 +
 app/test-pmd/testpmd.c                      | 153 ++++++++++++++++++++
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  40 +++++
 4 files changed, 208 insertions(+), 2 deletions(-)
app/test-pmd/cmdline.c +12 -2
index 7ab0575e64..479e0290c4 100644
@@ -773,6 +773,12 @@ static void cmd_help_long_parsed(void *parsed_result,
 			"port attach (ident)\n"
 			"    Attach physical or virtual dev by pci address or virtual device name\n\n"
 
+#ifdef RTE_NET_MLX5
+			"port attach (ident) mlx5_socket=(path)\n"
+			"    Attach physical or virtual dev by pci address or virtual device name "
+			"and add \"cmd_fd\" and \"pd_handle\" devargs before attaching\n\n"
+#endif
+
 			"port detach (port_id)\n"
 			"    Detach physical or virtual dev by port_id\n\n"
 
@@ -1379,8 +1385,12 @@ cmdline_parse_token_string_t cmd_operate_attach_port_identifier =
 cmdline_parse_inst_t cmd_operate_attach_port = {
 	.f = cmd_operate_attach_port_parsed,
 	.data = NULL,
-	.help_str = "port attach <identifier>: "
-		"(identifier: pci address or virtual dev name)",
+	.help_str = "port attach <identifier> mlx5_socket=<path>: "
+		"(identifier: pci address or virtual dev name"
+#ifdef RTE_NET_MLX5
+		", path (optional): socket path to get cmd FD and PD handle"
+#endif
+		")",
 	.tokens = {
 		(void *)&cmd_operate_attach_port_port,
 		(void *)&cmd_operate_attach_port_keyword,
app/test-pmd/meson.build +3 -0
index 43130c8856..c4fd379e67 100644
@@ -73,3 +73,6 @@ endif
 if dpdk_conf.has('RTE_NET_DPAA')
     deps += ['bus_dpaa', 'mempool_dpaa', 'net_dpaa']
 endif
+if dpdk_conf.has('RTE_NET_MLX5')
+    deps += 'net_mlx5'
+endif
app/test-pmd/testpmd.c +153 -0

176 lines not on this page · raw message

doc/guides/testpmd_app_ug/testpmd_funcs.rst +40 -0
index 1083c6d538..d6490947c4 100644
@@ -2127,6 +2127,46 @@ the mode and slave parameters must be given.
    Done
 
 
+port attach with mlx5 socket path
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+MLX5 internal option to attach a port specified by pci address or virtual device
+args and add extra devargs to it, which is imported from external process::
+
+   testpmd> port attach (identifier) mlx5_socket=(path)
+
+where:
+
+* ``identifier``: pci address or virtual device args.
+* ``path``: socket path to import arguments agreed by the external process.
+
+The mlx5 PMD enables to import CTX and PD created outside the PMD.
+It gets as devargs the device's ``cmd_fd`` and ``pd_handle``,
+then using those arguments to import objects.
+See :ref:`mlx5 driver options <mlx5_common_driver_options>` for more information.
+
+When ``cmd_fd`` and ``pd_handle`` arguments are coming from another process,
+the FD must be dup'd before being passed.
+In this function, testpmd initializes IPC socket to get FD using SCM_RIGHTS.
+It gets the external process socket path, then import the ``cmd_fd`` and
+``pd_handle`` arguments and add them to devargs list.
+After updating this, it calls the regular ``port attach`` function
+with extended idevtifier.
+
+For example, to attach a port whose pci address is ``0000:0a:00.0`` and its
+socket path is ``/var/run/import_ipc_socket``.
+
+.. code-block:: console
+
+   testpmd> port attach 0000:0a:00.0 mlx5_socket=/var/run/import_ipc_socket
+   Attaching a new port...
+   testpmd: MLX5 socket path is /var/run/import_ipc_socket
+   testpmd: Attach port with extra devargs 0000:0a:00.0,cmd_fd=40,pd_handle=1
+   EAL: Probe PCI driver: mlx5_pci (15b3:101d) device: 0000:03:00.0 (socket 0)
+   Port 0 is attached. Now total ports is 1
+   Done
+
+
 port detach
 ~~~~~~~~~~~
 
Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH 1/2] app/testpmd: add test for remote PD and CTX

Quoted 16 lines · Michael Baum

Add mlx5 internal option in testpmd run-time function "port attach" to add another parameter named "mlx5_socket" for attaching port and add 2 devargs before.

The arguments are "cmd_fd" and "pd_handle" using to import device created out of PMD. Testpmd application import it using IPC, and updates the devargs list before attaching.

The syntax is:

testpmd > port attach (identifier) mlx5_socket=(path)

Where "path" is the IPC socket path agreed on the remote process.

<...>

app/test-pmd/meson.build endif · line 78

Quoted 11 lines
app/test-pmd/meson.build +3 -0
index 43130c8856..c4fd379e67 100644
@@ -73,3 +73,6 @@ endif
  if dpdk_conf.has('RTE_NET_DPAA')
      deps += ['bus_dpaa', 'mempool_dpaa', 'net_dpaa']
  endif
+if dpdk_conf.has('RTE_NET_MLX5')
+    deps += 'net_mlx5'
+endif

Is this patch introduce any build time dependency to mlx5 driver? If not this chunk should go to next patch, which uses mlx5 PMD specific API.

<...>

Quoted 38 lines
doc/guides/testpmd_app_ug/testpmd_funcs.rst +30 -0
index 1083c6d538..d6490947c4 100644
@@ -2127,6 +2127,46 @@ the mode and slave parameters must be given.
     Done
 
 
+port attach with mlx5 socket path
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+MLX5 internal option to attach a port specified by pci address or virtual device
+args and add extra devargs to it, which is imported from external process::
+
+   testpmd> port attach (identifier) mlx5_socket=(path)
+
+where:
+
+* ``identifier``: pci address or virtual device args.
+* ``path``: socket path to import arguments agreed by the external process.
+
+The mlx5 PMD enables to import CTX and PD created outside the PMD.
+It gets as devargs the device's ``cmd_fd`` and ``pd_handle``,
+then using those arguments to import objects.
+See :ref:`mlx5 driver options <mlx5_common_driver_options>` for more information.
+
+When ``cmd_fd`` and ``pd_handle`` arguments are coming from another process,
+the FD must be dup'd before being passed.
+In this function, testpmd initializes IPC socket to get FD using SCM_RIGHTS.
+It gets the external process socket path, then import the ``cmd_fd`` and
+``pd_handle`` arguments and add them to devargs list.
+After updating this, it calls the regular ``port attach`` function
+with extended idevtifier.
+
+For example, to attach a port whose pci address is ``0000:0a:00.0`` and its
+socket path is ``/var/run/import_ipc_socket``.
+
+.. code-block:: console

doc/guides/testpmd_app_ug/testpmd_funcs.rst the mode and slave parameters must be given. · line 2169

Quoted 10 lines
doc/guides/testpmd_app_ug/testpmd_funcs.rst +10 -0
+
+   testpmd> port attach 0000:0a:00.0 mlx5_socket=/var/run/import_ipc_socket
+   Attaching a new port...
+   testpmd: MLX5 socket path is /var/run/import_ipc_socket
+   testpmd: Attach port with extra devargs 0000:0a:00.0,cmd_fd=40,pd_handle=1
+   EAL: Probe PCI driver: mlx5_pci (15b3:101d) device: 0000:03:00.0 (socket 0)
+   Port 0 is attached. Now total ports is 1
+   Done
+
+

Hi Michael,

This is too much mlx5 specific addition, and I don't think it is good to extend testpmd with PMD specific code.
If we enable it, sure there will be other vendors willing to do the same, making testpmd even messier.

I don't know what those ``cmd_fd`` and ``pd_handle`` (that read from provided socket), but can they be read from some other script and feed to testpmd, like a python wrapper etc...

#3 lore raw

RE: [PATCH 1/2] app/testpmd: add test for remote PD and CTX

Quoted 20 lines · Ferruh Yigit
Quoted 16 lines · Michael Baum

Add mlx5 internal option in testpmd run-time function "port attach" to add another parameter named "mlx5_socket" for attaching port and add 2 devargs before.

The arguments are "cmd_fd" and "pd_handle" using to import device created out of PMD. Testpmd application import it using IPC, and updates the devargs list before attaching.

The syntax is:

testpmd > port attach (identifier) mlx5_socket=(path)

Where "path" is the IPC socket path agreed on the remote process.

<...>

Quoted 14 lines

app/test-pmd/meson.build endif · line 78

Quoted 11 lines
app/test-pmd/meson.build index renamed from app/test-pmd/meson.build +0 -0

43130c8856..c4fd379e67 100644

app/test-pmd/meson.build +3 -0
@@ -73,3 +73,6 @@ endif
  if dpdk_conf.has('RTE_NET_DPAA')
      deps += ['bus_dpaa', 'mempool_dpaa', 'net_dpaa']
  endif
+if dpdk_conf.has('RTE_NET_MLX5')
+    deps += 'net_mlx5'
+endif

Is this patch introduce any build time dependency to mlx5 driver? If not this chunk should go to next patch, which uses mlx5 PMD specific API.

OK

Quoted 55 lines

<...>

Quoted 38 lines
doc/guides/testpmd_app_ug/testpmd_funcs.rst +29 -0
index 1083c6d538..d6490947c4 100644
@@ -2127,6 +2127,46 @@ the mode and slave parameters must be given.
     Done
 
 
+port attach with mlx5 socket path
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+MLX5 internal option to attach a port specified by pci address or
+virtual device args and add extra devargs to it, which is imported from external process::
+
+   testpmd> port attach (identifier) mlx5_socket=(path)
+
+where:
+
+* ``identifier``: pci address or virtual device args.
+* ``path``: socket path to import arguments agreed by the external process.
+
+The mlx5 PMD enables to import CTX and PD created outside the PMD.
+It gets as devargs the device's ``cmd_fd`` and ``pd_handle``, then
+using those arguments to import objects.
+See :ref:`mlx5 driver options <mlx5_common_driver_options>` for more information.
+
+When ``cmd_fd`` and ``pd_handle`` arguments are coming from another
+process, the FD must be dup'd before being passed.
+In this function, testpmd initializes IPC socket to get FD using SCM_RIGHTS.
+It gets the external process socket path, then import the ``cmd_fd``
+and ``pd_handle`` arguments and add them to devargs list.
+After updating this, it calls the regular ``port attach`` function
+with extended idevtifier.
+
+For example, to attach a port whose pci address is ``0000:0a:00.0``
+and its socket path is ``/var/run/import_ipc_socket``.
+

doc/guides/testpmd_app_ug/testpmd_funcs.rst the mode and slave parameters must be given. · line 2168

Quoted 10 lines
doc/guides/testpmd_app_ug/testpmd_funcs.rst +10 -0
+.. code-block:: console
+
+   testpmd> port attach 0000:0a:00.0 mlx5_socket=/var/run/import_ipc_socket
+   Attaching a new port...
+   testpmd: MLX5 socket path is /var/run/import_ipc_socket
+   testpmd: Attach port with extra devargs 0000:0a:00.0,cmd_fd=40,pd_handle=1
+   EAL: Probe PCI driver: mlx5_pci (15b3:101d) device: 0000:03:00.0 (socket 0)
+   Port 0 is attached. Now total ports is 1
+   Done
+

Hi Michael,

Quoted 4 lines

This is too much mlx5 specific addition, and I don't think it is good to extend testpmd with PMD specific code.
If we enable it, sure there will be other vendors willing to do the same, making testpmd even messier.

Hi Ferruh,

It is mlx5 PMD specific API, which enables to import device from remote process.
This extension is the way to test this API, you can see a lot of PMD specific APIs along testpmd files.

If one day, other vendors want to import devargs from remote process, they will remove the mlx5 build time dependency and use it.

Quoted 4 lines

I don't know what those ``cmd_fd`` and ``pd_handle`` (that read from provided socket), but can they be read from some other script and feed to testpmd, like a python wrapper etc...

#4 lore raw

Re: [PATCH 1/2] app/testpmd: add test for remote PD and CTX

07/03/2022 17:07, Michael Baum:

Quoted 8 lines · Ferruh Yigit
Quoted 6 lines

Hi Michael,

This is too much mlx5 specific addition, and I don't think it is good to extend testpmd with PMD specific code.
If we enable it, sure there will be other vendors willing to do the same, making testpmd even messier.

Quoted 10 lines

Hi Ferruh,

It is mlx5 PMD specific API, which enables to import device from remote process.
This extension is the way to test this API, you can see a lot of PMD specific APIs along testpmd files.

If one day, other vendors want to import devargs from remote process, they will remove the mlx5 build time dependency and use it.

Quoted 3 lines

I don't know what those ``cmd_fd`` and ``pd_handle`` (that read from provided socket), but can they be read from some other script and feed to testpmd, like a python wrapper etc...

I agree with Ferruh that it's a lot of code only for mlx5. Yes we are already calling other PMD-specific API in testpmd but we should try to keep it as small as possible.
I propose to try a rework to make it easier to digest. As a consequence, we won't have this testpmd feature in 22.03, and we can work together for the next release.

#5 lore raw

PATCH 2/2 app/testpmd: add test for external RxQ

In reply to Michael Baum

Add mlx5 internal test for map and unmap external RxQs. This patch adds to Testpmd app a runtime function to test the mapping API.

For insert mapping use this command:

testpmd> port (port_id) ext_rxq map (rte_queue_id) (hw_queue_id)

For insert mapping use this command:

testpmd> port (port_id) ext_rxq unmap (rte_queue_id)

---
 app/test-pmd/cmdline.c                      | 158 ++++++++++++++++++++
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  20 +++
 2 files changed, 178 insertions(+)
app/test-pmd/cmdline.c +158 -0
index 479e0290c4..929680f5cb 100644
@@ -63,6 +63,9 @@
 #ifdef RTE_NET_BNXT
 #include <rte_pmd_bnxt.h>
 #endif
+#ifdef RTE_NET_MLX5
+#include <rte_pmd_mlx5.h>
+#endif
 #include "testpmd.h"
 #include "cmdline_mtr.h"
 #include "cmdline_tm.h"
@@ -917,6 +920,15 @@ static void cmd_help_long_parsed(void *parsed_result,
 
 			"port cleanup (port_id) txq (queue_id) (free_cnt)\n"
 			"    Cleanup txq mbufs for a specific Tx queue\n\n"
+
+#ifdef RTE_NET_MLX5
+			"port (port_id) ext_rxq map (rte_queue_id) (hw_queue_id)\n"
+			"    Map HW queue index (32 bit) to rte_flow queue"
+			" index (16 bit) for external RxQ\n\n"
+
+			"port (port_id) ext_rxq unmap (rte_queue_id)\n"
+			"    Unmap external Rx queue rte_flow index mapping\n\n"
+#endif
 		);
 	}
 
@@ -17817,6 +17829,148 @@ cmdline_parse_inst_t cmd_show_port_flow_transfer_proxy = {
 	}
 };
 
+#ifdef RTE_NET_MLX5
+
+/* Map HW queue index to rte queue index. */
+struct cmd_map_ext_rxq {
+	cmdline_fixed_string_t port;
+	portid_t port_id;
+	cmdline_fixed_string_t ext_rxq;
+	cmdline_fixed_string_t map;
+	uint16_t rte_queue_id;
+	uint32_t hw_queue_id;
+};
+
+cmdline_parse_token_string_t cmd_map_ext_rxq_port =
+	TOKEN_STRING_INITIALIZER(struct cmd_map_ext_rxq, port, "port");
+cmdline_parse_token_num_t cmd_map_ext_rxq_port_id =
+	TOKEN_NUM_INITIALIZER(struct cmd_map_ext_rxq, port_id, RTE_UINT16);
+cmdline_parse_token_string_t cmd_map_ext_rxq_ext_rxq =
+	TOKEN_STRING_INITIALIZER(struct cmd_map_ext_rxq, ext_rxq, "ext_rxq");
+cmdline_parse_token_string_t cmd_map_ext_rxq_map =
+	TOKEN_STRING_INITIALIZER(struct cmd_map_ext_rxq, map, "map");
+cmdline_parse_token_num_t cmd_map_ext_rxq_rte_queue_id =
+	TOKEN_NUM_INITIALIZER(struct cmd_map_ext_rxq, rte_queue_id, RTE_UINT16);
+cmdline_parse_token_num_t cmd_map_ext_rxq_hw_queue_id =
+	TOKEN_NUM_INITIALIZER(struct cmd_map_ext_rxq, hw_queue_id, RTE_UINT32);
+
+static void
+cmd_map_ext_rxq_parsed(void *parsed_result,
+		       __rte_unused struct cmdline *cl,
+		       __rte_unused void *data)
+{
+	struct cmd_map_ext_rxq *res = parsed_result;
+	int ret;
+
+	if (port_id_is_invalid(res->port_id, ENABLED_WARN))
+		return;
+	ret = rte_pmd_mlx5_external_rx_queue_id_map(res->port_id,
+						    res->rte_queue_id,
+						    res->hw_queue_id);
+	switch (ret) {
+	case 0:
+		break;
+	case -EINVAL:
+		fprintf(stderr, "invalid rte_flow index (%u), out of range\n",
+			res->rte_queue_id);
+		break;
+	case -ENODEV:
+		fprintf(stderr, "invalid port_id %u\n", res->port_id);
+		break;
+	case -ENOTSUP:
+		fprintf(stderr, "function not implemented or supported\n");
+		break;
+	case -EEXIST:
+		fprintf(stderr, "mapping with index %u already exists\n",
+			res->rte_queue_id);
+		break;
+	default:
+		fprintf(stderr, "programming error: (%s)\n", strerror(-ret));
+	}
+}
+
+cmdline_parse_inst_t cmd_map_ext_rxq = {
+	.f = cmd_map_ext_rxq_parsed,
+	.data = NULL,
+	.help_str = "port <port_id> ext_rxq map <rte_queue_id> <hw_queue_id>",
+	.tokens = {
+		(void *)&cmd_map_ext_rxq_port,
+		(void *)&cmd_map_ext_rxq_port_id,
+		(void *)&cmd_map_ext_rxq_ext_rxq,
+		(void *)&cmd_map_ext_rxq_map,
+		(void *)&cmd_map_ext_rxq_rte_queue_id,
+		(void *)&cmd_map_ext_rxq_hw_queue_id,
+		NULL,
+	}
+};
+
+/* Unmap HW queue index to rte queue index. */
+struct cmd_unmap_ext_rxq {
+	cmdline_fixed_string_t port;
+	portid_t port_id;
+	cmdline_fixed_string_t ext_rxq;
+	cmdline_fixed_string_t unmap;
+	uint16_t queue_id;
+};
+
+cmdline_parse_token_string_t cmd_unmap_ext_rxq_port =
+	TOKEN_STRING_INITIALIZER(struct cmd_unmap_ext_rxq, port, "port");
+cmdline_parse_token_num_t cmd_unmap_ext_rxq_port_id =
+	TOKEN_NUM_INITIALIZER(struct cmd_unmap_ext_rxq, port_id, RTE_UINT16);
+cmdline_parse_token_string_t cmd_unmap_ext_rxq_ext_rxq =
+	TOKEN_STRING_INITIALIZER(struct cmd_unmap_ext_rxq, ext_rxq, "ext_rxq");
+cmdline_parse_token_string_t cmd_unmap_ext_rxq_unmap =
+	TOKEN_STRING_INITIALIZER(struct cmd_unmap_ext_rxq, unmap, "unmap");
+cmdline_parse_token_num_t cmd_unmap_ext_rxq_queue_id =
+	TOKEN_NUM_INITIALIZER(struct cmd_unmap_ext_rxq, queue_id, RTE_UINT16);
+
+static void
+cmd_unmap_ext_rxq_parsed(void *parsed_result,
+			 __rte_unused struct cmdline *cl,
+			 __rte_unused void *data)
+{
+	struct cmd_unmap_ext_rxq *res = parsed_result;
+	int ret;
+
+	if (port_id_is_invalid(res->port_id, ENABLED_WARN))
+		return;
+	ret = rte_pmd_mlx5_external_rx_queue_id_unmap(res->port_id,
+						      res->queue_id);
+	switch (ret) {
+	case 0:
+		break;
+	case -EINVAL:
+		fprintf(stderr, "invalid rte_flow index (%u), "
+			"out of range, doesn't exist or still referenced\n",
+			res->queue_id);
+		break;
+	case -ENODEV:
+		fprintf(stderr, "invalid port_id %u\n", res->port_id);
+		break;
+	case -ENOTSUP:
+		fprintf(stderr, "function not implemented or supported\n");
+		break;
+	default:
+		fprintf(stderr, "programming error: (%s)\n", strerror(-ret));
+	}
+}
+
+cmdline_parse_inst_t cmd_unmap_ext_rxq = {
+	.f = cmd_unmap_ext_rxq_parsed,
+	.data = NULL,
+	.help_str = "port <port_id> ext_rxq unmap <queue_id>",
+	.tokens = {
+		(void *)&cmd_unmap_ext_rxq_port,
+		(void *)&cmd_unmap_ext_rxq_port_id,
+		(void *)&cmd_unmap_ext_rxq_ext_rxq,
+		(void *)&cmd_unmap_ext_rxq_unmap,
+		(void *)&cmd_unmap_ext_rxq_queue_id,
+		NULL,
+	}
+};
+
+#endif /* RTE_NET_MLX5 */
+
 /* ******************************************************************************** */
 
 /* list of instructions */
@@ -18103,6 +18257,10 @@ cmdline_parse_ctx_t main_ctx[] = {
 	(cmdline_parse_inst_t *)&cmd_show_capability,
 	(cmdline_parse_inst_t *)&cmd_set_flex_is_pattern,
 	(cmdline_parse_inst_t *)&cmd_set_flex_spec_pattern,
+#ifdef RTE_NET_MLX5
+	(cmdline_parse_inst_t *)&cmd_map_ext_rxq,
+	(cmdline_parse_inst_t *)&cmd_unmap_ext_rxq,
+#endif
 	NULL,
 };
 
doc/guides/testpmd_app_ug/testpmd_funcs.rst +20 -0
index d6490947c4..de5665c886 100644
@@ -2502,6 +2502,26 @@ To cleanup txq mbufs currently cached by driver::
 
 If the value of ``free_cnt`` is 0, driver should free all cached mbufs.
 
+
+port map external RxQ
+~~~~~~~~~~~~~~~~~~~~~
+
+MLX5 internal API for external RxQ mapping management.
+
+Map HW queue index (32 bit) to rte_flow queue index (16 bit) for external RxQ::
+
+   testpmd> port (port_id) ext_rxq map (rte_queue_id) (hw_queue_id)
+
+Unmap external Rx queue rte_flow index mapping::
+
+   testpmd> port (port_id) ext_rxq unmap (rte_queue_id)
+
+where:
+
+* ``rte_queue_id``: queue index in reage [64536, 65535].
+* ``hw_queue_id``: queue index given by HW in queue creation.
+
+
 Device Functions
 ----------------
 
Signature · 1 line
2.25.1
#6 lore raw

Re: [PATCH 2/2] app/testpmd: add test for external RxQ

Quoted 15 lines · Michael Baum
doc/guides/testpmd_app_ug/testpmd_funcs.rst +7 -0
index d6490947c4..de5665c886 100644
@@ -2502,6 +2502,26 @@ To cleanup txq mbufs currently cached by driver::
 
  If the value of ``free_cnt`` is 0, driver should free all cached mbufs.
 
+
+port map external RxQ
+~~~~~~~~~~~~~~~~~~~~~
+
+MLX5 internal API for external RxQ mapping management.
+
+Map HW queue index (32 bit) to rte_flow queue index (16 bit) for external RxQ::

doc/guides/testpmd_app_ug/testpmd_funcs.rst To cleanup txq mbufs currently cached by driver:: · line 2521

Quoted 10 lines
doc/guides/testpmd_app_ug/testpmd_funcs.rst +10 -0
+
+   testpmd> port (port_id) ext_rxq map (rte_queue_id) (hw_queue_id)
+
+Unmap external Rx queue rte_flow index mapping::
+
+   testpmd> port (port_id) ext_rxq unmap (rte_queue_id)
+
+where:
+
+* ``rte_queue_id``: queue index in reage [64536, 65535].

s/reage/range/ ?

And range looks odd, is [64536, 65535] correct? If so does it deserve additional clarification?

Quoted 5 lines
doc/guides/testpmd_app_ug/testpmd_funcs.rst +3 -0
+* ``hw_queue_id``: queue index given by HW in queue creation.
+
+
  Device Functions
  ----------------
#7 lore raw

RE: [PATCH 2/2] app/testpmd: add test for external RxQ

Quoted 19 lines · Ferruh Yigit

doc/guides/testpmd_app_ug/testpmd_funcs.rst To cleanup txq mbufs currently cached by

Quoted 6 lines · Michael Baum
doc/guides/testpmd_app_ug/testpmd_funcs.rst +0 -0
index d6490947c4..de5665c886 100644
@@ -2502,6 +2502,26 @@ To cleanup txq mbufs currently cached by

driver::

doc/guides/testpmd_app_ug/testpmd_funcs.rst To cleanup txq mbufs currently cached by driver::

Quoted 10 lines
doc/guides/testpmd_app_ug/testpmd_funcs.rst +7 -0
  If the value of ``free_cnt`` is 0, driver should free all cached mbufs.
 
+
+port map external RxQ
+~~~~~~~~~~~~~~~~~~~~~
+
+MLX5 internal API for external RxQ mapping management.
+
+Map HW queue index (32 bit) to rte_flow queue index (16 bit) for

external RxQ::

Quoted 12 lines

doc/guides/testpmd_app_ug/testpmd_funcs.rst To cleanup txq mbufs currently cached by driver:: · line 2521

Quoted 10 lines
doc/guides/testpmd_app_ug/testpmd_funcs.rst +10 -0
+
+   testpmd> port (port_id) ext_rxq map (rte_queue_id) (hw_queue_id)
+
+Unmap external Rx queue rte_flow index mapping::
+
+   testpmd> port (port_id) ext_rxq unmap (rte_queue_id)
+
+where:
+
+* ``rte_queue_id``: queue index in reage [64536, 65535].

s/reage/range/ ?

Yes you right, It should have been "range". Thank you for This correction.

Quoted 2 lines

And range looks odd, is [64536, 65535] correct? If so does it deserve additional clarification?

It is correct, it the highest 1000 numbers in 16 bits. [64536, 65535] is [UINT16_MAX - 1000 +1, UINT16_MAX]. I'll add more explanation.

Quoted 5 lines
Quoted 5 lines
doc/guides/testpmd_app_ug/testpmd_funcs.rst +3 -0
+* ``hw_queue_id``: queue index given by HW in queue creation.
+
+
  Device Functions
  ----------------
#8 lore raw

v2 cover mlx5/testpmd: external RxQ tests

In reply to Michael Baum

Recently [1] mlx5 PMD added support for external queues, in the following patches add internal tests for in Testpmd application.

[1]
https://patchwork.dpdk.org/project/dpdk/cover/[email protected]/

Depends-on: series=112853 ("introduce per-queue available descriptor threshold and host shaper")

v1: Initial commit.
v2: Fix typos in documentation.
Move mlx5 specific tests to mlx5 library. Change socket style SOCK_DGRAM -> SOCK_SEQPACKET.

Michael Baum (2):
app/testpmd: add test for remote PD and CTX
app/testpmd: add test for external RxQ

 app/test-pmd/cmdline.c          |  14 +-
 app/test-pmd/testpmd.c          |   5 +
 doc/guides/nics/mlx5.rst        |  63 +++++++
 drivers/net/mlx5/mlx5_testpmd.c | 298 +++++++++++++++++++++++++++++++-
 drivers/net/mlx5/mlx5_testpmd.h |  16 ++
 5 files changed, 392 insertions(+), 4 deletions(-)
Signature · 1 line
2.25.1
#9 lore raw

PATCH v2 1/2 app/testpmd: add test for remote PD and CTX

Add mlx5 internal option in testpmd run-time function "port attach" to add another parameter named "mlx5_socket" for attaching port and add 2 devargs before.

The arguments are "cmd_fd" and "pd_handle" using to import device created out of PMD. Testpmd application import it using IPC, and updates the devargs list before attaching.

The syntax is:

testpmd > port attach (identifier) mlx5_socket=(path)

Where "path" is the IPC socket path agreed on the remote process.

---
 app/test-pmd/cmdline.c          |  14 ++-
 app/test-pmd/testpmd.c          |   5 ++
 doc/guides/nics/mlx5.rst        |  44 ++++++++++
 drivers/net/mlx5/mlx5_testpmd.c | 145 ++++++++++++++++++++++++++++++++
 drivers/net/mlx5/mlx5_testpmd.h |  16 ++++
 5 files changed, 222 insertions(+), 2 deletions(-)
app/test-pmd/cmdline.c +12 -2
index a59e6166d5..869ecd3d2a 100644
@@ -780,6 +780,12 @@ static void cmd_help_long_parsed(void *parsed_result,
 			"port attach (ident)\n"
 			"    Attach physical or virtual dev by pci address or virtual device name\n\n"
 
+#ifdef RTE_NET_MLX5
+			"port attach (ident) mlx5_socket=(path)\n"
+			"    Attach physical or virtual dev by pci address or virtual device name "
+			"and add \"cmd_fd\" and \"pd_handle\" devargs before attaching\n\n"
+#endif
+
 			"port detach (port_id)\n"
 			"    Detach physical or virtual dev by port_id\n\n"
 
@@ -1401,8 +1407,12 @@ static cmdline_parse_token_string_t cmd_operate_attach_port_identifier =
 static cmdline_parse_inst_t cmd_operate_attach_port = {
 	.f = cmd_operate_attach_port_parsed,
 	.data = NULL,
-	.help_str = "port attach <identifier>: "
-		"(identifier: pci address or virtual dev name)",
+	.help_str = "port attach <identifier> mlx5_socket=<path>: "
+		"(identifier: pci address or virtual dev name"
+#ifdef RTE_NET_MLX5
+		", path (optional): socket path to get cmd FD and PD handle"
+#endif
+		")",
 	.tokens = {
 		(void *)&cmd_operate_attach_port_port,
 		(void *)&cmd_operate_attach_port_keyword,
app/test-pmd/testpmd.c +5 -0
index e6321bdedb..d2df6732a0 100644
@@ -3360,6 +3360,11 @@ attach_port(char *identifier)
 		return;
 	}
 
+#if defined(RTE_NET_MLX5) && !defined(RTE_EXEC_ENV_WINDOWS)
+	if (mlx5_test_attach_port_extend_devargs(identifier) < 0)
+		return;
+#endif
+
 	if (rte_dev_probe(identifier) < 0) {
 		TESTPMD_LOG(ERR, "Failed to attach port %s\n", identifier);
 		return;
doc/guides/nics/mlx5.rst +44 -0

47 lines not on this page · raw message

drivers/net/mlx5/mlx5_testpmd.c +145 -0

163 lines not on this page · raw message

drivers/net/mlx5/mlx5_testpmd.h +16 -0
index 7a54658eb5..06976341a4 100644
@@ -23,4 +23,20 @@
 void
 mlx5_test_avail_thresh_event_handler(uint16_t port_id, uint16_t rxq_id);
 
+/**
+ * Extend devargs list with "cmd_fd" and "pd_handle" coming from external
+ * process. It happens only in this format:
+ *  testpmd> port attach (identifier) mlx5_socket=<socket path>
+ * all "(identifier) mlx5_socket=<socket path>" is in the same string pointed
+ * by the input parameter 'identifier'.
+ *
+ * @param identifier
+ *   Identifier of port attach command line.
+ *
+ * @return
+ *   0 on success, -1 on failure.
+ */
+int
+mlx5_test_attach_port_extend_devargs(char *identifier);
+
 #endif
Signature · 1 line
2.25.1
#10 lore raw

PATCH v2 2/2 app/testpmd: add test for external RxQ

In reply to Michael Baum

Add mlx5 internal test for map and unmap external RxQs. This patch adds to Testpmd app a runtime function to test the mapping API.

For insert mapping use this command:

testpmd> port (port_id) ext_rxq map (rte_queue_id) (hw_queue_id)

For insert mapping use this command:

testpmd> port (port_id) ext_rxq unmap (rte_queue_id)

---
 doc/guides/nics/mlx5.rst        |  19 ++++
 drivers/net/mlx5/mlx5_testpmd.c | 153 +++++++++++++++++++++++++++++++-
 2 files changed, 170 insertions(+), 2 deletions(-)
doc/guides/nics/mlx5.rst +19 -0
index 392292cc95..9007bfcac9 100644
@@ -1821,3 +1821,22 @@ socket path is ``/var/run/import_ipc_socket``.
    Port 0 is attached. Now total ports is 1
    Done
 
+
+port map external RxQ
+~~~~~~~~~~~~~~~~~~~~~
+
+API for external RxQ mapping management.
+
+Map HW queue index (32 bit) to rte_flow queue index (16 bit) for external RxQ::
+
+   testpmd> port (port_id) ext_rxq map (rte_queue_id) (hw_queue_id)
+
+Unmap external Rx queue rte_flow index mapping::
+
+   testpmd> port (port_id) ext_rxq unmap (rte_queue_id)
+
+where:
+
+* ``rte_queue_id``: queue index in range [64536, 65535].
+  This range is the highest 1000 numbers represented by 16 bits.
+* ``hw_queue_id``: queue index given by HW in queue creation.
drivers/net/mlx5/mlx5_testpmd.c +151 -2

164 lines not on this page · raw message

Signature · 1 line
2.25.1
#11 lore raw

RE: [PATCH v2 0/2] mlx5/testpmd: external RxQ tests

In reply to Michael Baum

Hi,

Quoted 36 lines

-----Original Message-----
From: Michael Baum <[email protected]>
Sent: Thursday, June 16, 2022 8:10 PM
To: [email protected]
Cc: Matan Azrad <[email protected]>; Raslan Darawsheh <[email protected]>; Slava Ovsiienko <[email protected]>
Subject: [PATCH v2 0/2] mlx5/testpmd: external RxQ tests

Recently [1] mlx5 PMD added support for external queues, in the following patches add internal tests for in Testpmd application.

[1]
https://patchwork.dpdk.org/project/dpdk/cover/20220224232511.3238707-
[email protected]/

Depends-on: series=112853 ("introduce per-queue available descriptor threshold and host shaper")

v1: Initial commit.
v2: Fix typos in documentation.
Move mlx5 specific tests to mlx5 library. Change socket style SOCK_DGRAM -> SOCK_SEQPACKET.

Michael Baum (2):
app/testpmd: add test for remote PD and CTX
app/testpmd: add test for external RxQ

 app/test-pmd/cmdline.c          |  14 +-
 app/test-pmd/testpmd.c          |   5 +
 doc/guides/nics/mlx5.rst        |  63 +++++++
 drivers/net/mlx5/mlx5_testpmd.c | 298
+++++++++++++++++++++++++++++++-  drivers/net/mlx5/mlx5_testpmd.h
|  16 ++
 5 files changed, 392 insertions(+), 4 deletions(-)
Quoted 2 lines

--
2.25.1

Series applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

#12 lore raw

v3 cover net/mlx5: external RxQ tests

In reply to Michael Baum

Recently [1] mlx5 PMD added support for external queues, in the following patches add internal tests for in Testpmd application.

[1]
https://patchwork.dpdk.org/project/dpdk/cover/[email protected]/

v1: Initial commit.
v2: Fix typos in documentation.
Move mlx5 specific tests to mlx5 library. Change socket style SOCK_DGRAM -> SOCK_SEQPACKET.
v3: Move all these tests to mlx5 library.
Add mlx5 prefix to mlx5 specific tests. Improve documentation.

Michael Baum (2):
net/mlx5: add test for remote PD and CTX
net/mlx5: add test for external Rx queue

 doc/guides/nics/mlx5.rst                    |  66 ++++
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |   2 +
 drivers/net/mlx5/mlx5_testpmd.c             | 383 ++++++++++++++++++++
 3 files changed, 451 insertions(+)
Signature · 1 line
2.25.1
#13 lore raw

PATCH v3 1/2 net/mlx5: add test for remote PD and CTX

Add mlx5 internal option in testpmd similar to run-time function "port attach" which adds another parameter named "socket" for attaching port and add 2 devargs before.

The arguments are "cmd_fd" and "pd_handle" using to import device created out of PMD. Testpmd application import it using IPC, and updates the devargs list before attaching.

These arguments was added in this commit [1].

The syntax is:

testpmd > mlx5 port attach (identifier) socket=(path)

Where "path" is the IPC socket path agreed on the remote process.

[1]
http://patches.dpdk.org/project/dpdk/patch/[email protected]/

---
 doc/guides/nics/mlx5.rst                    |  47 +++++
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |   2 +
 drivers/net/mlx5/mlx5_testpmd.c             | 220 ++++++++++++++++++++
 3 files changed, 269 insertions(+)
doc/guides/nics/mlx5.rst +47 -0
index bc2bd2c8a6..cd3a613640 100644
@@ -1793,3 +1793,50 @@ and disables ``avail_thresh_triggered``.
 .. code-block:: console
 
    testpmd> mlx5 set port 1 host_shaper avail_thresh_triggered 0 rate 50
+
+
+Testpmd
+-------
+
+port attach with socket path
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+It is possible to allocate a port with ``libibverbs`` from external application.
+For importing the external port with extra device arguments,
+there is a specific testpmd command
+similar to :ref:`port attach command <port_attach>`::
+
+   testpmd> mlx5 port attach (identifier) socket=(path)
+
+where:
+
+* ``identifier``: device identifier with optional parameters
+  as same as :ref:`port attach command <port_attach>`.
+* ``path``: path to IPC server socket created by the external application.
+
+This command performs:
+
+#. Open IPC client socket using the given path, and connect it.
+
+#. Import ibverbs context and ibverbs protection domain.
+
+#. Add two device arguments for context (``cmd_fd``)
+   and protection domain (``pd_handle``) to the device identifier.
+   See :ref:`mlx5 driver options <mlx5_common_driver_options>` for more
+   information about these device arguments.
+
+#. Call the regular ``port attach`` function with updated identifier.
+
+For example, to attach a port whose PCI address is ``0000:0a:00.0``
+and its socket path is ``/var/run/import_ipc_socket``:
+
+.. code-block:: console
+
+   testpmd> mlx5 port attach 0000:0a:00.0 socket=/var/run/import_ipc_socket
+   testpmd: MLX5 socket path is /var/run/import_ipc_socket
+   testpmd: Attach port with extra devargs 0000:0a:00.0,cmd_fd=40,pd_handle=1
+   Attaching a new port...
+   EAL: Probe PCI driver: mlx5_pci (15b3:101d) device: 0000:0a:00.0 (socket 0)
+   Port 0 is attached. Now total ports is 1
+   Done
+
doc/guides/testpmd_app_ug/testpmd_funcs.rst +2 -0
index f716ea2797..c0965cd3b9 100644
@@ -1882,6 +1882,8 @@ The following sections show functions for configuring ports.
 
    Port configuration changes only become active when forwarding is started/restarted.
 
+.. _port_attach:
+
 port attach
 ~~~~~~~~~~~
 
drivers/net/mlx5/mlx5_testpmd.c +220 -0

250 lines not on this page · raw message

Signature · 1 line
2.25.1
#14 lore raw

PATCH v3 2/2 net/mlx5: add test for external Rx queue

In reply to Michael Baum

Add mlx5 internal test for map and unmap external RxQs. This patch adds to Testpmd app a runtime function to test the mapping API.

For insert mapping use this command:

testpmd> mlx5 port (port_id) ext_rxq map (sw_queue_id) (hw_queue_id)

For insert mapping use this command:

testpmd> mlx5 port (port_id) ext_rxq unmap (sw_queue_id)

---
 doc/guides/nics/mlx5.rst        |  19 ++++
 drivers/net/mlx5/mlx5_testpmd.c | 163 ++++++++++++++++++++++++++++++++
 2 files changed, 182 insertions(+)
doc/guides/nics/mlx5.rst +19 -0
index cd3a613640..9f2832e284 100644
@@ -1840,3 +1840,22 @@ and its socket path is ``/var/run/import_ipc_socket``:
    Port 0 is attached. Now total ports is 1
    Done
 
+
+port map external Rx queue
+~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+External Rx queue indexes mapping management.
+
+Map HW queue index (32-bit) to ethdev queue index (16-bit) for external Rx queue::
+
+   testpmd> mlx5 port (port_id) ext_rxq map (sw_queue_id) (hw_queue_id)
+
+Unmap external Rx queue::
+
+   testpmd> mlx5 port (port_id) ext_rxq unmap (sw_queue_id)
+
+where:
+
+* ``sw_queue_id``: queue index in range [64536, 65535].
+  This range is the highest 1000 numbers.
+* ``hw_queue_id``: queue index given by HW in queue creation.
drivers/net/mlx5/mlx5_testpmd.c +163 -0

175 lines not on this page · raw message

Signature · 1 line
2.25.1
#15 lore raw

RE: [PATCH v3 0/2] net/mlx5: external RxQ tests

In reply to Michael Baum

Hi,

Quoted 27 lines

-----Original Message-----
From: Michael Baum <[email protected]>
Sent: Tuesday, June 28, 2022 5:59 PM
To: [email protected]
Cc: Matan Azrad <[email protected]>; Raslan Darawsheh <[email protected]>; Slava Ovsiienko <[email protected]>
Subject: [PATCH v3 0/2] net/mlx5: external RxQ tests

Recently [1] mlx5 PMD added support for external queues, in the following patches add internal tests for in Testpmd application.

[1]
https://patchwork.dpdk.org/project/dpdk/cover/20220224232511.3238707-
[email protected]/

v1: Initial commit.
v2: Fix typos in documentation.
Move mlx5 specific tests to mlx5 library. Change socket style SOCK_DGRAM -> SOCK_SEQPACKET.
v3: Move all these tests to mlx5 library.
Add mlx5 prefix to mlx5 specific tests. Improve documentation.

Michael Baum (2):
net/mlx5: add test for remote PD and CTX
net/mlx5: add test for external Rx queue

Quoted 7 lines
 doc/guides/nics/mlx5.rst                    |  66 ++++
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |   2 +
 drivers/net/mlx5/mlx5_testpmd.c             | 383 ++++++++++++++++++++
 3 files changed, 451 insertions(+)

--
2.25.1

Replaced old series with this version:
Series applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh