Skip to contentSkip to conversation

selftests/powerpc: Fix matrix multiply assist test

PATCH Applied Rashmica Gupta 2 participants 2 messages Jun 17, 2022 – Jul 29, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/powerpc: Fix matrix multiply assist test

The ISA states: "when ACC[i] contains defined data, the contents of VSRs 4×i to 4×i+3 are undefined until either a VSX Move From ACC instruction is used to copy the contents of ACC[i] to VSRs 4×i to 4×i+3 or some other instruction directly writes to one of these VSRs." We aren't doing this.

This test only works on Power10 because the hardware implementation happens to map ACC0 to VSRs 0-3, but will fail on any other implementation that doesn't do this. So add xxmfacc between writing to the accumulator and accessing the VSRs.

Fixes commit 3527e1ab9a79 ("selftests/powerpc: Add matrix multiply assist (MMA) test")

---
 tools/testing/selftests/powerpc/math/mma.S | 3 +++
 1 file changed, 3 insertions(+)
tools/testing/selftests/powerpc/math/mma.S +3 -0
index 8528c9849565..61cc88b1b26b 100644
@@ -20,6 +20,9 @@ test_mma:
 	/* xvi16ger2s */
 	.long	0xec042958
 
+	/* Deprime the accumulator - xxmfacc 0 */
+	.long 0x7c000162
+
 	/* Store result in image passed in r5 */
 	stxvw4x	0,0,5
 	addi	5,5,16
Signature · 1 line
2.35.3
#1 lore raw
Quoted 11 lines · Rashmica Gupta

The ISA states: "when ACC[i] contains defined data, the contents of VSRs 4×i to 4×i+3 are undefined until either a VSX Move From ACC instruction is used to copy the contents of ACC[i] to VSRs 4×i to 4×i+3 or some other instruction directly writes to one of these VSRs." We aren't doing this.

This test only works on Power10 because the hardware implementation happens to map ACC0 to VSRs 0-3, but will fail on any other implementation that doesn't do this. So add xxmfacc between writing to the accumulator and accessing the VSRs.

[...]

Applied to powerpc/next.

[1/1] selftests/powerpc: Fix matrix multiply assist test

      https://git.kernel.org/powerpc/c/cd1e64935f79e31d666172c52c951ca97152b783

cheers