drm/meson: add support for MIPI DSI Display
Subsystems (5)
v3 cover drm/meson: add support for MIPI DSI Display
The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI glue on the same Amlogic SoCs.
This adds support for the glue managing the transceiver, mimicing the init flow provided by Amlogic to setup the ENCL encoder, the glue, the transceiver, the digital D-PHY and the Analog PHY in the proper way.
The DW-MIPI-DSI transceiver + D-PHY are clocked by the GP0 PLL, and the ENCL encoder + VIU pixel reader by the VCLK2 clock using the HDMI PLL.
The DW-MIPI-DSI transceiver gets this pixel stream as input clocked with the VCLK2 clock.
An optional "MEAS" clock can be enabled to measure the delay between each vsync feeding the DW-MIPI-DSI transceiver.
This patchset is based on an earlier attempt at [1] for the AXG SoCs, but:
- the AXG has a single clock source for both transceiver + pixel, which makes it an exception instead of a rule, it's simpler to add support for G12A then add AXG on it
- previous glue code was a single monolitic code mixing encoders & bridges, this version is aligned on the previous cleanup done on HDMI & CVBS bridges architecture at [2]
- since the only output of AXG is DSI, AXG VPU support is post-poned until we implement single-clock DSI support specific case on top of this.
Changes from v2 at [4]:
- Fixed patch 3
- Added reviews from Jagan
- Rebased on v5.19-rc1
Changes from v1 at [3]:
- fixed DSI host bindings
- add reviewed-by tags for bindings
- moved magic values to defines thanks to Martin's searches
- added proper prefixes to defines
- moved phy_configure to phy_init() dw-mipi-dsi callback
- moved phy_on to a new phy_power_on() dw-mipi-dsi callback
- correctly return phy_init/configure errors to callback returns
[1] https://lore.kernel.org/r/[email protected]
[2] https://lore.kernel.org/r/[email protected]
[3] https://lore.kernel.org/r/[email protected]
[4] https://lore.kernel.org/r/[email protected]
Neil Armstrong (6):
dt-bindings: display: add Amlogic MIPI DSI Host Controller bindings
dt-bindings: display: meson-vpu: add third DPI output port drm/meson: venc: add ENCL encoder setup for MIPI-DSI output drm/meson: vclk: add DSI clock config
drm/meson: add DSI encoder
drm/meson: add support for MIPI-DSI transceiver
.../display/amlogic,meson-dw-mipi-dsi.yaml | 116 ++++++ .../bindings/display/amlogic,meson-vpu.yaml | 5 + drivers/gpu/drm/meson/Kconfig | 7 + drivers/gpu/drm/meson/Makefile | 3 +- drivers/gpu/drm/meson/meson_drv.c | 7 + drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 358 ++++++++++++++++++ drivers/gpu/drm/meson/meson_dw_mipi_dsi.h | 160 ++++++++ drivers/gpu/drm/meson/meson_encoder_dsi.c | 160 ++++++++ drivers/gpu/drm/meson/meson_encoder_dsi.h | 12 + drivers/gpu/drm/meson/meson_registers.h | 25 ++ drivers/gpu/drm/meson/meson_vclk.c | 47 +++ drivers/gpu/drm/meson/meson_vclk.h | 1 + drivers/gpu/drm/meson/meson_venc.c | 211 ++++++++++- drivers/gpu/drm/meson/meson_venc.h | 6 + drivers/gpu/drm/meson/meson_vpp.h | 2 + 15 files changed, 1117 insertions(+), 3 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/amlogic,meson-dw-mipi-dsi.yaml create mode 100644 drivers/gpu/drm/meson/meson_dw_mipi_dsi.c create mode 100644 drivers/gpu/drm/meson/meson_dw_mipi_dsi.h create mode 100644 drivers/gpu/drm/meson/meson_encoder_dsi.c create mode 100644 drivers/gpu/drm/meson/meson_encoder_dsi.h
Signature · 1 line
2.25.1
PATCH v3 1/6 dt-bindings: display: add Amlogic MIPI DSI Host Controller bindings
The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI Glue on the same Amlogic SoCs.
--- .../display/amlogic,meson-dw-mipi-dsi.yaml | 116 ++++++++++++++++++ 1 file changed, 116 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/amlogic,meson-dw-mipi-dsi.yaml
Documentation/devicetree/bindings/display/amlogic,meson-dw-mipi-dsi.yaml new file +116 -0
@@ -0,0 +1,116 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2020 BayLibre, SAS +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/display/amlogic,meson-dw-mipi-dsi.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Amlogic specific extensions to the Synopsys Designware MIPI DSI Host Controller + +maintainers: + - Neil Armstrong <[email protected]> + +description: | + The Amlogic Meson Synopsys Designware Integration is composed of + - A Synopsys DesignWare MIPI DSI Host Controller IP + - A TOP control block controlling the Clocks & Resets of the IP + +allOf: + - $ref: dsi-controller.yaml# + +properties: + compatible: + enum: + - amlogic,meson-g12a-dw-mipi-dsi + + reg: + maxItems: 1 + + clocks: + minItems: 2 + + clock-names: + minItems: 2 + items: + - const: pclk + - const: px_clk + - const: meas_clk + + resets: + minItems: 1 + + reset-names: + items: + - const: top + + phys: + minItems: 1 + + phy-names: + items: + - const: dphy + + ports: + $ref: /schemas/graph.yaml#/properties/ports + + properties: + port@0: + $ref: /schemas/graph.yaml#/properties/port + description: Input node to receive pixel data. + + port@1: + $ref: /schemas/graph.yaml#/properties/port + description: DSI output node to panel. + + required: + - port@0 + - port@1 + +required: + - compatible + - reg + - clocks + - clock-names + - resets + - reset-names + - phys + - phy-names + - ports + +unevaluatedProperties: false + +examples: + - | + dsi@7000 { + compatible = "amlogic,meson-g12a-dw-mipi-dsi"; + reg = <0x6000 0x400>; + resets = <&reset_top>; + reset-names = "top"; + clocks = <&clk_pclk>, <&clk_px>; + clock-names = "pclk", "px_clk"; + phys = <&mipi_dphy>; + phy-names = "dphy"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + /* VPU VENC Input */ + mipi_dsi_venc_port: port@0 { + reg = <0>; + + mipi_dsi_in: endpoint { + remote-endpoint = <&dpi_out>; + }; + }; + + /* DSI Output */ + mipi_dsi_panel_port: port@1 { + reg = <1>; + + mipi_out_panel: endpoint { + remote-endpoint = <&mipi_in_panel>; + }; + }; + }; + };
Signature · 1 line
2.25.1
PATCH v3 2/6 dt-bindings: display: meson-vpu: add third DPI output port
In reply to Neil ArmstrongAdd third port corresponding to the ENCL DPI encoder used to connect to DSI or LVDS transceivers.
--- .../devicetree/bindings/display/amlogic,meson-vpu.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml +5 -0
@@ -96,6 +96,11 @@ properties: description: A port node pointing to the HDMI-TX port node. + port@2: + $ref: /schemas/graph.yaml#/properties/port + description: + A port node pointing to the DPI port node (e.g. DSI or LVDS transceiver). + "#address-cells": const: 1
Signature · 1 line
2.25.1
PATCH v3 3/6 drm/meson: venc: add ENCL encoder setup for MIPI-DSI output
In reply to Neil ArmstrongThis adds supports for the ENCL encoder connected to a MIPI-DSI transceiver on the Amlogic AXG, G12A, G12B & SM1 SoCs.
--- drivers/gpu/drm/meson/meson_registers.h | 25 +++ drivers/gpu/drm/meson/meson_venc.c | 211 +++++++++++++++++++++++- drivers/gpu/drm/meson/meson_venc.h | 6 + drivers/gpu/drm/meson/meson_vpp.h | 2 + 4 files changed, 242 insertions(+), 2 deletions(-)
drivers/gpu/drm/meson/meson_registers.h +25 -0
@@ -812,6 +812,7 @@#define VENC_STATA 0x1b6d#define VENC_INTCTRL 0x1b6e#define VENC_INTCTRL_ENCI_LNRST_INT_EN BIT(1) +#define VENC_INTCTRL_ENCP_LNRST_INT_EN BIT(9)#define VENC_INTFLAG 0x1b6f#define VENC_VIDEO_TST_EN 0x1b70#define VENC_VIDEO_TST_MDSEL 0x1b71
@@ -1192,7 +1193,11 @@#define ENCL_VIDEO_PB_OFFST 0x1ca5#define ENCL_VIDEO_PR_OFFST 0x1ca6#define ENCL_VIDEO_MODE 0x1ca7 +#define ENCL_PX_LN_CNT_SHADOW_EN BIT(15)#define ENCL_VIDEO_MODE_ADV 0x1ca8 +#define ENCL_VIDEO_MODE_ADV_VFIFO_EN BIT(3) +#define ENCL_VIDEO_MODE_ADV_GAIN_HDTV BIT(4) +#define ENCL_SEL_GAMMA_RGB_IN BIT(10)#define ENCL_DBG_PX_RST 0x1ca9#define ENCL_DBG_LN_RST 0x1caa#define ENCL_DBG_PX_INT 0x1cab
@@ -1219,11 +1224,14 @@#define ENCL_VIDEO_VOFFST 0x1cc0#define ENCL_VIDEO_RGB_CTRL 0x1cc1#define ENCL_VIDEO_FILT_CTRL 0x1cc2 +#define ENCL_VIDEO_FILT_CTRL_BYPASS_FILTER BIT(12)#define ENCL_VIDEO_OFLD_VPEQ_OFST 0x1cc3#define ENCL_VIDEO_OFLD_VOAV_OFST 0x1cc4#define ENCL_VIDEO_MATRIX_CB 0x1cc5#define ENCL_VIDEO_MATRIX_CR 0x1cc6#define ENCL_VIDEO_RGBIN_CTRL 0x1cc7 +#define ENCL_VIDEO_RGBIN_RGB BIT(0) +#define ENCL_VIDEO_RGBIN_ZBLK BIT(1)#define ENCL_MAX_LINE_SWITCH_POINT 0x1cc8#define ENCL_DACSEL_0 0x1cc9#define ENCL_DACSEL_1 0x1cca
@@ -1300,13 +1308,28 @@#define RDMA_STATUS2 0x1116#define RDMA_STATUS3 0x1117#define L_GAMMA_CNTL_PORT 0x1400 +#define L_GAMMA_CNTL_PORT_VCOM_POL BIT(7)/* RW */ +#define L_GAMMA_CNTL_PORT_RVS_OUT BIT(6)/* RW */ +#define L_GAMMA_CNTL_PORT_ADR_RDY BIT(5)/* Read Only */ +#define L_GAMMA_CNTL_PORT_WR_RDY BIT(4)/* Read Only */ +#define L_GAMMA_CNTL_PORT_RD_RDY BIT(3)/* Read Only */ +#define L_GAMMA_CNTL_PORT_TR BIT(2)/* RW */ +#define L_GAMMA_CNTL_PORT_SET BIT(1)/* RW */ +#define L_GAMMA_CNTL_PORT_EN BIT(0)/* RW */ #define L_GAMMA_DATA_PORT 0x1401#define L_GAMMA_ADDR_PORT 0x1402 +#define L_GAMMA_ADDR_PORT_RD BIT(12) +#define L_GAMMA_ADDR_PORT_AUTO_INC BIT(11) +#define L_GAMMA_ADDR_PORT_SEL_R BIT(10) +#define L_GAMMA_ADDR_PORT_SEL_G BIT(9) +#define L_GAMMA_ADDR_PORT_SEL_B BIT(8) +#define L_GAMMA_ADDR_PORT_ADDR GENMASK(7, 0)#define L_GAMMA_VCOM_HSWITCH_ADDR 0x1403#define L_RGB_BASE_ADDR 0x1405#define L_RGB_COEFF_ADDR 0x1406#define L_POL_CNTL_ADDR 0x1407#define L_DITH_CNTL_ADDR 0x1408 +#define L_DITH_CNTL_DITH10_EN BIT(10)#define L_GAMMA_PROBE_CTRL 0x1409#define L_GAMMA_PROBE_COLOR_L 0x140a#define L_GAMMA_PROBE_COLOR_H 0x140b
@@ -1363,6 +1386,8 @@#define L_LCD_PWM1_HI_ADDR 0x143f#define L_INV_CNT_ADDR 0x1440#define L_TCON_MISC_SEL_ADDR 0x1441 +#define L_TCON_MISC_SEL_STV1 BIT(4) +#define L_TCON_MISC_SEL_STV2 BIT(5)#define L_DUAL_PORT_CNTL_ADDR 0x1442#define MLVDS_CLK_CTL1_HI 0x1443#define MLVDS_CLK_CTL1_LO 0x1444
drivers/gpu/drm/meson/meson_venc.c +209 -2
229 lines not on this page · raw message
drivers/gpu/drm/meson/meson_venc.h +6 -0
@@ -21,6 +21,7 @@ enum {MESON_VENC_MODE_CVBS_PAL ,MESON_VENC_MODE_CVBS_NTSC ,MESON_VENC_MODE_HDMI , + MESON_VENC_MODE_MIPI_DSI, }; struct meson_cvbs_enci_mode {
@@ -47,6 +48,9 @@ struct meson_cvbs_enci_mode {unsigned int analog_sync_adj; }; +/* LCD Encoder gamma setup */ +void meson_encl_load_gamma (struct meson_drm *priv); +/* HDMI Clock parameters */ enum drm_mode_status meson_venc_hdmi_supported_mode (const struct drm_display_mode *mode);
@@ -63,6 +67,8 @@ void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic,unsigned int ycrcb_map, bool yuv420_mode, const struct drm_display_mode *mode); +void meson_venc_mipi_dsi_mode_set (struct meson_drm *priv, +const struct drm_display_mode *mode);unsigned int meson_venci_get_field (struct meson_drm *priv);void meson_venc_enable_vsync (struct meson_drm *priv);
drivers/gpu/drm/meson/meson_vpp.h +2 -0
@@ -12,6 +12,8 @@struct drm_rect ;struct meson_drm ; +/* Mux VIU/VPP to ENCL */ +#define MESON_VIU_VPP_MUX_ENCL 0x0/* Mux VIU/VPP to ENCI */ #define MESON_VIU_VPP_MUX_ENCI 0x5/* Mux VIU/VPP to ENCP */
Signature · 1 line
2.25.1
PATCH v3 4/6 drm/meson: vclk: add DSI clock config
In reply to Neil ArmstrongThe DSI path used the ENCL pixel encoder, thus this adds a clock config using the HDMI PLL in order to feed the ENCL encoder via the VCLK2 path and the CTS_ENCL clock output.
--- drivers/gpu/drm/meson/meson_vclk.c | 47 ++++++++++++++++++++++++++++++ drivers/gpu/drm/meson/meson_vclk.h | 1 + 2 files changed, 48 insertions(+)
drivers/gpu/drm/meson/meson_vclk.c +47 -0
@@ -55,6 +55,8 @@#define VCLK2_DIV_MASK 0xff#define VCLK2_DIV_EN BIT(16)#define VCLK2_DIV_RESET BIT(17) +#define CTS_ENCL_SEL_MASK (0xf << 12) +#define CTS_ENCL_SEL_SHIFT 12#define CTS_VDAC_SEL_MASK (0xf << 28)#define CTS_VDAC_SEL_SHIFT 28#define HHI_VIID_CLK_CNTL 0x12c/* 0x4b offset in data sheet */
@@ -83,6 +85,7 @@#define VCLK_DIV12_EN BIT(4)#define HHI_VID_CLK_CNTL2 0x194/* 0x65 offset in data sheet */ #define CTS_ENCI_EN BIT(0) +#define CTS_ENCL_EN BIT(3)#define CTS_ENCP_EN BIT(2)#define CTS_VDAC_EN BIT(4)#define HDMI_TX_PIXEL_EN BIT(5)
@@ -1024,6 +1027,47 @@ static void meson_vclk_set(struct meson_drm *priv, unsigned int pll_base_freq,regmap_update_bits (priv->hhi,HHI_VID_CLK_CNTL ,VCLK_EN ,VCLK_EN ); } +static void meson_dsi_clock_config (struct meson_drm *priv,unsigned int freq) +{ +meson_hdmi_pll_generic_set (priv, freq *10 ); + +/* Setup vid_pll divider value /5 */ +meson_vid_pll_set (priv,VID_PLL_DIV_5 ); + +/* Disable VCLK2 */ +regmap_update_bits (priv->hhi,HHI_VIID_CLK_CNTL ,VCLK2_EN ,0 ); + +/* Setup the VCLK2 divider value /2 */ +regmap_update_bits (priv->hhi,HHI_VIID_CLK_DIV ,VCLK2_DIV_MASK ,2 -1 ); + +/* select vid_pll for vclk2 */ +regmap_update_bits (priv->hhi,HHI_VIID_CLK_CNTL , +VCLK2_SEL_MASK , (0 <<VCLK2_SEL_SHIFT )); + +/* enable vclk2 gate */ +regmap_update_bits (priv->hhi,HHI_VIID_CLK_CNTL ,VCLK2_EN ,VCLK2_EN ); + +/* select vclk2_div1 for encl */ +regmap_update_bits (priv->hhi,HHI_VIID_CLK_DIV , +CTS_ENCL_SEL_MASK , (8 <<CTS_ENCL_SEL_SHIFT )); + +/* release vclk2_div_reset and enable vclk2_div */ +regmap_update_bits (priv->hhi,HHI_VIID_CLK_DIV ,VCLK2_DIV_EN |VCLK2_DIV_RESET , +VCLK2_DIV_EN ); + +/* enable vclk2_div1 gate */ +regmap_update_bits (priv->hhi,HHI_VIID_CLK_CNTL ,VCLK2_DIV1_EN ,VCLK2_DIV1_EN ); + +/* reset vclk2 */ +regmap_update_bits (priv->hhi,HHI_VIID_CLK_CNTL ,VCLK2_SOFT_RESET ,VCLK2_SOFT_RESET ); +regmap_update_bits (priv->hhi,HHI_VIID_CLK_CNTL ,VCLK2_SOFT_RESET ,0 ); + +/* enable encl_clk */ +regmap_update_bits (priv->hhi,HHI_VID_CLK_CNTL2 ,CTS_ENCL_EN ,CTS_ENCL_EN ); + +usleep_range (10000 ,11000 ); +} + void meson_vclk_setup(struct meson_drm *priv, unsigned int target, unsigned int phy_freq, unsigned int vclk_freq, unsigned int venc_freq, unsigned int dac_freq,
@@ -1050,6 +1094,9 @@ void meson_vclk_setup(struct meson_drm *priv, unsigned int target,meson_vclk_set (priv, phy_freq,0 ,0 ,0 ,VID_PLL_DIV_5 ,2 ,1 ,1 , false, false);return ; + }else if (target ==MESON_VCLK_TARGET_DSI ) { +meson_dsi_clock_config (priv, phy_freq); +return ; } hdmi_tx_div = vclk_freq / dac_freq;
drivers/gpu/drm/meson/meson_vclk.h +1 -0
@@ -17,6 +17,7 @@ enum {MESON_VCLK_TARGET_CVBS =0 ,MESON_VCLK_TARGET_HDMI =1 ,MESON_VCLK_TARGET_DMT =2 , + MESON_VCLK_TARGET_DSI = 3, };/* 27MHz is the CVBS Pixel Clock */
Signature · 1 line
2.25.1
PATCH v3 5/6 drm/meson: add DSI encoder
In reply to Neil ArmstrongThis adds an encoder bridge designed to drive a MIPI-DSI display by using the ENCL encoder through the internal MIPI DSI transceiver connected to the output of the ENCL pixel encoder.
--- drivers/gpu/drm/meson/Makefile | 2 +- drivers/gpu/drm/meson/meson_drv.c | 7 + drivers/gpu/drm/meson/meson_encoder_dsi.c | 160 ++++++++++++++++++++++ drivers/gpu/drm/meson/meson_encoder_dsi.h | 12 ++ 4 files changed, 180 insertions(+), 1 deletion(-) create mode 100644 drivers/gpu/drm/meson/meson_encoder_dsi.c create mode 100644 drivers/gpu/drm/meson/meson_encoder_dsi.h
drivers/gpu/drm/meson/Makefile +1 -1
@@ -2,7 +2,7 @@ meson-drm-y := meson_drv.o meson_plane.o meson_crtc.o meson_encoder_cvbs.o meson-drm-y += meson_viu.o meson_vpp.o meson_venc.o meson_vclk.o meson_overlay.o meson-drm-y += meson_rdma.o meson_osd_afbcd.o -meson-drm-y += meson_encoder_hdmi.o +meson-drm-y += meson_encoder_hdmi.o meson_encoder_dsi.o obj-$(CONFIG_DRM_MESON) += meson-drm.o obj-$(CONFIG_DRM_MESON_DW_HDMI) += meson_dw_hdmi.o
drivers/gpu/drm/meson/meson_drv.c +7 -0
@@ -34,6 +34,7 @@#include "meson_registers.h" #include "meson_encoder_cvbs.h" #include "meson_encoder_hdmi.h" +#include "meson_encoder_dsi.h" #include "meson_viu.h" #include "meson_vpp.h" #include "meson_rdma.h"
@@ -324,6 +325,12 @@ static int meson_drv_bind_master(struct device *dev, bool has_components)if (ret) goto exit_afbcd; +if (meson_vpu_is_compatible (priv,VPU_COMPATIBLE_G12A )) { + ret =meson_encoder_dsi_init (priv); +if (ret) + goto free_drm; + } + ret =meson_plane_create (priv);if (ret) goto exit_afbcd;
drivers/gpu/drm/meson/meson_encoder_dsi.c new file +160 -0
160 lines not on this page · raw message
drivers/gpu/drm/meson/meson_encoder_dsi.h new file +12 -0
@@ -0,0 +1,12 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* +* Copyright (C) 2021 BayLibre, SAS +* Author: Neil Armstrong <[email protected]> +*/ + +#ifndef __MESON_ENCODER_DSI_H +#define __MESON_ENCODER_DSI_H + +int meson_encoder_dsi_init (struct meson_drm *priv); + +#endif /* __MESON_ENCODER_DSI_H */
Signature · 1 line
2.25.1
Re: [PATCH v3 5/6] drm/meson: add DSI encoder
Quoted 7 lines · Neil Armstrong
This adds an encoder bridge designed to drive a MIPI-DSI display by using the ENCL encoder through the internal MIPI DSI transceiver connected to the output of the ENCL pixel encoder.
Signed-off-by Neil Armstrong <[email protected]>Reviewed-by Jagan Teki <[email protected]>
PATCH v3 6/6 drm/meson: add support for MIPI-DSI transceiver
In reply to Neil ArmstrongThe Amlogic G12A/G12B/SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI Glue on other Amlogic SoCs.
This adds support for the Glue managing the transceiver, mimicing the init flow provided by Amlogic to setup the ENCL encoder, the glue, the transceiver, the digital D-PHY and the Analog PHY in the proper way.
An optional "MEAS" clock can be enabled to measure the delay between each vsync feeding the DW-MIPI-DSI transceiver.
--- drivers/gpu/drm/meson/Kconfig | 7 + drivers/gpu/drm/meson/Makefile | 1 + drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 358 ++++++++++++++++++++++ drivers/gpu/drm/meson/meson_dw_mipi_dsi.h | 160 ++++++++++ 4 files changed, 526 insertions(+) create mode 100644 drivers/gpu/drm/meson/meson_dw_mipi_dsi.c create mode 100644 drivers/gpu/drm/meson/meson_dw_mipi_dsi.h
drivers/gpu/drm/meson/Kconfig +7 -0
@@ -17,3 +17,10 @@ config DRM_MESON_DW_HDMI default y if DRM_MESON select DRM_DW_HDMI imply DRM_DW_HDMI_I2S_AUDIO + +config DRM_MESON_DW_MIPI_DSI + tristate "MIPI DSI Synopsys Controller support for Amlogic Meson Display" + depends on DRM_MESON + default y if DRM_MESON + select DRM_DW_MIPI_DSI + select GENERIC_PHY_MIPI_DPHY
drivers/gpu/drm/meson/Makefile +1 -0
@@ -6,3 +6,4 @@ meson-drm-y += meson_encoder_hdmi.o meson_encoder_dsi.o obj-$(CONFIG_DRM_MESON) += meson-drm.o obj-$(CONFIG_DRM_MESON_DW_HDMI) += meson_dw_hdmi.o +obj-$(CONFIG_DRM_MESON_DW_MIPI_DSI) += meson_dw_mipi_dsi.o
drivers/gpu/drm/meson/meson_dw_mipi_dsi.c new file +358 -0
358 lines not on this page · raw message
drivers/gpu/drm/meson/meson_dw_mipi_dsi.h new file +160 -0
160 lines not on this page · raw message
Signature · 1 line
2.25.1
Martin Blumenstingl
reviewerRe: [PATCH v3 6/6] drm/meson: add support for MIPI-DSI transceiver
Hi Neil,
Quoted 3 lines · Neil Armstrong
+/* [31:16] RW intr_stat/clr. Default 0.
+ * For each bit, read as this interrupt level status,
+ * write 1 to clear.
Do you know if an interrupt line from GIC is routed to the MIPI-DSI transceiver? If so, we should make it mandatory in patch #1 of this series (dt-bindings patch), even though it's not in use by the driver at the moment.
Re: [PATCH v3 6/6] drm/meson: add support for MIPI-DSI transceiver
Hi,
Quoted 10 lines · Martin Blumenstingl
Hi Neil,
Quoted 3 lines · Neil Armstrong
+/* [31:16] RW intr_stat/clr. Default 0.
+ * For each bit, read as this interrupt level status,
+ * write 1 to clear.Do you know if an interrupt line from GIC is routed to the MIPI-DSI transceiver? If so, we should make it mandatory in patch #1 of this series (dt-bindings patch), even though it's not in use by the driver at the moment.
Probably yes, let me check