Skip to contentSkip to conversation

dt-bindings: rtc: ds1307: Convert to json-schema

PATCH In review Thierry Reding 3 participants 7 messages Jun 17, 2022 – Aug 4, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 dt-bindings: rtc: ds1307: Convert to json-schema

From: Thierry Reding <[email protected]>

Convert the DS1307 (and compatible) RTC bindings from the free-form text format to json-schema.

---
Changes in v2:
- add compatible string list for [ st,m41t00, dallas,ds1338 ]
- allow second interrupt and interrupt-names
- remove commented-out section
- allow vcc-supply

 .../devicetree/bindings/rtc/rtc-ds1307.txt    |  52 ---------
 .../devicetree/bindings/rtc/rtc-ds1307.yaml   | 102 ++++++++++++++++++
 2 files changed, 102 insertions(+), 52 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-ds1307.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/rtc-ds1307.yaml
Documentation/devicetree/bindings/rtc/rtc-ds1307.txt deleted +0 -52
deleted file mode 100644
index 36f610bb051e..000000000000
@@ -1,52 +0,0 @@
-Dallas DS1307 and compatible RTC
-
-Required properties:
-- compatible: should be one of:
-	"dallas,ds1307",
-	"dallas,ds1308",
-	"dallas,ds1337",
-	"dallas,ds1338",
-	"dallas,ds1339",
-	"dallas,ds1388",
-	"dallas,ds1340",
-	"dallas,ds1341",
-	"maxim,ds3231",
-	"st,m41t0",
-	"st,m41t00",
-	"st,m41t11",
-	"microchip,mcp7940x",
-	"microchip,mcp7941x",
-	"pericom,pt7c4338",
-	"epson,rx8025",
-	"isil,isl12057"
-	"epson,rx8130"
-- reg: I2C bus address of the device
-
-Optional properties:
-- interrupts: rtc alarm interrupt.
-- clock-output-names: From common clock binding to override the default output
-                      clock name
-- wakeup-source: Enables wake up of host system on alarm
-- trickle-resistor-ohms : ds1339, ds1340 and ds 1388 only
-	Selected resistor for trickle charger
-	Possible values are 250, 2000, 4000
-	Should be given if trickle charger should be enabled
-- aux-voltage-chargeable: ds1339, ds1340, ds1388 and rx8130 only
-	Tells whether the battery/supercap of the RTC (if any) is
-	chargeable or not.
-	Possible values are 0 (not chargeable), 1 (chargeable)
-
-Deprecated properties:
-- trickle-diode-disable : ds1339, ds1340 and ds1388 only
-	Do not use internal trickle charger diode
-	Should be given if internal trickle charger diode should be disabled
-	(superseded by aux-voltage-chargeable)
-
-Example:
-	ds1339: rtc@68 {
-		compatible = "dallas,ds1339";
-		reg = <0x68>;
-		interrupt-parent = <&gpio4>;
-		interrupts = <20 0>;
-		trickle-resistor-ohms = <250>;
-	};
Documentation/devicetree/bindings/rtc/rtc-ds1307.yaml new file +102 -0

102 lines not on this page · raw message

Signature · 1 line
2.36.1
#1 lore raw

PATCH v2 2/2 dt-bindings: rtc: Add EM Microelectronic EM3027 bindings

From: Thierry Reding <[email protected]>

Document the bindings for the EM Microelectronic EM3027 RTC.

---
Changes in v2:
- add to list of trivial RTCs

 Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/rtc/trivial-rtc.yaml +2 -0
index 13925bb78ec7..d9fc120c61cc 100644
@@ -30,6 +30,8 @@ properties:
       - dallas,ds1672
       # Extremely Accurate I²C RTC with Integrated Crystal and SRAM
       - dallas,ds3232
+      # EM Microelectronic EM3027 RTC
+      - emmicro,em3027
       # I2C-BUS INTERFACE REAL TIME CLOCK MODULE
       - epson,rx8010
       # I2C-BUS INTERFACE REAL TIME CLOCK MODULE
Signature · 1 line
2.36.1
maintainer Reviewed-by on v2 2/2
#2 lore raw

Re: [PATCH v2 2/2] dt-bindings: rtc: Add EM Microelectronic EM3027 bindings

Quoted 4 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Document the bindings for the EM Microelectronic EM3027 RTC.

Quoted 8 lines

---
Changes in v2:
- add to list of trivial RTCs

 Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 2 ++
 1 file changed, 2 insertions(+)
maintainer Reviewed-by on v2 1/2
#3 lore raw
In reply to Thierry Reding
Quoted 13 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Convert the DS1307 (and compatible) RTC bindings from the free-form text format to json-schema.

---
Changes in v2:
- add compatible string list for [ st,m41t00, dallas,ds1338 ]
- allow second interrupt and interrupt-names
- remove commented-out section
- allow vcc-supply

Quoted 6 lines
 .../devicetree/bindings/rtc/rtc-ds1307.txt    |  52 ---------
 .../devicetree/bindings/rtc/rtc-ds1307.yaml   | 102 ++++++++++++++++++
 2 files changed, 102 insertions(+), 52 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-ds1307.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/rtc-ds1307.yaml
maintainer
#4 lore raw
In reply to Thierry Reding
Quoted 13 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Convert the DS1307 (and compatible) RTC bindings from the free-form text format to json-schema.

---
Changes in v2:
- add compatible string list for [ st,m41t00, dallas,ds1338 ]
- allow second interrupt and interrupt-names
- remove commented-out section
- allow vcc-supply

Quoted 6 lines
 .../devicetree/bindings/rtc/rtc-ds1307.txt    |  52 ---------
 .../devicetree/bindings/rtc/rtc-ds1307.yaml   | 102 ++++++++++++++++++
 2 files changed, 102 insertions(+), 52 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-ds1307.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/rtc-ds1307.yaml

Looks like this hasn't been picked up so I've applied both patches, thanks!

Rob

#5 lore raw

Hello,

Quoted 21 lines · Rob Herring
Quoted 13 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Convert the DS1307 (and compatible) RTC bindings from the free-form text format to json-schema.

---
Changes in v2:
- add compatible string list for [ st,m41t00, dallas,ds1338 ]
- allow second interrupt and interrupt-names
- remove commented-out section
- allow vcc-supply

Quoted 6 lines
 .../devicetree/bindings/rtc/rtc-ds1307.txt    |  52 ---------
 .../devicetree/bindings/rtc/rtc-ds1307.yaml   | 102 ++++++++++++++++++
 2 files changed, 102 insertions(+), 52 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-ds1307.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/rtc-ds1307.yaml
Quoted 2 lines

Looks like this hasn't been picked up so I've applied both patches, thanks!

This was on my radar but I'm never sure what you prefer for dt-bindings only series.

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
maintainer
#6 lore raw
Quoted 25 lines · Alexandre Belloni

Hello,

Quoted 21 lines · Rob Herring
Quoted 19 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Convert the DS1307 (and compatible) RTC bindings from the free-form text format to json-schema.

---
Changes in v2:
- add compatible string list for [ st,m41t00, dallas,ds1338 ]
- allow second interrupt and interrupt-names
- remove commented-out section
- allow vcc-supply

 .../devicetree/bindings/rtc/rtc-ds1307.txt    |  52 ---------
 .../devicetree/bindings/rtc/rtc-ds1307.yaml   | 102 ++++++++++++++++++
 2 files changed, 102 insertions(+), 52 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-ds1307.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/rtc-ds1307.yaml
Quoted 5 lines
Quoted 2 lines

Looks like this hasn't been picked up so I've applied both patches, thanks!

This was on my radar but I'm never sure what you prefer for dt-bindings only series.

My (or Krzysztof's) Reviewed-by/Acked-by means I expect it to go via subsystem tree.

Rob