arm: mach-imx: Fix refcount leak bug in src
Subsystems (3)
PATCH 1/1 arm: mach-imx: Fix refcount leak bug in src
In imx7_src_init(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore.
--- arch/arm/mach-imx/src.c | 2 ++ 1 file changed, 2 insertions(+)
arch/arm/mach-imx/src.c +2 -0
@@ -195,6 +195,7 @@ void __init imx7_src_init(void)return ; src_base =of_iomap (np,0 ); +of_node_put (np);if (!src_base)return ;
@@ -203,6 +204,7 @@ void __init imx7_src_init(void)return ; gpc_base =of_iomap (np,0 ); +of_node_put (np);if (!gpc_base)return ; }
Signature · 1 line
2.25.1
Hi,
Quoted 20 lines · Liang He
In
imx7_src_init(),of_find_compatible_node()will return a node pointer with refcount incremented. We should useof_node_put()when it is not used anymore.Signed-off-by Liang He <[email protected]>---
arch/arm/mach-imx/src.c | 2 ++1 file changed, 2 insertions(+)arch/arm/mach-imx/src.c +0
-0@@ -195,6 +195,7 @@ void __init imx7_src_init(void) return;
src_base=of_iomap(np, 0);
arch/arm/mach-imx/src.c
Quoted 1 line
arch/arm/mach-imx/src.c +1
-0+of_node_put (np);
Thank you for the patch. There is another instance of this pattern a few lines above, in imx_src_init().
regards
Philipp
Quoted 22 lines · Philipp Zabel
Hi,
Quoted 19 lines · Liang He
In
imx7_src_init(),of_find_compatible_node()will return a node pointer with refcount incremented. We should useof_node_put()when it is not used anymore.Signed-off-by Liang He <[email protected]>---
arch/arm/mach-imx/src.c | 2 ++1 file changed, 2 insertions(+)arch/arm/mach-imx/src.c +0
-0@@ -195,6 +195,7 @@ void __init imx7_src_init(void) return;
Quoted 8 lines
arch/arm/mach-imx/src.c
Quoted 2 lines
src_base=of_iomap(np, 0);arch/arm/mach-imx/src.c +1
-0+of_node_put (np);Thank you for the patch. There is another instance of this pattern a few lines above, in
imx_src_init().regards
Philipp
Thanks very much for your reply, Philipp.
In fact, I have confirmed if there is any existed same patch in
lore.kernel.org before I begin to send my patch.
So there is indeed a patch reported by Miaoqian for imx_src_init(). However, that patch does not consider the bug in imx7_src_init().
Thanks again.
Liang
Quoted 6 lines · Liang He
In
imx7_src_init(),of_find_compatible_node()will return a node pointer with refcount incremented. We should useof_node_put()when it is not used anymore.Signed-off-by Liang He <[email protected]>---
Before applying the patch please check it carefully. Previous evidence [1][2] suggests that not it was not even compiled.
[1] https://lore.kernel.org/all/[email protected]/
[2]
https://lore.kernel.org/all/[email protected]/
Best regards,
Krzysztof