mips: lantiq: falcon: Fix refcount leak bug in sysctrl
Subsystems (2)
PATCH 1/1 mips: lantiq: falcon: Fix refcount leak bug in sysctrl
In ltq_soc_init(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore.
Signed-off-by Liang He <[email protected]>
--- arch/mips/lantiq/falcon/sysctrl.c | 6 ++++++ 1 file changed, 6 insertions(+)
arch/mips/lantiq/falcon/sysctrl.c +6 -0
@@ -208,6 +208,12 @@ void __init ltq_soc_init(void) of_address_to_resource(np_sysgpe, 0, &res_sys[2]))panic ("Failed to get core resources" ); +of_node_put (np_status); +of_node_put (np_ebu); +of_node_put (np_sys1); +of_node_put (np_syseth); +of_node_put (np_sysgpe); + if ((request_mem_region(res_status.start, resource_size(&res_status), res_status.name) < 0) || (request_mem_region(res_ebu.start, resource_size(&res_ebu),
Signature · 1 line
2.25.1
Quoted 28 lines · Liang He
In
ltq_soc_init(),of_find_compatible_node()will return a node pointer with refcount incremented. We should useof_node_put()when it is not used anymore.Signed-off-by Liang He <[email protected]>--- arch/mips/lantiq/falcon/sysctrl.c | 6 ++++++ 1 file changed, 6 insertions(+)arch/mips/lantiq/falcon/sysctrl.c +6
-0@@ -208,6 +208,12 @@ void __init ltq_soc_init(void) of_address_to_resource(np_sysgpe, 0, &res_sys[2]))panic ("Failed to get core resources" ); +of_node_put (np_status); +of_node_put (np_ebu); +of_node_put (np_sys1); +of_node_put (np_syseth); +of_node_put (np_sysgpe); + if ((request_mem_region(res_status.start, resource_size(&res_status), res_status.name) < 0) || (request_mem_region(res_ebu.start, resource_size(&res_ebu),Signature · 1 line
2.25.1
applied to mips-fixes.
Thomas.
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]