mips: lantiq: xway: Fix refcount leak bug in sysctrl
Subsystems (2)
PATCH 1/1 mips: lantiq: xway: Fix refcount leak bug in sysctrl
In ltq_soc_init(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore.
Signed-off-by Liang He <[email protected]>
--- arch/mips/lantiq/xway/sysctrl.c | 4 ++++ 1 file changed, 4 insertions(+)
arch/mips/lantiq/xway/sysctrl.c +4 -0
@@ -441,6 +441,10 @@ void __init ltq_soc_init(void) of_address_to_resource(np_ebu, 0, &res_ebu))panic ("Failed to get core resources" ); +of_node_put (np_pmu); +of_node_put (np_cgu); +of_node_put (np_ebu); +if (!request_mem_region (res_pmu.start,resource_size (&res_pmu), res_pmu.name) || !request_mem_region(res_cgu.start, resource_size(&res_cgu),
Signature · 1 line
2.25.1
Quoted 26 lines · Liang He
In
ltq_soc_init(),of_find_compatible_node()will return a node pointer with refcount incremented. We should useof_node_put()when it is not used anymore.Signed-off-by Liang He <[email protected]>--- arch/mips/lantiq/xway/sysctrl.c | 4 ++++ 1 file changed, 4 insertions(+)arch/mips/lantiq/xway/sysctrl.c +4
-0@@ -441,6 +441,10 @@ void __init ltq_soc_init(void) of_address_to_resource(np_ebu, 0, &res_ebu))panic ("Failed to get core resources" ); +of_node_put (np_pmu); +of_node_put (np_cgu); +of_node_put (np_ebu); +if (!request_mem_region (res_pmu.start,resource_size (&res_pmu), res_pmu.name) || !request_mem_region(res_cgu.start, resource_size(&res_cgu),Signature · 1 line
2.25.1
applied to mips-fixes.
Thomas.
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]