Skip to contentSkip to conversation

powerpc: maple: Fix refcount leak bug in time.c

PATCH Applied Liang He 2 participants 2 messages Jun 17, 2022 – Sep 9, 2022 PowerPC

lore
Share & tools
lore

Liang He

author
#0 lore raw

PATCH 1/1 powerpc: maple: Fix refcount leak bug in time.c

In maple_get_boot_time(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() in fail path or when it is not used anymore.

---
 arch/powerpc/platforms/maple/time.c | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/platforms/maple/time.c +1 -0
index 823e219ef8ee..91606411d2e0 100644
@@ -153,6 +153,7 @@ time64_t __init maple_get_boot_time(void)
 		       maple_rtc_addr);
 	}
  bail:
+	of_node_put(rtcs);
 	if (maple_rtc_addr == 0) {
 		maple_rtc_addr = RTC_PORT(0); /* legacy address */
 		printk(KERN_INFO "Maple: No device node for RTC, assuming "
Signature · 1 line
2.25.1