Skip to contentSkip to conversation

arm64: dts: imx8mq-kontron-pitx-imx8m-u-boot.dtsi: disable assigned clocks

PATCH In review Heiko Thiery 3 participants 6 messages Jun 11, 2022 – Jun 17, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: imx8mq-kontron-pitx-imx8m-u-boot.dtsi: disable assigned clocks

With the move to use DM_CLK the boards uart stops working. The used properties are not supported by the imx8mq clock driver. Thus the correct baudrate cannot be selected. Remove this properties here and the board can start with working uart. Keep it in the main dts because linux handles these porperties fine.

---
 .../arm/dts/imx8mq-kontron-pitx-imx8m-u-boot.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
arch/arm/dts/imx8mq-kontron-pitx-imx8m-u-boot.dtsi +15 -0
index 6f9c81462e..d361f3f559 100644
@@ -10,3 +10,18 @@
 	sd-uhs-sdr104;
 	sd-uhs-ddr50;
 };
+
+&uart1 {
+	/delete-property/ assigned-clocks;
+	/delete-property/ assigned-clock-parents;
+};
+
+&uart2 {
+	/delete-property/ assigned-clocks;
+	/delete-property/ assigned-clock-parents;
+};
+
+&uart3 {
+	/delete-property/ assigned-clocks;
+	/delete-property/ assigned-clock-parents;
+};
Signature · 1 line
2.30.2
#1 lore raw
Quoted 5 lines · Heiko Thiery

With the move to use DM_CLK the boards uart stops working. The used properties are not supported by the imx8mq clock driver. Thus the correct baudrate cannot be selected. Remove this properties here and the board can start with working uart. Keep it in the main dts because linux handles these porperties fine.

Is this yet another

75f080df46f ("Revert "clk: Detect failure to set defaults"")

kind of failure, where the clock uclass returns error code on something?

Maybe the clock uclass should rather warn than fail outright, so we won't need these workarounds in DT files ?

#2 lore raw

Hi Marek,

Am Sa., 11. Juni 2022 um 12:15 Uhr schrieb Marek Vasut <[email protected]>:

Quoted 8 lines · Heiko Thiery
Quoted 5 lines

With the move to use DM_CLK the boards uart stops working. The used properties are not supported by the imx8mq clock driver. Thus the correct baudrate cannot be selected. Remove this properties here and the board can start with working uart. Keep it in the main dts because linux handles these porperties fine.

Quoted 8 lines

Is this yet another

75f080df46f ("Revert "clk: Detect failure to set defaults"")

kind of failure, where the clock uclass returns error code on something?

Maybe the clock uclass should rather warn than fail outright, so we won't need these workarounds in DT files ?

I think this is another kind of issue here. I had already tried to solve the problem [1], but had not been able to follow it through to the end.

Maybe now is the right time to tackle it again. But due to lack of time i can't say when i will get to it yet.

[1] https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

Signature · 1 line
Heiko
#3 lore raw

Hi Tom,

Am Sa., 11. Juni 2022 um 16:56 Uhr schrieb Heiko Thiery <[email protected]>:

Quoted 21 lines

Hi Marek,

Am Sa., 11. Juni 2022 um 12:15 Uhr schrieb Marek Vasut <[email protected]>:

Quoted 8 lines · Heiko Thiery
Quoted 5 lines

With the move to use DM_CLK the boards uart stops working. The used properties are not supported by the imx8mq clock driver. Thus the correct baudrate cannot be selected. Remove this properties here and the board can start with working uart. Keep it in the main dts because linux handles these porperties fine.

Quoted 8 lines

Is this yet another

75f080df46f ("Revert "clk: Detect failure to set defaults"")

kind of failure, where the clock uclass returns error code on something?

Maybe the clock uclass should rather warn than fail outright, so we won't need these workarounds in DT files ?

Quoted 8 lines

I think this is another kind of issue here. I had already tried to solve the problem [1], but had not been able to follow it through to the end.

Maybe now is the right time to tackle it again. But due to lack of time i can't say when i will get to it yet.

[1] https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

Is there a chance that this patch can still come in the next RC? Without this change, the board no longer starts correctly.

Quoted 2 lines

--
Heiko

#4 lore raw
Quoted 29 lines · Heiko Thiery

Hi Tom,

Am Sa., 11. Juni 2022 um 16:56 Uhr schrieb Heiko Thiery <[email protected]>:

Quoted 25 lines

Hi Marek,

Am Sa., 11. Juni 2022 um 12:15 Uhr schrieb Marek Vasut <[email protected]>:

Quoted 8 lines · Heiko Thiery
Quoted 5 lines

With the move to use DM_CLK the boards uart stops working. The used properties are not supported by the imx8mq clock driver. Thus the correct baudrate cannot be selected. Remove this properties here and the board can start with working uart. Keep it in the main dts because linux handles these porperties fine.

Quoted 8 lines

Is this yet another

75f080df46f ("Revert "clk: Detect failure to set defaults"")

kind of failure, where the clock uclass returns error code on something?

Maybe the clock uclass should rather warn than fail outright, so we won't need these workarounds in DT files ?

I think this is another kind of issue here. I had already tried to solve the problem [1], but had not been able to follow it through to the end.

Quoted 7 lines
Quoted 4 lines

Maybe now is the right time to tackle it again. But due to lack of time i can't say when i will get to it yet.

[1] https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

Is there a chance that this patch can still come in the next RC? Without this change, the board no longer starts correctly.

I've put it in my queue.

Signature · 1 line
Tom
#5 lore raw
In reply to Heiko Thiery
Quoted 7 lines · Heiko Thiery

With the move to use DM_CLK the boards uart stops working. The used properties are not supported by the imx8mq clock driver. Thus the correct baudrate cannot be selected. Remove this properties here and the board can start with working uart. Keep it in the main dts because linux handles these porperties fine.

Applied to u-boot/master, thanks!

Signature · 1 line
Tom