Skip to contentSkip to conversation

powerpc: sysdev: Fix refcount leak bug in mpic_msgr

PATCH New Liang He 1 participant 1 message Jun 17, 2022 PowerPC

lore
Share & tools
lore

Liang He

author
#0 lore raw

PATCH 1/1 powerpc: sysdev: Fix refcount leak bug in mpic_msgr

In mpic_msgr_number_of_blocks() and mpic_msgr_block_number(), of_find_node_by_name() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore.

---
 arch/powerpc/sysdev/mpic_msgr.c | 2 ++
 1 file changed, 2 insertions(+)
arch/powerpc/sysdev/mpic_msgr.c +2 -0
index 698fefaaa6dd..c2a235d9eb09 100644
@@ -122,6 +122,7 @@ static unsigned int mpic_msgr_number_of_blocks(void)
 			count += 1;
 		}
 	}
+	of_node_put(aliases);
 
 	return count;
 }
@@ -150,6 +151,7 @@ static int mpic_msgr_block_number(struct device_node *node)
 		if (node == of_find_node_by_path(prop->value))
 			break;
 	}
+	of_node_put(aliases);
 
 	return index == number_of_blocks ? -1 : index;
 }
Signature · 1 line
2.25.1