Skip to contentSkip to conversation

remove IWYU flagged headers

PATCH Superseded Sean Morrissey 5 participants 82 messages Apr 21, 2022 – Jun 21, 2022

lore
Share & tools
lore
#0 lore raw

cover remove IWYU flagged headers

This patchset removes unused header includes flagged by the IWYU tool for the 22.07 release.

Sean Morrissey (19):
cmdline: remove unneeded header includes
eal: remove unneeded header includes
ethdev: remove unneeded header includes
gpudev: remove unneeded header includes
gso: remove unneeded header includes
hash: remove unneeded header includes
ip_frag: remove unneeded header includes
jobstats: remove unneeded header includes
mempool: remove unneeded header includes
meter: remove unneeded header includes
net: remove unneeded header includes
power: remove unneeded header includes
rawdev: remove unneeded header includes
regexdev: remove unneeded header includes
sched: remove unneeded header includes
stack: remove unneeded header includes
table: remove unneeded header includes
timer: remove unneeded header includes
vhost: remove unneeded header includes

 lib/cmdline/cmdline_cirbuf.h       | 1 -
 lib/cmdline/cmdline_parse_num.c    | 3 ---
 lib/cmdline/cmdline_socket.c       | 5 -----
 lib/cmdline/cmdline_socket.h       | 1 -
 lib/eal/common/eal_common_config.c | 1 -
 lib/eal/common/eal_common_launch.c | 1 -
 lib/eal/common/eal_common_log.c    | 1 -
 lib/eal/common/malloc_heap.h       | 1 -
 lib/eal/linux/eal.c                | 1 -
 lib/eal/linux/eal_thread.c         | 6 ------
 lib/eal/linux/eal_vfio.c           | 1 -
 lib/eal/unix/eal_filesystem.c      | 2 --
 lib/ethdev/rte_class_eth.c         | 2 --
 lib/ethdev/rte_ethdev.c            | 9 ---------
 lib/ethdev/rte_ethdev.h            | 1 -
 lib/ethdev/rte_flow.c              | 2 --
 lib/ethdev/rte_flow.h              | 3 ---
 lib/ethdev/rte_mtr.c               | 1 -
 lib/ethdev/rte_mtr.h               | 1 -
 lib/gpudev/gpudev.c                | 1 -
 lib/gso/gso_common.c               | 1 -
 lib/gso/gso_common.h               | 1 -
 lib/gso/gso_tcp4.h                 | 1 -
 lib/gso/gso_tunnel_tcp4.h          | 1 -
 lib/gso/gso_tunnel_udp4.h          | 1 -
 lib/gso/gso_udp4.h                 | 1 -
 lib/hash/rte_cuckoo_hash.c         | 3 ---
 lib/ip_frag/ip_frag_internal.c     | 1 -
 lib/jobstats/rte_jobstats.h        | 1 -
 lib/mempool/rte_mempool.h          | 1 -
 lib/meter/rte_meter.c              | 3 ---
 lib/net/rte_net.h                  | 1 -
 lib/power/power_pstate_cpufreq.c   | 1 -
 lib/power/rte_power_empty_poll.h   | 3 ---
 lib/power/rte_power_pmd_mgmt.c     | 2 --
 lib/power/rte_power_pmd_mgmt.h     | 5 -----
 lib/rawdev/rte_rawdev.h            | 1 -
 lib/regexdev/rte_regexdev.h        | 1 -
 lib/sched/rte_pie.c                | 1 -
 lib/stack/rte_stack.h              | 1 -
 lib/table/rte_swx_table_learner.c  | 1 -
 lib/timer/rte_timer.c              | 3 ---
 lib/timer/rte_timer.h              | 2 --
 lib/vhost/vhost.h                  | 3 ---
 lib/vhost/vhost_user.h             | 1 -
 45 files changed, 85 deletions(-)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/19 cmdline: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/cmdline/cmdline_cirbuf.h    | 1 -
 lib/cmdline/cmdline_parse_num.c | 3 ---
 lib/cmdline/cmdline_socket.c    | 5 -----
 lib/cmdline/cmdline_socket.h    | 1 -
 4 files changed, 10 deletions(-)
lib/cmdline/cmdline_cirbuf.h +0 -1
index c23b211ad4..c58fdabf00 100644
@@ -7,7 +7,6 @@
 #ifndef _CIRBUF_H_
 #define _CIRBUF_H_
 
-#include <rte_config.h>
 
 #ifdef __cplusplus
 extern "C" {
lib/cmdline/cmdline_parse_num.c +0 -3
index b37dd94ae9..820af071fb 100644
@@ -7,10 +7,7 @@
 #include <stdio.h>
 #include <stdint.h>
 #include <inttypes.h>
-#include <ctype.h>
 #include <string.h>
-#include <stdarg.h>
-#include <errno.h>
 #include <rte_string_fns.h>
 
 #include "cmdline_parse.h"
lib/cmdline/cmdline_socket.c +0 -5
index ebd5343754..d6c2431cb8 100644
@@ -5,11 +5,6 @@
  */
 
 #include <stdio.h>
-#include <string.h>
-#include <unistd.h>
-#include <stdlib.h>
-#include <stdarg.h>
-#include <inttypes.h>
 #include <fcntl.h>
 
 #include "cmdline.h"
lib/cmdline/cmdline_socket.h +0 -1
index 80542e5599..a9c4ea26ad 100644
@@ -8,7 +8,6 @@
 #define _CMDLINE_SOCKET_H_
 
 #include <cmdline_parse.h>
-#include <cmdline.h>
 
 #ifdef __cplusplus
 extern "C" {
Signature · 1 line
2.25.1
#2 lore raw

PATCH 2/19 eal: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/eal/common/eal_common_config.c | 1 -
 lib/eal/common/eal_common_launch.c | 1 -
 lib/eal/common/eal_common_log.c    | 1 -
 lib/eal/common/malloc_heap.h       | 1 -
 lib/eal/linux/eal.c                | 1 -
 lib/eal/linux/eal_thread.c         | 6 ------
 lib/eal/linux/eal_vfio.c           | 1 -
 lib/eal/unix/eal_filesystem.c      | 2 --
 8 files changed, 14 deletions(-)
lib/eal/common/eal_common_config.c +0 -1
index 3cef43a4f7..0daf0f3188 100644
@@ -1,7 +1,6 @@
 /* SPDX-License-Identifier: BSD-3-Clause
  * Copyright(c) 2020 Mellanox Technologies, Ltd
  */
-#include <string.h>
 
 #include <rte_string_fns.h>
 
lib/eal/common/eal_common_launch.c +0 -1
index 992f8e4631..462c886e30 100644
@@ -6,7 +6,6 @@
 
 #include <rte_launch.h>
 #include <rte_eal_trace.h>
-#include <rte_atomic.h>
 #include <rte_pause.h>
 #include <rte_lcore.h>
 
lib/eal/common/eal_common_log.c +0 -1
index d57dca9785..bd7b188ceb 100644
@@ -13,7 +13,6 @@
 #include <sys/queue.h>
 
 #include <rte_log.h>
-#include <rte_os_shim.h>
 #include <rte_per_lcore.h>
 
 #include "eal_log.h"
lib/eal/common/malloc_heap.h +0 -1
index 3b2fbc0aa0..1d5c348530 100644
@@ -9,7 +9,6 @@
 #include <sys/queue.h>
 
 #include <rte_malloc.h>
-#include <rte_spinlock.h>
 
 /* Number of free lists per heap, grouped by size. */
 #define RTE_HEAP_NUM_FREELISTS  13
lib/eal/linux/eal.c +0 -1
index 1ef263434a..1390b6cf47 100644
@@ -34,7 +34,6 @@
 #include <rte_service_component.h>
 #include <rte_log.h>
 #include <rte_string_fns.h>
-#include <rte_cpuflags.h>
 #include <rte_bus.h>
 #include <rte_version.h>
 #include <malloc_heap.h>
lib/eal/linux/eal_thread.c +0 -6
index 820cc905e0..e9294127d1 100644
@@ -4,20 +4,14 @@
 
 #include <errno.h>
 #include <stdio.h>
-#include <stdint.h>
 #include <unistd.h>
 #include <pthread.h>
 #include <sys/syscall.h>
 
-#include <rte_debug.h>
-#include <rte_launch.h>
-#include <rte_log.h>
 #include <rte_eal.h>
 #include <rte_lcore.h>
 #include <rte_string_fns.h>
 
-#include "eal_private.h"
-#include "eal_thread.h"
 
 /* require calling thread tid by gettid() */
 int rte_sys_gettid(void)
lib/eal/linux/eal_vfio.c +0 -1
index 549b86ae1d..c4fd7d63b0 100644
@@ -15,7 +15,6 @@
 #include <rte_vfio.h>
 
 #include "eal_filesystem.h"
-#include "eal_memcfg.h"
 #include "eal_vfio.h"
 #include "eal_private.h"
 #include "eal_internal_cfg.h"
lib/eal/unix/eal_filesystem.c +0 -2
index 094a2bf7e4..afbab9368a 100644
@@ -10,10 +10,8 @@
 #include <stdlib.h>
 #include <string.h>
 #include <sys/stat.h>
-#include <sys/types.h>
 #include <unistd.h>
 
-#include <rte_common.h>
 #include <rte_log.h>
 
 #include "eal_private.h"
Signature · 1 line
2.25.1
#3 lore raw

PATCH 3/19 ethdev: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/ethdev/rte_class_eth.c | 2 --
 lib/ethdev/rte_ethdev.c    | 9 ---------
 lib/ethdev/rte_ethdev.h    | 1 -
 lib/ethdev/rte_flow.c      | 2 --
 lib/ethdev/rte_flow.h      | 3 ---
 lib/ethdev/rte_mtr.c       | 1 -
 lib/ethdev/rte_mtr.h       | 1 -
 7 files changed, 19 deletions(-)
lib/ethdev/rte_class_eth.c +0 -2
index c8e8fc9244..3be84dd45c 100644
@@ -5,13 +5,11 @@
 #include <string.h>
 
 #include <rte_class.h>
-#include <rte_compat.h>
 #include <rte_errno.h>
 #include <rte_kvargs.h>
 #include <rte_log.h>
 
 #include "rte_ethdev.h"
-#include "rte_ethdev_core.h"
 #include "ethdev_driver.h"
 #include "ethdev_private.h"
 
lib/ethdev/rte_ethdev.c +0 -9
index 29a3d80466..c4120e6d51 100644
@@ -11,18 +11,9 @@
 #include <string.h>
 #include <sys/queue.h>
 
-#include <rte_byteorder.h>
 #include <rte_log.h>
-#include <rte_debug.h>
 #include <rte_interrupts.h>
-#include <rte_memory.h>
 #include <rte_memcpy.h>
-#include <rte_memzone.h>
-#include <rte_launch.h>
-#include <rte_eal.h>
-#include <rte_per_lcore.h>
-#include <rte_lcore.h>
-#include <rte_branch_prediction.h>
 #include <rte_common.h>
 #include <rte_mempool.h>
 #include <rte_malloc.h>
lib/ethdev/rte_ethdev.h +0 -1
index 04cff8ee10..131be93f6e 100644
@@ -169,7 +169,6 @@ extern "C" {
 #include <rte_errno.h>
 #include <rte_common.h>
 #include <rte_config.h>
-#include <rte_ether.h>
 #include <rte_power_intrinsics.h>
 
 #include "rte_ethdev_trace_fp.h"
lib/ethdev/rte_flow.c +0 -2
index 2c35a2f13e..501be9d602 100644
@@ -6,13 +6,11 @@
 #include <errno.h>
 #include <stddef.h>
 #include <stdint.h>
-#include <string.h>
 
 #include <rte_common.h>
 #include <rte_errno.h>
 #include <rte_branch_prediction.h>
 #include <rte_string_fns.h>
-#include <rte_mbuf.h>
 #include <rte_mbuf_dyn.h>
 #include "rte_ethdev.h"
 #include "rte_flow_driver.h"
lib/ethdev/rte_flow.h +0 -3
index d8827dd184..5e9d206986 100644
@@ -17,7 +17,6 @@
 #include <stddef.h>
 #include <stdint.h>
 
-#include <rte_arp.h>
 #include <rte_common.h>
 #include <rte_ether.h>
 #include <rte_icmp.h>
@@ -26,12 +25,10 @@
 #include <rte_tcp.h>
 #include <rte_udp.h>
 #include <rte_vxlan.h>
-#include <rte_byteorder.h>
 #include <rte_esp.h>
 #include <rte_higig.h>
 #include <rte_ecpri.h>
 #include <rte_bitops.h>
-#include <rte_mbuf.h>
 #include <rte_mbuf_dyn.h>
 #include <rte_meter.h>
 #include <rte_gtp.h>
lib/ethdev/rte_mtr.c +0 -1
index e49fcf271c..754872f6af 100644
@@ -5,7 +5,6 @@
 #include <stdint.h>
 
 #include <rte_errno.h>
-#include "rte_compat.h"
 #include "rte_ethdev.h"
 #include "rte_mtr_driver.h"
 #include "rte_mtr.h"
lib/ethdev/rte_mtr.h +0 -1
index 40df0888c8..d8c1066c9b 100644
@@ -49,7 +49,6 @@
 #include <rte_compat.h>
 #include <rte_common.h>
 #include <rte_meter.h>
-#include <rte_flow.h>
 
 #ifdef __cplusplus
 extern "C" {
Signature · 1 line
2.25.1
#4 lore raw

PATCH 4/19 gpudev: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/gpudev/gpudev.c | 1 -
 1 file changed, 1 deletion(-)
lib/gpudev/gpudev.c +0 -1
index 56033f4a5f..ee3ae80f82 100644
@@ -9,7 +9,6 @@
 #include <rte_malloc.h>
 #include <rte_errno.h>
 #include <rte_log.h>
-#include <rte_eal_paging.h>
 
 #include "rte_gpudev.h"
 #include "gpudev_driver.h"
Signature · 1 line
2.25.1
#5 lore raw

PATCH 5/19 gso: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/gso/gso_common.c      | 1 -
 lib/gso/gso_common.h      | 1 -
 lib/gso/gso_tcp4.h        | 1 -
 lib/gso/gso_tunnel_tcp4.h | 1 -
 lib/gso/gso_tunnel_udp4.h | 1 -
 lib/gso/gso_udp4.h        | 1 -
 6 files changed, 6 deletions(-)
lib/gso/gso_common.c +0 -1
index 0fad1132fc..378bf2c6aa 100644
@@ -6,7 +6,6 @@
 #include <errno.h>
 
 #include <rte_memcpy.h>
-#include <rte_mempool.h>
 
 #include "gso_common.h"
 
lib/gso/gso_common.h +0 -1
index 2c258b22bf..9456d596d3 100644
@@ -7,7 +7,6 @@
 
 #include <stdint.h>
 
-#include <rte_mbuf.h>
 #include <rte_ip.h>
 #include <rte_tcp.h>
 #include <rte_udp.h>
lib/gso/gso_tcp4.h +0 -1
index 10d4b3acdd..7527fa51c9 100644
@@ -6,7 +6,6 @@
 #define _GSO_TCP4_H_
 
 #include <stdint.h>
-#include <rte_mbuf.h>
 
 /**
  * Segment an IPv4/TCP packet. This function doesn't check if the input
lib/gso/gso_tunnel_tcp4.h +0 -1
index c522ed27f2..3a7ea238c8 100644
@@ -6,7 +6,6 @@
 #define _GSO_TUNNEL_TCP4_H_
 
 #include <stdint.h>
-#include <rte_mbuf.h>
 
 /**
  * Segment a tunneling packet with inner TCP/IPv4 headers. This function
lib/gso/gso_tunnel_udp4.h +0 -1
index c49b43fe3e..214a69ccd5 100644
@@ -6,7 +6,6 @@
 #define _GSO_TUNNEL_UDP4_H_
 
 #include <stdint.h>
-#include <rte_mbuf.h>
 
 /**
  * Segment a tunneling packet with inner UDP/IPv4 headers. This function
lib/gso/gso_udp4.h +0 -1
index b2a2908e54..8baa0ba6db 100644
@@ -6,7 +6,6 @@
 #define _GSO_UDP4_H_
 
 #include <stdint.h>
-#include <rte_mbuf.h>
 
 /**
  * Segment an UDP/IPv4 packet. This function doesn't check if the input
Signature · 1 line
2.25.1
#6 lore raw

PATCH 6/19 hash: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/hash/rte_cuckoo_hash.c | 3 ---
 1 file changed, 3 deletions(-)
lib/hash/rte_cuckoo_hash.c +0 -3
index 490f94af4b..de7d941638 100644
@@ -10,7 +10,6 @@
 #include <sys/queue.h>
 
 #include <rte_common.h>
-#include <rte_memory.h>         /* for definition of RTE_CACHE_LINE_SIZE */
 #include <rte_log.h>
 #include <rte_prefetch.h>
 #include <rte_branch_prediction.h>
@@ -21,8 +20,6 @@
 #include <rte_cpuflags.h>
 #include <rte_rwlock.h>
 #include <rte_ring_elem.h>
-#include <rte_compat.h>
-#include <rte_vect.h>
 #include <rte_tailq.h>
 
 #include "rte_hash.h"
Signature · 1 line
2.25.1
#7 lore raw

PATCH 7/19 ip_frag: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/ip_frag/ip_frag_internal.c | 1 -
 1 file changed, 1 deletion(-)
lib/ip_frag/ip_frag_internal.c +0 -1
index b436a4c931..043b0ffba3 100644
@@ -4,7 +4,6 @@
 
 #include <stddef.h>
 
-#include <rte_jhash.h>
 #include <rte_hash_crc.h>
 
 #include "ip_frag_common.h"
Signature · 1 line
2.25.1
#8 lore raw

PATCH 8/19 jobstats: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/jobstats/rte_jobstats.h | 1 -
 1 file changed, 1 deletion(-)
lib/jobstats/rte_jobstats.h +0 -1
index 023d9dd15c..45b460e603 100644
@@ -8,7 +8,6 @@
 #include <stdint.h>
 
 #include <rte_memory.h>
-#include <rte_memcpy.h>
 
 #ifdef __cplusplus
 extern "C" {
Signature · 1 line
2.25.1
#9 lore raw

PATCH 9/19 mempool: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/mempool/rte_mempool.h | 1 -
 1 file changed, 1 deletion(-)
lib/mempool/rte_mempool.h +0 -1
index 3ada37cb86..8d6554fbae 100644
@@ -38,7 +38,6 @@
 #include <inttypes.h>
 
 #include <rte_config.h>
-#include <rte_spinlock.h>
 #include <rte_debug.h>
 #include <rte_lcore.h>
 #include <rte_branch_prediction.h>
Signature · 1 line
2.25.1
#10 lore raw

PATCH 10/19 meter: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/meter/rte_meter.c | 3 ---
 1 file changed, 3 deletions(-)
lib/meter/rte_meter.c +0 -3
index da01429a8b..4549b97d36 100644
@@ -2,12 +2,9 @@
  * Copyright(c) 2010-2014 Intel Corporation
  */
 
-#include <inttypes.h>
 #include <stdio.h>
 #include <math.h>
 
-#include <rte_common.h>
-#include <rte_log.h>
 #include <rte_cycles.h>
 
 #include "rte_meter.h"
Signature · 1 line
2.25.1
#11 lore raw

PATCH 11/19 net: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/net/rte_net.h | 1 -
 1 file changed, 1 deletion(-)
lib/net/rte_net.h +0 -1
index 53a7f4d360..56611fc8f9 100644
@@ -12,7 +12,6 @@ extern "C" {
 #include <rte_ip.h>
 #include <rte_udp.h>
 #include <rte_tcp.h>
-#include <rte_sctp.h>
 
 /**
  * Structure containing header lengths associated to a packet, filled
Signature · 1 line
2.25.1
#12 lore raw

PATCH 12/19 power: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/power/power_pstate_cpufreq.c | 1 -
 lib/power/rte_power_empty_poll.h | 3 ---
 lib/power/rte_power_pmd_mgmt.c   | 2 --
 lib/power/rte_power_pmd_mgmt.h   | 5 -----
 4 files changed, 11 deletions(-)
lib/power/power_pstate_cpufreq.c +0 -1
index f4c36179ec..959eccffd8 100644
@@ -8,7 +8,6 @@
 #include <unistd.h>
 #include <limits.h>
 #include <errno.h>
-#include <inttypes.h>
 
 #include <rte_memcpy.h>
 
lib/power/rte_power_empty_poll.h +0 -3
index 43fb276077..f6306fdcdf 100644
@@ -13,10 +13,7 @@
 #include <stdbool.h>
 
 #include <rte_common.h>
-#include <rte_byteorder.h>
-#include <rte_log.h>
 #include <rte_string_fns.h>
-#include <rte_power.h>
 #include <rte_timer.h>
 
 #ifdef __cplusplus
lib/power/rte_power_pmd_mgmt.c +0 -2
index 39a2b4cd23..e6fab9639e 100644
@@ -4,10 +4,8 @@
 
 #include <rte_lcore.h>
 #include <rte_cycles.h>
-#include <rte_cpuflags.h>
 #include <rte_malloc.h>
 #include <rte_ethdev.h>
-#include <rte_power_intrinsics.h>
 
 #include "rte_power_pmd_mgmt.h"
 
lib/power/rte_power_pmd_mgmt.h +0 -5
index 444e7b8a66..e83aec3484 100644
@@ -11,13 +11,8 @@
  */
 
 #include <stdint.h>
-#include <stdbool.h>
 
-#include <rte_common.h>
-#include <rte_byteorder.h>
-#include <rte_log.h>
 #include <rte_power.h>
-#include <rte_atomic.h>
 
 #ifdef __cplusplus
 extern "C" {
Signature · 1 line
2.25.1
#13 lore raw

PATCH 13/19 rawdev: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/rawdev/rte_rawdev.h | 1 -
 1 file changed, 1 deletion(-)
lib/rawdev/rte_rawdev.h +0 -1
index 14e8eb972f..66080eae9e 100644
@@ -20,7 +20,6 @@ extern "C" {
 
 #include <rte_common.h>
 #include <rte_memory.h>
-#include <rte_errno.h>
 
 /* Rawdevice object - essentially a void to be typecast by implementation */
 typedef void *rte_rawdev_obj_t;
Signature · 1 line
2.25.1
Acked-by on v1 13/19
#14 lore raw

RE: [PATCH v1 13/19] rawdev: remove unneeded header includes

Quoted 30 lines

-----Original Message-----
From: Sean Morrissey <[email protected]>
Sent: Friday, April 22, 2022 12:39 AM
To: Nipun Gupta <[email protected]>; Hemant Agrawal <[email protected]>
Cc: [email protected]; Sean Morrissey <[email protected]>
Subject: [PATCH v1 13/19] rawdev: remove unneeded header includes
Importance: High

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/rawdev/rte_rawdev.h | 1 -
 1 file changed, 1 deletion(-)
lib/rawdev/rte_rawdev.h index renamed from lib/rawdev/rte_rawdev.h +0 -0

14e8eb972f..66080eae9e 100644

lib/rawdev/rte_rawdev.h +0 -2
@@ -20,7 +20,6 @@ extern "C" {
 
 #include <rte_common.h>
 #include <rte_memory.h>
-#include <rte_errno.h>
 
 /* Rawdevice object - essentially a void to be typecast by implementation */
 typedef void *rte_rawdev_obj_t;
--

2.25.1

#15 lore raw

PATCH 14/19 regexdev: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/regexdev/rte_regexdev.h | 1 -
 1 file changed, 1 deletion(-)
lib/regexdev/rte_regexdev.h +0 -1
index 3bce8090f6..ce3dba5c10 100644
@@ -200,7 +200,6 @@ extern "C" {
 
 #include <rte_common.h>
 #include <rte_dev.h>
-#include <rte_mbuf.h>
 
 #define RTE_REGEXDEV_NAME_MAX_LEN RTE_DEV_NAME_MAX_LEN
 
Signature · 1 line
2.25.1
#16 lore raw

PATCH 15/19 sched: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/sched/rte_pie.c | 1 -
 1 file changed, 1 deletion(-)
lib/sched/rte_pie.c +0 -1
index d37b79e6dd..c84f75a18c 100644
@@ -6,7 +6,6 @@
 #include <string.h>
 
 #include "rte_pie.h"
-#include <rte_malloc.h>
 
 #ifdef __INTEL_COMPILER
 #pragma warning(disable:2259) /* conversion may lose significant bits */
Signature · 1 line
2.25.1
#17 lore raw

PATCH 16/19 stack: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/stack/rte_stack.h | 1 -
 1 file changed, 1 deletion(-)
lib/stack/rte_stack.h +0 -1
index 91fc570767..af8c3804f3 100644
@@ -22,7 +22,6 @@ extern "C" {
 #include <rte_debug.h>
 #include <rte_errno.h>
 #include <rte_memzone.h>
-#include <rte_spinlock.h>
 
 #define RTE_TAILQ_STACK_NAME "RTE_STACK"
 #define RTE_STACK_MZ_PREFIX "STK_"
Signature · 1 line
2.25.1
#18 lore raw

Re: [PATCH v1 16/19] stack: remove unneeded header includes

Quoted 13 lines · On Thu, 21 Apr 2022 19:08:56 +0000 Sean Morrissey <[email protected]>…

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/stack/rte_stack.h | 1 -
 1 file changed, 1 deletion(-)
lib/stack/rte_stack.h +0 -0
index 91fc570767..af8c3804f3 100644

lib/stack/rte_stack.h extern "C" { · line 25

Quoted 4 lines
lib/stack/rte_stack.h +0 -1
@@ -22,7 +22,6 @@ extern "C" {
 #include <rte_debug.h>
 #include <rte_errno.h>
 #include <rte_memzone.h>
-#include <rte_spinlock.h>

This file is using rte_spinlock_t so where is it getting defined?

#19 lore raw

PATCH 17/19 table: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/table/rte_swx_table_learner.c | 1 -
 1 file changed, 1 deletion(-)
lib/table/rte_swx_table_learner.c +0 -1
index 15576c2aa3..f9d4d7faac 100644
@@ -6,7 +6,6 @@
 #include <errno.h>
 
 #include <rte_common.h>
-#include <rte_cycles.h>
 #include <rte_prefetch.h>
 
 #include "rte_swx_table_learner.h"
Signature · 1 line
2.25.1
#20 lore raw

Re: [PATCH v1 17/19] table: remove unneeded header includes

Quoted 13 lines · On Thu, 21 Apr 2022 19:08:57 +0000 Sean Morrissey <[email protected]>…

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/table/rte_swx_table_learner.c | 1 -
 1 file changed, 1 deletion(-)
lib/table/rte_swx_table_learner.c +0 -0
index 15576c2aa3..f9d4d7faac 100644

lib/table/rte_swx_table_learner.c line 11

Quoted 7 lines
lib/table/rte_swx_table_learner.c +0 -1
@@ -6,7 +6,6 @@
 #include <errno.h>
 
 #include <rte_common.h>
-#include <rte_cycles.h>
 #include <rte_prefetch.h>
 
 #include "rte_swx_table_learner.h"

This file is using rte_get_tsc_hz(), where is that getting defined?

#21 lore raw

PATCH 18/19 timer: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/timer/rte_timer.c | 3 ---
 lib/timer/rte_timer.h | 2 --
 2 files changed, 5 deletions(-)
lib/timer/rte_timer.c +0 -3
index c51a393e5c..f52ccc33ed 100644
@@ -5,12 +5,9 @@
 #include <stdio.h>
 #include <stdint.h>
 #include <stdbool.h>
-#include <inttypes.h>
 #include <assert.h>
-#include <sys/queue.h>
 
 #include <rte_common.h>
-#include <rte_cycles.h>
 #include <rte_eal_memconfig.h>
 #include <rte_memory.h>
 #include <rte_lcore.h>
lib/timer/rte_timer.h +0 -2
index 0f820555c0..503438a36b 100644
@@ -36,9 +36,7 @@
 
 #include <stdio.h>
 #include <stdint.h>
-#include <stddef.h>
 #include <rte_common.h>
-#include <rte_config.h>
 #include <rte_spinlock.h>
 
 #ifdef __cplusplus
Signature · 1 line
2.25.1
#22 lore raw

Re: [PATCH v1 18/19] timer: remove unneeded header includes

Quoted 7 lines · On Thu, 21 Apr 2022 19:08:58 +0000 Sean Morrissey <[email protected]>…
lib/timer/rte_timer.c +0 -0
index c51a393e5c..f52ccc33ed 100644
@@ -5,12 +5,9 @@
 #include <stdio.h>
 #include <stdint.h>

lib/timer/rte_timer.c line 13

Quoted 10 lines
lib/timer/rte_timer.c +0 -3
 #include <stdbool.h>
-#include <inttypes.h>
 #include <assert.h>
-#include <sys/queue.h>
 
 #include <rte_common.h>
-#include <rte_cycles.h>
 #include <rte_eal_memconfig.h>
 #include <rte_memory.h>
 #include <rte_lcore.h>

This doesn't look right.

rte_timer.c relies on rte_get_timer_cycles() which is defined in rte_cycles.h

Perhaps iwyu is getting confused, or thinking that is already covered by another include file?

#23 lore raw

Re: [PATCH v1 18/19] timer: remove unneeded header includes

Quoted 22 lines · Stephen Hemminger
Quoted 7 lines · On Thu, 21 Apr 2022 19:08:58 +0000 Sean Morrissey <[email protected]>…
lib/timer/rte_timer.c +0 -0
index c51a393e5c..f52ccc33ed 100644
@@ -5,12 +5,9 @@
  #include <stdio.h>
  #include <stdint.h>

lib/timer/rte_timer.c line 13

Quoted 10 lines
lib/timer/rte_timer.c +0 -3
  #include <stdbool.h>
-#include <inttypes.h>
  #include <assert.h>
-#include <sys/queue.h>
 
  #include <rte_common.h>
-#include <rte_cycles.h>
  #include <rte_eal_memconfig.h>
  #include <rte_memory.h>
  #include <rte_lcore.h>

This doesn't look right.

Quoted 5 lines

rte_timer.c relies on rte_get_timer_cycles() which is defined in rte_cycles.h

Perhaps iwyu is getting confused, or thinking that is already covered by another include file?

IWYU can throw false positives.

Please let me fix all build issues with this patchset and get back to you. It could re-introduce the header in question. If not I will investigate where IWYU believes the include is coming from.

Typically the headers removed by this tool are usually already included from a daisy chain of includes from another header.

#24 lore raw

PATCH 19/19 vhost: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/vhost/vhost.h      | 3 ---
 lib/vhost/vhost_user.h | 1 -
 2 files changed, 4 deletions(-)
lib/vhost/vhost.h +0 -3
index a9edc271aa..711bb8cd83 100644
@@ -7,12 +7,9 @@
 #include <stdint.h>
 #include <stdio.h>
 #include <stdbool.h>
-#include <sys/types.h>
 #include <sys/queue.h>
 #include <unistd.h>
-#include <linux/vhost.h>
 #include <linux/virtio_net.h>
-#include <sys/socket.h>
 #include <linux/if.h>
 
 #include <rte_log.h>
lib/vhost/vhost_user.h +0 -1
index c946cc2ef4..8d216c380f 100644
@@ -6,7 +6,6 @@
 #define _VHOST_NET_USER_H
 
 #include <stdint.h>
-#include <linux/vhost.h>
 
 #include "rte_vhost.h"
 
Signature · 1 line
2.25.1
#25 lore raw

v2 cover remove IWYU flagged headers

In reply to Sean Morrissey

This patchset removes unused header includes flagged by the IWYU tool for the 22.07 release.

V2:
* Fix various build issues.

Sean Morrissey (19):
cmdline: remove unneeded header includes
eal: remove unneeded header includes
ethdev: remove unneeded header includes
gpudev: remove unneeded header includes
gso: remove unneeded header includes
hash: remove unneeded header includes
ip_frag: remove unneeded header includes
jobstats: remove unneeded header includes
mempool: remove unneeded header includes
meter: remove unneeded header includes
net: remove unneeded header includes
power: remove unneeded header includes
rawdev: remove unneeded header includes
regexdev: remove unneeded header includes
sched: remove unneeded header includes
stack: remove unneeded header includes
table: remove unneeded header includes
timer: remove unneeded header includes
vhost: remove unneeded header includes

 lib/cmdline/cmdline_cirbuf.h       | 1 -
 lib/cmdline/cmdline_parse_num.c    | 3 ---
 lib/cmdline/cmdline_socket.c       | 4 ----
 lib/cmdline/cmdline_socket.h       | 1 -
 lib/eal/common/eal_common_config.c | 1 -
 lib/eal/common/eal_common_launch.c | 1 -
 lib/eal/common/eal_common_log.c    | 1 -
 lib/eal/linux/eal.c                | 1 -
 lib/eal/linux/eal_thread.c         | 6 ------
 lib/eal/linux/eal_vfio.c           | 1 -
 lib/eal/unix/eal_filesystem.c      | 2 --
 lib/ethdev/rte_class_eth.c         | 2 --
 lib/ethdev/rte_ethdev.c            | 9 ---------
 lib/ethdev/rte_ethdev.h            | 1 -
 lib/ethdev/rte_flow.c              | 2 --
 lib/ethdev/rte_flow.h              | 3 ---
 lib/ethdev/rte_mtr.c               | 1 -
 lib/gpudev/gpudev.c                | 1 -
 lib/gso/gso_common.c               | 1 -
 lib/gso/gso_common.h               | 1 -
 lib/gso/gso_tcp4.h                 | 1 -
 lib/gso/gso_tunnel_tcp4.h          | 1 -
 lib/gso/gso_tunnel_udp4.h          | 1 -
 lib/gso/gso_udp4.h                 | 1 -
 lib/hash/rte_cuckoo_hash.c         | 3 ---
 lib/ip_frag/ip_frag_internal.c     | 1 -
 lib/jobstats/rte_jobstats.h        | 1 -
 lib/mempool/rte_mempool.h          | 1 -
 lib/meter/rte_meter.c              | 3 ---
 lib/net/rte_net.h                  | 1 -
 lib/power/power_pstate_cpufreq.c   | 1 -
 lib/power/rte_power_empty_poll.h   | 3 ---
 lib/power/rte_power_pmd_mgmt.c     | 2 --
 lib/power/rte_power_pmd_mgmt.h     | 5 -----
 lib/rawdev/rte_rawdev.h            | 1 -
 lib/regexdev/rte_regexdev.h        | 1 -
 lib/sched/rte_pie.c                | 1 -
 lib/stack/rte_stack.h              | 1 -
 lib/table/rte_swx_table_learner.c  | 1 -
 lib/timer/rte_timer.c              | 2 --
 lib/timer/rte_timer.h              | 2 --
 lib/vhost/vhost.h                  | 2 --
 lib/vhost/vhost_user.h             | 1 -
 43 files changed, 80 deletions(-)
Signature · 1 line
2.25.1
#26 lore raw

PATCH v2 1/19 cmdline: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/cmdline/cmdline_cirbuf.h    | 1 -
 lib/cmdline/cmdline_parse_num.c | 3 ---
 lib/cmdline/cmdline_socket.c    | 4 ----
 lib/cmdline/cmdline_socket.h    | 1 -
 4 files changed, 9 deletions(-)
lib/cmdline/cmdline_cirbuf.h +0 -1
index c23b211ad4..c58fdabf00 100644
@@ -7,7 +7,6 @@
 #ifndef _CIRBUF_H_
 #define _CIRBUF_H_
 
-#include <rte_config.h>
 
 #ifdef __cplusplus
 extern "C" {
lib/cmdline/cmdline_parse_num.c +0 -3
index b37dd94ae9..820af071fb 100644
@@ -7,10 +7,7 @@
 #include <stdio.h>
 #include <stdint.h>
 #include <inttypes.h>
-#include <ctype.h>
 #include <string.h>
-#include <stdarg.h>
-#include <errno.h>
 #include <rte_string_fns.h>
 
 #include "cmdline_parse.h"
lib/cmdline/cmdline_socket.c +0 -4
index ebd5343754..78fb67c474 100644
@@ -5,11 +5,7 @@
  */
 
 #include <stdio.h>
-#include <string.h>
 #include <unistd.h>
-#include <stdlib.h>
-#include <stdarg.h>
-#include <inttypes.h>
 #include <fcntl.h>
 
 #include "cmdline.h"
lib/cmdline/cmdline_socket.h +0 -1
index 80542e5599..a9c4ea26ad 100644
@@ -8,7 +8,6 @@
 #define _CMDLINE_SOCKET_H_
 
 #include <cmdline_parse.h>
-#include <cmdline.h>
 
 #ifdef __cplusplus
 extern "C" {
Signature · 1 line
2.25.1
#27 lore raw

PATCH v2 2/19 eal: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/eal/common/eal_common_config.c | 1 -
 lib/eal/common/eal_common_launch.c | 1 -
 lib/eal/common/eal_common_log.c    | 1 -
 lib/eal/linux/eal.c                | 1 -
 lib/eal/linux/eal_thread.c         | 6 ------
 lib/eal/linux/eal_vfio.c           | 1 -
 lib/eal/unix/eal_filesystem.c      | 2 --
 7 files changed, 13 deletions(-)
lib/eal/common/eal_common_config.c +0 -1
index 3cef43a4f7..0daf0f3188 100644
@@ -1,7 +1,6 @@
 /* SPDX-License-Identifier: BSD-3-Clause
  * Copyright(c) 2020 Mellanox Technologies, Ltd
  */
-#include <string.h>
 
 #include <rte_string_fns.h>
 
lib/eal/common/eal_common_launch.c +0 -1
index 992f8e4631..462c886e30 100644
@@ -6,7 +6,6 @@
 
 #include <rte_launch.h>
 #include <rte_eal_trace.h>
-#include <rte_atomic.h>
 #include <rte_pause.h>
 #include <rte_lcore.h>
 
lib/eal/common/eal_common_log.c +0 -1
index d57dca9785..bd7b188ceb 100644
@@ -13,7 +13,6 @@
 #include <sys/queue.h>
 
 #include <rte_log.h>
-#include <rte_os_shim.h>
 #include <rte_per_lcore.h>
 
 #include "eal_log.h"
lib/eal/linux/eal.c +0 -1
index 1ef263434a..1390b6cf47 100644
@@ -34,7 +34,6 @@
 #include <rte_service_component.h>
 #include <rte_log.h>
 #include <rte_string_fns.h>
-#include <rte_cpuflags.h>
 #include <rte_bus.h>
 #include <rte_version.h>
 #include <malloc_heap.h>
lib/eal/linux/eal_thread.c +0 -6
index 820cc905e0..e9294127d1 100644
@@ -4,20 +4,14 @@
 
 #include <errno.h>
 #include <stdio.h>
-#include <stdint.h>
 #include <unistd.h>
 #include <pthread.h>
 #include <sys/syscall.h>
 
-#include <rte_debug.h>
-#include <rte_launch.h>
-#include <rte_log.h>
 #include <rte_eal.h>
 #include <rte_lcore.h>
 #include <rte_string_fns.h>
 
-#include "eal_private.h"
-#include "eal_thread.h"
 
 /* require calling thread tid by gettid() */
 int rte_sys_gettid(void)
lib/eal/linux/eal_vfio.c +0 -1
index 549b86ae1d..c4fd7d63b0 100644
@@ -15,7 +15,6 @@
 #include <rte_vfio.h>
 
 #include "eal_filesystem.h"
-#include "eal_memcfg.h"
 #include "eal_vfio.h"
 #include "eal_private.h"
 #include "eal_internal_cfg.h"
lib/eal/unix/eal_filesystem.c +0 -2
index 094a2bf7e4..afbab9368a 100644
@@ -10,10 +10,8 @@
 #include <stdlib.h>
 #include <string.h>
 #include <sys/stat.h>
-#include <sys/types.h>
 #include <unistd.h>
 
-#include <rte_common.h>
 #include <rte_log.h>
 
 #include "eal_private.h"
Signature · 1 line
2.25.1
#28 lore raw

PATCH v2 3/19 ethdev: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/ethdev/rte_class_eth.c | 2 --
 lib/ethdev/rte_ethdev.c    | 9 ---------
 lib/ethdev/rte_ethdev.h    | 1 -
 lib/ethdev/rte_flow.c      | 2 --
 lib/ethdev/rte_flow.h      | 3 ---
 lib/ethdev/rte_mtr.c       | 1 -
 6 files changed, 18 deletions(-)
lib/ethdev/rte_class_eth.c +0 -2
index c8e8fc9244..3be84dd45c 100644
@@ -5,13 +5,11 @@
 #include <string.h>
 
 #include <rte_class.h>
-#include <rte_compat.h>
 #include <rte_errno.h>
 #include <rte_kvargs.h>
 #include <rte_log.h>
 
 #include "rte_ethdev.h"
-#include "rte_ethdev_core.h"
 #include "ethdev_driver.h"
 #include "ethdev_private.h"
 
lib/ethdev/rte_ethdev.c +0 -9
index 90e50eb02b..1979dc0850 100644
@@ -11,18 +11,9 @@
 #include <string.h>
 #include <sys/queue.h>
 
-#include <rte_byteorder.h>
 #include <rte_log.h>
-#include <rte_debug.h>
 #include <rte_interrupts.h>
-#include <rte_memory.h>
 #include <rte_memcpy.h>
-#include <rte_memzone.h>
-#include <rte_launch.h>
-#include <rte_eal.h>
-#include <rte_per_lcore.h>
-#include <rte_lcore.h>
-#include <rte_branch_prediction.h>
 #include <rte_common.h>
 #include <rte_mempool.h>
 #include <rte_malloc.h>
lib/ethdev/rte_ethdev.h +0 -1
index 045ee64747..de9e970d4d 100644
@@ -169,7 +169,6 @@ extern "C" {
 #include <rte_errno.h>
 #include <rte_common.h>
 #include <rte_config.h>
-#include <rte_ether.h>
 #include <rte_power_intrinsics.h>
 
 #include "rte_ethdev_trace_fp.h"
lib/ethdev/rte_flow.c +0 -2
index 2c35a2f13e..501be9d602 100644
@@ -6,13 +6,11 @@
 #include <errno.h>
 #include <stddef.h>
 #include <stdint.h>
-#include <string.h>
 
 #include <rte_common.h>
 #include <rte_errno.h>
 #include <rte_branch_prediction.h>
 #include <rte_string_fns.h>
-#include <rte_mbuf.h>
 #include <rte_mbuf_dyn.h>
 #include "rte_ethdev.h"
 #include "rte_flow_driver.h"
lib/ethdev/rte_flow.h +0 -3
index 1b56f23cba..a79f1e7ef0 100644
@@ -17,7 +17,6 @@
 #include <stddef.h>
 #include <stdint.h>
 
-#include <rte_arp.h>
 #include <rte_common.h>
 #include <rte_ether.h>
 #include <rte_icmp.h>
@@ -26,12 +25,10 @@
 #include <rte_tcp.h>
 #include <rte_udp.h>
 #include <rte_vxlan.h>
-#include <rte_byteorder.h>
 #include <rte_esp.h>
 #include <rte_higig.h>
 #include <rte_ecpri.h>
 #include <rte_bitops.h>
-#include <rte_mbuf.h>
 #include <rte_mbuf_dyn.h>
 #include <rte_meter.h>
 #include <rte_gtp.h>
lib/ethdev/rte_mtr.c +0 -1
index 441ea1dca9..c460e4f4e0 100644
@@ -5,7 +5,6 @@
 #include <stdint.h>
 
 #include <rte_errno.h>
-#include "rte_compat.h"
 #include "rte_ethdev.h"
 #include "rte_mtr_driver.h"
 #include "rte_mtr.h"
Signature · 1 line
2.25.1
#29 lore raw

PATCH v2 4/19 gpudev: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/gpudev/gpudev.c | 1 -
 1 file changed, 1 deletion(-)
lib/gpudev/gpudev.c +0 -1
index 56033f4a5f..ee3ae80f82 100644
@@ -9,7 +9,6 @@
 #include <rte_malloc.h>
 #include <rte_errno.h>
 #include <rte_log.h>
-#include <rte_eal_paging.h>
 
 #include "rte_gpudev.h"
 #include "gpudev_driver.h"
Signature · 1 line
2.25.1
#30 lore raw

PATCH v2 5/19 gso: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/gso/gso_common.c      | 1 -
 lib/gso/gso_common.h      | 1 -
 lib/gso/gso_tcp4.h        | 1 -
 lib/gso/gso_tunnel_tcp4.h | 1 -
 lib/gso/gso_tunnel_udp4.h | 1 -
 lib/gso/gso_udp4.h        | 1 -
 6 files changed, 6 deletions(-)
lib/gso/gso_common.c +0 -1
index 0fad1132fc..378bf2c6aa 100644
@@ -6,7 +6,6 @@
 #include <errno.h>
 
 #include <rte_memcpy.h>
-#include <rte_mempool.h>
 
 #include "gso_common.h"
 
lib/gso/gso_common.h +0 -1
index 2c258b22bf..9456d596d3 100644
@@ -7,7 +7,6 @@
 
 #include <stdint.h>
 
-#include <rte_mbuf.h>
 #include <rte_ip.h>
 #include <rte_tcp.h>
 #include <rte_udp.h>
lib/gso/gso_tcp4.h +0 -1
index 10d4b3acdd..7527fa51c9 100644
@@ -6,7 +6,6 @@
 #define _GSO_TCP4_H_
 
 #include <stdint.h>
-#include <rte_mbuf.h>
 
 /**
  * Segment an IPv4/TCP packet. This function doesn't check if the input
lib/gso/gso_tunnel_tcp4.h +0 -1
index c522ed27f2..3a7ea238c8 100644
@@ -6,7 +6,6 @@
 #define _GSO_TUNNEL_TCP4_H_
 
 #include <stdint.h>
-#include <rte_mbuf.h>
 
 /**
  * Segment a tunneling packet with inner TCP/IPv4 headers. This function
lib/gso/gso_tunnel_udp4.h +0 -1
index c49b43fe3e..214a69ccd5 100644
@@ -6,7 +6,6 @@
 #define _GSO_TUNNEL_UDP4_H_
 
 #include <stdint.h>
-#include <rte_mbuf.h>
 
 /**
  * Segment a tunneling packet with inner UDP/IPv4 headers. This function
lib/gso/gso_udp4.h +0 -1
index b2a2908e54..8baa0ba6db 100644
@@ -6,7 +6,6 @@
 #define _GSO_UDP4_H_
 
 #include <stdint.h>
-#include <rte_mbuf.h>
 
 /**
  * Segment an UDP/IPv4 packet. This function doesn't check if the input
Signature · 1 line
2.25.1
#31 lore raw

PATCH v2 6/19 hash: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/hash/rte_cuckoo_hash.c | 3 ---
 1 file changed, 3 deletions(-)
lib/hash/rte_cuckoo_hash.c +0 -3
index 490f94af4b..de7d941638 100644
@@ -10,7 +10,6 @@
 #include <sys/queue.h>
 
 #include <rte_common.h>
-#include <rte_memory.h>         /* for definition of RTE_CACHE_LINE_SIZE */
 #include <rte_log.h>
 #include <rte_prefetch.h>
 #include <rte_branch_prediction.h>
@@ -21,8 +20,6 @@
 #include <rte_cpuflags.h>
 #include <rte_rwlock.h>
 #include <rte_ring_elem.h>
-#include <rte_compat.h>
-#include <rte_vect.h>
 #include <rte_tailq.h>
 
 #include "rte_hash.h"
Signature · 1 line
2.25.1
#32 lore raw

PATCH v2 7/19 ip_frag: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/ip_frag/ip_frag_internal.c | 1 -
 1 file changed, 1 deletion(-)
lib/ip_frag/ip_frag_internal.c +0 -1
index b436a4c931..043b0ffba3 100644
@@ -4,7 +4,6 @@
 
 #include <stddef.h>
 
-#include <rte_jhash.h>
 #include <rte_hash_crc.h>
 
 #include "ip_frag_common.h"
Signature · 1 line
2.25.1
#33 lore raw

PATCH v2 8/19 jobstats: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/jobstats/rte_jobstats.h | 1 -
 1 file changed, 1 deletion(-)
lib/jobstats/rte_jobstats.h +0 -1
index 023d9dd15c..45b460e603 100644
@@ -8,7 +8,6 @@
 #include <stdint.h>
 
 #include <rte_memory.h>
-#include <rte_memcpy.h>
 
 #ifdef __cplusplus
 extern "C" {
Signature · 1 line
2.25.1
#34 lore raw

PATCH v2 9/19 mempool: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/mempool/rte_mempool.h | 1 -
 1 file changed, 1 deletion(-)
lib/mempool/rte_mempool.h +0 -1
index 3ada37cb86..8d6554fbae 100644
@@ -38,7 +38,6 @@
 #include <inttypes.h>
 
 #include <rte_config.h>
-#include <rte_spinlock.h>
 #include <rte_debug.h>
 #include <rte_lcore.h>
 #include <rte_branch_prediction.h>
Signature · 1 line
2.25.1
#35 lore raw

PATCH v2 10/19 meter: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/meter/rte_meter.c | 3 ---
 1 file changed, 3 deletions(-)
lib/meter/rte_meter.c +0 -3
index da01429a8b..4549b97d36 100644
@@ -2,12 +2,9 @@
  * Copyright(c) 2010-2014 Intel Corporation
  */
 
-#include <inttypes.h>
 #include <stdio.h>
 #include <math.h>
 
-#include <rte_common.h>
-#include <rte_log.h>
 #include <rte_cycles.h>
 
 #include "rte_meter.h"
Signature · 1 line
2.25.1
#36 lore raw

PATCH v2 11/19 net: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/net/rte_net.h | 1 -
 1 file changed, 1 deletion(-)
lib/net/rte_net.h +0 -1
index 53a7f4d360..56611fc8f9 100644
@@ -12,7 +12,6 @@ extern "C" {
 #include <rte_ip.h>
 #include <rte_udp.h>
 #include <rte_tcp.h>
-#include <rte_sctp.h>
 
 /**
  * Structure containing header lengths associated to a packet, filled
Signature · 1 line
2.25.1
#37 lore raw

PATCH v2 12/19 power: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/power/power_pstate_cpufreq.c | 1 -
 lib/power/rte_power_empty_poll.h | 3 ---
 lib/power/rte_power_pmd_mgmt.c   | 2 --
 lib/power/rte_power_pmd_mgmt.h   | 5 -----
 4 files changed, 11 deletions(-)
lib/power/power_pstate_cpufreq.c +0 -1
index 78c9197695..fc258157a8 100644
@@ -8,7 +8,6 @@
 #include <unistd.h>
 #include <limits.h>
 #include <errno.h>
-#include <inttypes.h>
 
 #include <rte_memcpy.h>
 
lib/power/rte_power_empty_poll.h +0 -3
index 43fb276077..f6306fdcdf 100644
@@ -13,10 +13,7 @@
 #include <stdbool.h>
 
 #include <rte_common.h>
-#include <rte_byteorder.h>
-#include <rte_log.h>
 #include <rte_string_fns.h>
-#include <rte_power.h>
 #include <rte_timer.h>
 
 #ifdef __cplusplus
lib/power/rte_power_pmd_mgmt.c +0 -2
index a66e08e574..7f445479bb 100644
@@ -4,10 +4,8 @@
 
 #include <rte_lcore.h>
 #include <rte_cycles.h>
-#include <rte_cpuflags.h>
 #include <rte_malloc.h>
 #include <rte_ethdev.h>
-#include <rte_power_intrinsics.h>
 
 #include "rte_power_pmd_mgmt.h"
 #include "power_common.h"
lib/power/rte_power_pmd_mgmt.h +0 -5
index 789fbe0e4d..c5a420861c 100644
@@ -11,13 +11,8 @@
  */
 
 #include <stdint.h>
-#include <stdbool.h>
 
-#include <rte_common.h>
-#include <rte_byteorder.h>
-#include <rte_log.h>
 #include <rte_power.h>
-#include <rte_atomic.h>
 
 #ifdef __cplusplus
 extern "C" {
Signature · 1 line
2.25.1
#38 lore raw

PATCH v2 13/19 rawdev: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/rawdev/rte_rawdev.h | 1 -
 1 file changed, 1 deletion(-)
lib/rawdev/rte_rawdev.h +0 -1
index 14e8eb972f..66080eae9e 100644
@@ -20,7 +20,6 @@ extern "C" {
 
 #include <rte_common.h>
 #include <rte_memory.h>
-#include <rte_errno.h>
 
 /* Rawdevice object - essentially a void to be typecast by implementation */
 typedef void *rte_rawdev_obj_t;
Signature · 1 line
2.25.1
Acked-by on v2 13/19
#39 lore raw

RE: [PATCH v2 13/19] rawdev: remove unneeded header includes

Quoted 30 lines

-----Original Message-----
From: Sean Morrissey <[email protected]>
Sent: Thursday, June 16, 2022 8:47 PM
To: Sachin Saxena (OSS) <[email protected]>; Hemant Agrawal <[email protected]>
Cc: [email protected]; Sean Morrissey <[email protected]>
Subject: [PATCH v2 13/19] rawdev: remove unneeded header includes
Importance: High

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/rawdev/rte_rawdev.h | 1 -
 1 file changed, 1 deletion(-)
lib/rawdev/rte_rawdev.h index renamed from lib/rawdev/rte_rawdev.h +0 -0

14e8eb972f..66080eae9e 100644

lib/rawdev/rte_rawdev.h +0 -2
@@ -20,7 +20,6 @@ extern "C" {
 
 #include <rte_common.h>
 #include <rte_memory.h>
-#include <rte_errno.h>
 
 /* Rawdevice object - essentially a void to be typecast by implementation */
 typedef void *rte_rawdev_obj_t;
--

2.25.1

#40 lore raw

PATCH v2 14/19 regexdev: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/regexdev/rte_regexdev.h | 1 -
 1 file changed, 1 deletion(-)
lib/regexdev/rte_regexdev.h +0 -1
index 3bce8090f6..ce3dba5c10 100644
@@ -200,7 +200,6 @@ extern "C" {
 
 #include <rte_common.h>
 #include <rte_dev.h>
-#include <rte_mbuf.h>
 
 #define RTE_REGEXDEV_NAME_MAX_LEN RTE_DEV_NAME_MAX_LEN
 
Signature · 1 line
2.25.1
#41 lore raw

PATCH v2 15/19 sched: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/sched/rte_pie.c | 1 -
 1 file changed, 1 deletion(-)
lib/sched/rte_pie.c +0 -1
index d37b79e6dd..c84f75a18c 100644
@@ -6,7 +6,6 @@
 #include <string.h>
 
 #include "rte_pie.h"
-#include <rte_malloc.h>
 
 #ifdef __INTEL_COMPILER
 #pragma warning(disable:2259) /* conversion may lose significant bits */
Signature · 1 line
2.25.1
#42 lore raw

PATCH v2 16/19 stack: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/stack/rte_stack.h | 1 -
 1 file changed, 1 deletion(-)
lib/stack/rte_stack.h +0 -1
index 91fc570767..af8c3804f3 100644
@@ -22,7 +22,6 @@ extern "C" {
 #include <rte_debug.h>
 #include <rte_errno.h>
 #include <rte_memzone.h>
-#include <rte_spinlock.h>
 
 #define RTE_TAILQ_STACK_NAME "RTE_STACK"
 #define RTE_STACK_MZ_PREFIX "STK_"
Signature · 1 line
2.25.1
#43 lore raw

PATCH v2 17/19 table: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/table/rte_swx_table_learner.c | 1 -
 1 file changed, 1 deletion(-)
lib/table/rte_swx_table_learner.c +0 -1
index f7f8e8aea9..3502cbd2a4 100644
@@ -6,7 +6,6 @@
 #include <errno.h>
 
 #include <rte_common.h>
-#include <rte_cycles.h>
 #include <rte_prefetch.h>
 
 #include "rte_swx_table_learner.h"
Signature · 1 line
2.25.1
#44 lore raw

PATCH v2 18/19 timer: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/timer/rte_timer.c | 2 --
 lib/timer/rte_timer.h | 2 --
 2 files changed, 4 deletions(-)
lib/timer/rte_timer.c +0 -2
index c51a393e5c..d914fcbf60 100644
@@ -7,10 +7,8 @@
 #include <stdbool.h>
 #include <inttypes.h>
 #include <assert.h>
-#include <sys/queue.h>
 
 #include <rte_common.h>
-#include <rte_cycles.h>
 #include <rte_eal_memconfig.h>
 #include <rte_memory.h>
 #include <rte_lcore.h>
lib/timer/rte_timer.h +0 -2
index 0f820555c0..503438a36b 100644
@@ -36,9 +36,7 @@
 
 #include <stdio.h>
 #include <stdint.h>
-#include <stddef.h>
 #include <rte_common.h>
-#include <rte_config.h>
 #include <rte_spinlock.h>
 
 #ifdef __cplusplus
Signature · 1 line
2.25.1
#45 lore raw

PATCH v2 19/19 vhost: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/vhost/vhost.h      | 2 --
 lib/vhost/vhost_user.h | 1 -
 2 files changed, 3 deletions(-)
lib/vhost/vhost.h +0 -2
index 14235aaf81..4ebcb7448a 100644
@@ -7,10 +7,8 @@
 #include <stdint.h>
 #include <stdio.h>
 #include <stdbool.h>
-#include <sys/types.h>
 #include <sys/queue.h>
 #include <unistd.h>
-#include <linux/vhost.h>
 #include <linux/virtio_net.h>
 #include <sys/socket.h>
 #include <linux/if.h>
lib/vhost/vhost_user.h +0 -1
index c4d091e175..8ecca68597 100644
@@ -6,7 +6,6 @@
 #define _VHOST_NET_USER_H
 
 #include <stdint.h>
-#include <linux/vhost.h>
 
 #include "rte_vhost.h"
 
Signature · 1 line
2.25.1
#46 lore raw

v3 cover remove IWYU flagged headers

In reply to Sean Morrissey

This patchset removes unused header includes flagged by the IWYU tool for the 22.07 release.

V3:
* Fix more linux build issues.
V2:
* Fix various build issues.

Sean Morrissey (18):
cmdline: remove unneeded header includes
eal: remove unneeded header includes
ethdev: remove unneeded header includes
gpudev: remove unneeded header includes
gso: remove unneeded header includes
hash: remove unneeded header includes
ip_frag: remove unneeded header includes
jobstats: remove unneeded header includes
meter: remove unneeded header includes
net: remove unneeded header includes
power: remove unneeded header includes
rawdev: remove unneeded header includes
regexdev: remove unneeded header includes
sched: remove unneeded header includes
stack: remove unneeded header includes
table: remove unneeded header includes
timer: remove unneeded header includes
vhost: remove unneeded header includes

 lib/cmdline/cmdline_cirbuf.h       | 1 -
 lib/cmdline/cmdline_parse_num.c    | 3 ---
 lib/cmdline/cmdline_socket.c       | 4 ----
 lib/cmdline/cmdline_socket.h       | 1 -
 lib/eal/common/eal_common_config.c | 1 -
 lib/eal/common/eal_common_launch.c | 1 -
 lib/eal/common/eal_common_log.c    | 1 -
 lib/eal/linux/eal_thread.c         | 6 ------
 lib/eal/unix/eal_filesystem.c      | 2 --
 lib/ethdev/rte_class_eth.c         | 2 --
 lib/ethdev/rte_ethdev.c            | 9 ---------
 lib/ethdev/rte_ethdev.h            | 1 -
 lib/ethdev/rte_flow.c              | 2 --
 lib/ethdev/rte_flow.h              | 3 ---
 lib/ethdev/rte_mtr.c               | 1 -
 lib/gpudev/gpudev.c                | 1 -
 lib/gso/gso_common.c               | 1 -
 lib/gso/gso_common.h               | 1 -
 lib/gso/gso_tcp4.h                 | 1 -
 lib/gso/gso_tunnel_tcp4.h          | 1 -
 lib/gso/gso_tunnel_udp4.h          | 1 -
 lib/gso/gso_udp4.h                 | 1 -
 lib/hash/rte_cuckoo_hash.c         | 3 ---
 lib/ip_frag/ip_frag_internal.c     | 1 -
 lib/jobstats/rte_jobstats.h        | 1 -
 lib/meter/rte_meter.c              | 3 ---
 lib/net/rte_net.h                  | 1 -
 lib/power/rte_power_empty_poll.h   | 3 ---
 lib/power/rte_power_pmd_mgmt.c     | 2 --
 lib/power/rte_power_pmd_mgmt.h     | 4 ----
 lib/rawdev/rte_rawdev.h            | 1 -
 lib/regexdev/rte_regexdev.h        | 1 -
 lib/sched/rte_pie.c                | 1 -
 lib/stack/rte_stack.h              | 1 -
 lib/table/rte_swx_table_learner.c  | 1 -
 lib/timer/rte_timer.c              | 2 --
 lib/timer/rte_timer.h              | 2 --
 lib/vhost/vhost.h                  | 2 --
 lib/vhost/vhost_user.h             | 1 -
 39 files changed, 75 deletions(-)
Signature · 1 line
2.25.1
#47 lore raw

PATCH v3 1/18 cmdline: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/cmdline/cmdline_cirbuf.h    | 1 -
 lib/cmdline/cmdline_parse_num.c | 3 ---
 lib/cmdline/cmdline_socket.c    | 4 ----
 lib/cmdline/cmdline_socket.h    | 1 -
 4 files changed, 9 deletions(-)
lib/cmdline/cmdline_cirbuf.h +0 -1
index c23b211ad4..c58fdabf00 100644
@@ -7,7 +7,6 @@
 #ifndef _CIRBUF_H_
 #define _CIRBUF_H_
 
-#include <rte_config.h>
 
 #ifdef __cplusplus
 extern "C" {
lib/cmdline/cmdline_parse_num.c +0 -3
index b37dd94ae9..820af071fb 100644
@@ -7,10 +7,7 @@
 #include <stdio.h>
 #include <stdint.h>
 #include <inttypes.h>
-#include <ctype.h>
 #include <string.h>
-#include <stdarg.h>
-#include <errno.h>
 #include <rte_string_fns.h>
 
 #include "cmdline_parse.h"
lib/cmdline/cmdline_socket.c +0 -4
index ebd5343754..78fb67c474 100644
@@ -5,11 +5,7 @@
  */
 
 #include <stdio.h>
-#include <string.h>
 #include <unistd.h>
-#include <stdlib.h>
-#include <stdarg.h>
-#include <inttypes.h>
 #include <fcntl.h>
 
 #include "cmdline.h"
lib/cmdline/cmdline_socket.h +0 -1
index 80542e5599..a9c4ea26ad 100644
@@ -8,7 +8,6 @@
 #define _CMDLINE_SOCKET_H_
 
 #include <cmdline_parse.h>
-#include <cmdline.h>
 
 #ifdef __cplusplus
 extern "C" {
Signature · 1 line
2.25.1
#48 lore raw

PATCH v3 2/18 eal: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/eal/common/eal_common_config.c | 1 -
 lib/eal/common/eal_common_launch.c | 1 -
 lib/eal/common/eal_common_log.c    | 1 -
 lib/eal/linux/eal_thread.c         | 6 ------
 lib/eal/unix/eal_filesystem.c      | 2 --
 5 files changed, 11 deletions(-)
lib/eal/common/eal_common_config.c +0 -1
index 3cef43a4f7..0daf0f3188 100644
@@ -1,7 +1,6 @@
 /* SPDX-License-Identifier: BSD-3-Clause
  * Copyright(c) 2020 Mellanox Technologies, Ltd
  */
-#include <string.h>
 
 #include <rte_string_fns.h>
 
lib/eal/common/eal_common_launch.c +0 -1
index 992f8e4631..462c886e30 100644
@@ -6,7 +6,6 @@
 
 #include <rte_launch.h>
 #include <rte_eal_trace.h>
-#include <rte_atomic.h>
 #include <rte_pause.h>
 #include <rte_lcore.h>
 
lib/eal/common/eal_common_log.c +0 -1
index d57dca9785..bd7b188ceb 100644
@@ -13,7 +13,6 @@
 #include <sys/queue.h>
 
 #include <rte_log.h>
-#include <rte_os_shim.h>
 #include <rte_per_lcore.h>
 
 #include "eal_log.h"
lib/eal/linux/eal_thread.c +0 -6
index 820cc905e0..e9294127d1 100644
@@ -4,20 +4,14 @@
 
 #include <errno.h>
 #include <stdio.h>
-#include <stdint.h>
 #include <unistd.h>
 #include <pthread.h>
 #include <sys/syscall.h>
 
-#include <rte_debug.h>
-#include <rte_launch.h>
-#include <rte_log.h>
 #include <rte_eal.h>
 #include <rte_lcore.h>
 #include <rte_string_fns.h>
 
-#include "eal_private.h"
-#include "eal_thread.h"
 
 /* require calling thread tid by gettid() */
 int rte_sys_gettid(void)
lib/eal/unix/eal_filesystem.c +0 -2
index 094a2bf7e4..afbab9368a 100644
@@ -10,10 +10,8 @@
 #include <stdlib.h>
 #include <string.h>
 #include <sys/stat.h>
-#include <sys/types.h>
 #include <unistd.h>
 
-#include <rte_common.h>
 #include <rte_log.h>
 
 #include "eal_private.h"
Signature · 1 line
2.25.1
#49 lore raw

PATCH v3 3/18 ethdev: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/ethdev/rte_class_eth.c | 2 --
 lib/ethdev/rte_ethdev.c    | 9 ---------
 lib/ethdev/rte_ethdev.h    | 1 -
 lib/ethdev/rte_flow.c      | 2 --
 lib/ethdev/rte_flow.h      | 3 ---
 lib/ethdev/rte_mtr.c       | 1 -
 6 files changed, 18 deletions(-)
lib/ethdev/rte_class_eth.c +0 -2
index c8e8fc9244..3be84dd45c 100644
@@ -5,13 +5,11 @@
 #include <string.h>
 
 #include <rte_class.h>
-#include <rte_compat.h>
 #include <rte_errno.h>
 #include <rte_kvargs.h>
 #include <rte_log.h>
 
 #include "rte_ethdev.h"
-#include "rte_ethdev_core.h"
 #include "ethdev_driver.h"
 #include "ethdev_private.h"
 
lib/ethdev/rte_ethdev.c +0 -9
index 90e50eb02b..1979dc0850 100644
@@ -11,18 +11,9 @@
 #include <string.h>
 #include <sys/queue.h>
 
-#include <rte_byteorder.h>
 #include <rte_log.h>
-#include <rte_debug.h>
 #include <rte_interrupts.h>
-#include <rte_memory.h>
 #include <rte_memcpy.h>
-#include <rte_memzone.h>
-#include <rte_launch.h>
-#include <rte_eal.h>
-#include <rte_per_lcore.h>
-#include <rte_lcore.h>
-#include <rte_branch_prediction.h>
 #include <rte_common.h>
 #include <rte_mempool.h>
 #include <rte_malloc.h>
lib/ethdev/rte_ethdev.h +0 -1
index 045ee64747..de9e970d4d 100644
@@ -169,7 +169,6 @@ extern "C" {
 #include <rte_errno.h>
 #include <rte_common.h>
 #include <rte_config.h>
-#include <rte_ether.h>
 #include <rte_power_intrinsics.h>
 
 #include "rte_ethdev_trace_fp.h"
lib/ethdev/rte_flow.c +0 -2
index 2c35a2f13e..501be9d602 100644
@@ -6,13 +6,11 @@
 #include <errno.h>
 #include <stddef.h>
 #include <stdint.h>
-#include <string.h>
 
 #include <rte_common.h>
 #include <rte_errno.h>
 #include <rte_branch_prediction.h>
 #include <rte_string_fns.h>
-#include <rte_mbuf.h>
 #include <rte_mbuf_dyn.h>
 #include "rte_ethdev.h"
 #include "rte_flow_driver.h"
lib/ethdev/rte_flow.h +0 -3
index 1b56f23cba..a79f1e7ef0 100644
@@ -17,7 +17,6 @@
 #include <stddef.h>
 #include <stdint.h>
 
-#include <rte_arp.h>
 #include <rte_common.h>
 #include <rte_ether.h>
 #include <rte_icmp.h>
@@ -26,12 +25,10 @@
 #include <rte_tcp.h>
 #include <rte_udp.h>
 #include <rte_vxlan.h>
-#include <rte_byteorder.h>
 #include <rte_esp.h>
 #include <rte_higig.h>
 #include <rte_ecpri.h>
 #include <rte_bitops.h>
-#include <rte_mbuf.h>
 #include <rte_mbuf_dyn.h>
 #include <rte_meter.h>
 #include <rte_gtp.h>
lib/ethdev/rte_mtr.c +0 -1
index 441ea1dca9..c460e4f4e0 100644
@@ -5,7 +5,6 @@
 #include <stdint.h>
 
 #include <rte_errno.h>
-#include "rte_compat.h"
 #include "rte_ethdev.h"
 #include "rte_mtr_driver.h"
 #include "rte_mtr.h"
Signature · 1 line
2.25.1
#50 lore raw

PATCH v3 4/18 gpudev: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/gpudev/gpudev.c | 1 -
 1 file changed, 1 deletion(-)
lib/gpudev/gpudev.c +0 -1
index 56033f4a5f..ee3ae80f82 100644
@@ -9,7 +9,6 @@
 #include <rte_malloc.h>
 #include <rte_errno.h>
 #include <rte_log.h>
-#include <rte_eal_paging.h>
 
 #include "rte_gpudev.h"
 #include "gpudev_driver.h"
Signature · 1 line
2.25.1
#51 lore raw

PATCH v3 5/18 gso: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/gso/gso_common.c      | 1 -
 lib/gso/gso_common.h      | 1 -
 lib/gso/gso_tcp4.h        | 1 -
 lib/gso/gso_tunnel_tcp4.h | 1 -
 lib/gso/gso_tunnel_udp4.h | 1 -
 lib/gso/gso_udp4.h        | 1 -
 6 files changed, 6 deletions(-)
lib/gso/gso_common.c +0 -1
index 0fad1132fc..378bf2c6aa 100644
@@ -6,7 +6,6 @@
 #include <errno.h>
 
 #include <rte_memcpy.h>
-#include <rte_mempool.h>
 
 #include "gso_common.h"
 
lib/gso/gso_common.h +0 -1
index 2c258b22bf..9456d596d3 100644
@@ -7,7 +7,6 @@
 
 #include <stdint.h>
 
-#include <rte_mbuf.h>
 #include <rte_ip.h>
 #include <rte_tcp.h>
 #include <rte_udp.h>
lib/gso/gso_tcp4.h +0 -1
index 10d4b3acdd..7527fa51c9 100644
@@ -6,7 +6,6 @@
 #define _GSO_TCP4_H_
 
 #include <stdint.h>
-#include <rte_mbuf.h>
 
 /**
  * Segment an IPv4/TCP packet. This function doesn't check if the input
lib/gso/gso_tunnel_tcp4.h +0 -1
index c522ed27f2..3a7ea238c8 100644
@@ -6,7 +6,6 @@
 #define _GSO_TUNNEL_TCP4_H_
 
 #include <stdint.h>
-#include <rte_mbuf.h>
 
 /**
  * Segment a tunneling packet with inner TCP/IPv4 headers. This function
lib/gso/gso_tunnel_udp4.h +0 -1
index c49b43fe3e..214a69ccd5 100644
@@ -6,7 +6,6 @@
 #define _GSO_TUNNEL_UDP4_H_
 
 #include <stdint.h>
-#include <rte_mbuf.h>
 
 /**
  * Segment a tunneling packet with inner UDP/IPv4 headers. This function
lib/gso/gso_udp4.h +0 -1
index b2a2908e54..8baa0ba6db 100644
@@ -6,7 +6,6 @@
 #define _GSO_UDP4_H_
 
 #include <stdint.h>
-#include <rte_mbuf.h>
 
 /**
  * Segment an UDP/IPv4 packet. This function doesn't check if the input
Signature · 1 line
2.25.1
#52 lore raw

PATCH v3 6/18 hash: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/hash/rte_cuckoo_hash.c | 3 ---
 1 file changed, 3 deletions(-)
lib/hash/rte_cuckoo_hash.c +0 -3
index 490f94af4b..de7d941638 100644
@@ -10,7 +10,6 @@
 #include <sys/queue.h>
 
 #include <rte_common.h>
-#include <rte_memory.h>         /* for definition of RTE_CACHE_LINE_SIZE */
 #include <rte_log.h>
 #include <rte_prefetch.h>
 #include <rte_branch_prediction.h>
@@ -21,8 +20,6 @@
 #include <rte_cpuflags.h>
 #include <rte_rwlock.h>
 #include <rte_ring_elem.h>
-#include <rte_compat.h>
-#include <rte_vect.h>
 #include <rte_tailq.h>
 
 #include "rte_hash.h"
Signature · 1 line
2.25.1
#53 lore raw

PATCH v3 7/18 ip_frag: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/ip_frag/ip_frag_internal.c | 1 -
 1 file changed, 1 deletion(-)
lib/ip_frag/ip_frag_internal.c +0 -1
index b436a4c931..043b0ffba3 100644
@@ -4,7 +4,6 @@
 
 #include <stddef.h>
 
-#include <rte_jhash.h>
 #include <rte_hash_crc.h>
 
 #include "ip_frag_common.h"
Signature · 1 line
2.25.1
#54 lore raw

PATCH v3 8/18 jobstats: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/jobstats/rte_jobstats.h | 1 -
 1 file changed, 1 deletion(-)
lib/jobstats/rte_jobstats.h +0 -1
index 023d9dd15c..45b460e603 100644
@@ -8,7 +8,6 @@
 #include <stdint.h>
 
 #include <rte_memory.h>
-#include <rte_memcpy.h>
 
 #ifdef __cplusplus
 extern "C" {
Signature · 1 line
2.25.1
#55 lore raw

PATCH v3 9/18 meter: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/meter/rte_meter.c | 3 ---
 1 file changed, 3 deletions(-)
lib/meter/rte_meter.c +0 -3
index da01429a8b..4549b97d36 100644
@@ -2,12 +2,9 @@
  * Copyright(c) 2010-2014 Intel Corporation
  */
 
-#include <inttypes.h>
 #include <stdio.h>
 #include <math.h>
 
-#include <rte_common.h>
-#include <rte_log.h>
 #include <rte_cycles.h>
 
 #include "rte_meter.h"
Signature · 1 line
2.25.1
#56 lore raw

PATCH v3 10/18 net: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/net/rte_net.h | 1 -
 1 file changed, 1 deletion(-)
lib/net/rte_net.h +0 -1
index 53a7f4d360..56611fc8f9 100644
@@ -12,7 +12,6 @@ extern "C" {
 #include <rte_ip.h>
 #include <rte_udp.h>
 #include <rte_tcp.h>
-#include <rte_sctp.h>
 
 /**
  * Structure containing header lengths associated to a packet, filled
Signature · 1 line
2.25.1
#57 lore raw

PATCH v3 11/18 power: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/power/rte_power_empty_poll.h | 3 ---
 lib/power/rte_power_pmd_mgmt.c   | 2 --
 lib/power/rte_power_pmd_mgmt.h   | 4 ----
 3 files changed, 9 deletions(-)
lib/power/rte_power_empty_poll.h +0 -3
index 43fb276077..f6306fdcdf 100644
@@ -13,10 +13,7 @@
 #include <stdbool.h>
 
 #include <rte_common.h>
-#include <rte_byteorder.h>
-#include <rte_log.h>
 #include <rte_string_fns.h>
-#include <rte_power.h>
 #include <rte_timer.h>
 
 #ifdef __cplusplus
lib/power/rte_power_pmd_mgmt.c +0 -2
index a66e08e574..7f445479bb 100644
@@ -4,10 +4,8 @@
 
 #include <rte_lcore.h>
 #include <rte_cycles.h>
-#include <rte_cpuflags.h>
 #include <rte_malloc.h>
 #include <rte_ethdev.h>
-#include <rte_power_intrinsics.h>
 
 #include "rte_power_pmd_mgmt.h"
 #include "power_common.h"
lib/power/rte_power_pmd_mgmt.h +0 -4
index 789fbe0e4d..7ae6ef2d32 100644
@@ -11,13 +11,9 @@
  */
 
 #include <stdint.h>
-#include <stdbool.h>
 
-#include <rte_common.h>
-#include <rte_byteorder.h>
 #include <rte_log.h>
 #include <rte_power.h>
-#include <rte_atomic.h>
 
 #ifdef __cplusplus
 extern "C" {
Signature · 1 line
2.25.1
#58 lore raw

PATCH v3 12/18 rawdev: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/rawdev/rte_rawdev.h | 1 -
 1 file changed, 1 deletion(-)
lib/rawdev/rte_rawdev.h +0 -1
index 14e8eb972f..66080eae9e 100644
@@ -20,7 +20,6 @@ extern "C" {
 
 #include <rte_common.h>
 #include <rte_memory.h>
-#include <rte_errno.h>
 
 /* Rawdevice object - essentially a void to be typecast by implementation */
 typedef void *rte_rawdev_obj_t;
Signature · 1 line
2.25.1
#59 lore raw

PATCH v3 13/18 regexdev: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/regexdev/rte_regexdev.h | 1 -
 1 file changed, 1 deletion(-)
lib/regexdev/rte_regexdev.h +0 -1
index 3bce8090f6..ce3dba5c10 100644
@@ -200,7 +200,6 @@ extern "C" {
 
 #include <rte_common.h>
 #include <rte_dev.h>
-#include <rte_mbuf.h>
 
 #define RTE_REGEXDEV_NAME_MAX_LEN RTE_DEV_NAME_MAX_LEN
 
Signature · 1 line
2.25.1
#60 lore raw

PATCH v3 14/18 sched: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/sched/rte_pie.c | 1 -
 1 file changed, 1 deletion(-)
lib/sched/rte_pie.c +0 -1
index d37b79e6dd..c84f75a18c 100644
@@ -6,7 +6,6 @@
 #include <string.h>
 
 #include "rte_pie.h"
-#include <rte_malloc.h>
 
 #ifdef __INTEL_COMPILER
 #pragma warning(disable:2259) /* conversion may lose significant bits */
Signature · 1 line
2.25.1
#61 lore raw

PATCH v3 15/18 stack: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/stack/rte_stack.h | 1 -
 1 file changed, 1 deletion(-)
lib/stack/rte_stack.h +0 -1
index 91fc570767..af8c3804f3 100644
@@ -22,7 +22,6 @@ extern "C" {
 #include <rte_debug.h>
 #include <rte_errno.h>
 #include <rte_memzone.h>
-#include <rte_spinlock.h>
 
 #define RTE_TAILQ_STACK_NAME "RTE_STACK"
 #define RTE_STACK_MZ_PREFIX "STK_"
Signature · 1 line
2.25.1
#62 lore raw

PATCH v3 16/18 table: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/table/rte_swx_table_learner.c | 1 -
 1 file changed, 1 deletion(-)
lib/table/rte_swx_table_learner.c +0 -1
index f7f8e8aea9..3502cbd2a4 100644
@@ -6,7 +6,6 @@
 #include <errno.h>
 
 #include <rte_common.h>
-#include <rte_cycles.h>
 #include <rte_prefetch.h>
 
 #include "rte_swx_table_learner.h"
Signature · 1 line
2.25.1
#63 lore raw

PATCH v3 17/18 timer: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/timer/rte_timer.c | 2 --
 lib/timer/rte_timer.h | 2 --
 2 files changed, 4 deletions(-)
lib/timer/rte_timer.c +0 -2
index c51a393e5c..d914fcbf60 100644
@@ -7,10 +7,8 @@
 #include <stdbool.h>
 #include <inttypes.h>
 #include <assert.h>
-#include <sys/queue.h>
 
 #include <rte_common.h>
-#include <rte_cycles.h>
 #include <rte_eal_memconfig.h>
 #include <rte_memory.h>
 #include <rte_lcore.h>
lib/timer/rte_timer.h +0 -2
index 0f820555c0..503438a36b 100644
@@ -36,9 +36,7 @@
 
 #include <stdio.h>
 #include <stdint.h>
-#include <stddef.h>
 #include <rte_common.h>
-#include <rte_config.h>
 #include <rte_spinlock.h>
 
 #ifdef __cplusplus
Signature · 1 line
2.25.1
#64 lore raw

PATCH v3 18/18 vhost: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/vhost/vhost.h      | 2 --
 lib/vhost/vhost_user.h | 1 -
 2 files changed, 3 deletions(-)
lib/vhost/vhost.h +0 -2
index 14235aaf81..4ebcb7448a 100644
@@ -7,10 +7,8 @@
 #include <stdint.h>
 #include <stdio.h>
 #include <stdbool.h>
-#include <sys/types.h>
 #include <sys/queue.h>
 #include <unistd.h>
-#include <linux/vhost.h>
 #include <linux/virtio_net.h>
 #include <sys/socket.h>
 #include <linux/if.h>
lib/vhost/vhost_user.h +0 -1
index c4d091e175..8ecca68597 100644
@@ -6,7 +6,6 @@
 #define _VHOST_NET_USER_H
 
 #include <stdint.h>
-#include <linux/vhost.h>
 
 #include "rte_vhost.h"
 
Signature · 1 line
2.25.1
Acked-by on v3 18/18
#65 lore raw

RE: [PATCH v3 18/18] vhost: remove unneeded header includes

Quoted 45 lines

-----Original Message-----
From: Morrissey, Sean <[email protected]>
Sent: Saturday, June 18, 2022 3:09 AM
To: Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>
Cc: [email protected]; Morrissey, Sean <[email protected]>
Subject: [PATCH v3 18/18] vhost: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/vhost/vhost.h      | 2 --
 lib/vhost/vhost_user.h | 1 -
 2 files changed, 3 deletions(-)
lib/vhost/vhost.h +0 -2
index 14235aaf81..4ebcb7448a 100644
@@ -7,10 +7,8 @@
 #include <stdint.h>
 #include <stdio.h>
 #include <stdbool.h>
-#include <sys/types.h>
 #include <sys/queue.h>
 #include <unistd.h>
-#include <linux/vhost.h>
 #include <linux/virtio_net.h>
 #include <sys/socket.h>
 #include <linux/if.h>
lib/vhost/vhost_user.h +0 -2
index c4d091e175..8ecca68597 100644
@@ -6,7 +6,6 @@
 #define _VHOST_NET_USER_H
 
 #include <stdint.h>
-#include <linux/vhost.h>
 
 #include "rte_vhost.h"
 
--
Quoted 1 line

2.25.1

#66 lore raw

v4 cover remove IWYU flagged headers

In reply to Sean Morrissey

This patchset removes unused header includes flagged by the IWYU tool for the 22.07 release.

V4:
* Fix arm build issues.
V3:
* Fix more linux build issues.
V2:
* Fix various build issues.

Sean Morrissey (14):
cmdline: remove unneeded header includes
eal: remove unneeded header includes
ethdev: remove unneeded header includes
gpudev: remove unneeded header includes
gso: remove unneeded header includes
hash: remove unneeded header includes
jobstats: remove unneeded header includes
meter: remove unneeded header includes
net: remove unneeded header includes
power: remove unneeded header includes
rawdev: remove unneeded header includes
sched: remove unneeded header includes
timer: remove unneeded header includes
vhost: remove unneeded header includes

 lib/cmdline/cmdline_cirbuf.h       | 1 -
 lib/cmdline/cmdline_parse_num.c    | 3 ---
 lib/cmdline/cmdline_socket.c       | 4 ----
 lib/cmdline/cmdline_socket.h       | 1 -
 lib/eal/common/eal_common_config.c | 1 -
 lib/eal/common/eal_common_launch.c | 1 -
 lib/eal/common/eal_common_log.c    | 1 -
 lib/eal/linux/eal_thread.c         | 6 ------
 lib/eal/unix/eal_filesystem.c      | 2 --
 lib/ethdev/rte_class_eth.c         | 2 --
 lib/ethdev/rte_ethdev.c            | 9 ---------
 lib/ethdev/rte_ethdev.h            | 1 -
 lib/ethdev/rte_flow.c              | 2 --
 lib/ethdev/rte_flow.h              | 3 ---
 lib/ethdev/rte_mtr.c               | 1 -
 lib/gpudev/gpudev.c                | 1 -
 lib/gso/gso_common.c               | 1 -
 lib/gso/gso_common.h               | 1 -
 lib/gso/gso_tcp4.h                 | 1 -
 lib/gso/gso_tunnel_tcp4.h          | 1 -
 lib/gso/gso_tunnel_udp4.h          | 1 -
 lib/gso/gso_udp4.h                 | 1 -
 lib/hash/rte_cuckoo_hash.c         | 2 --
 lib/jobstats/rte_jobstats.h        | 1 -
 lib/meter/rte_meter.c              | 3 ---
 lib/net/rte_net.h                  | 1 -
 lib/power/rte_power_empty_poll.h   | 3 ---
 lib/power/rte_power_pmd_mgmt.h     | 4 ----
 lib/rawdev/rte_rawdev.h            | 1 -
 lib/sched/rte_pie.c                | 1 -
 lib/timer/rte_timer.c              | 1 -
 lib/timer/rte_timer.h              | 2 --
 lib/vhost/vhost.h                  | 2 --
 lib/vhost/vhost_user.h             | 1 -
 34 files changed, 67 deletions(-)
Signature · 1 line
2.25.1
#67 lore raw

PATCH v4 1/14 cmdline: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/cmdline/cmdline_cirbuf.h    | 1 -
 lib/cmdline/cmdline_parse_num.c | 3 ---
 lib/cmdline/cmdline_socket.c    | 4 ----
 lib/cmdline/cmdline_socket.h    | 1 -
 4 files changed, 9 deletions(-)
lib/cmdline/cmdline_cirbuf.h +0 -1
index c23b211ad4..c58fdabf00 100644
@@ -7,7 +7,6 @@
 #ifndef _CIRBUF_H_
 #define _CIRBUF_H_
 
-#include <rte_config.h>
 
 #ifdef __cplusplus
 extern "C" {
lib/cmdline/cmdline_parse_num.c +0 -3
index b37dd94ae9..820af071fb 100644
@@ -7,10 +7,7 @@
 #include <stdio.h>
 #include <stdint.h>
 #include <inttypes.h>
-#include <ctype.h>
 #include <string.h>
-#include <stdarg.h>
-#include <errno.h>
 #include <rte_string_fns.h>
 
 #include "cmdline_parse.h"
lib/cmdline/cmdline_socket.c +0 -4
index ebd5343754..78fb67c474 100644
@@ -5,11 +5,7 @@
  */
 
 #include <stdio.h>
-#include <string.h>
 #include <unistd.h>
-#include <stdlib.h>
-#include <stdarg.h>
-#include <inttypes.h>
 #include <fcntl.h>
 
 #include "cmdline.h"
lib/cmdline/cmdline_socket.h +0 -1
index 80542e5599..a9c4ea26ad 100644
@@ -8,7 +8,6 @@
 #define _CMDLINE_SOCKET_H_
 
 #include <cmdline_parse.h>
-#include <cmdline.h>
 
 #ifdef __cplusplus
 extern "C" {
Signature · 1 line
2.25.1
#68 lore raw

PATCH v4 2/14 eal: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/eal/common/eal_common_config.c | 1 -
 lib/eal/common/eal_common_launch.c | 1 -
 lib/eal/common/eal_common_log.c    | 1 -
 lib/eal/linux/eal_thread.c         | 6 ------
 lib/eal/unix/eal_filesystem.c      | 2 --
 5 files changed, 11 deletions(-)
lib/eal/common/eal_common_config.c +0 -1
index 3cef43a4f7..0daf0f3188 100644
@@ -1,7 +1,6 @@
 /* SPDX-License-Identifier: BSD-3-Clause
  * Copyright(c) 2020 Mellanox Technologies, Ltd
  */
-#include <string.h>
 
 #include <rte_string_fns.h>
 
lib/eal/common/eal_common_launch.c +0 -1
index 992f8e4631..462c886e30 100644
@@ -6,7 +6,6 @@
 
 #include <rte_launch.h>
 #include <rte_eal_trace.h>
-#include <rte_atomic.h>
 #include <rte_pause.h>
 #include <rte_lcore.h>
 
lib/eal/common/eal_common_log.c +0 -1
index d57dca9785..bd7b188ceb 100644
@@ -13,7 +13,6 @@
 #include <sys/queue.h>
 
 #include <rte_log.h>
-#include <rte_os_shim.h>
 #include <rte_per_lcore.h>
 
 #include "eal_log.h"
lib/eal/linux/eal_thread.c +0 -6
index 820cc905e0..e9294127d1 100644
@@ -4,20 +4,14 @@
 
 #include <errno.h>
 #include <stdio.h>
-#include <stdint.h>
 #include <unistd.h>
 #include <pthread.h>
 #include <sys/syscall.h>
 
-#include <rte_debug.h>
-#include <rte_launch.h>
-#include <rte_log.h>
 #include <rte_eal.h>
 #include <rte_lcore.h>
 #include <rte_string_fns.h>
 
-#include "eal_private.h"
-#include "eal_thread.h"
 
 /* require calling thread tid by gettid() */
 int rte_sys_gettid(void)
lib/eal/unix/eal_filesystem.c +0 -2
index 094a2bf7e4..afbab9368a 100644
@@ -10,10 +10,8 @@
 #include <stdlib.h>
 #include <string.h>
 #include <sys/stat.h>
-#include <sys/types.h>
 #include <unistd.h>
 
-#include <rte_common.h>
 #include <rte_log.h>
 
 #include "eal_private.h"
Signature · 1 line
2.25.1
#69 lore raw

PATCH v4 3/14 ethdev: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/ethdev/rte_class_eth.c | 2 --
 lib/ethdev/rte_ethdev.c    | 9 ---------
 lib/ethdev/rte_ethdev.h    | 1 -
 lib/ethdev/rte_flow.c      | 2 --
 lib/ethdev/rte_flow.h      | 3 ---
 lib/ethdev/rte_mtr.c       | 1 -
 6 files changed, 18 deletions(-)
lib/ethdev/rte_class_eth.c +0 -2
index c8e8fc9244..3be84dd45c 100644
@@ -5,13 +5,11 @@
 #include <string.h>
 
 #include <rte_class.h>
-#include <rte_compat.h>
 #include <rte_errno.h>
 #include <rte_kvargs.h>
 #include <rte_log.h>
 
 #include "rte_ethdev.h"
-#include "rte_ethdev_core.h"
 #include "ethdev_driver.h"
 #include "ethdev_private.h"
 
lib/ethdev/rte_ethdev.c +0 -9
index 90e50eb02b..1979dc0850 100644
@@ -11,18 +11,9 @@
 #include <string.h>
 #include <sys/queue.h>
 
-#include <rte_byteorder.h>
 #include <rte_log.h>
-#include <rte_debug.h>
 #include <rte_interrupts.h>
-#include <rte_memory.h>
 #include <rte_memcpy.h>
-#include <rte_memzone.h>
-#include <rte_launch.h>
-#include <rte_eal.h>
-#include <rte_per_lcore.h>
-#include <rte_lcore.h>
-#include <rte_branch_prediction.h>
 #include <rte_common.h>
 #include <rte_mempool.h>
 #include <rte_malloc.h>
lib/ethdev/rte_ethdev.h +0 -1
index 045ee64747..de9e970d4d 100644
@@ -169,7 +169,6 @@ extern "C" {
 #include <rte_errno.h>
 #include <rte_common.h>
 #include <rte_config.h>
-#include <rte_ether.h>
 #include <rte_power_intrinsics.h>
 
 #include "rte_ethdev_trace_fp.h"
lib/ethdev/rte_flow.c +0 -2
index 2c35a2f13e..501be9d602 100644
@@ -6,13 +6,11 @@
 #include <errno.h>
 #include <stddef.h>
 #include <stdint.h>
-#include <string.h>
 
 #include <rte_common.h>
 #include <rte_errno.h>
 #include <rte_branch_prediction.h>
 #include <rte_string_fns.h>
-#include <rte_mbuf.h>
 #include <rte_mbuf_dyn.h>
 #include "rte_ethdev.h"
 #include "rte_flow_driver.h"
lib/ethdev/rte_flow.h +0 -3
index 1b56f23cba..a79f1e7ef0 100644
@@ -17,7 +17,6 @@
 #include <stddef.h>
 #include <stdint.h>
 
-#include <rte_arp.h>
 #include <rte_common.h>
 #include <rte_ether.h>
 #include <rte_icmp.h>
@@ -26,12 +25,10 @@
 #include <rte_tcp.h>
 #include <rte_udp.h>
 #include <rte_vxlan.h>
-#include <rte_byteorder.h>
 #include <rte_esp.h>
 #include <rte_higig.h>
 #include <rte_ecpri.h>
 #include <rte_bitops.h>
-#include <rte_mbuf.h>
 #include <rte_mbuf_dyn.h>
 #include <rte_meter.h>
 #include <rte_gtp.h>
lib/ethdev/rte_mtr.c +0 -1
index 441ea1dca9..c460e4f4e0 100644
@@ -5,7 +5,6 @@
 #include <stdint.h>
 
 #include <rte_errno.h>
-#include "rte_compat.h"
 #include "rte_ethdev.h"
 #include "rte_mtr_driver.h"
 #include "rte_mtr.h"
Signature · 1 line
2.25.1
#70 lore raw

PATCH v4 4/14 gpudev: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/gpudev/gpudev.c | 1 -
 1 file changed, 1 deletion(-)
lib/gpudev/gpudev.c +0 -1
index 56033f4a5f..ee3ae80f82 100644
@@ -9,7 +9,6 @@
 #include <rte_malloc.h>
 #include <rte_errno.h>
 #include <rte_log.h>
-#include <rte_eal_paging.h>
 
 #include "rte_gpudev.h"
 #include "gpudev_driver.h"
Signature · 1 line
2.25.1
#71 lore raw

PATCH v4 5/14 gso: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/gso/gso_common.c      | 1 -
 lib/gso/gso_common.h      | 1 -
 lib/gso/gso_tcp4.h        | 1 -
 lib/gso/gso_tunnel_tcp4.h | 1 -
 lib/gso/gso_tunnel_udp4.h | 1 -
 lib/gso/gso_udp4.h        | 1 -
 6 files changed, 6 deletions(-)
lib/gso/gso_common.c +0 -1
index 0fad1132fc..378bf2c6aa 100644
@@ -6,7 +6,6 @@
 #include <errno.h>
 
 #include <rte_memcpy.h>
-#include <rte_mempool.h>
 
 #include "gso_common.h"
 
lib/gso/gso_common.h +0 -1
index 2c258b22bf..9456d596d3 100644
@@ -7,7 +7,6 @@
 
 #include <stdint.h>
 
-#include <rte_mbuf.h>
 #include <rte_ip.h>
 #include <rte_tcp.h>
 #include <rte_udp.h>
lib/gso/gso_tcp4.h +0 -1
index 10d4b3acdd..7527fa51c9 100644
@@ -6,7 +6,6 @@
 #define _GSO_TCP4_H_
 
 #include <stdint.h>
-#include <rte_mbuf.h>
 
 /**
  * Segment an IPv4/TCP packet. This function doesn't check if the input
lib/gso/gso_tunnel_tcp4.h +0 -1
index c522ed27f2..3a7ea238c8 100644
@@ -6,7 +6,6 @@
 #define _GSO_TUNNEL_TCP4_H_
 
 #include <stdint.h>
-#include <rte_mbuf.h>
 
 /**
  * Segment a tunneling packet with inner TCP/IPv4 headers. This function
lib/gso/gso_tunnel_udp4.h +0 -1
index c49b43fe3e..214a69ccd5 100644
@@ -6,7 +6,6 @@
 #define _GSO_TUNNEL_UDP4_H_
 
 #include <stdint.h>
-#include <rte_mbuf.h>
 
 /**
  * Segment a tunneling packet with inner UDP/IPv4 headers. This function
lib/gso/gso_udp4.h +0 -1
index b2a2908e54..8baa0ba6db 100644
@@ -6,7 +6,6 @@
 #define _GSO_UDP4_H_
 
 #include <stdint.h>
-#include <rte_mbuf.h>
 
 /**
  * Segment an UDP/IPv4 packet. This function doesn't check if the input
Signature · 1 line
2.25.1
#72 lore raw

PATCH v4 6/14 hash: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/hash/rte_cuckoo_hash.c | 2 --
 1 file changed, 2 deletions(-)
lib/hash/rte_cuckoo_hash.c +0 -2
index 490f94af4b..62c762439a 100644
@@ -10,7 +10,6 @@
 #include <sys/queue.h>
 
 #include <rte_common.h>
-#include <rte_memory.h>         /* for definition of RTE_CACHE_LINE_SIZE */
 #include <rte_log.h>
 #include <rte_prefetch.h>
 #include <rte_branch_prediction.h>
@@ -21,7 +20,6 @@
 #include <rte_cpuflags.h>
 #include <rte_rwlock.h>
 #include <rte_ring_elem.h>
-#include <rte_compat.h>
 #include <rte_vect.h>
 #include <rte_tailq.h>
 
Signature · 1 line
2.25.1
#73 lore raw

PATCH v4 7/14 jobstats: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/jobstats/rte_jobstats.h | 1 -
 1 file changed, 1 deletion(-)
lib/jobstats/rte_jobstats.h +0 -1
index 023d9dd15c..45b460e603 100644
@@ -8,7 +8,6 @@
 #include <stdint.h>
 
 #include <rte_memory.h>
-#include <rte_memcpy.h>
 
 #ifdef __cplusplus
 extern "C" {
Signature · 1 line
2.25.1
#74 lore raw

PATCH v4 8/14 meter: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/meter/rte_meter.c | 3 ---
 1 file changed, 3 deletions(-)
lib/meter/rte_meter.c +0 -3
index da01429a8b..4549b97d36 100644
@@ -2,12 +2,9 @@
  * Copyright(c) 2010-2014 Intel Corporation
  */
 
-#include <inttypes.h>
 #include <stdio.h>
 #include <math.h>
 
-#include <rte_common.h>
-#include <rte_log.h>
 #include <rte_cycles.h>
 
 #include "rte_meter.h"
Signature · 1 line
2.25.1
#75 lore raw

PATCH v4 9/14 net: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/net/rte_net.h | 1 -
 1 file changed, 1 deletion(-)
lib/net/rte_net.h +0 -1
index 53a7f4d360..56611fc8f9 100644
@@ -12,7 +12,6 @@ extern "C" {
 #include <rte_ip.h>
 #include <rte_udp.h>
 #include <rte_tcp.h>
-#include <rte_sctp.h>
 
 /**
  * Structure containing header lengths associated to a packet, filled
Signature · 1 line
2.25.1
#76 lore raw

PATCH v4 10/14 power: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/power/rte_power_empty_poll.h | 3 ---
 lib/power/rte_power_pmd_mgmt.h   | 4 ----
 2 files changed, 7 deletions(-)
lib/power/rte_power_empty_poll.h +0 -3
index 43fb276077..f6306fdcdf 100644
@@ -13,10 +13,7 @@
 #include <stdbool.h>
 
 #include <rte_common.h>
-#include <rte_byteorder.h>
-#include <rte_log.h>
 #include <rte_string_fns.h>
-#include <rte_power.h>
 #include <rte_timer.h>
 
 #ifdef __cplusplus
lib/power/rte_power_pmd_mgmt.h +0 -4
index 789fbe0e4d..7ae6ef2d32 100644
@@ -11,13 +11,9 @@
  */
 
 #include <stdint.h>
-#include <stdbool.h>
 
-#include <rte_common.h>
-#include <rte_byteorder.h>
 #include <rte_log.h>
 #include <rte_power.h>
-#include <rte_atomic.h>
 
 #ifdef __cplusplus
 extern "C" {
Signature · 1 line
2.25.1
#77 lore raw

PATCH v4 11/14 rawdev: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/rawdev/rte_rawdev.h | 1 -
 1 file changed, 1 deletion(-)
lib/rawdev/rte_rawdev.h +0 -1
index 14e8eb972f..66080eae9e 100644
@@ -20,7 +20,6 @@ extern "C" {
 
 #include <rte_common.h>
 #include <rte_memory.h>
-#include <rte_errno.h>
 
 /* Rawdevice object - essentially a void to be typecast by implementation */
 typedef void *rte_rawdev_obj_t;
Signature · 1 line
2.25.1
#78 lore raw

PATCH v4 12/14 sched: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/sched/rte_pie.c | 1 -
 1 file changed, 1 deletion(-)
lib/sched/rte_pie.c +0 -1
index d37b79e6dd..c84f75a18c 100644
@@ -6,7 +6,6 @@
 #include <string.h>
 
 #include "rte_pie.h"
-#include <rte_malloc.h>
 
 #ifdef __INTEL_COMPILER
 #pragma warning(disable:2259) /* conversion may lose significant bits */
Signature · 1 line
2.25.1
#79 lore raw

PATCH v4 13/14 timer: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/timer/rte_timer.c | 1 -
 lib/timer/rte_timer.h | 2 --
 2 files changed, 3 deletions(-)
lib/timer/rte_timer.c +0 -1
index c51a393e5c..9994813d0d 100644
@@ -7,7 +7,6 @@
 #include <stdbool.h>
 #include <inttypes.h>
 #include <assert.h>
-#include <sys/queue.h>
 
 #include <rte_common.h>
 #include <rte_cycles.h>
lib/timer/rte_timer.h +0 -2
index 0f820555c0..503438a36b 100644
@@ -36,9 +36,7 @@
 
 #include <stdio.h>
 #include <stdint.h>
-#include <stddef.h>
 #include <rte_common.h>
-#include <rte_config.h>
 #include <rte_spinlock.h>
 
 #ifdef __cplusplus
Signature · 1 line
2.25.1
#80 lore raw

PATCH v4 14/14 vhost: remove unneeded header includes

In reply to Sean Morrissey

These header includes have been flagged by the iwyu_tool and removed.

---
 lib/vhost/vhost.h      | 2 --
 lib/vhost/vhost_user.h | 1 -
 2 files changed, 3 deletions(-)
lib/vhost/vhost.h +0 -2
index 14235aaf81..4ebcb7448a 100644
@@ -7,10 +7,8 @@
 #include <stdint.h>
 #include <stdio.h>
 #include <stdbool.h>
-#include <sys/types.h>
 #include <sys/queue.h>
 #include <unistd.h>
-#include <linux/vhost.h>
 #include <linux/virtio_net.h>
 #include <sys/socket.h>
 #include <linux/if.h>
lib/vhost/vhost_user.h +0 -1
index c4d091e175..8ecca68597 100644
@@ -6,7 +6,6 @@
 #define _VHOST_NET_USER_H
 
 #include <stdint.h>
-#include <linux/vhost.h>
 
 #include "rte_vhost.h"
 
Signature · 1 line
2.25.1
#81 lore raw
In reply to Sean Morrissey

20/06/2022 12:40, Sean Morrissey:

Quoted 9 lines

This patchset removes unused header includes flagged by the IWYU tool for the 22.07 release.

V4:
* Fix arm build issues.
V3:
* Fix more linux build issues.
V2:
* Fix various build issues.

Build looks fine now.
Applied, thanks.