Skip to contentSkip to conversation

video: fbdev: Fix refcount leak bug in valkyriefb.c

PATCH New Liang He 1 participant 1 message Jun 18, 2022 Framebuffer layer

lore
Share & tools
lore

Liang He

author
#0 lore raw

PATCH 1/1 video: fbdev: Fix refcount leak bug in valkyriefb.c

In valkyriefb_init(), of_find_node_by_name() will return a node pointer with refcount incremented. We should use of_node_put() in fail path or when it is not used anymore.

---
 drivers/video/fbdev/valkyriefb.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/video/fbdev/valkyriefb.c +3 -0
index a6c9d4f26669..20d727a8069d 100644
@@ -334,10 +334,13 @@ int __init valkyriefb_init(void)
 			return 0;
 
 		if (of_address_to_resource(dp, 0, &r)) {
+			of_node_put(dp);
 			printk(KERN_ERR "can't find address for valkyrie\n");
 			return 0;
 		}
 
+		of_node_put(dp);
+
 		frame_buffer_phys = r.start;
 		cmap_regs_phys = r.start + 0x304000;
 	}
Signature · 1 line
2.25.1