powerpc: embedded6xx: Fix refcount leak bugs
PATCH v2 1/1 powerpc: embedded6xx: Fix refcount leak bugs
In xx_init_xx(), of_find_node_by_type() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore.
Signed-off-by Liang He <[email protected]>
---
v2: we merge all embedded6xx related bugs into one commit
v1: we only report the bug in holly_init_pci() of holly.c
arch/powerpc/platforms/embedded6xx/holly.c | 6 ++++++ arch/powerpc/platforms/embedded6xx/mpc7448_hpc2.c | 3 +++ 2 files changed, 9 insertions(+)
arch/powerpc/platforms/embedded6xx/holly.c +6 -0
@@ -123,6 +123,8 @@ static void __init holly_init_pci(void)if (np)tsi108_setup_pci (np,HOLLY_PCI_CFG_PHYS ,1 ); +of_node_put (np); + ppc_md.pci_exclude_device = holly_exclude_device;if (ppc_md.progress) ppc_md.progress ("tsi108: resources set" ,0x100 );
@@ -184,6 +186,9 @@ static void __init holly_init_IRQ(void)tsi108_pci_int_init (cascade_node);irq_set_handler_data (cascade_pci_irq, mpic);irq_set_chained_handler (cascade_pci_irq, tsi108_irq_cascade); + +of_node_put (tsi_pci); +of_node_put (cascade_node);#endif /* Configure MPIC outputs to CPU0 */ tsi108_write_reg (TSI108_MPIC_OFFSET +0x30c ,0 );
@@ -210,6 +215,7 @@ static void __noreturn holly_restart(char *cmd)if (bridge) { prop =of_get_property (bridge,"reg" , &size); addr =of_translate_address (bridge, prop); +of_node_put (bridge); } addr += (TSI108_PB_OFFSET +0x414 );
arch/powerpc/platforms/embedded6xx/mpc7448_hpc2.c +3 -0
@@ -135,6 +135,9 @@ static void __init mpc7448_hpc2_init_IRQ(void)tsi108_pci_int_init (cascade_node);irq_set_handler_data (cascade_pci_irq, mpic);irq_set_chained_handler (cascade_pci_irq, tsi108_irq_cascade); + +of_node_put (tsi_pci); +of_node_put (cascade_node);#endif /* Configure MPIC outputs to CPU0 */ tsi108_write_reg (TSI108_MPIC_OFFSET +0x30c ,0 );
Signature · 1 line
2.25.1
Michael Ellerman
AppliedQuoted 5 lines · Liang He
In
xx_init_xx(),of_find_node_by_type()will return a node pointer with refcount incremented. We should useof_node_put()when it is not used anymore.
Applied to powerpc/next.
[1/1] powerpc: embedded6xx: Fix refcount leak bugs
https://git.kernel.org/powerpc/c/6b2d17d514b105ecf486bdf011c444978e633085
cheers