Skip to contentSkip to conversation

tty: Add N_CAN327 line discipline ID for ELM327 based CAN driver

PATCH In review Max Staudt 3 participants 3 messages Jun 18, 2022 – Jun 27, 2022

Subsystems (2)
lore
Share & tools
lore

Max Staudt

author
#0 lore raw

PATCH 1/1 tty: Add N_CAN327 line discipline ID for ELM327 based CAN driver

The actual driver will be added via the CAN tree.

---
Dear TTY maintainers,

The CAN people (well, a subset) have spoken and decided to accept the can327 driver (formerly elmcan), an ldisc based CAN driver allowing CAN experiments with commodity hardware.

After several rounds of reviews, the final condition is for you to accept this patch for N_CAN327, so here goes - please add this new line discipline to the list, and once this filters through, the driver itself will be added to can-next :)

Thanks!

Max

---
 include/uapi/linux/tty.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/uapi/linux/tty.h +2 -1
index 9d0f06bfbac3..68aeae2addec 100644
@@ -38,8 +38,9 @@
 #define N_NULL		27	/* Null ldisc used for error handling */
 #define N_MCTP		28	/* MCTP-over-serial */
 #define N_DEVELOPMENT	29	/* Manual out-of-tree testing */
+#define N_CAN327	30	/* ELM327 based OBD-II interfaces */
 
 /* Always the newest line discipline + 1 */
-#define NR_LDISCS	30
+#define NR_LDISCS	31
 
 #endif /* _UAPI_LINUX_TTY_H */
Signature · 1 line
2.30.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Max Staudt

The actual driver will be added via the CAN tree.

Marc

Signature · 4 lines
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |
#2 lore raw
In reply to Max Staudt
Quoted 6 lines · Max Staudt

The actual driver will be added via the CAN tree.

---
Dear TTY maintainers,

Quoted 8 lines

The CAN people (well, a subset) have spoken and decided to accept the can327 driver (formerly elmcan), an ldisc based CAN driver allowing CAN experiments with commodity hardware.

After several rounds of reviews, the final condition is for you to accept this patch for N_CAN327, so here goes - please add this new line discipline to the list, and once this filters through, the driver itself will be added to can-next :)

Great, will go to Linus before 5.19-final is out.

thanks,

greg k-h