Skip to contentSkip to conversation

drm: panel-orientation-quirks: Add quirk for Aya Neo Next

PATCH In review Maccraft123 3 participants 4 messages Jun 19, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm: panel-orientation-quirks: Add quirk for Aya Neo Next

From: Maya Matuszczyk <[email protected]>

The device is identified by "NEXT" in board name, however there are different versions of it, "Next Advance" and "Next Pro", that have different DMI board names.
Due to a production error a batch or two have their board names prefixed by "AYANEO", this makes it 6 different DMI board names. To save some space in final kernel image DMI_MATCH is used instead of DMI_EXACT_MATCH.

---
Changes from v1:
- Changed it to use only one entry, with less exact match, as requested by Hans de Goede

---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/drm_panel_orientation_quirks.c +6 -0
index 4e853acfd1e8..df87ba99a87c 100644
@@ -152,6 +152,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AYA NEO 2021"),
 		},
 		.driver_data = (void *)&lcd800x1280_rightside_up,
+	}, {	/* AYA NEO NEXT */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
+		  DMI_MATCH(DMI_BOARD_NAME, "NEXT"),
+		},
+		.driver_data = (void *)&lcd800x1280_rightside_up,
 	}, {	/* Chuwi HiBook (CWI514) */
 		.matches = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
Signature · 1 line
2.36.1
Reviewed-by on v2 1/1
#1 lore raw

Hello Maya,

Quoted 10 lines · On 6/19/22 13:19, Maccraft123 wrote:

From: Maya Matuszczyk <[email protected]>

The device is identified by "NEXT" in board name, however there are different versions of it, "Next Advance" and "Next Pro", that have different DMI board names.
Due to a production error a batch or two have their board names prefixed by "AYANEO", this makes it 6 different DMI board names. To save some space in final kernel image DMI_MATCH is used instead of DMI_EXACT_MATCH.

Quoted 2 lines

Patch looks good to me.

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat
Reviewed-by
#2 lore raw

Hi,

Quoted 13 lines · Javier Martinez Canillas

Hello Maya,

Quoted 10 lines · On 6/19/22 13:19, Maccraft123 wrote:

From: Maya Matuszczyk <[email protected]>

The device is identified by "NEXT" in board name, however there are different versions of it, "Next Advance" and "Next Pro", that have different DMI board names.
Due to a production error a batch or two have their board names prefixed by "AYANEO", this makes it 6 different DMI board names. To save some space in final kernel image DMI_MATCH is used instead of DMI_EXACT_MATCH.

Quoted 6 lines
Quoted 2 lines

Patch looks good to me.

New version looks good to me too:

I've some upcoming travel, so it would be good if someone else can push this to drm-misc-fixes.

Regards,

Hans

#3 lore raw

Hello Hans,

Quoted 21 lines · Hans de Goede

Hi,

Quoted 18 lines · Javier Martinez Canillas

Hello Maya,

Quoted 10 lines · On 6/19/22 13:19, Maccraft123 wrote:

From: Maya Matuszczyk <[email protected]>

The device is identified by "NEXT" in board name, however there are different versions of it, "Next Advance" and "Next Pro", that have different DMI board names.
Due to a production error a batch or two have their board names prefixed by "AYANEO", this makes it 6 different DMI board names. To save some space in final kernel image DMI_MATCH is used instead of DMI_EXACT_MATCH.

Quoted 2 lines

Patch looks good to me.

Quoted 9 lines
Quoted 1 line

New version looks good to me too:

I've some upcoming travel, so it would be good if someone else can push this to drm-misc-fixes.

Sure, I've pushed to drm-misc-fixes now. Thanks!

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat