Skip to contentSkip to conversation

Add 'dma-noncoherent' property as a standard property

PATCH In review Heiko Stuebner 2 participants 5 messages Jun 19, 2022 – Jul 2, 2022 2 messages not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add 'dma-noncoherent' property as a standard property

Similar to the 'dma-coherent' property, some architectures may be coherent by default with some devices being non-coherent. Add a property for this case tool.

---
Companion patch to RISC-V Zicbom noncoherent dma support
https://lore.kernel.org/linux-riscv/20220619203212.3604485-1-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org/

 source/chapter2-devicetree-basics.rst | 13 +++++++++++++
 1 file changed, 13 insertions(+)
source/chapter2-devicetree-basics.rst +13 -0
index 47d2fad..bdd7b9f 100644
@@ -832,6 +832,19 @@ Description:
    coherent DMA operations. Some architectures have coherent DMA by default
    and this property is not applicable.
 
+dma-noncoherent
+~~~~~~~~~~~~
+
+Property name: ``dma-noncoherent``
+
+Value type: ``<empty>``
+
+Description:
+   For architectures which are by default coherent for I/O, the
+   *dma-noncoherent* property is used to indicate a device is not capable of
+   coherent DMA operations. Some architectures have non-coherent DMA by
+   default and this property is not applicable.
+
 name (deprecated)
 ~~~~~~~~~~~~~~~~~
 
Signature · 1 line
2.35.1

A message that is not in the archive (sent off-list or not yet received): 20220619203719.3604757-1-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org

#2 lore raw
Quoted 4 lines · Heiko Stuebner

Similar to the 'dma-coherent' property, some architectures may be coherent by default with some devices being non-coherent. Add a property for this case tool.

Looks fine, but I also need a schema.

Yeah, that's redundant unfortunately. Maybe someday someone will care enough to generate the spec from the schemas.

Quoted 36 lines

---
Companion patch to RISC-V Zicbom noncoherent dma support
https://lore.kernel.org/linux-riscv/20220619203212.3604485-1-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org/

 source/chapter2-devicetree-basics.rst | 13 +++++++++++++
 1 file changed, 13 insertions(+)
source/chapter2-devicetree-basics.rst +13 -1
index 47d2fad..bdd7b9f 100644
@@ -832,6 +832,19 @@ Description:
    coherent DMA operations. Some architectures have coherent DMA by default
    and this property is not applicable.
 
+dma-noncoherent
+~~~~~~~~~~~~
+
+Property name: ``dma-noncoherent``
+
+Value type: ``<empty>``
+
+Description:
+   For architectures which are by default coherent for I/O, the
+   *dma-noncoherent* property is used to indicate a device is not capable of
+   coherent DMA operations. Some architectures have non-coherent DMA by
+   default and this property is not applicable.
+
 name (deprecated)
 ~~~~~~~~~~~~~~~~~
 
--

2.35.1

A message that is not in the archive (sent off-list or not yet received): CAL_JsqK20v34ZFWzeicaVoDWmjAsBwPyc89kaV-26Se_1eKtmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#4 lore raw

Am Montag, 27. Juni 2022, 17:14:45 CEST schrieb Rob Herring:

Quoted 10 lines · Heiko Stuebner
Quoted 4 lines

Similar to the 'dma-coherent' property, some architectures may be coherent by default with some devices being non-coherent. Add a property for this case tool.

Looks fine, but I also need a schema.

Yeah, that's redundant unfortunately. Maybe someday someone will care enough to generate the spec from the schemas.

No worries and sorry I didn't think of where the schema comes from in the first place. I'll do the relevant schema work as well.

Heiko

Quoted 36 lines
Quoted 35 lines

---
Companion patch to RISC-V Zicbom noncoherent dma support
https://lore.kernel.org/linux-riscv/20220619203212.3604485-1-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org/

 source/chapter2-devicetree-basics.rst | 13 +++++++++++++
 1 file changed, 13 insertions(+)
source/chapter2-devicetree-basics.rst +13 -1
index 47d2fad..bdd7b9f 100644
@@ -832,6 +832,19 @@ Description:
    coherent DMA operations. Some architectures have coherent DMA by default
    and this property is not applicable.
 
+dma-noncoherent
+~~~~~~~~~~~~
+
+Property name: ``dma-noncoherent``
+
+Value type: ``<empty>``
+
+Description:
+   For architectures which are by default coherent for I/O, the
+   *dma-noncoherent* property is used to indicate a device is not capable of
+   coherent DMA operations. Some architectures have non-coherent DMA by
+   default and this property is not applicable.
+
 name (deprecated)
 ~~~~~~~~~~~~~~~~~
 
--

2.35.1

#5 lore raw

Hi Rob,

Am Montag, 27. Juni 2022, 17:51:51 CEST schrieb Heiko Stübner:

Quoted 7 lines

Am Montag, 27. Juni 2022, 17:14:45 CEST schrieb Rob Herring:

Quoted 6 lines · Heiko Stuebner
Quoted 4 lines

Similar to the 'dma-coherent' property, some architectures may be coherent by default with some devices being non-coherent. Add a property for this case tool.

Quoted 7 lines
Quoted 4 lines

Looks fine, but I also need a schema.

Yeah, that's redundant unfortunately. Maybe someday someone will care enough to generate the spec from the schemas.

No worries and sorry I didn't think of where the schema comes from in the first place. I'll do the relevant schema work as well.

Done in https://github.com/devicetree-org/dt-schema/pull/78 .

I wasn't sure about the "development model" of dt-schema [0] but there were already github pull-requests pending, so I've added another one for the new property :-) .

Heiko

[0] The devicetree-specification documentation said mailinglist, though I also see pull-requests there now that I was looking at github.

Quoted 38 lines
Quoted 36 lines
Quoted 35 lines

---
Companion patch to RISC-V Zicbom noncoherent dma support
https://lore.kernel.org/linux-riscv/20220619203212.3604485-1-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org/

 source/chapter2-devicetree-basics.rst | 13 +++++++++++++
 1 file changed, 13 insertions(+)
source/chapter2-devicetree-basics.rst +13 -1
index 47d2fad..bdd7b9f 100644
@@ -832,6 +832,19 @@ Description:
    coherent DMA operations. Some architectures have coherent DMA by default
    and this property is not applicable.
 
+dma-noncoherent
+~~~~~~~~~~~~
+
+Property name: ``dma-noncoherent``
+
+Value type: ``<empty>``
+
+Description:
+   For architectures which are by default coherent for I/O, the
+   *dma-noncoherent* property is used to indicate a device is not capable of
+   coherent DMA operations. Some architectures have non-coherent DMA by
+   default and this property is not applicable.
+
 name (deprecated)
 ~~~~~~~~~~~~~~~~~
 
--

2.35.1

#6 lore raw

Hi Rob,

Am Dienstag, 28. Juni 2022, 13:22:31 CEST schrieb Heiko Stübner:

Quoted 13 lines

Am Montag, 27. Juni 2022, 17:51:51 CEST schrieb Heiko Stübner:

Quoted 12 lines

Am Montag, 27. Juni 2022, 17:14:45 CEST schrieb Rob Herring:

Quoted 10 lines · Heiko Stuebner
Quoted 4 lines

Similar to the 'dma-coherent' property, some architectures may be coherent by default with some devices being non-coherent. Add a property for this case tool.

Looks fine, but I also need a schema.

Yeah, that's redundant unfortunately. Maybe someday someone will care enough to generate the spec from the schemas.

Quoted 8 lines
Quoted 2 lines

No worries and sorry I didn't think of where the schema comes from in the first place. I'll do the relevant schema work as well.

Done in https://github.com/devicetree-org/dt-schema/pull/78 .

I wasn't sure about the "development model" of dt-schema [0] but there were already github pull-requests pending, so I've added another one for the new property :-) .

so as the dt-schema patch did go through the github-pull,. I've converted this patch as well, so there is now a matching pull-request on github for the spec addition.

Heiko