Skip to contentSkip to conversation

PM / devfreq: Fix kernel warning with cpufreq passive register fail

PATCH Applied Christian Marangi 2 participants 2 messages Jun 19, 2022 – Jun 29, 2022 Device frequency (devfreq)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PM / devfreq: Fix kernel warning with cpufreq passive register fail

Remove cpufreq_passive_unregister_notifier from cpufreq_passive_register_notifier in case of error as devfreq core already call unregister on GOV_START fail.

This fix the kernel always printing a WARN on governor PROBE_DEFER as cpufreq_passive_unregister_notifier is called two times and return error on the second call as the cpufreq is already unregistered.

Fixes a03dacb0316f ("PM / devfreq: Add cpu based scaling support to passive governor")
---
 drivers/devfreq/governor_passive.c | 1 -
 1 file changed, 1 deletion(-)
drivers/devfreq/governor_passive.c +0 -1
index 72c67979ebe1..8055801cf182 100644
@@ -336,7 +336,6 @@ static int cpufreq_passive_register_notifier(struct devfreq *devfreq)
 err_put_policy:
 	cpufreq_cpu_put(policy);
 err:
-	WARN_ON(cpufreq_passive_unregister_notifier(devfreq));
 
 	return ret;
 }
Signature · 1 line
2.36.1
Applied
#1 lore raw
Quoted 19 lines · Christian Marangi

Remove cpufreq_passive_unregister_notifier from cpufreq_passive_register_notifier in case of error as devfreq core already call unregister on GOV_START fail.

This fix the kernel always printing a WARN on governor PROBE_DEFER as cpufreq_passive_unregister_notifier is called two times and return error on the second call as the cpufreq is already unregistered.

Fixes a03dacb0316f ("PM / devfreq: Add cpu based scaling support to passive governor")
---
 drivers/devfreq/governor_passive.c | 1 -
 1 file changed, 1 deletion(-)
drivers/devfreq/governor_passive.c +0 -0
index 72c67979ebe1..8055801cf182 100644

drivers/devfreq/governor_passive.c static int cpufreq_passive_register_notifier(struct devfreq *devfreq) · line 341

Quoted 7 lines
drivers/devfreq/governor_passive.c +0 -1
@@ -336,7 +336,6 @@ static int cpufreq_passive_register_notifier(struct devfreq *devfreq)
 err_put_policy:
 	cpufreq_cpu_put(policy);
 err:
-	WARN_ON(cpufreq_passive_unregister_notifier(devfreq));
 
 	return ret;
 }

Applied. Thanks.

Signature · 3 lines
Best Regards,
Samsung Electronics
Chanwoo Choi