lib/crypto/blake2s-selftest.c:632:1: warning: the frame size of 1088 bytes is larger than 1024 bytes
Subsystems (2)
kernel test robot
build bottree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: bffa1fc065893a14703545efba7d69bb4082b18a commit: 2d16803c562ecc644803d42ba98a8e0aef9c014e [18/27] crypto: blake2s - remove shash module config: riscv-randconfig-r042-20220619 (https://download.01.org/0day-ci/archive/20220620/[email protected]/config) compiler: riscv32-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=2d16803c562ecc644803d42ba98a8e0aef9c014e
git remote add herbert-cryptodev-2.6 https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
git fetch --no-tags herbert-cryptodev-2.6 master
git checkout 2d16803c562ecc644803d42ba98a8e0aef9c014e
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash lib/crypto/
If you fix the issue, kindly add following tag where applicable
All warnings (new ones prefixed by >>):
lib/crypto/blake2s-selftest.c: In function 'blake2s_selftest':
>> lib/crypto/blake2s-selftest.c:632:1: warning: the frame size of 1088 bytes is larger than 1024 bytes [-Wframe-larger-than=]
632 | }
| ^vim +632 lib/crypto/blake2s-selftest.c
2d16803c562ecc Jason A. Donenfeld 2022-05-28 614
2d16803c562ecc Jason A. Donenfeld 2022-05-28 615 memcpy(&state1, &state, sizeof(state1));
2d16803c562ecc Jason A. Donenfeld 2022-05-28 616 blake2s_compress(&state1, blocks, 1, BLAKE2S_BLOCK_SIZE);
2d16803c562ecc Jason A. Donenfeld 2022-05-28 617 for (l = 1; l < TEST_ALIGNMENT; ++l) {
2d16803c562ecc Jason A. Donenfeld 2022-05-28 618 memcpy(unaligned_block + l, blocks,
2d16803c562ecc Jason A. Donenfeld 2022-05-28 619 BLAKE2S_BLOCK_SIZE);
2d16803c562ecc Jason A. Donenfeld 2022-05-28 620 memcpy(&state2, &state, sizeof(state2));
2d16803c562ecc Jason A. Donenfeld 2022-05-28 621 blake2s_compress(&state2, unaligned_block + l, 1,
2d16803c562ecc Jason A. Donenfeld 2022-05-28 622 BLAKE2S_BLOCK_SIZE);
2d16803c562ecc Jason A. Donenfeld 2022-05-28 623 if (memcmp(&state1, &state2, sizeof(state1))) {
2d16803c562ecc Jason A. Donenfeld 2022-05-28 624 pr_err("blake2s random compress align %d self-test %d: FAIL\n",
2d16803c562ecc Jason A. Donenfeld 2022-05-28 625 l, i + 1);
2d16803c562ecc Jason A. Donenfeld 2022-05-28 626 success = false;
2d16803c562ecc Jason A. Donenfeld 2022-05-28 627 }
2d16803c562ecc Jason A. Donenfeld 2022-05-28 628 }
2d16803c562ecc Jason A. Donenfeld 2022-05-28 629 }
2d16803c562ecc Jason A. Donenfeld 2022-05-28 630
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 631 return success;66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 @632 }
:::::: The code at line 632 was first introduced by commit
:::::: 66d7fb94e4ffe5acc589e0b2b4710aecc1f07a28 crypto: blake2s - generic C library implementation and selftest
:::::: TO: Jason A. Donenfeld <[email protected]> :::::: CC: Herbert Xu <[email protected]>
Signature · 2 lines
0-DAY CI Kernel Test Service https://01.org/lkp
Jason A. Donenfeld
maintainerPATCH 1/1 lib/crypto: blake2s: reduce stack frame usage in self test
Using 3 blocks here doesn't give us much more than using 2, and it causes a stack frame size warning on certain compiler/config/arch combinations:
lib/crypto/blake2s-selftest.c: In function 'blake2s_selftest':
Quoted 1 line
Quoted 1 line
lib/crypto/blake2s-selftest.c:632:1: warning: the frame size of 1088 bytes is larger than 1024 bytes [-Wframe-larger-than=]
632 | }
| ^So this patch just reduces the block from 3 to 2, which makes the warning go away.
--- lib/crypto/blake2s-selftest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
lib/crypto/blake2s-selftest.c +3 -3
@@ -593,7 +593,7 @@ bool __init blake2s_selftest(void)enum {TEST_ALIGNMENT =16 };u8 unaligned_block[BLAKE2S_BLOCK_SIZE +TEST_ALIGNMENT -1 ]__aligned(TEST_ALIGNMENT) ; -u8 blocks[BLAKE2S_BLOCK_SIZE *3 ]; +u8 blocks[BLAKE2S_BLOCK_SIZE *2 ];struct blake2s_state state1, state2;get_random_bytes (blocks,sizeof (blocks));
@@ -603,8 +603,8 @@ bool __init blake2s_selftest(void) defined(CONFIG_CRYPTO_ARCH_HAVE_LIB_BLAKE2S) memcpy(&state1, &state, sizeof(state1));memcpy (&state2, &state,sizeof (state2)); -blake2s_compress (&state1, blocks,3 ,BLAKE2S_BLOCK_SIZE ); -blake2s_compress_generic (&state2, blocks,3 ,BLAKE2S_BLOCK_SIZE ); +blake2s_compress (&state1, blocks,2 ,BLAKE2S_BLOCK_SIZE ); +blake2s_compress_generic (&state2, blocks,2 ,BLAKE2S_BLOCK_SIZE );if (memcmp (&state1, &state2,sizeof (state1))) {pr_err ("blake2s random compress self-test %d: FAIL\n" , i +1 );
Signature · 1 line
2.35.1
Herbert Xu
maintainerRe: [PATCH] lib/crypto: blake2s: reduce stack frame usage in self test
Quoted 12 lines · Jason A. Donenfeld
Using 3 blocks here doesn't give us much more than using 2, and it causes a stack frame size warning on certain compiler/config/arch combinations:
lib/crypto/blake2s-selftest.c: In function 'blake2s_selftest':Quoted 1 line
Quoted 1 line
lib/crypto/blake2s-selftest.c:632:1: warning: the frame size of 1088 bytes is larger than 1024 bytes [-Wframe-larger-than=]632 | } | ^So this patch just reduces the block from 3 to 2, which makes the warning go away.
Quoted 7 lines
Reported-by kernel test robot <[email protected]>Fixes 2d16803c562e ("crypto: blake2s - remove shash module")Signed-off-by Jason A. Donenfeld <[email protected]>--- lib/crypto/blake2s-selftest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt