Skip to contentSkip to conversation

ARM: dts: am33xx: Fix MMCHS0 dma properties

PATCH In review YuTong Chang 2 participants 2 messages Jun 20, 2022 Device tree bindings

lore
Share & tools
lore

YuTong Chang

author
#0 lore raw

PATCH 1/1 ARM: dts: am33xx: Fix MMCHS0 dma properties

According to technical manual(table 11-24),
the DMA of MMCHS0 should be direct mapped.

Signed-off-by YuTong Chang <[email protected]>
---
 arch/arm/boot/dts/am33xx-l4.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/am33xx-l4.dtsi +2 -2
index 7da42a5b959c..0446e2622d5f 100644
@@ -1502,8 +1502,8 @@ SYSC_OMAP2_SOFTRESET |
 			mmc1: mmc@0 {
 				compatible = "ti,am335-sdhci";
 				ti,needs-special-reset;
-				dmas = <&edma_xbar 24 0 0
-					&edma_xbar 25 0 0>;
+				dmas = <&edma 24 0
+					&edma 25 0>;
 				dma-names = "tx", "rx";
 				interrupts = <64>;
 				reg = <0x0 0x1000>;
Signature · 1 line
2.36.1
#1 lore raw
Quoted 2 lines · YuTong Chang

According to technical manual(table 11-24),
the DMA of MMCHS0 should be direct mapped.

Please wrap the commit according to Linux coding style.

https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586

Quoted 11 lines
Signed-off-by YuTong Chang <[email protected]>
---
 arch/arm/boot/dts/am33xx-l4.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/am33xx-l4.dtsi +0 -0
index 7da42a5b959c..0446e2622d5f 100644

arch/arm/boot/dts/am33xx-l4.dtsi SYSC_OMAP2_SOFTRESET | · line 1506

Quoted 7 lines
arch/arm/boot/dts/am33xx-l4.dtsi +2 -2
@@ -1502,8 +1502,8 @@ SYSC_OMAP2_SOFTRESET |
 			mmc1: mmc@0 {
 				compatible = "ti,am335-sdhci";
 				ti,needs-special-reset;
-				dmas = <&edma_xbar 24 0 0
-					&edma_xbar 25 0 0>;
+				dmas = <&edma 24 0
+					&edma 25 0>;

This is still wrong from syntax point of view - should be two phandles, so <edma ...>, <edma ...>

arch/arm/boot/dts/am33xx-l4.dtsi SYSC_OMAP2_SOFTRESET | · line 1509

Quoted 3 lines
arch/arm/boot/dts/am33xx-l4.dtsi +0 -0
 				dma-names = "tx", "rx";
 				interrupts = <64>;
 				reg = <0x0 0x1000>;

Best regards,
Krzysztof