Skip to contentSkip to conversation

drm/nouveau/Kconfig: Drop duplicate "select ACPI_VIDEO"

PATCH In review Hans de Goede 2 participants 3 messages Jun 20, 2022 – Jun 23, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/nouveau/Kconfig: Drop duplicate "select ACPI_VIDEO"

Before this change nouveau's Kconfig section had 2 "select ACPI_VIDEO" statements:

select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && INPUT select ACPI_VIDEO if ACPI && X86

Drop the one with the extra conditions, if the conditions for that one are true then the second statement will always select ACPI_VIDEO already.

---
 drivers/gpu/drm/nouveau/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/nouveau/Kconfig +0 -1
index 34760164c271..03d12caf9e26 100644
@@ -11,7 +11,6 @@ config DRM_NOUVEAU
 	select DRM_TTM
 	select DRM_TTM_HELPER
 	select BACKLIGHT_CLASS_DEVICE if DRM_NOUVEAU_BACKLIGHT
-	select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && INPUT
 	select X86_PLATFORM_DEVICES if ACPI && X86
 	select ACPI_WMI if ACPI && X86
 	select MXM_WMI if ACPI && X86
Signature · 1 line
2.36.0
maintainer Reviewed-by on v1 1/1
#1 lore raw

Also, you have my permission to push this to drm-misc-next.

Quoted 28 lines · Hans de Goede

Before this change nouveau's Kconfig section had 2 "select ACPI_VIDEO" statements:

select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && INPUT select ACPI_VIDEO if ACPI && X86

Drop the one with the extra conditions, if the conditions for that one are true then the second statement will always select ACPI_VIDEO already.

---
 drivers/gpu/drm/nouveau/Kconfig | 1 -

 1 file changed, 1 deletion(-)
drivers/gpu/drm/nouveau/Kconfig +0 -0
index 34760164c271..03d12caf9e26 100644
@@ -11,7 +11,6 @@ config DRM_NOUVEAU

        select DRM_TTM
        select DRM_TTM_HELPER
        select BACKLIGHT_CLASS_DEVICE if DRM_NOUVEAU_BACKLIGHT -       select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && INPUT select X86_PLATFORM_DEVICES if ACPI && X86
        select ACPI_WMI if ACPI && X86
        select MXM_WMI if ACPI && X86

Signature · 3 lines
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat
#2 lore raw

Hi Lyude,

Quoted 3 lines · Lyude Paul

Also, you have my permission to push this to drm-misc-next.

Thanks, I've pushed this to drm-misc-next now.

Regards,

Hans

Quoted 31 lines · Hans de Goede
Quoted 28 lines

Before this change nouveau's Kconfig section had 2 "select ACPI_VIDEO" statements:

select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && INPUT select ACPI_VIDEO if ACPI && X86

Drop the one with the extra conditions, if the conditions for that one are true then the second statement will always select ACPI_VIDEO already.

---
 drivers/gpu/drm/nouveau/Kconfig | 1 -

 1 file changed, 1 deletion(-)
drivers/gpu/drm/nouveau/Kconfig +0 -0
index 34760164c271..03d12caf9e26 100644
@@ -11,7 +11,6 @@ config DRM_NOUVEAU

        select DRM_TTM
        select DRM_TTM_HELPER
        select BACKLIGHT_CLASS_DEVICE if DRM_NOUVEAU_BACKLIGHT -       select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && INPUT select X86_PLATFORM_DEVICES if ACPI && X86
        select ACPI_WMI if ACPI && X86
        select MXM_WMI if ACPI && X86