add missing normalize-resolvconf file since it has been moved to a separate file since version 1.90
PATCH 1/1 add missing normalize-resolvconf file since it has been moved to a separate file since version 1.90
From: Qorin <[email protected]>
--- meta/recipes-connectivity/resolvconf/resolvconf_1.91.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-connectivity/resolvconf/resolvconf_1.91.bb +2 -1
@@ -9,7 +9,7 @@ LICENSE = "GPL-2.0-or-later" LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b" AUTHOR = "Thomas Hood" HOMEPAGE = "http://packages.debian.org/resolvconf" -RDEPENDS:${PN} = "bash" +RDEPENDS:${PN} = "bash sed" SRC_URI = "git://salsa.debian.org/debian/resolvconf.git;protocol=https;branch=unstable \ file://99_resolvconf \
@@ -46,6 +46,7 @@ do_install () { chown -R root:root ${D}${sysconfdir}/ install -m 0755 bin/resolvconf ${D}${base_sbindir}/ install -m 0755 bin/list-records ${D}${base_libdir}/${BPN} + install -m 0755 bin/normalize-resolvconf ${D}${base_libdir}/${BPN} install -d ${D}/${sysconfdir}/network/if-up.d install -m 0755 debian/resolvconf.000resolvconf.if-up ${D}/${sysconfdir}/network/if-up.d/000resolvconf install -d ${D}/${sysconfdir}/network/if-down.d
Signature · 1 line
2.30.2
Hi Qorin,
Quoted 11 lines · On Mon, 20 Jun 2022 10:08:20 +0200 "Qorin Wu" <[email protected]> wrote:
From: Qorin <[email protected]>
--- meta/recipes-connectivity/resolvconf/resolvconf_1.91.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)meta/recipes-connectivity/resolvconf/resolvconf_1.91.bb +0
-0
meta/recipes-connectivity/resolvconf/resolvconf_1.91.bb LICENSE = "GPL-2.0-or-later" · line 12
Quoted 5 lines
meta/recipes-connectivity/resolvconf/resolvconf_1.91.bb +1
-1@@ -9,7 +9,7 @@ LICENSE = "GPL-2.0-or-later" LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b" AUTHOR = "Thomas Hood" HOMEPAGE = "http://packages.debian.org/resolvconf" -RDEPENDS:${PN} = "bash" +RDEPENDS:${PN} = "bash sed"
Can you pelase explain how adding the 'sed' RDEPENDS is related to the normalize-resolvconf change?
Quoted 10 lines
meta/recipes-connectivity/resolvconf/resolvconf_1.91.bb +1
-0SRC_URI = "git://salsa.debian.org/debian/resolvconf.git;protocol=https;branch=unstable \ file://99_resolvconf \@@ -46,6 +46,7 @@ do_install () { chown -R root:root ${D}${sysconfdir}/ install -m 0755 bin/resolvconf ${D}${base_sbindir}/ install -m 0755 bin/list-records ${D}${base_libdir}/${BPN} + install -m 0755 bin/normalize-resolvconf ${D}${base_libdir}/${BPN} install -d ${D}/${sysconfdir}/network/if-up.d install -m 0755 debian/resolvconf.000resolvconf.if-up ${D}/${sysconfdir}/network/if-up.d/000resolvconf install -d ${D}/${sysconfdir}/network/if-down.d
Signature · 3 lines
Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
A message that is not in the archive (sent off-list or not yet received): AM0PR06MB4625172F0F099B35BB980A7BD9B09@AM0PR06MB4625.eurprd06.prod.outlook.com
Hi Qorin,
Quoted 7 lines · On Mon, 20 Jun 2022 09:24:22 +0000 Qorin Qorinna <[email protected]>…
Hi Luca,
it's because the normalize-resolvconf requires sed.
These are the error messages that I got when I built the package w/o sed
ERROR: resolvconf-1.91-r0do_package_qa: QA Issue:/lib/resolvconf/normalize-resolvconfcontained in package resolvconf requires/bin/sed, but no providers found in RDEPENDS:resolvconf? [file-rdeps]
ERROR: resolvconf-1.91-r0do_package_qa: Fatal QA errors were found, failing task.
I see. In this case it would be nice to add either a line to the commit message or a comment in the .bb file, just to avoid others to wonder why sed is needed.
I added a line to the commit message on my branch that I'm going to test. It would be great if you could do so for future patches. Thanks!
Signature · 3 lines
Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Quoted 9 lines
-----Original Message-----
From: [email protected] <openembedded-
[email protected]> On Behalf Of Luca Ceresoli via
lists.openembedded.org
Sent: den 20 juni 2022 11:50
To: Qorin Qorinna <[email protected]>
Cc: Qorin Wu <[email protected]>; openembedded-
[email protected]
Subject: Re: [OE-core] [PATCH] add missing normalize-resolvconf file since it has been moved to a separate file since version 1.90
It is expected that the subject line is prefixed with the recipe name. It is also a very long subject line. Better would be to move half of it to the commit message body, e.g.:
resolvconf: Install missing normalize-resolvconf file
It was moved to a separate file in version 1.90.
Quoted 9 lines
Hi Qorin,
Quoted 4 lines · On Mon, 20 Jun 2022 09:24:22 +0000 Qorin Qorinna <[email protected]>…
Hi Luca,
it's because the normalize-resolvconf requires sed.
Quoted 7 lines
Quoted 3 lines
These are the error messages that I got when I built the package w/o sed
ERROR: resolvconf-1.91-r0do_package_qa: QA Issue:/lib/resolvconf/normalize-resolvconfcontained in package resolvconf requires/bin/sed, but no providers found in RDEPENDS:resolvconf? [file-rdeps]
ERROR: resolvconf-1.91-r0do_package_qa: Fatal QA errors were found, failing task.I see. In this case it would be nice to add either a line to the commit message or a comment in the .bb file, just to avoid others to wonder why sed is needed.
The problem here is that sed is provided by busybox and in almost all cases you do not want an explicit dependency on sed as that instead will install the sed program from the sed recipe.
In this case I would recommend to add something like this:
# The normalize-resolvconf sed script uses /bin/sed on the shebang line. # Ignore the file-rdeps test to avoid having to add a runtime dependency on sed. INSANE_SKIP:${PN} += "file-rdeps"
Quoted 7 lines
I added a line to the commit message on my branch that I'm going to test. It would be great if you could do so for future patches. Thanks!
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
//Peter
Hi Peter and Luca,
Thanks. I have updated the sed dependency and fixed the commit message. Ignore the 2nd mail, the 3rd mail was the correct one.
Regards,
Qorin
Quoted 63 lines · Peter Kjellerstedt
Quoted 9 lines
-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Luca Ceresoli via lists.openembedded.org
Sent: den 20 juni 2022 11:50
To: Qorin Qorinna <[email protected]>
Cc: Qorin Wu <[email protected]>; openembedded- [email protected]
Subject: Re: [OE-core] [PATCH] add missing normalize-resolvconf filesince it has been moved to a separate file since version 1.90
It is expected that the subject line is prefixed with the recipe name. It is also a very long subject line. Better would be to move half of it to the commit message body, e.g.:
resolvconf: Install missing normalize-resolvconf file
It was moved to a separate file in version 1.90.
Quoted 10 lines
Hi Qorin,
Quoted 5 lines · On Mon, 20 Jun 2022 09:24:22 +0000 Qorin Qorinna <[email protected]>…
Hi Luca,
it's because the normalize-resolvconf requires sed.
These are the error messages that I got when I built the package w/o
sed
Quoted 1 line
Quoted 1 line
ERROR: resolvconf-1.91-r0
do_package_qa: QA Issue:
/lib/resolvconf/normalize-resolvconfcontained in package resolvconf requires/bin/sed, but no providers found in RDEPENDS:resolvconf? [file-rdeps]Quoted 1 line
Quoted 1 line
ERROR: resolvconf-1.91-r0
do_package_qa: Fatal QA errors were found,failing task.
Quoted 4 lines
I see. In this case it would be nice to add either a line to the commit message or a comment in the .bb file, just to avoid others to wonder why sed is needed.
The problem here is that sed is provided by busybox and in almost all cases you do not want an explicit dependency on sed as that instead will install the sed program from the sed recipe.
In this case I would recommend to add something like this:
# The normalize-resolvconf sed script uses
/bin/sedon the shebang line. # Ignore the file-rdeps test to avoid having to add a runtime dependency on sed.
INSANE_SKIP:${PN} += "file-rdeps"Quoted 7 lines
I added a line to the commit message on my branch that I'm going to test. It would be great if you could do so for future patches. Thanks!
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com//Peter
Hi Qorin,
Quoted 20 lines · On Mon, 20 Jun 2022 10:08:20 +0200 "Qorin Wu" <[email protected]> wrote:
From: Qorin <[email protected]>
--- meta/recipes-connectivity/resolvconf/resolvconf_1.91.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)meta/recipes-connectivity/resolvconf/resolvconf_1.91.bb +1
-1@@ -9,7 +9,7 @@ LICENSE = "GPL-2.0-or-later" LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b" AUTHOR = "Thomas Hood" HOMEPAGE = "http://packages.debian.org/resolvconf" -RDEPENDS:${PN} = "bash" +RDEPENDS:${PN} = "bash sed" SRC_URI = "git://salsa.debian.org/debian/resolvconf.git;protocol=https;branch=unstable \ file://99_resolvconf \
meta/recipes-connectivity/resolvconf/resolvconf_1.91.bb do_install () { · line 52
Quoted 7 lines
meta/recipes-connectivity/resolvconf/resolvconf_1.91.bb +1
-0@@ -46,6 +46,7 @@ do_install () { chown -R root:root ${D}${sysconfdir}/ install -m 0755 bin/resolvconf ${D}${base_sbindir}/ install -m 0755 bin/list-records ${D}${base_libdir}/${BPN} + install -m 0755 bin/normalize-resolvconf ${D}${base_libdir}/${BPN} install -d ${D}/${sysconfdir}/network/if-up.d install -m 0755 debian/resolvconf.000resolvconf.if-up ${D}/${sysconfdir}/network/if-up.d/000resolvconf install -d ${D}/${sysconfdir}/network/if-down.d
When running this patch in the autobuilders, there are failures related to resolvconf:
ERROR: When reparsing /tmp/selftest-fetchpkz67tpd/test.bb:do_checkuri,
the basehash value changed from 84b9e23a83a764e7a5d8a96ee523199e2b1c604f4280a45030e248de0ff52962 to 4123da244f465feffecb2b4fd2b132b64851981ec2fb70bf9445df8b0ea6a69e. The metadata is not deterministic and this needs to be fixed.
I must say there is no clear reason for me for this error given the simple patch you sent. Other here can be more helpful. I'm waiting for this to be understood before taking updated version of your patch.
Here are some logs showing the error:
https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/3671/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/3687/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/3731/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/3723/steps/15/logs/stdio
Signature · 3 lines
Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com