Skip to contentSkip to conversation

cgroup.c: remove redundant check for mixable cgroup in cgroup_migrate_vet_dst

PATCH Applied Lin Feng 3 participants 3 messages Jun 21, 2022 – Jun 27, 2022 cgroup

lore
Share & tools
lore

Lin Feng

author
#0 lore raw

PATCH 1/1 cgroup.c: remove redundant check for mixable cgroup in cgroup_migrate_vet_dst

We have:
int cgroup_migrate_vet_dst(struct cgroup *dst_cgrp) {
...

	/* mixables don't care */
	if (cgroup_is_mixable(dst_cgrp))
		return 0;

	/*
	 * If @dst_cgrp is already or can become a thread root or is
	 * threaded, it doesn't matter.
	 */
	if (cgroup_can_be_thread_root(dst_cgrp) || cgroup_is_threaded(dst_cgrp))
		return 0;

...
}

but in fact the entry of cgroup_can_be_thread_root() covers case that checking cgroup_is_mixable() as following:
static bool cgroup_can_be_thread_root(struct cgroup *cgrp)

{
        /* mixables don't care */
        if (cgroup_is_mixable(cgrp))
                return true;

...
}

so explicitly checking in cgroup_migrate_vet_dst is unnecessary.

---
 kernel/cgroup/cgroup.c | 4 ----
 1 file changed, 4 deletions(-)
kernel/cgroup/cgroup.c +0 -4
index 1779ccddb734..ad4aa08ec988 100644
@@ -2570,10 +2570,6 @@ int cgroup_migrate_vet_dst(struct cgroup *dst_cgrp)
 	if (!cgroup_is_valid_domain(dst_cgrp->dom_cgrp))
 		return -EOPNOTSUPP;
 
-	/* mixables don't care */
-	if (cgroup_is_mixable(dst_cgrp))
-		return 0;
-
 	/*
 	 * If @dst_cgrp is already or can become a thread root or is
 	 * threaded, it doesn't matter.
Signature · 1 line
2.31.1