dt-bindings: phy: qcom,qmp: add IPQ8074 PCIe Gen3 PHY binding
PATCH v2 1/2 dt-bindings: phy: qcom,qmp: add IPQ8074 PCIe Gen3 PHY binding
IPQ8074 has 2 different single lane PCIe PHY-s, one Gen2 and one Gen3. Gen2 one is already supported, document the bindings for the Gen3 one.
--- Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml +2 -0
@@ -19,6 +19,7 @@ properties: enum: - qcom,ipq6018-qmp-pcie-phy - qcom,ipq6018-qmp-usb3-phy + - qcom,ipq8074-qmp-gen3-pcie-phy - qcom,ipq8074-qmp-pcie-phy - qcom,ipq8074-qmp-usb3-phy - qcom,msm8996-qmp-pcie-phy
@@ -312,6 +313,7 @@ allOf: contains: enum: - qcom,ipq6018-qmp-pcie-phy + - qcom,ipq8074-qmp-gen3-pcie-phy - qcom,ipq8074-qmp-pcie-phy then: properties:
Signature · 1 line
2.36.1
PATCH v2 2/2 phy: qcom-qmp-pcie: add IPQ8074 PCIe Gen3 QMP PHY support
IPQ8074 has 2 different single lane PCIe PHY-s, one Gen2 and one Gen3. Gen2 one is already supported, so add the support for the Gen3 one. It uses the same register layout as IPQ6018.
---
Changes in v2:
* Rebase onto next-20220621 to apply on the refactored driver
* Remove non existant has_phy_com_ctrl and has_lane_rst
--- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 171 ++++++++++++++++++++++- 1 file changed, 169 insertions(+), 2 deletions(-)
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +169 -2
@@ -450,6 +450,133 @@ static const struct qmp_phy_init_tbl ipq8074_pcie_pcs_tbl[] = { QMP_PHY_INIT_CFG_L(QPHY_START_CTRL, 0x3), }; +static const struct qmp_phy_init_tbl ipq8074_pcie_gen3_serdes_tbl[] = { +QMP_PHY_INIT_CFG (QSERDES_PLL_BIAS_EN_CLKBUFLR_EN ,0x18 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_BIAS_EN_CTRL_BY_PSM ,0x01 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_CLK_SELECT ,0x31 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_PLL_IVCO ,0x0f ), +QMP_PHY_INIT_CFG (QSERDES_PLL_BG_TRIM ,0x0f ), +QMP_PHY_INIT_CFG (QSERDES_PLL_CMN_CONFIG ,0x06 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_LOCK_CMP_EN ,0x42 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_RESETSM_CNTRL ,0x20 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_SVS_MODE_CLK_SEL ,0x01 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_VCO_TUNE_MAP ,0x04 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_SVS_MODE_CLK_SEL ,0x05 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_VCO_TUNE_TIMER1 ,0xff ), +QMP_PHY_INIT_CFG (QSERDES_PLL_VCO_TUNE_TIMER2 ,0x3f ), +QMP_PHY_INIT_CFG (QSERDES_PLL_CORE_CLK_EN ,0x30 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_HSCLK_SEL ,0x21 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_DEC_START_MODE0 ,0x82 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_DIV_FRAC_START3_MODE0 ,0x03 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_DIV_FRAC_START2_MODE0 ,0x355 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_DIV_FRAC_START1_MODE0 ,0x35555 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_LOCK_CMP2_MODE0 ,0x1a ), +QMP_PHY_INIT_CFG (QSERDES_PLL_LOCK_CMP1_MODE0 ,0x1a0a ), +QMP_PHY_INIT_CFG (QSERDES_PLL_CP_CTRL_MODE0 ,0xb ), +QMP_PHY_INIT_CFG (QSERDES_PLL_PLL_RCTRL_MODE0 ,0x16 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_PLL_CCTRL_MODE0 ,0x28 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_INTEGLOOP_GAIN1_MODE0 ,0x0 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_INTEGLOOP_GAIN0_MODE0 ,0x40 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_VCO_TUNE2_MODE0 ,0x02 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_VCO_TUNE1_MODE0 ,0x24 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_SVS_MODE_CLK_SEL ,0x05 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_CORE_CLK_EN ,0x20 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_CORECLK_DIV ,0xa ), +QMP_PHY_INIT_CFG (QSERDES_PLL_CLK_SELECT ,0x32 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_SYS_CLK_CTRL ,0x02 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_SYSCLK_BUF_ENABLE ,0x07 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_SYSCLK_EN_SEL ,0x08 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_BG_TIMER ,0xa ), +QMP_PHY_INIT_CFG (QSERDES_PLL_HSCLK_SEL ,0x1 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_DEC_START_MODE1 ,0x68 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_DIV_FRAC_START3_MODE1 ,0x2 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_DIV_FRAC_START2_MODE1 ,0x2aa ), +QMP_PHY_INIT_CFG (QSERDES_PLL_DIV_FRAC_START1_MODE1 ,0x2aaab ), +QMP_PHY_INIT_CFG (QSERDES_PLL_CLK_ENABLE1 ,0x90 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_LOCK_CMP2_MODE1 ,0x34 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_LOCK_CMP1_MODE1 ,0x3414 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_CP_CTRL_MODE1 ,0x0b ), +QMP_PHY_INIT_CFG (QSERDES_PLL_PLL_RCTRL_MODE1 ,0x16 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_PLL_CCTRL_MODE1 ,0x28 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_INTEGLOOP_GAIN1_MODE1 ,0x0 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_INTEGLOOP_GAIN0_MODE1 ,0x40 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_VCO_TUNE2_MODE1 ,0x03 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_VCO_TUNE1_MODE1 ,0xb4 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_SVS_MODE_CLK_SEL ,0x05 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_CORE_CLK_EN ,0x0 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_CORECLK_DIV_MODE1 ,0x08 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_CLK_EP_DIV_MODE0 ,0x19 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_CLK_EP_DIV_MODE1 ,0x28 ), +QMP_PHY_INIT_CFG (QSERDES_PLL_CLK_ENABLE1 ,0x90 ), +}; + +static const struct qmp_phy_init_tbl ipq8074_pcie_gen3_tx_tbl[] = { +QMP_PHY_INIT_CFG (QSERDES_TX0_RES_CODE_LANE_OFFSET_TX ,0x02 ), +QMP_PHY_INIT_CFG (QSERDES_TX0_RCV_DETECT_LVL_2 ,0x12 ), +QMP_PHY_INIT_CFG (QSERDES_TX0_HIGHZ_DRVR_EN ,0x10 ), +QMP_PHY_INIT_CFG (QSERDES_TX0_LANE_MODE_1 ,0x06 ), +}; + +static const struct qmp_phy_init_tbl ipq8074_pcie_gen3_rx_tbl[] = { +QMP_PHY_INIT_CFG (QSERDES_RX0_SIGDET_CNTRL ,0x03 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_SIGDET_ENABLES ,0x1c ), +QMP_PHY_INIT_CFG (QSERDES_RX0_SIGDET_DEGLITCH_CNTRL ,0x14 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_EQU_ADAPTOR_CNTRL2 ,0xe ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_EQU_ADAPTOR_CNTRL3 ,0x4 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_EQU_ADAPTOR_CNTRL4 ,0x1b ), +QMP_PHY_INIT_CFG (QSERDES_RX0_DFE_EN_TIMER ,0x04 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_UCDR_SO_SATURATION_AND_ENABLE ,0x7f ), +QMP_PHY_INIT_CFG (QSERDES_RX0_UCDR_PI_CONTROLS ,0x70 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_EQ_OFFSET_ADAPTOR_CNTRL1 ,0x73 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_OFFSET_ADAPTOR_CNTRL2 ,0x80 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_MODE_10_LOW ,0x00 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_MODE_10_HIGH ,0x02 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_MODE_10_HIGH2 ,0xc8 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_MODE_10_HIGH3 ,0x09 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_MODE_10_HIGH4 ,0xb1 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_MODE_01_LOW ,0x01 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_MODE_01_HIGH ,0x02 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_MODE_01_HIGH2 ,0xc8 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_MODE_01_HIGH3 ,0x09 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_MODE_01_HIGH4 ,0xb1 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_MODE_00_LOW ,0xf0 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_MODE_00_HIGH ,0x2 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_MODE_00_HIGH2 ,0x2f ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_MODE_00_HIGH3 ,0xd3 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_MODE_00_HIGH4 ,0x40 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_IDAC_TSETTLE_HIGH ,0x00 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_RX_IDAC_TSETTLE_LOW ,0xc0 ), +QMP_PHY_INIT_CFG (QSERDES_RX0_UCDR_FO_GAIN ,0x0c ), +QMP_PHY_INIT_CFG (QSERDES_RX0_UCDR_SO_GAIN ,0x02 ), +}; + +static const struct qmp_phy_init_tbl ipq8074_pcie_gen3_pcs_tbl[] = { +QMP_PHY_INIT_CFG (PCS_COM_FLL_CNTRL2 ,0x83 ), +QMP_PHY_INIT_CFG (PCS_COM_FLL_CNT_VAL_L ,0x9 ), +QMP_PHY_INIT_CFG (PCS_COM_FLL_CNT_VAL_H_TOL ,0x42 ), +QMP_PHY_INIT_CFG (PCS_COM_FLL_MAN_CODE ,0x40 ), +QMP_PHY_INIT_CFG (PCS_COM_FLL_CNTRL1 ,0x01 ), +QMP_PHY_INIT_CFG (PCS_COM_P2U3_WAKEUP_DLY_TIME_AUXCLK_H ,0x0 ), +QMP_PHY_INIT_CFG (PCS_COM_P2U3_WAKEUP_DLY_TIME_AUXCLK_L ,0x1 ), +QMP_PHY_INIT_CFG (PCS_PCIE_OSC_DTCT_ACTIONS ,0x0 ), +QMP_PHY_INIT_CFG (PCS_PCIE_L1P1_WAKEUP_DLY_TIME_AUXCLK_H ,0x00 ), +QMP_PHY_INIT_CFG (PCS_PCIE_L1P1_WAKEUP_DLY_TIME_AUXCLK_L ,0x01 ), +QMP_PHY_INIT_CFG (PCS_PCIE_L1P2_WAKEUP_DLY_TIME_AUXCLK_H ,0x00 ), +QMP_PHY_INIT_CFG (PCS_PCIE_L1P2_WAKEUP_DLY_TIME_AUXCLK_L ,0x01 ), +QMP_PHY_INIT_CFG (PCS_PCIE_EQ_CONFIG1 ,0x11 ), +QMP_PHY_INIT_CFG (PCS_PCIE_EQ_CONFIG2 ,0xb ), +QMP_PHY_INIT_CFG (PCS_PCIE_POWER_STATE_CONFIG4 ,0x07 ), +QMP_PHY_INIT_CFG (PCS_PCIE_OSC_DTCT_CONFIG2 ,0x52 ), +QMP_PHY_INIT_CFG (PCS_PCIE_OSC_DTCT_MODE2_CONFIG2 ,0x50 ), +QMP_PHY_INIT_CFG (PCS_PCIE_OSC_DTCT_MODE2_CONFIG4 ,0x1a ), +QMP_PHY_INIT_CFG (PCS_PCIE_OSC_DTCT_MODE2_CONFIG5 ,0x6 ), +QMP_PHY_INIT_CFG (PCS_COM_G12S1_TXDEEMPH_M3P5DB ,0x10 ), +QMP_PHY_INIT_CFG (PCS_PCIE_ENDPOINT_REFCLK_DRIVE ,0xc1 ), +QMP_PHY_INIT_CFG (PCS_COM_RX_DCC_CAL_CONFIG ,0x01 ), +QMP_PHY_INIT_CFG (PCS_COM_RX_SIGDET_LVL ,0xaa ), +QMP_PHY_INIT_CFG (PCS_COM_REFGEN_REQ_CONFIG1 ,0x0d ), +}; +static const struct qmp_phy_init_tbl sdm845_qmp_pcie_serdes_tbl[] = {QMP_PHY_INIT_CFG (QSERDES_V3_COM_BIAS_EN_CLKBUFLR_EN ,0x14 ),QMP_PHY_INIT_CFG (QSERDES_V3_COM_CLK_SELECT ,0x30 ),
@@ -1421,6 +1548,34 @@ static const struct qmp_phy_cfg ipq8074_pciephy_cfg = { .pwrdn_delay_max = 1005, /* us */ }; +static const struct qmp_phy_cfg ipq8074_pciephy_gen3_cfg = { + .type =PHY_TYPE_PCIE , + .nlanes =1 , + + .serdes_tbl = ipq8074_pcie_gen3_serdes_tbl, + .serdes_tbl_num =ARRAY_SIZE (ipq8074_pcie_gen3_serdes_tbl), + .tx_tbl = ipq8074_pcie_gen3_tx_tbl, + .tx_tbl_num =ARRAY_SIZE (ipq8074_pcie_gen3_tx_tbl), + .rx_tbl = ipq8074_pcie_gen3_rx_tbl, + .rx_tbl_num =ARRAY_SIZE (ipq8074_pcie_gen3_rx_tbl), + .pcs_tbl = ipq8074_pcie_gen3_pcs_tbl, + .pcs_tbl_num =ARRAY_SIZE (ipq8074_pcie_gen3_pcs_tbl), + .clk_list = ipq8074_pciephy_clk_l, + .num_clks =ARRAY_SIZE (ipq8074_pciephy_clk_l), + .reset_list = ipq8074_pciephy_reset_l, + .num_resets =ARRAY_SIZE (ipq8074_pciephy_reset_l), + .vreg_list =NULL , + .num_vregs =0 , + .regs = ipq_pciephy_gen3_regs_layout, + + .start_ctrl =SERDES_START |PCS_START , + .pwrdn_ctrl =SW_PWRDN |REFCLK_DRV_DSBL , + + .has_pwrdn_delay = true, + .pwrdn_delay_min =995 ,/* us */ + .pwrdn_delay_max =1005 ,/* us */ +}; +static const struct qmp_phy_cfg ipq6018_pciephy_cfg = { .type =PHY_TYPE_PCIE , .nlanes =1 ,
@@ -2107,6 +2262,7 @@ static int phy_pipe_clk_register(struct qcom_qmp *qmp, struct device_node *np) {struct clk_fixed_rate *fixed;struct clk_init_data init = { }; +u32 rate;int ret; ret =of_property_read_string (np,"clock-output-names" , &init.name);
@@ -2121,8 +2277,16 @@ static int phy_pipe_clk_register(struct qcom_qmp *qmp, struct device_node *np) init.ops = &clk_fixed_rate_ops; -/* controllers using QMP phys use 125MHz pipe clock interface */ - fixed->fixed_rate =125000000 ; +/* +* Controllers using QMP PHY-s use 125MHz pipe clock interface +* unless other frequency is specified in the DTS. +*/ + ret =of_property_read_u32 (np,"clock-output-rate" , &rate); +if (ret) + fixed->fixed_rate =125000000 ; +else + fixed->fixed_rate = rate; + fixed->hw.init = &init; ret =devm_clk_hw_register (qmp->dev, &fixed->hw);
@@ -2255,6 +2419,9 @@ static const struct of_device_id qcom_qmp_phy_pcie_of_match_table[] = { }, { .compatible = "qcom,ipq8074-qmp-pcie-phy", .data = &ipq8074_pciephy_cfg, + }, { + .compatible = "qcom,ipq8074-qmp-gen3-pcie-phy", + .data = &ipq8074_pciephy_gen3_cfg, }, { .compatible = "qcom,ipq6018-qmp-pcie-phy", .data = &ipq6018_pciephy_cfg,
Signature · 1 line
2.36.1
Re: [PATCH v2 2/2] phy: qcom-qmp-pcie: add IPQ8074 PCIe Gen3 QMP PHY support
Quoted 18 lines · Robert Marko
IPQ8074 has 2 different single lane PCIe PHY-s, one Gen2 and one Gen3. Gen2 one is already supported, so add the support for the Gen3 one. It uses the same register layout as IPQ6018.
Signed-off-by Robert Marko <[email protected]>---
Changes in v2:
* Rebase onto next-20220621 to apply on the refactored driver
* Remove non existanthas_phy_com_ctrlandhas_lane_rst--- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 171 ++++++++++++++++++++++- 1 file changed, 169 insertions(+), 2 deletions(-)drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +0
-0
[skipped]
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c static int phy_pipe_clk_register(struct qcom_qmp *qmp, struct device_node *np) · line 2284
Quoted 11 lines
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +5
-2@@ -2121,8 +2277,16 @@ static int phy_pipe_clk_register(struct qcom_qmp *qmp, struct device_node *np) init.ops = &clk_fixed_rate_ops; -/* controllers using QMP phys use 125MHz pipe clock interface */ - fixed->fixed_rate =125000000 ; +/* +* Controllers using QMP PHY-s use 125MHz pipe clock interface +* unless other frequency is specified in the DTS. +*/ + ret =of_property_read_u32 (np,"clock-output-rate" , &rate);
The clock-output-rate is a new property, which doesn't exist yet. If the rate is peculiar to your platform/PHY, I'd suggest adding a field to the qmp configuration instead.
Quoted 21 lines
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +8
-1+if (ret) + fixed->fixed_rate =125000000 ; +else + fixed->fixed_rate = rate; + fixed->hw.init = &init; ret =devm_clk_hw_register (qmp->dev, &fixed->hw);@@ -2255,6 +2419,9 @@ static const struct of_device_id qcom_qmp_phy_pcie_of_match_table[] = { }, { .compatible = "qcom,ipq8074-qmp-pcie-phy", .data = &ipq8074_pciephy_cfg, + }, { + .compatible = "qcom,ipq8074-qmp-gen3-pcie-phy", + .data = &ipq8074_pciephy_gen3_cfg, }, { .compatible = "qcom,ipq6018-qmp-pcie-phy", .data = &ipq6018_pciephy_cfg, --2.36.1
Signature · 2 lines
With best wishes Dmitry
Re: [PATCH v2 2/2] phy: qcom-qmp-pcie: add IPQ8074 PCIe Gen3 QMP PHY support
Quoted 27 lines · Dmitry Baryshkov
Quoted 18 lines · Robert Marko
IPQ8074 has 2 different single lane PCIe PHY-s, one Gen2 and one Gen3. Gen2 one is already supported, so add the support for the Gen3 one. It uses the same register layout as IPQ6018.
Signed-off-by Robert Marko <[email protected]>---
Changes in v2:
* Rebase onto next-20220621 to apply on the refactored driver
* Remove non existanthas_phy_com_ctrlandhas_lane_rst--- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 171 ++++++++++++++++++++++- 1 file changed, 169 insertions(+), 2 deletions(-)drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +0
-0[skipped]
Quoted 4 lines
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +0
-0@@ -2121,8 +2277,16 @@ static int phy_pipe_clk_register(struct qcom_qmp *qmp, struct device_node *np) init.ops = &clk_fixed_rate_ops;
Quoted 11 lines
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c static int phy_pipe_clk_register(struct qcom_qmp *qmp, struct device_node *np) · line 2284
Quoted 7 lines
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +5
-2-/* controllers using QMP phys use 125MHz pipe clock interface */ - fixed->fixed_rate =125000000 ; +/* +* Controllers using QMP PHY-s use 125MHz pipe clock interface +* unless other frequency is specified in the DTS. +*/ + ret =of_property_read_u32 (np,"clock-output-rate" , &rate);The clock-output-rate is a new property, which doesn't exist yet. If the rate is peculiar to your platform/PHY, I'd suggest adding a field to the qmp configuration instead.
Hi,
That sounds like a better idea than adding new DT property, it's specific only to the Gen3 PHY
for IPQ8074.
I will change it for v3.
Regards,
Robert
Quoted 27 lines
Quoted 20 lines
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +8
-1+if (ret) + fixed->fixed_rate =125000000 ; +else + fixed->fixed_rate = rate; + fixed->hw.init = &init; ret =devm_clk_hw_register (qmp->dev, &fixed->hw);@@ -2255,6 +2419,9 @@ static const struct of_device_id qcom_qmp_phy_pcie_of_match_table[] = { }, { .compatible = "qcom,ipq8074-qmp-pcie-phy", .data = &ipq8074_pciephy_cfg, + }, { + .compatible = "qcom,ipq8074-qmp-gen3-pcie-phy", + .data = &ipq8074_pciephy_gen3_cfg, }, { .compatible = "qcom,ipq6018-qmp-pcie-phy", .data = &ipq6018_pciephy_cfg, --Quoted 2 lines
2.36.1
--
With best wishes
Dmitry