Skip to contentSkip to conversation

mips: mti-malta: Fix refcount leak in malta-time.c

PATCH Applied Liang He 2 participants 2 messages Jun 16, 2022 – Jun 21, 2022 MIPS

lore
Share & tools
lore

Liang He

author
#0 lore raw

PATCH 1/1 mips: mti-malta: Fix refcount leak in malta-time.c

In update_gic_frequency_dt(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore.

---
 arch/mips/mti-malta/malta-time.c | 2 ++
 1 file changed, 2 insertions(+)
arch/mips/mti-malta/malta-time.c +2 -0
index bbf1e38e1431..2cb708cdf01a 100644
@@ -214,6 +214,8 @@ static void update_gic_frequency_dt(void)
 
 	if (of_update_property(node, &gic_frequency_prop) < 0)
 		pr_err("error updating gic frequency property\n");
+
+	of_node_put(node);
 }
 
 #endif
Signature · 1 line
2.25.1
maintainer Applied
#1 lore raw
Quoted 24 lines · Liang He

In update_gic_frequency_dt(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore.

---
 arch/mips/mti-malta/malta-time.c | 2 ++
 1 file changed, 2 insertions(+)
arch/mips/mti-malta/malta-time.c +2 -0
index bbf1e38e1431..2cb708cdf01a 100644
@@ -214,6 +214,8 @@ static void update_gic_frequency_dt(void)
 
 	if (of_update_property(node, &gic_frequency_prop) < 0)
 		pr_err("error updating gic frequency property\n");
+
+	of_node_put(node);
 }
 
 #endif
Signature · 1 line
2.25.1

applied to mips-fixes.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]