MIPS: Fix 2 typos
PATCH 1/1 MIPS: Fix 2 typos
Change 'modifed' to 'modified'.
Change 'relys' to 'relays'.
--- arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/mips/cavium-octeon/executive/cvmx-helper-board.c +2 -2
@@ -282,9 +282,9 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port)* support and should return the number of actual ports on the * board. * -* This function must be modifed for every new Octeon board. +* This function must be modified for every new Octeon board. * Internally it uses switch statements based on the cvmx_sysinfo -* data to determine board types and revisions. It relys on the +* data to determine board types and revisions. It relays on the * fact that every Octeon board receives a unique board type * enumeration from the bootloader. *
Signature · 1 line
2.25.1
Hello!
Quoted 2 lines · Zhang Jiaming
Change 'modifed' to 'modified'.
Change 'relys' to 'relays'.
I think it should be 'relies', not 'relays'.
Quoted 11 lines
Signed-off-by Zhang Jiaming <[email protected]>--- arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/mips/cavium-octeon/executive/cvmx-helper-board.c +0
-0@@ -282,9 +282,9 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port)* support and should return the number of actual ports on the
arch/mips/cavium-octeon/executive/cvmx-helper-board.c union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port) · line 290
Quoted 10 lines
arch/mips/cavium-octeon/executive/cvmx-helper-board.c +2
-2* board. * -* This function must be modifed for every new Octeon board. +* This function must be modified for every new Octeon board. * Internally it uses switch statements based on the cvmx_sysinfo -* data to determine board types and revisions. It relys on the +* data to determine board types and revisions. It relays on the * fact that every Octeon board receives a unique board type * enumeration from the bootloader. *
MBR, Sergey
PATCH v2 1/1 MIPS: Fix some typos
In reply to Zhang JiamingChange 'modifed' to 'modified'.
Change 'relys' to 'relies'.
--- .../mips/cavium-octeon/executive/cvmx-helper-board.c | 4 ++-- arch/mips/include/asm/octeon/cvmx-helper-board.h | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-)
arch/mips/cavium-octeon/executive/cvmx-helper-board.c +2 -2
@@ -282,9 +282,9 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port)* support and should return the number of actual ports on the * board. * -* This function must be modifed for every new Octeon board. +* This function must be modified for every new Octeon board. * Internally it uses switch statements based on the cvmx_sysinfo -* data to determine board types and revisions. It relys on the +* data to determine board types and revisions. It relies on the * fact that every Octeon board receives a unique board type * enumeration from the bootloader. *
arch/mips/include/asm/octeon/cvmx-helper-board.h +6 -6
@@ -63,9 +63,9 @@ typedef enum {* connected to this port. On chips supporting multiple MII * busses the bus number is encoded in bits <15:8>. * -* This function must be modifed for every new Octeon board. +* This function must be modified for every new Octeon board. * Internally it uses switch statements based on the cvmx_sysinfo -* data to determine board types and revisions. It relys on the +* data to determine board types and revisions. It relies on the * fact that every Octeon board receives a unique board type * enumeration from the bootloader. *
@@ -81,9 +81,9 @@ extern int cvmx_helper_board_get_mii_address(int ipd_port);* and are handled by the fall through case. This function must be * updated for boards that don't have the normal Marvell PHYs. * -* This function must be modifed for every new Octeon board. +* This function must be modified for every new Octeon board. * Internally it uses switch statements based on the cvmx_sysinfo -* data to determine board types and revisions. It relys on the +* data to determine board types and revisions. It relies on the * fact that every Octeon board receives a unique board type * enumeration from the bootloader. *
@@ -103,9 +103,9 @@ extern union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port);* support and should return the number of actual ports on the * board. * -* This function must be modifed for every new Octeon board. +* This function must be modified for every new Octeon board. * Internally it uses switch statements based on the cvmx_sysinfo -* data to determine board types and revisions. It relys on the +* data to determine board types and revisions. It relies on the * fact that every Octeon board receives a unique board type * enumeration from the bootloader. *
Signature · 1 line
2.25.1
Re: [PATCH v2] MIPS: Fix some typos
Quoted 8 lines · Zhang Jiaming
Change 'modifed' to 'modified'.
Change 'relys' to 'relies'.Signed-off-by Zhang Jiaming <[email protected]>--- .../mips/cavium-octeon/executive/cvmx-helper-board.c | 4 ++-- arch/mips/include/asm/octeon/cvmx-helper-board.h | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-)
applied to mips-next.
Thomas.
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
Quoted 13 lines · Zhang Jiaming
Change 'modifed' to 'modified'.
Change 'relys' to 'relays'.Signed-off-by Zhang Jiaming <[email protected]>--- arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/mips/cavium-octeon/executive/cvmx-helper-board.c +0
-0
arch/mips/cavium-octeon/executive/cvmx-helper-board.c union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port) · line 287
Quoted 7 lines
arch/mips/cavium-octeon/executive/cvmx-helper-board.c +1
-2@@ -282,9 +282,9 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port)* support and should return the number of actual ports on the * board. * -* This function must be modifed for every new Octeon board. +* This function must be modified for every new Octeon board. * Internally it uses switch statements based on the cvmx_sysinfo -* data to determine board types and revisions. It relys on the
relies
But it would be better to restrict this barrage (or swarm) of patches to Kconfig help text problems and/or strings that are printed to users.
Quoted 4 lines
arch/mips/cavium-octeon/executive/cvmx-helper-board.c +1
-0+* data to determine board types and revisions. It relays on the * fact that every Octeon board receives a unique board type * enumeration from the bootloader. *
Signature · 1 line
~Randy
Quoted 3 lines · Randy Dunlap
Quoted 2 lines · Zhang Jiaming
Change 'modifed' to 'modified'.
Change 'relys' to 'relays'.
[]
Quoted 1 line
arch/mips/cavium-octeon/executive/cvmx-helper-board.c
Quoted 1 line
arch/mips/cavium-octeon/executive/cvmx-helper-board.c +0
-0
[]
Quoted 11 lines
arch/mips/cavium-octeon/executive/cvmx-helper-board.c union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port) · line 287
Quoted 8 lines
arch/mips/cavium-octeon/executive/cvmx-helper-board.c +1
-2@@ -282,9 +282,9 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port)* support and should return the number of actual ports on the * board. * -* This function must be modifed for every new Octeon board. +* This function must be modified for every new Octeon board. * Internally it uses switch statements based on the cvmx_sysinfo -* data to determine board types and revisions. It relys on the relies
Quoted 2 lines
But it would be better to restrict this barrage (or swarm) of patches to
Kconfighelp text problems and/or strings that are printed to users.
I believe fixing typos isn't a particular problem and is overall rather a good thing.
Though backporting these patches would be silly.
Quoted 18 lines · Joe Perches
Quoted 3 lines · Randy Dunlap
Quoted 2 lines · Zhang Jiaming
Change 'modifed' to 'modified'.
Change 'relys' to 'relays'.[]
Quoted 1 line
arch/mips/cavium-octeon/executive/cvmx-helper-board.c
Quoted 1 line
arch/mips/cavium-octeon/executive/cvmx-helper-board.c +0
-0[]
Quoted 11 lines
arch/mips/cavium-octeon/executive/cvmx-helper-board.c union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port) · line 287
Quoted 8 lines
arch/mips/cavium-octeon/executive/cvmx-helper-board.c +1
-2@@ -282,9 +282,9 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port)* support and should return the number of actual ports on the * board. * -* This function must be modifed for every new Octeon board. +* This function must be modified for every new Octeon board. * Internally it uses switch statements based on the cvmx_sysinfo -* data to determine board types and revisions. It relys on the relies
Quoted 5 lines
Quoted 2 lines
But it would be better to restrict this barrage (or swarm) of patches to
Kconfighelp text problems and/or strings that are printed to users.I believe fixing typos isn't a particular problem and is overall rather a good thing.
OK, I can agree with that.
Quoted 1 line
Though backporting these patches would be silly.
Ack.
Signature · 1 line
~Randy