Skip to contentSkip to conversation

*** option to disable xnvme build even if found ***

PATCH Applied Ankit Kumar 2 participants 3 messages Jun 22, 2022 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): CGME20220622113122epcas5p209ab7fab23d77d895b8a16ccf812041f@epcas5p2.samsung.com

#1 lore raw

cover *** option to disable xnvme build even if found ***

Add config option to disable xnvme ioengine build even if its support is present. Remove enable xnvme build option as by default we are anyway probing for it.

Ankit Kumar (1):
configure: add option to disable xnvme build

 configure | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
2.17.1
#2 lore raw

PATCH 1/1 configure: add option to disable xnvme build

Add option to disable xnvme build even if found. Remove enable xnvme build option, as xnvme support is already being probed.

---
 configure | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
configure +4 -4
index 510af424..04a1d0e2 100755
@@ -171,7 +171,7 @@ march_set="no"
 libiscsi="no"
 libnbd="no"
 libnfs="no"
-xnvme="no"
+xnvme=""
 libzbc=""
 dfs=""
 dynamic_engines="no"
@@ -241,7 +241,7 @@ for opt do
   ;;
   --disable-libzbc) libzbc="no"
   ;;
-  --enable-xnvme) xnvme="yes"
+  --disable-xnvme) xnvme="no"
   ;;
   --disable-tcmalloc) disable_tcmalloc="yes"
   ;;
@@ -294,7 +294,7 @@ if test "$show_help" = "yes" ; then
   echo "--with-ime=             Install path for DDN's Infinite Memory Engine"
   echo "--enable-libiscsi       Enable iscsi support"
   echo "--enable-libnbd         Enable libnbd (NBD engine) support"
-  echo "--enable-xnvme          Enable xnvme support"
+  echo "--disable-xnvme         Disable xnvme support even if found"
   echo "--disable-libzbc        Disable libzbc even if found"
   echo "--disable-tcmalloc      Disable tcmalloc support"
   echo "--dynamic-libengines    Lib-based ioengines as dynamic libraries"
@@ -2619,7 +2619,7 @@ fi
 
 ##########################################
 # Check if we have xnvme
-if test "$xnvme" != "yes" ; then
+if test "$xnvme" != "no" ; then
   if check_min_lib_version xnvme 0.2.0; then
     xnvme="yes"
     xnvme_cflags=$(pkg-config --cflags xnvme)
Signature · 1 line
2.17.1
Applied
#3 lore raw
In reply to Ankit Kumar
Quoted 8 lines · Ankit Kumar

Add config option to disable xnvme ioengine build even if its support is present. Remove enable xnvme build option as by default we are anyway probing for it.

Ankit Kumar (1):
configure: add option to disable xnvme build

[...]

Applied, thanks!

[1/1] configure: add option to disable xnvme build

      commit: 6aaebfbe7269f95164ac83a04505869f96f5f83a

Best regards,

Signature · 1 line
Jens Axboe