Skip to contentSkip to conversation

soc: mediatek: SVS: Use DEFINE_SIMPLE_DEV_PM_OPS for svs_pm_ops

PATCH In review Nathan Chancellor 2 participants 3 messages Jun 22, 2022 – Jul 7, 2022 Arm MediaTek

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: mediatek: SVS: Use DEFINE_SIMPLE_DEV_PM_OPS for svs_pm_ops

When building this driver for an architecture that does not support CONFIG_PM_SLEEP, such as hexagon, the following warnings occur:

drivers/soc/mediatek/mtk-svs.c:1481:12: error: unused function 'svs_suspend' [-Werror,-Wunused-function] static int svs_suspend(struct device *dev)

             ^
  drivers/soc/mediatek/mtk-svs.c:1515:12: error: unused function 'svs_resume' [-Werror,-Wunused-function]
  static int svs_resume(struct device *dev)
             ^

2 errors generated.

This happens because SIMPLE_DEV_PM_OPS uses SET_SYSTEM_SLEEP_PM_OPS, which evaluates to nothing when CONFIG_PM_SLEEP is not set, leaving the functions unused in the eyes of the compiler.

This problem was rectified in commit 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate old ones") with new macros. Use DEFINE_SIMPLE_DEV_PM_OPS to fix the warning while not changing svs_pm_ops when CONFIG_PM_SLEEP is set.

Fixes 681a02e95000 ("soc: mediatek: SVS: introduce MTK SVS engine")
---
 drivers/soc/mediatek/mtk-svs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/mediatek/mtk-svs.c +1 -1
index 606a00a2e57d..d70903f45ddf 100644
@@ -2381,7 +2381,7 @@ static int svs_probe(struct platform_device *pdev)
 	return ret;
 }
 
-static SIMPLE_DEV_PM_OPS(svs_pm_ops, svs_suspend, svs_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(svs_pm_ops, svs_suspend, svs_resume);
 
 static struct platform_driver svs_driver = {
 	.probe	= svs_probe,

base-commit: 71eaf1887203d0a59c92fd9dd3436b8d8489d68c

Signature · 1 line
2.37.0.rc1
maintainer
#1 lore raw
Quoted 15 lines · Nathan Chancellor

When building this driver for an architecture that does not support CONFIG_PM_SLEEP, such as hexagon, the following warnings occur:

drivers/soc/mediatek/mtk-svs.c:1481:12: error: unused function 'svs_suspend' [-Werror,-Wunused-function] static int svs_suspend(struct device *dev)

              ^
   drivers/soc/mediatek/mtk-svs.c:1515:12: error: unused function 'svs_resume' [-Werror,-Wunused-function]
   static int svs_resume(struct device *dev)
              ^

2 errors generated.

This happens because SIMPLE_DEV_PM_OPS uses SET_SYSTEM_SLEEP_PM_OPS, which evaluates to nothing when CONFIG_PM_SLEEP is not set, leaving the functions unused in the eyes of the compiler.

Quoted 7 lines

This problem was rectified in commit 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate old ones") with new macros. Use DEFINE_SIMPLE_DEV_PM_OPS to fix the warning while not changing svs_pm_ops when CONFIG_PM_SLEEP is set.

Fixes 681a02e95000 ("soc: mediatek: SVS: introduce MTK SVS engine")

Thanks for the patch. The same issue was addressed by Jin Xiayun here:
https://lore.kernel.org/linux-mediatek/[email protected]/T/#u

I'm happy for any review help.

Regards,
Matthias

Quoted 19 lines
---
  drivers/soc/mediatek/mtk-svs.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/mediatek/mtk-svs.c +1 -1
index 606a00a2e57d..d70903f45ddf 100644
@@ -2381,7 +2381,7 @@ static int svs_probe(struct platform_device *pdev)
  	return ret;
  }
 
-static SIMPLE_DEV_PM_OPS(svs_pm_ops, svs_suspend, svs_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(svs_pm_ops, svs_suspend, svs_resume);
 
  static struct platform_driver svs_driver = {
  	.probe	= svs_probe,

base-commit: 71eaf1887203d0a59c92fd9dd3436b8d8489d68c

maintainer
#2 lore raw
Quoted 23 lines · Matthias Brugger
Quoted 20 lines · Nathan Chancellor

When building this driver for an architecture that does not support CONFIG_PM_SLEEP, such as hexagon, the following warnings occur:

   drivers/soc/mediatek/mtk-svs.c:1481:12: error: unused function 'svs_suspend' [-Werror,-Wunused-function] static int svs_suspend(struct device *dev)
              ^
   drivers/soc/mediatek/mtk-svs.c:1515:12: error: unused function 'svs_resume' [-Werror,-Wunused-function] static int svs_resume(struct device *dev)
              ^
   2 errors generated.

This happens because SIMPLE_DEV_PM_OPS uses SET_SYSTEM_SLEEP_PM_OPS, which evaluates to nothing when CONFIG_PM_SLEEP is not set, leaving the functions unused in the eyes of the compiler.

This problem was rectified in commit 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate old ones") with new macros. Use DEFINE_SIMPLE_DEV_PM_OPS to fix the warning while not changing svs_pm_ops when CONFIG_PM_SLEEP is set.

Quoted 9 lines
Quoted 2 lines
Fixes 681a02e95000 ("soc: mediatek: SVS: introduce MTK SVS engine")

Thanks for the patch. The same issue was addressed by Jin Xiayun here:
https://lore.kernel.org/linux-mediatek/[email protected]/T/#u

I'm happy for any review help.

As there was no progress on the other patch, I now applied yours.

Thanks!
Matthias

Quoted 20 lines

Regards,
Matthias

Quoted 17 lines

---
  drivers/soc/mediatek/mtk-svs.c | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/mediatek/mtk-svs.c +1 -1
index 606a00a2e57d..d70903f45ddf 100644
@@ -2381,7 +2381,7 @@ static int svs_probe(struct platform_device *pdev)
       return ret;
   }
-static SIMPLE_DEV_PM_OPS(svs_pm_ops, svs_suspend, svs_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(svs_pm_ops, svs_suspend, svs_resume);
   static struct platform_driver svs_driver = {
       .probe    = svs_probe,
 

base-commit: 71eaf1887203d0a59c92fd9dd3436b8d8489d68c