more null pointer check removal
Subsystems (3)
cover more null pointer check removal
Reran the Cocci script to check for unnecessary null pointer comparisons before free related functions.
Stephen Hemminger (3):
vdpa/mlx5: remove unnecessary null check
raw/ifpga: remove unnecessary null check
dmap/dpaa2: remove unnecessary null check
drivers/dma/dpaa2/dpaa2_qdma.c | 6 ++---- drivers/raw/ifpga/ifpga_rawdev.c | 3 +-- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 3 +-- 3 files changed, 4 insertions(+), 8 deletions(-)
Signature · 1 line
2.35.1
PATCH 1/3 vdpa/mlx5: remove unnecessary null check
Found by nullfree.cocci.
--- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/vdpa/mlx5/mlx5_vdpa_virtq.c +1 -2
@@ -285,8 +285,7 @@ mlx5_vdpa_virtq_setup(struct mlx5_vdpa_priv *priv, int index)if (virtq->umems[i].obj)claim_zero (mlx5_glue->devx_umem_dereg (virtq->umems[i].obj)); -if (virtq->umems[i].buf) -rte_free (virtq->umems[i].buf); +rte_free (virtq->umems[i].buf); virtq->umems[i].size =0 ; virtq->umems[i].obj =NULL ; virtq->umems[i].buf =NULL ;
Signature · 1 line
2.35.1
RE: [PATCH 1/3] vdpa/mlx5: remove unnecessary null check
From: Stephen Hemminger
Quoted 3 lines
Found by
nullfree.cocci.Signed-off-by Stephen Hemminger <[email protected]>
PATCH 2/3 raw/ifpga: remove unnecessary null check
In reply to Stephen HemmingerThe function rte_kvargs_free handles calling with NULL. Found by nullfree.cocci.
--- drivers/raw/ifpga/ifpga_rawdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/raw/ifpga/ifpga_rawdev.c +1 -2
@@ -1768,8 +1768,7 @@ ifpga_vdev_parse_devargs(struct rte_devargs *devargs, ret =0 ; end: -if (kvlist) -rte_kvargs_free (kvlist); +rte_kvargs_free (kvlist);return ret; }
Signature · 1 line
2.35.1
PATCH 3/3 dmap/dpaa2: remove unnecessary null check
In reply to Stephen HemmingerThe function rte_free already handles being called with NULL. Found by nullfree.cocci.
--- drivers/dma/dpaa2/dpaa2_qdma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/dma/dpaa2/dpaa2_qdma.c +2 -4
@@ -1404,11 +1404,9 @@ dpaa2_qdma_reset(struct rte_dma_dev *dev)/* Reset and free virtual queues */ for (i =0 ; i < qdma_dev->num_vqs; i++) { -if (qdma_dev->vqs[i].status_ring) -rte_ring_free (qdma_dev->vqs[i].status_ring); +rte_ring_free (qdma_dev->vqs[i].status_ring); } -if (qdma_dev->vqs) -rte_free (qdma_dev->vqs); +rte_free (qdma_dev->vqs); qdma_dev->vqs =NULL ;/* Reset QDMA device structure */
Signature · 1 line
2.35.1
Quoted 8 lines · Stephen Hemminger
Reran the Cocci script to check for unnecessary null pointer comparisons before free related functions.
Stephen Hemminger (3):
vdpa/mlx5: remove unnecessary null check
raw/ifpga: remove unnecessary null check
dmap/dpaa2: remove unnecessary null check
Quoted 6 lines
drivers/dma/dpaa2/dpaa2_qdma.c | 6 ++---- drivers/raw/ifpga/ifpga_rawdev.c | 3 +-- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 3 +-- 3 files changed, 4 insertions(+), 8 deletions(-)
Quoted 13 lines · Stephen Hemminger
Reran the Cocci script to check for unnecessary null pointer comparisons before free related functions.
Stephen Hemminger (3):
vdpa/mlx5: remove unnecessary null check
raw/ifpga: remove unnecessary null check
dmap/dpaa2: remove unnecessary null checkdrivers/dma/dpaa2/dpaa2_qdma.c | 6 ++---- drivers/raw/ifpga/ifpga_rawdev.c | 3 +-- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 3 +-- 3 files changed, 4 insertions(+), 8 deletions(-)
Quoted 3 lines · Stephen Hemminger
Reran the Cocci script to check for unnecessary null pointer comparisons before free related functions.
Applied with series
https://patchwork.dpdk.org/project/dpdk/list/?series=21752&state=*
Signature · 1 line
David Marchand